Commit graph

206 commits

Author SHA1 Message Date
Adam Vollrath
cbd1d95848
GHA Workflows: Sanitize user input from fork workflows. (#20466)
* Improvements to Uffizzi Preview Workflows.

Signed-off-by: Adam Vollrath <adam.d.vollrath@gmail.com>

* Also unzip the rendered compose file.

Signed-off-by: Adam Vollrath <adam.d.vollrath@gmail.com>

---------

Signed-off-by: Adam Vollrath <adam.d.vollrath@gmail.com>
2023-12-21 12:56:02 +00:00
Mac Siri
d249d3989b
Consolidate dockerfile (#20460)
* Consolidate dockerfile

* Specify dockerfile target for uffizzi

* Syntax error

* Specify target in the right location
2023-12-20 14:47:03 +00:00
Mac Siri
59ee1461a4
Upgrade to Node 20 (#20424)
* Upgrade to Node 18

* Run audit fix to resolve node 16 openssl issue

* Update babel.config.js

* Replace node-version with node-version-file

* Add NODE_OPTIONS

* Specify major version only

* Try setting locally instead

* Try custom hashFunction

* Trying two things at once

* Try without legacy option

* Add back openssl-legacy-provider

* Add resolution for terser-webpack-plugin

* Use older terser-webpack-plugin

* Revert changes to CI

* Add compression-webpack-plugin to resolution

* Use new node_module cache

* Add NODE_OPTION in build_test

* Maybe remove redundant label

* Upgrade storybook

* Update bin/webpack

* Revert "Upgrade storybook"

This reverts commit fca3fb5c8718786b7db20538c5c4ae6cf44b45b8.

* Remove unnecessary change

* Update yarn.lock again

* Now try with Node 20

* Upgrade Node module cache CI

* Lint

* Update base image sha
2023-12-15 14:27:36 +00:00
Mac Siri
a0232a5f02
Extend retry time for code-coverage upload (#20373) 2023-11-21 08:52:06 -05:00
Mac Siri
4a9a08b81d
[CI] Make CLAAssistant reusable (#20359) 2023-11-15 13:38:29 -05:00
Mac Siri
5f89bc33ed
Enable merge queue (#20348) 2023-11-14 08:32:46 -05:00
Mac Siri
6d6e042465
[CI] Move CLA allowist to env var (#20340) 2023-11-10 09:00:45 -05:00
Mac Siri
f46f8ef804
Update CLA workflow (#20336) 2023-11-09 12:53:44 -05:00
Mac Siri
c479a08ad4
Migrate to contributor-assistant (#20333) 2023-11-09 07:23:45 -05:00
Mac Siri
b68a8b253c
Update CI's jest reporters (#20281) 2023-10-26 15:29:35 -04:00
PJ
67bb7a6e76
Revert "Bump sidekiq and sidekiq-unique-jobs dependencies in tandem" (#20132) 2023-09-18 13:27:08 -04:00
Mai Irie
9332ef7123
Reduce Codecov's patch target to 60% (#20095)
* Reduce Codecov's patch target to 50%

* Update codecov.yml

After internal discussion, settled on 60% as the floor for the baseline.

* Code Cov note in PR template
2023-09-15 13:31:22 -04:00
Mac Siri
40122a5c5c
[CI] Use actions/checkout@v4 (#20045) 2023-09-05 11:43:11 -04:00
Josh Klar
b58ab2fe37
ci: Fix base image builder... the right way... (#19889) 2023-08-03 13:55:29 -04:00
Josh Klar
5903372e1a
ci: Allow workflow_dispatch runs to log in to GHCR. (#19885) 2023-08-03 10:38:18 -07:00
Josh Klar
0150887926
ci: Allow workflow_dispatch runs to push to GHCR. (#19884) 2023-08-02 14:36:40 -07:00
Josh Klar
a23e1494f5
ci: Track changes to .ruby-version-next for base image builds. (#19875)
In #19871 base images changed to referencing `.ruby-version-next`
(enabling two-PR sequences for updating our Ruby version target), but
the corresponding GitHub Action was not updated, now necessitating a
manual CI run for that particular version update. This commit fixes this
oversight for future runs.
2023-08-02 11:40:35 -07:00
Peter Frank
b39b4642fe
Add "bug" label to bug issue template (#19814)
Just adding a label
2023-07-24 14:55:04 -04:00
Mac Siri
fa31b5fc60
Revert Yarn dependencies update & tighten CI settings (#19781) 2023-07-19 17:35:40 -04:00
Mac Siri
290b9bd775
[CI] Add branch specific rule for codecov upload (#19736) 2023-07-12 09:08:50 -04:00
Josh Klar
10e4fe4d6c
infra: Automatically build and push base container image when Ruby versions are updated. (#19657) 2023-07-11 12:23:49 -07:00
Helio Cola
c7bb3be603
Upgrade ruby 3.0.6 (#19651)
Co-authored-by: Josh Klar <jklar@forem.com>
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2023-07-06 16:42:20 -04:00
Mac Siri
894a318f99
Add retry to codecov upload (#19679) 2023-07-03 16:40:51 -04:00
PJ
90780fd97a
Fix comment moderation's UI bugs (#19554) 2023-06-23 09:56:24 -04:00
Mai Irie
282afaa6a2
Update PR template to include a11y checklist (#19538) 2023-05-26 12:37:48 -04:00
Mac Siri
a6a3417e5e
[CI] Move code-coverage upload into isolated process (#19532) 2023-05-26 09:09:39 -04:00
Mac Siri
a5842bd779
Revert Uffizzi refactors (#19526) 2023-05-24 10:55:27 -04:00
Mac Siri
f85db74b92
[CI] Refactor Uffizzi-build.yml (#19463)
* Simplify Uffizzi setup & use cached assets

* Remove cache assets usage

* Don't feature too many articles in seed

* Update db/seeds.rb
2023-05-16 09:41:52 -07:00
Mac Siri
e2a2d170e8
[CI] Combine Uffizzi workflows (#19429) 2023-05-05 12:59:08 -04:00
Joshua Wehner
7a9d71666f
Refactor for_display to pass article instead of params (#19376)
* Refactor for_display to pass article instead of params

* Refactor: use options in FilteredAdsQuery, deconstruct article in DisplayAd.for_display

* Typo

* Restore applicable comments
2023-04-26 16:57:10 +02:00
Peter Frank
3d53351b8f
Update issue templates and automatic comment on new issues (#19357)
* Update issue templates

Adding a new issue template as part of an effort to clean up the way we use GitHub / GitHub Discussions

* Update config.yml

* Update issue.yml
2023-04-24 13:15:40 -07:00
Mac Siri
531f15566d
Track Deploys with Honeybadger (#19338) 2023-04-17 11:14:58 -04:00
Ridhwana
0771a5cd2e
Load post_comments billboard asynchronously (#19285)
* feat: add a route to the async_info for display ads

* feat: load the billboard asyncronously

* feat: move the methods to the display_ads controller

* feat: handle params better

* feat: cache control headers

* feat: test fastly caching headers on display ads

* fix: surrogate key test

* feat: use safe navigation operator to handle cases where there is no article id

* fix: article id present then find the article

* feat: add a response test

* Fragment caching

* feat: update the article decorator

* feat: update cache keys for fragment

* feat: remove an empty line

* feat: add article id

* feat: bust cache

* feat: setup dropdown for billboard

* chore: add chunk to same line

* feat: add to safe params for caching

* Update app/controllers/display_ads_controller.rb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* feat: remove the cache deletion

* feat: update the routes to follow a new scope

* feat: update the cache params

---------

Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-04-12 18:15:15 +02:00
Mac Siri
f88a861125
Keep rubocop's usage consistent (#19293) 2023-04-06 07:53:59 -04:00
Mai Irie
3775f2b06c
PR Template cleanup (#19277)
* PR Template cleanup

Removed some sections we've been using less often to streamline the PR review process.
2023-04-05 11:58:57 -04:00
Mac Siri
e3b6e5b08d
[CI] Make CodeCov less noisy (#19286) 2023-04-03 15:56:20 -04:00
Mac Siri
f368a4ce7f
Fix broken cypress code coverage (#19282) 2023-03-30 12:36:12 -04:00
Mac Siri
64c10957e3
Update CODEOWNERS (#19276) 2023-03-29 17:20:41 -04:00
Mac Siri
88108b3037
Implement code coverage for Cypress (#19250) 2023-03-29 15:37:50 -04:00
Mac Siri
1e1064de0b
Undo changes to Sprockets::UglifierWithSourceMapsCompressor (#19261) 2023-03-24 12:48:59 -04:00
Mac Siri
b7f00706bd
[CI] Adjust cancel-in-progress concurrency (#19244)
* [CI] Adjust cancel-in-progress concurrency

* Revert "[CI] Lock setup-ruby to v1.144.0 (#19243)"

This reverts commit 44a3527983.
2023-03-21 10:05:31 -04:00
Mac Siri
44a3527983
[CI] Lock setup-ruby to v1.144.0 (#19243) 2023-03-20 11:17:18 -04:00
Mac Siri
047a68cc66
[CI] Add concurrency & remove slack alert (#19237)
* Remove CI's slack report

* Add concurrency to per branch

* Dynamic cancel-in-progress
2023-03-20 08:59:14 -04:00
Mac Siri
bfe797f44d
Create cleanup-cache.yml (#19232) 2023-03-17 12:18:51 -04:00
Mac Siri
2e759c823d
Merge bundle-audit and rubocop into CI & add precompile step (#19228) 2023-03-16 15:34:38 -04:00
Mac Siri
61bd41930d
Add build steps and expand CI node (#19220)
* Add build step

* Use retrieve cache instead for tests

* Add assets_precompile step

* Rename method

* Forgot ruby

* Typo

* Try exit early

* Speed up yarn_install

* Try again

* why

* Oops

* debug echo

* Move order

* Refine lookup process

* Synxtax error

* Remove redundant yarn install

* Separate Storybook

* Simplify

* Revert "Simplify"

This reverts commit 2e07724dcc4d08d03b9f50c41669f9ee94045002.

* Expand node counts

* Experimental bypass

* Remove verbose cypress install

* Revert "Remove verbose cypress install"

This reverts commit 5ace028feb91f44358a384bfaa8d3da1cdf68c07.

* Provide precompiled asset to RSpec

* lets try 10 nodes

* Only cache webpack

* Test speed with 8 node counts

* No need for assets precompile
2023-03-15 09:36:30 -04:00
Mac Siri
09291b4205
Update CI node count (#19174) 2023-02-27 12:54:05 -05:00
Adam Vollrath
4668e11dcc
Improvements to Uffizzi Preview Workflows (#19029) 2023-02-24 12:34:02 -05:00
Mac Siri
ff3c3c9324
[CI] Collect RSpec artifacts (#19128)
Co-authored-by: Lawrence <lawrence@forem.com>
2023-02-22 12:52:52 -05:00
Aramayis
c758272aec
Fix Uffizzi sign in bug(#19100) 2023-02-20 16:21:05 -05:00