Commit graph

4334 commits

Author SHA1 Message Date
ludwiczakpawel
bf8e2e53f1
Titles & subtitles cleanup (#10508)
* .

* .

* .
2020-10-02 12:37:39 +02:00
Robin Gagnon
87590e77d3
[deploy] feat: Disable autoplay on native videos (#10516) 2020-10-01 16:52:12 -06:00
Diogo Osório
3bc51a13cc
Fixes 500 error when viewing the "Tag Mods" page without having the role on the database (#10515)
* Makes the ModeratorsQuery not return an exception on invalid role

The current implementation of the query would yield an exception when
recieving an invalid state parameter. As per the [GH issue
discussion](https://github.com/forem/forem/issues/10060#issuecomment-692295217),
Zhao recommended to change its behaviour and not trigger an exception in
this condition.

This commit does just that. If the state argument is invalid, the query
now returns an empty result set.

* Adds a warning when there are no matching mods

* Re-trigger the build
2020-10-01 12:55:25 -06:00
Mac Siri
c2e61074e1
Refactor: Extract app-shell unsupported paths (#10504) 2020-10-01 13:41:59 -04:00
Vaidehi Joshi
6a697173bc
Split EdgeCache::Bust into Fastly + Nginx-specific classes (#10505) [deploy]
* Split EdgeCache::Bust into Fastly + Nginx-specific classes

* Update EdgeCache::Bust service specs

* Move Nginx TODO comment into Nginx-specific file
2020-10-01 10:07:51 -07:00
rhymes
10efa25c0a
Add missing presence validators to models (#10495)
* Add missing presence validator for Tag

* Add missing presence validators to Follow

* Add missing presence validators to ProfileField

* Add missing presence validators to Comment

* Add missing presence validators to Profile

* Add missing presence validators to Organization

* Add missing presence validators to Badge

* Add missing presence validators to Webhook::Endpoint

* Add missing presence validators to NotificationSubscription

* Add missing presence validators to PodcastEpisode

* Add missing presence validators to Sponsorship

* Add missing presence validators to PollOption

* Add missing presence validators to Poll

* Add missing presence validators to Article

* Add missing presence validators to EmailAuthorization

* Add missing presence validators to AuditLog

* Add missing presence validators to DataUpdateScript

* Add missing presence validators to User

* Add missing presence validators to SiteConfig

* Fix specs
2020-10-01 16:15:32 +02:00
Molly Struve
d2d9984f28
[deploy] Return Cache Bust Response When Busting a Cached Path (#10500) 2020-09-30 17:17:04 -05:00
Alex
a35009e339
Remove redirect for listings#update (#10499)
* Remove redirect for listings update

* Quick refactor

* Extract query to convenience method
2020-09-30 16:20:39 -04:00
Mac Siri
02bd3111af
[deploy] Refactor: Create setCurrentUserToNavBar (#10501) 2020-09-30 16:20:23 -04:00
Lisa Sy
46d2e5cddb
Add and apply crayons link header style (#10368)
* Add and apply crayons link header style

* Add crayons-subheader style
2020-09-30 16:14:38 +02:00
ludwiczakpawel
90d04a73db
Crayonsification of Listings form (#10429)
* i dont know how to test

* fix i guess

* layout update

* layout updates

* edit

* edit listing

* fix

* tags field

* specs|

* Update app/javascript/listings/__tests__/ContactViaConnect.test.jsx

Co-authored-by: Fernando Valverde <fernando@visualcosita.com>

Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
2020-09-30 09:14:48 +02:00
rhymes
d7976a75d6
[deploy] Add missing FKs to BadgeAchievements BanishedUsers BufferUpdates (#10366)
* Add missing FKs to BackupData BadgeAchievements BanishedUsers BufferUpdates

* Add relations and specs

* Fix specs

* Trigger Travis CI

* Remove traces of backup_data has it has been removed on master

* Fix trailing whitespace
2020-09-29 21:43:14 +02:00
Alex
1fbd20087a
[deploy] Remove redirect on comments#update (#10337)
* Remove redirect on comments#update

* Delete unecessary view

* Refactor to account for orgs and podcasts

* Code cleanup

* Add specs

* Fix podcast comment update

* Add more safe navigation operators

* Update safe nav operators again

* Update comment to explain more
2020-09-29 15:33:51 -04:00
Arit Amana
877e9a13b1
Fix bug that arises when a previously tagged comment is deleted (#10486)
* Starting to dig

* Stil figuring out

* Complete implementation; remains tests

* Modify comment_tag specs
2020-09-29 13:43:25 -04:00
Rafi
2c6555939e
Handling links from different domain (#10479)
* Preventing url from other domains

* Converting slug to keyword

* Changing wording of error message

* Changing wording of error message

* Fixing breaking test
2020-09-29 13:36:32 -04:00
rhymes
0ca4e8b371
[deploy] Add missing FKs to FeedbackMessage, Note, Taggings, Tag, and UserRole (#10376)
* Add missing FKs to FeedbackMessage, Note, Taggings, Tag, and UserRole

* Add missing relations and specs

* Fix spec
2020-09-29 16:49:47 +02:00
Hugo Peixoto
24e9f81f5a
Fix newlines being chomped in RSS import (#10476)
The CustomText converter was monkey patched to fix a bug related to
preserve_tags. Somewhere in that process, remove_inner_newlines was
changed to strip newlines completely, instead of replacing them with a
single space. This restores that functionality.

In development mode, files are not eager loaded. That means that the
converters were not being required, so it was not possible to reproduce
that issue in development mode (since it was falling back to the
original converter, which does not have the bug). This commit also adds
an initializer that requires every converter.
2020-09-29 10:38:36 -04:00
rhymes
fe75dcde1c
Routine rubocop fixes (#10478) 2020-09-29 10:14:26 -04:00
rhymes
bfa06466ef
GitHub liquid tag: add support for img tags with no src attribute (#10470) 2020-09-29 10:37:53 +02:00
narender2031
649c23f854
add no console rule front-end (#10362)
* add no console rule front-end

* add no-console to root eslintrc

* disbale no console rule

* remove console
2020-09-29 09:56:37 +02:00
Mac Siri
8d9db4cce1
Update Imgproxy to use predetermined endpoint (#10412) 2020-09-28 18:30:29 -04:00
Rafi
873dc988fd
Removing close button from right panel in moderation view (#10353)
* Removing close button in moderation view

* Fixing typo
2020-09-28 16:02:38 -04:00
ludwiczakpawel
b6bc589a4f
Crayonisification of "Reading list" (#10428)
* saved

* saved

* headers level

* maybe i can test

* revert renaming

* fix
2020-09-28 15:53:20 -04:00
Fernando Valverde
b5309c4a21
[deploy] User agent check fix for native iOS (#10472) 2020-09-28 14:45:36 -04:00
Rafi
13e985991a
[deploy] Handling empty gist link error in liquid tag (#10437)
* Handling empty gist link

* Fixing wording

* Fixing wording

* Handle empty url in initialize

* Seperate test for empty url

* Converting link to symbol

* Trigger Travis CI

Co-authored-by: rhymes <rhymes@hey.com>
2020-09-28 17:23:54 +02:00
Fernando Valverde
2297e84f35
[deploy] HTML Variant admin dashboard (#10188)
* HTML Variant admin dashboard

* Tweaks to actions & spec fixes

* Update app/controllers/admin/html_variants_controller.rb

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Removes old html_variants dashboards

* Removes old lingering spec

Co-authored-by: Michael Kohl <citizen428@dev.to>
2020-09-28 09:22:13 -06:00
Ricky Stam
f14648796c
Remove border from Embed videos in comments (#10434)
* Update _fitvids.html.erb

Fix for issue #9787, remove the border

* Trigger Travis CI

Co-authored-by: rhymes <rhymes@hey.com>
2020-09-28 16:30:45 +02:00
Molly Struve
6193ceeace
[deploy] Refactor: Cleanup Frontend Code (#10466) 2020-09-28 08:57:34 -05:00
Molly Struve
9eb0833134
[deploy] Bug Fix:Remove More ReadingList Index Code (#10439) 2020-09-25 13:40:54 -05:00
Takuma
fb707621d0
[deploy] Fix unable to unfollow tags (#10324) 2020-09-25 13:00:55 -05:00
Molly Struve
3303186125
Bug Fix:Count the Health Checks Controller as Public (#10435) 2020-09-25 10:35:10 +07:00
ludwiczakpawel
3e9b56a7dd
[deploy] Frontend cleanups (#10416) 2020-09-24 08:15:12 -05:00
Molly Struve
e9cb7b2fd9
[deploy] Refactor:Remove Reaction Search Code (#10377) 2020-09-23 12:27:50 -05:00
Molly Struve
b0e086346d
[deploy] Refactor:Remove BackupData Model and Code (#10409) 2020-09-22 16:45:18 -05:00
ludwiczakpawel
afa5f56faf
bg for pre (#10400) 2020-09-22 15:06:16 +02:00
ludwiczakpawel
f05dce9c2b
Better position: sticky support (#10401)
* sticky support

* Whoops, typo
2020-09-22 13:55:33 +02:00
narender2031
f149a8fcba
auto resize on type message connect (#10378) 2020-09-22 11:37:12 +02:00
Michael Kohl
099e416d35
Remove profile validations from user (#10257)
* Remove profile validations from user

* Update specs
2020-09-22 10:32:23 +07:00
Anna Buianova
aa40d5ffdb
Improve setup not completed notification (#10411) 2020-09-22 10:26:50 +07:00
ludwiczakpawel
4fd68efdd0
adding missing variable (#10405) 2020-09-22 10:17:13 +07:00
Ben Halpern
81cbde8b31
[deploy] Fix extra character (#10382) 2020-09-21 12:03:50 -05:00
Rafi
d570edcf07
Showing date in listing tile (#10217)
* Showing date in listing tile

* Displaying date in listing tile

1. Sending created_at in listing search API
2. Global util functions for short and long date formatting
3. New date util functions extend timestampToLocalDateTime
4. Converting div to time tag
5. Adding title attribute for date

* originally_published_at column

* Displaying originally_published_at date

* Fixing test in modal

* Fixing all listing test

* Fixing casing of dateTime

* Adding tests for originally_published_at

* Reverting to bumped_at

* Backfilling only published listing

* Removing ReIndexListingWithOriginallyPublishedAt
2020-09-21 10:14:26 +02:00
Vaidehi Joshi
d5f810a6f8
[deploy] Refactor edge caching logic to live in EdgeCache::Service (#10369)
* Refactor edge caching logic to live in EdgeCache::Service

* Rename EdgeCache::Service to EdgeCache::Buster

* Reorganize some code, move from Buster to Bust naming
2020-09-18 16:41:40 -05:00
Dana Scheider
24641d537a
API: Add route for fetching a user's followed tags (#9108)
* Add route for fetching a user's followed tags

* Move followed tags route to FollowsController instead of TagsController and add JSON view

* Add missing new line

* Change the dots for our linter

Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Molly Struve <mollylbs@gmail.com>
2020-09-18 16:28:42 -05:00
Andy Zhao
b65ebdf99c
[deploy] Fix case sensitive published bug (#10352) 2020-09-18 11:45:45 -04:00
Ben Halpern
1a531bca0e
Replace need for GitHub ENV vars on bootup (#10372)
* Un-eagerload dev mode

* Change approach

* Fix for_user

* Fix spec?

* Fix spec?

* Fix spec?

* Fix spec?

* Fix spec?
2020-09-18 11:21:31 -04:00
Anna Buianova
fec947ce45
More detailed notification when setup is not completed (#10375) 2020-09-18 09:24:49 -04:00
Michael Kohl
6d1984163e
Add opacity to HexComparer (#10361)
* Refactor code

* Add opacity method
2020-09-18 13:49:03 +07:00
Molly Struve
86cb66e858
[deploy] Feature: Serve Reading List from FeedContent Index (#10294)
* Feature:Serve Reading List from FeedContent Index
* Fix paging, order ID desc, improve comments
2020-09-17 17:20:14 -05:00
Brunno Souza
9272da5ee8
Remove exceeded line (#10290) 2020-09-17 11:28:03 -06:00