maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2287 commits 1 branch 0 tags 1.6 GiB
Commit graph

195 commits

Author SHA1 Message Date
Ben Halpern
b731df44ca
Add badges to key tags (#3074) 
* Add badges to key tags

* Adjust vertical-align

* Fix YouTube tag mistake and refactor map to pluck
 2019-06-07 19:09:43 -04:00
Anna Buianova
9751e84549 Moved Podcast#pull_all_episodes to a separate ActiveJob #2952 #2497 (#3057) 
* Use one PodcastFeed instance while fetching podcasts

* Moved Podcast#pull_all_episodes to a separate ActiveJob
 2019-06-06 09:49:10 -04:00
Anna Buianova
f6bb00a26a Add specs for the PodcastFeed #2952 (#3039) [ci skip] 2019-06-04 14:50:25 -04:00
Jess Lee
c3e2a0c5f1 Add missing instance var for /manage & Bust rails cache on comments (#3004) 2019-05-30 12:23:20 -04:00
rhymes
a99c072525 Guard bust_comment against nil commentable (#2991) 2019-05-29 14:03:20 -04:00
rhymes
6a626e819d Refactor: fix issues raised by bullet (#2965) 
* Preload organization, not user

* Preload users only when needed

* Pre-load podcasts for podcast episodes in API

* Avoid eager loading error by loading rating votes separately

* Preload associations for moderation

* Preload user comments in trees

* Preload organization for non org dashboard and cleanup queries

* Optimize ArticleSuggester to only load N articles at need

* Remove eager loading and pass variables to partials for easier debug

* Reorganize tags validation code and ignore actsastaggableon eager loading issues

* Remove unused eager loading and bring up comments relation

* Preload podcasts when loading podcast episodes

* Fix views specs

* Make sure ArticleSuggester never returns duplicates

* Remove commented code

* Re-trigger build

* Move suggested articles back to view to respect fragment caching
 2019-05-28 17:32:53 -04:00
Ben Halpern
37fabd08b1
Fix some connect bugs with wrong url and remove some dead code (#2953) 2019-05-24 12:19:59 -04:00
Clara
48b9d16e6e Bug/markdown underscores in usernames (#2948) 
* Add method into MardownFixer and call in Comment

* Add test

* Escape all underscores in usernames and adapt tests

* Rework regex [WIP]

* Add new idea

* Clean up method and add correct tests
 2019-05-24 08:34:14 -04:00
rhymes
9e14ef2afd Add a proper exception in case of XSS attempt (#2927) 
Fixes the generic error message with a proper one
 2019-05-21 17:20:39 -04:00
Kartikey Tanna
03a122f0ce Implemented ActiveJob for RateLimitChecker Job (#2878) 
* Implemented ActiveJob for RateLimitChecker Job

* Changes as per the review

* Further changes as per the review
 2019-05-21 08:45:58 -04:00
Jess Lee
b935fdd920 Limit number of cover image uploads (#2851) 2019-05-17 15:59:07 -04:00
cyrillefr
68f06c2076 send_milestone_notification in own job (#2804) 
- that calls a service
  - spec for job + move spec to service
  - minor refactoring
 2019-05-16 13:46:50 -04:00
Jess Lee
c225fed1ff check for optin once more before sending ddigest (#2840) 2019-05-15 12:36:46 -04:00
Ben Halpern
dd20e70f12
Simplify article show page reactions (#2827) 
* Simplify article show page reactions

* Clean up styling and adjust zen mode logic

* Remove unused variables

* Update app/views/articles/_actions.html.erb

Co-Authored-By: Nick Taylor <nick@iamdeveloper.com>

* Small style mods

* Slight padding change

* Finalize new show page button design
 2019-05-15 10:32:36 -04:00
Ben Halpern
d9e11da157
Finalize Medium liquid tag and add video to video article liquid tags (#2832) 
* Finalize Medium liquid tag and add video to video article liquid tags

* Add Medium section to editor guide
 2019-05-14 17:02:37 -04:00
rhymes
66ddcbca02 Upgrade rubocop and rubocop-performance (#2802) [ci skip] 2019-05-13 19:21:24 -04:00
Ben Halpern
c7d7d55460
[WIP] Move both v1 and v2 editor to v2 preact-driven editor (#2797) 
* Initial work on v2

* Initial changes merger

* Work to finalize v1/v2 editor adjustments

* Clean up styling

* Fiddle with form margins

* Fix some tests

* Change video

* skip a couple tests

* Modify tests to work with new code
 2019-05-13 12:27:36 -04:00
Ben Halpern
b645942dd2
Add loading='lazy' attribute to some images (#2776) 2019-05-09 16:37:06 -04:00
Ben Halpern
c76abbbdb3
Allow users to follow podcasts (#2690) 
* Allow users to follow podcasts

* Only display podcasts user follows

* Add main_color_hex to factory

* Fix podcast test and modify styles

* Fix tests

* Remove weird test
 2019-05-04 15:30:40 -04:00
Glenn Carremans
575dd6d287 Award contributor badge to DEV Android contributors (#2687) 2019-05-04 09:04:35 -04:00
Ben Halpern
5891b2ea58
Add application "page" model (#2657) 
* Generate page model

* Add page model

* Conditionally modify html rendering
 2019-05-02 18:24:06 -04:00
Ben Halpern
076047e13b
Add proper filtering for inappropriate tags in listings (#2611) 2019-04-29 09:21:42 -04:00
Anna Buianova
d57f8eec4a BlackBox specs #2524 (#2542) 
* Specs for FuctionCaller

* Fix accepting nil values from AWS lambda

* Specs for the black_box #2524

* Spec for BlackBox#comment_quality_score

* Remove vcr cassette usage from the CouponGenerator spec
 2019-04-25 10:19:11 -04:00
Edison Yap
3d12535272 #118 Allow users to embed Medium posts with Liquid Tags (#1161) 
* Add ability to embed Medium URL as liquid tag

- Added new liquid tag - "{% medium https://medium.com}"
- Added a scraper - `MediumArticleRetrievalService` which crawls the
given Medium URL for informations needed for the liquid tag

* Add Medium logo in rendered liquid tag
 2019-04-17 10:13:38 -04:00
Ben Halpern
d45f2c5898
Adjust badge streak copy (#2467) 2019-04-16 16:41:16 -04:00
Yaroslav Barkovskiy
e2503ec1c2 Fix colon emoji in codeblock (#2216) (#2360) 2019-04-13 16:16:36 -04:00
rhymes
5782ffd7e0 Use published scope for articles (#2374) 
* Use published scope for articles

* Fix variable name

* The sequencing in the union query matters

* Fix spec

* Restore a published: true condition

* This test is actually misleading due to the union

* Revert this change, not sure why it's not a relation

* Fix useless diff
 2019-04-11 13:18:26 -04:00
Jess Lee
f637d9e02b Manage tag and community mod lists in Mailchimp (#2362) 
* add moderation email list columns

* automate tag moderator mailing list

* reorder logic for tag mod list

* add community mod list

* remove trusted privileges when reverting a user to a regular member

* automatically make tag mods community mods

* fix merge conflicts

* add community view

* make methods less complex based on code climate sugggestion

* add specs

* refactor tag moderator module

* fix spec
 2019-04-10 14:45:06 -04:00
cyrillefr
4fd66372dc Enable Layout/AlignParameters (#2340) 
Check if the parameters on a multi-line method call or definition are aligned.

Resolves: #2021
 2019-04-08 18:47:34 -04:00
Ben Halpern
bd95c6a8bf
Fix human language detection (#2338) 
* Update language detection

* Modify feed to account for languages
 2019-04-08 15:47:29 -04:00
rhymes
a1787d0702 Fixed some Style/* rubocop violations (#2314) 
* Fix Style/FormatString and Style/TrivialAccessors

* Fix Style/NegatedIf and Style/DoubleNegation

* Style/ClassAndModuleChildren is already enabled by default

* Fix Style/GlobalVars

* Group all style/ cops inside rubocop config file
 2019-04-06 14:24:33 -04:00
Ben Halpern
42a5124fe4
Clean up videos page and add tests (#2315) 2019-04-05 16:05:50 -04:00
Abraham Williams
b98565a931 Update rubocop to 0.67 (#2313) [ci skip] 2019-04-05 12:55:13 -04:00
rhymes
3a53d5797e Upgrade Rails to 5.2.3 (#1408) 2019-04-03 13:08:59 -04:00
Mac Siri
73127aca01 Remove controller specs (#2224) 
* Create more request specs

* Update wording

* Update guard to work with requests

* Fix broken spec

* Remove rails-controller-testing gem

* Move article_specs

* Move last controller spec out

* Remove controller spec config

* Fix broken spec

* Remove all use of render_template

* Refactor spec

* Tweak User#remember_me

* Create ArticleAnalyticFetcher spec

* Undo User#remember_me

* Use srand in rspec

* Create FeedbackMessagesHelper spec

* Add DigestMailer spec

* Fix broken test
 2019-03-29 19:05:02 -04:00
Lito
2ebd37aba2 Improved article slug generation (#2218) 
* Improved article slug generation

Ruby on Rails has a built-in slug generator since Rails 2.2

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2 

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2 

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Fix downcase transform on event model
 2019-03-26 13:39:35 -04:00
Abraham Williams
9cb40e546b Enables Rails cops (#2186) 
* Enable Rails cops

* Fix Rails/DynamicFindBy

* Fix Rails/HttpStatus

* Fix Rails/Blank

* Fix Rails/RequestReferer

* Fix Rails/ActiveRecordAliases

* Fix Rails/FindBy

* Fix Rails/Presence

* Fix Rails/Delegate

* Fix Rails/Validation

* Fix Rails/PluralizationGrammar

* Fix Rails/Present

* Fix Rails/Output

* Fix Rails/Blank

* Fix Rails/FilePath

* Fix Rails/InverseOf

* Fix Rails/LexicallyScopedActionFilter

* Add Rails/OutputSafety to TODO

* Add Rails/HasManyOrHasOneDependent to TODO

* Add Rails/SkipsModelValidations to TODO
 2019-03-25 09:25:55 -04:00
cyrillefr
a2fcbdc4a4 Enable performance rubocop cops (#2140) 2019-03-21 16:01:45 -04:00
rhymes
116d6b3278 Replace puts with proper logging (#2139) 2019-03-21 13:00:21 -04:00
Tim Lange
3494264404 Enabled rubocop/lint (#2130) 
* WIP: Enabled rubocop/lint

* FIX: Fixed failing test

* FIX: Small change to return

* FIX: Changed indent
 2019-03-21 10:53:44 -04:00
Glenn Carremans
b5eca77d63 Refactor award_yearly_club_badges (#2035) 2019-03-20 13:26:52 -04:00
rhymes
c851953d83 Fix unescaped front matter description in MarkdownFixer (#1989) 2019-03-19 18:19:23 -04:00
Keshav Biswa
8d57d45ecc Rubocop Style cops enabled (#2056) 
* Rubocop enabled style/alias

* Enabled Style/ArrayJoin Cop

* Enabled Style/Attr

* Enabled Case Equality

* Enabled CharacterLiteral

*  Enabled ColonMethodCall Cop

* Enabled CommentAnnotation cop

* Enabled PreferredHashMethods Cop

*  Enabled DoubleNegation Cop

* Enabled EachWithObject Cop

* Enabled EmptyLiteral Cop

* Enabled EvenOdd Cop

* Enabled IfWithSemicolon Cop

* Enabled Lambda and LambdaCall Cop

* Enabled LineEndConcatenation Cop

* Enabled ModuleFunction Cop;

* Enable NegatedIf and NegatedWhile Cop

* Enabled NilComparison Cop

* Enabled Not Cop

* Enabled NumericLiterals Cop

* Enabled OneLineConditional Cop

* Enabled PercentLiteralDelimiters Cop

* Excluded internal/users_controller from negated_if cop

* Reverted the double negation change from github_issue_tag and github_issue.rb"

* Enabled PerlBackrefs Cop

* Changed Regexp.last_match(1) to Regexp.last_match(0)

* Enabled proc cop

* Enabled RaiseArgs Cop

* Reverted Regexp.last_match(0) to Regexp.last_match(1)

* Enabled SelfAssignment Cop

* Enabled SingleLineMethods Cop

* Enabled SpecialGlobalVars Cop

* Enabled VariableInterpolation Cop

* Enabled WhenThen Cop

* Enabled WhileUntilModifier Cop

* Enabled WordArray Cop

* Enabled IfUnlessModifier Cop

* Enabled GuardClause Cop
 2019-03-15 18:33:54 -04:00
Anna Buianova
343f109c0f Optimize stories (#1988) 
* Add db index to articles path

* Slight stories optimizations

* Select only needed fields for the flare tag

* Revert the last commit (to check builds)

* Return selecting only needed fields for tag
 2019-03-12 16:38:22 -07:00
Conlin Durbin
14beb68fd3 Add new gifs to random_gif.rb (#1944) 
* Add new gifs to random_gif.rb

* Update app/labor/random_gif.rb

Co-Authored-By: wuz <conlindurbin@protonmail.com>
 2019-03-05 08:09:06 -08:00
Anna Buianova
0ac8eb1f73 Make less queries when displaying articles flare tags (#1957) 
* Make less queries when displaying flare tag

* Make less sql queries to display articles flare tags
 2019-03-05 07:27:51 -08:00
Ben Halpern
f280d9e266
Fix a couple things and modify dev digest logic (#1954) 2019-03-03 18:25:39 -08:00
Pavel Sušický
40e6078a32 add gifs to random_gif.rb (#1945) 2019-03-02 07:21:43 -08:00
Ben Halpern
c93bc48010
Fix issue with boosted article in email digest (#1936) 
* Adjust email digest

* Fix for missing user.experience_level

* Fix direction of greater than

* Adjust tests for new criteria
 2019-03-01 13:51:06 -08:00
Andy Zhao
b157190ef0 Add missing data for org milestone notifications (#1939) 
* Remove duplicate line

* Add missing json_data for org notifications
 2019-03-01 13:42:38 -08:00