Commit graph

5 commits

Author SHA1 Message Date
Nick Taylor
a71d78df6e
[deploy] Add comment subscription component to article page (#7205)
* wip

* Right aligned the comment subscription panel.

* Cleaned up the comment area on the article page so it uses crayon margin classes.

* Updated tests

* Removed old UI for comment subscriptions.

* Made Discussion text bigger and bolder.

* Fixed some layout issues as per PR comments.

* Fixed some layout issues as per PR comments.

* Updated Storybook stories, tests and snapshots

* wip

* Everything works now, just need to integrate snackbar.

* Removed setTimeout I was debugging with.

* Using the new utilities/http/request utility now.

* Added the <SnackbarPoller />

* Now when unsubscribed, the subscription type resets to all comments.

* Removed overflow hidden from .home CSS class so comment subscription component displays properly.

* Now unsuccessful subscribes/unsubscribes error properly.

* Changed button text from Done to Subscribe

* Merged the <SnackbarPoller /> component into the <Snackbar /> component.

* Fixed a propType issue.

* Fixed a test.

* Removed snackbar tests for now. Need to figure out polling in tests.

* Now comment subscription component is only loaded for logged on users.

* Added a comment.

* Updated some storybook stories.

* Fixed a small formatting issue.

* Reduced snackbar item lifespans to 3 seconds.

* Extracted <CogIcon /> to it's own file because other features are going to need it.

* Added some Storybook stories and tests for the <CogIcon /> component.

* Revert "Extracted <CogIcon /> to it's own file because other features are going to need it."

This reverts commit b30406a50e491c53c3dce5be03bcdf8112b043df.

* Put back <CogIcon /> component.

* Added some error handling if the component doesn't load.

* Moving some things around.

* Rename the article pack file.

* Changed wording from "article" to "post".

* Fixed false negative CSS issue. It was a dangling div tag.

* Add the option to add an optional close button to snackbar items.

* Fixed z-index of subscription type options panel so it is always visible on mobile.

* Reworked the comment subsciption utilities a bit.

* Added test for comment subscription utilities.

* Fixed a broken test from a refactor.

* Added more tests for comment subscription utiltities.

* Fixed comments footer bottom padding.

* Fixed issue with stale find in comment subscription test.

* Update app/javascript/packs/articlePage.jsx

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/article-show.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Changed close button wording to Dismiss.

* Fixed padding to use utility variable instead.

* Added missing import for SASS file.

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-05-05 12:50:30 -04:00
Andy Zhao
f5c94391b7
[deploy] Revert "[deploy] Revert "[deploy] Buttons (#7361)" (#7399)" (#7400)
This reverts commit 028121b39d.
2020-04-20 16:40:50 -04:00
Molly Struve
028121b39d
[deploy] Revert "[deploy] Buttons (#7361)" (#7399)
This reverts commit a20e76995c.
2020-04-20 15:57:38 -04:00
ludwiczakpawel
a20e76995c
[deploy] Buttons (#7361)
* cleanup

* more cleanups

* copy fix + groups

* more buttons

* we are good.

* little shadow update

* .

* doc update

* themes

* stories

* button with icon

* html stories

* button groups

* comment subscription component

* Update small-bell.svg

* tests

* Fix polish locale in snapshots

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-20 14:35:49 -04:00
Nick Taylor
4d0959783f
Comment Subscription Component (#7136)
* Created the <RadioButton /> and <FormField /> components.

* wip

* Now variant for a <FormField /< is optional

* Added the name prop to the <RadioButton /> component.

* Added the onClick prop to the <RadioButton /> component.

* Updated <CommentSubscription /> component with new subscription functionality.

* Added some tests.

* Fixed a bug found be tests I added.

* Reenabled a skipped test.

* Replaced a string with a constant.
2020-04-08 18:11:59 -04:00