Ben Halpern
92b24a9978
Add html_variant split testing to /badge ( #1763 )
...
* Add /badge html_variant
* Fix some of the linting
2019-02-08 12:45:14 -04:00
Ben Halpern
ea63374408
Add below-article html variant ( #1669 )
...
* Add below-article html variant
* Fix tests for variant number
* Fix stories show tests for html_variants
2019-01-28 14:31:43 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
rhymes
96d01b20a2
Use allow/allowed instead of whitelist ( #1296 )
...
* Use allow/allowed instead of whitelist
* Remove duplication in comment
2018-12-10 13:16:16 -05:00
Ben Halpern
f124c2f65a
Fix html variant image prefix issue + other small fixes ( #1005 )
2018-10-24 17:44:59 -04:00
Ben Halpern
735a96432c
Add usability features to html_variants ( #991 )
2018-10-23 16:23:48 -04:00
Ben Halpern
302e8f202d
Add HTML variants for cta optimization and other nav bar adjustments ( #970 )
...
* Add HTML variants for cta optimization and other nav bar adjustments
* Fix 1==1 non-random mistake
* Spruce up org call-to-action
* Change default text color
* Add html variant trial and success request specs
* Fix article sidebar caching issue
* One line adjustment
* Modify schema
* Add include ActionView::Helpers::TagHelper to user_tag_spec
* Modify follow_button to remove session context
* Dummy commit
* Change Edit Article to Edit Post
* Dummy commit
* Fix rubocop concerns
* Fix rubocop style
2018-10-22 17:03:57 -04:00
