cyrillefr
4fd66372dc
Enable Layout/AlignParameters ( #2340 )
...
Check if the parameters on a multi-line method call or definition are aligned.
Resolves : #2021
2019-04-08 18:47:34 -04:00
rhymes
3a53d5797e
Upgrade Rails to 5.2.3 ( #1408 )
2019-04-03 13:08:59 -04:00
Anna Buianova
9c56e4413a
Rubocop fixes ( #2232 )
...
* Enable ClassVars cop
* Enable Style/MultilineBlockChain cop
* Enable Style/SignalException
* Remove config parts matching with the default config
* Fix rubocop issue
* Moved cops that need to be fixed into the .rubocop_todo.yml
2019-03-28 07:35:17 -04:00
Lito
2ebd37aba2
Improved article slug generation ( #2218 )
...
* Improved article slug generation
Ruby on Rails has a built-in slug generator since Rails 2.2
This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6
* Ruby on Rails has a built-in slug generator since Rails 2.2
This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6
* Ruby on Rails has a built-in slug generator since Rails 2.2
This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6
* Ruby on Rails has a built-in slug generator since Rails 2.2
This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6
* Ruby on Rails has a built-in slug generator since Rails 2.2
This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6
* Fix downcase transform on event model
2019-03-26 13:39:35 -04:00
Mario See
91968e3860
block/report abuse in dev-connect ( #2074 )
...
* block chat method
* block and report buttons
* styling
* more styling
* add id redirect
* remove whitespace
* authorize channel in block_chat method
* remove trailing whitespace
* make variable local
* validate using policy
* check channel direct
* fix comparison in chat_channel model
* fix channel variable
2019-03-26 11:53:30 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
Tim Lange
3494264404
Enabled rubocop/lint ( #2130 )
...
* WIP: Enabled rubocop/lint
* FIX: Fixed failing test
* FIX: Small change to return
* FIX: Changed indent
2019-03-21 10:53:44 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
rhymes
dee7429883
Replace each with find_each for AR queries ( #1557 )
2019-01-15 16:38:03 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Mario See
c5e9f010d4
/connect channel members profile pic fix ( #1255 )
...
* update channelDetails, its test, and snapshots
* spacing
* spacing
* spacing
* label spacing
* label spacing
* label spacing
* snapshot update
* refactor implementation
* spacing fix
* styling and small changes
channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users
Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss
* spacing
* update testing and snapshots
* fixed functionality, tests and styling
* leave button update
* show message for empty group
* limit users in channel and show message for empty group
* remove extra period
* change limit from 12 to 11
* show members header
* hide members h3
* increase channel details user limit, increase user object profile pic index
* remove return
* add members header
* Revert "add members header"
This reverts commit 200c6a7f83e3a958cf4199ee295e6a3809249abe.
* limit to 25
2018-12-04 15:00:49 -05:00
Ben Halpern
a761dfbc83
Finalize merge accounts ( #820 )
...
* Add initial remove association feature
* Add initial account deletion feature
* Add back in cursor pointer
* Update email text copy
* Update copy on email html
* Fix nav issue and add integration buttons to account
2018-10-04 12:27:37 -04:00
Maksim Litvinov
33db32e5f4
Fix rubocop lints ( #794 )
2018-10-03 13:00:09 -04:00
Kohei Sugi
1ccfdd4651
Fix Naming/UncommunicativeMethodParamName lint ( #501 )
...
* Fix Naming/UncommunicativeMethodParamName
* code climate
2018-09-04 18:00:26 -04:00
Ben Halpern
01e43a99e7
Fix /connect bug and add email-if-inactive functionality ( #482 )
...
* Add basic functionality for connect message emails
* Fix lint
* Add connect messages email permission
2018-08-27 14:29:53 -04:00
Mac Siri
379829719f
Misc DX improvement ( #621 )
...
* Add updated rack env keys
* Tone-down rack-timeout config
* Avoid cl_image_path in development
* Update README & create env var template
* Update Travis notification config
* Expand Seed file
* Manually-set Rack-timeout config vars
* Fix lint
* Fix Typo(?)
* Add ChatChannel to Seed
* Disable fbq when not in production
* Tweak after_deploy script
* Fix condition
* Change fbq clause
2018-07-25 22:08:17 -07:00
Ben Halpern
e2dbd7cfcc
Remove beta label on /connect and other small changes ( #589 )
...
* Remove beta label on /connect and other small changes
* Add better placeholder for narrow screens
* Adjust comma/bracket placement
* Add description to chat channels
2018-07-16 14:48:38 -04:00
Arun Kumar
9b753a4e9c
Refactor channel permission method ( #584 )
2018-07-16 10:55:18 -04:00
Andy Zhao
6dfcf2e856
Fix adding quotes and dashes in codeblocks ( #557 )
...
* Fix adding quotes and dashes in codeblocks
* Use find_by for all remove_from_feed methods (#558 )
* Destroy memberships when chat channel is destroyed
2018-07-10 13:41:54 -04:00
Ben Halpern
926991f5fc
Fix timezone issues and small adjustment to connect features ( #548 )
2018-07-05 16:39:04 -04:00
Ben Halpern
424be43865
Add chat_channel_membership roles and invite functionality ( #541 )
2018-07-03 13:16:48 -04:00
Ben Halpern
94e5154668
Add initial invitation framework for chat channels ( #528 )
...
* Add initial invitation framework for chat channels
* Update chat_channel specs
* Add DIY concept of accepting invite
* Add some js and fix spec
* Add full invite accept functionality
* Remove console.log from chat
2018-07-02 16:31:20 -04:00
Ben Halpern
258a6ea74f
Add filter buttons to /connect ( #508 )
2018-06-27 21:14:06 -04:00
Ben Halpern
51ba78d015
Fix last opened issue on chat channels ( #445 )
2018-06-14 15:16:58 -04:00
Ben Halpern
fccaf2707f
Adjust chat_channel model ( #441 )
2018-06-14 13:14:12 -04:00
Ben Halpern
115ed2e7f7
Make code work more properly and bind pusher states ( #440 )
2018-06-14 12:50:50 -04:00
Ben Halpern
dc7f8f03b1
Fix connect issue ( #425 )
...
* Add status to chat_channels
* Add allowance for updating existing chat_channel
* Fix index issue
2018-06-12 18:47:04 -04:00
Ben Halpern
87c6a758bb
Add top bar indicator and other Connect features ( #424 )
...
* Add algolia public search key
* Add status to chat_channels
2018-06-12 18:24:57 -04:00
Ben Halpern
75c912c593
Auto create channels for mutual follows ( #419 )
2018-06-11 17:54:30 -04:00
Ben Halpern
cfb0bff881
Fix /live and codemirror stuff ( #417 )
2018-06-11 14:56:52 -04:00
Ben Halpern
bf56ad5cb4
Add message HTML and other goodies ( #411 )
2018-06-08 23:15:21 -04:00
Ben Halpern
1a85bddd2c
Make pusher channels private ( #410 )
2018-06-08 18:49:59 -04:00
Ben Halpern
645de032df
Rearchitect chat channel subscriptions ( #409 )
...
* Update chat and add precompilation paths
* Update chat and add precompilation paths
* Adjust assets.rb
* Remove inconsistent test
* Fix check for pathname in chat
* Rearchitect chat channel subscriptions
2018-06-08 18:38:53 -04:00
Ben Halpern
98d84d2456
Update chat and add precompilation paths ( #406 )
...
* Update chat and add precompilation paths
* Update chat and add precompilation paths
* Adjust assets.rb
2018-06-08 15:31:48 -04:00
Ben Halpern
ab85216621
Update chat and modify article score calc indexing ( #395 )
2018-06-06 16:08:12 -04:00
Ben Halpern
10c3b52b0a
Add chat channel indicator ( #379 )
...
* Add new message indicator to chat
* Add indicator switch to chat
* Add chat switch indicator
2018-06-01 18:16:10 -04:00
Ben Halpern
4171a0814a
Add basic alpha DM functionality to chat ( #375 )
...
* Initial chat DM features
* Update functionality for DM chats
2018-06-01 16:21:48 -04:00
Mac Siri
b4292ade33
Implement chatroom ( #308 )
...
* Fix multiple chat loading bug
* Open profile links in chat via new tab
* Add unmount handling for chat
* Add overscroll property to chat
* Add channel_name to ChatChannel model
* Create route and page for chatroom WIP
* Expose ChatChannel id to live page
* Implement multichannel support WIP
* Implement chatroom page WIP
* Add css for chatroom
* Update chat's moderation
* Refactor chat's message type
* Swap the use of :message_markdown & :message_html
* Add channel permissions WIP
* Fix failing specs
* Adjust json reponses
* Add empty message prevention
* Update participant error message
* Change Workshop channel to General
2018-05-14 12:50:32 -04:00
Mac Siri
0f35939906
Update chat app's features ( #204 )
...
* Update chat.scss --skip-ci
* Fix height issue
* Add highlighting
* Implement bannged user handling for chat
* Add scroll obsever
* Limit initial messages load count & max messages
* Add new message alert when scrolled
* Add link to usernames in chat
* Implement channel clearing feature
* Update parserOptions
* Implement banning feature for chat app WIP
* Add policy for ChatChannelsController
* Fix arugment error
* Update user_not_authorized to handle JSON request
* Update specs for updated user_not_authorized
* Update font-weight for windows os
2018-04-16 13:20:12 -07:00
Mac Siri
8003191a4e
Create Chat app ( #175 )
...
* Setup Pusher gem
* Create ChatChannel and Message model
* Create ChatChannelController
* Add back fix-db-schema-conflicts gem
* Add pusher-js package
* Add validations on Message & ChatChannel models
* Update Route
* Create MessageController
* Update ChatChannelController
* Create Chat app WIP
* Extract messenger render to Message Component
* Implement live chat WIP
* Implement live chat WIP (2)
* Add style and scrollToBottom feature for chat
* Create getUserDataAndCsrfToken function
* Add feature toggle to the new live chat
* Clean up ChatChannelsController & create spec
* Update ChatChannel spec
* Update Message spec
* Create MessagesController spec & refactor
* Clean up Chat app
* Fix lint
* Add character limit to Message
2018-04-04 14:19:57 -07:00
