Commit graph

905 commits

Author SHA1 Message Date
Jess Lee
38091ba486 Update twitter validation and internal/articles query (#1571)
* update validation and only show published articles

* update twitter satellite count

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>
2019-01-16 17:15:22 -05:00
rhymes
5ee725410b Replace data with content in export email copy (#1572) 2019-01-16 17:10:06 -05:00
Ben Halpern
b1f18f5bbc
Improve feed and add more randomness (#1570)
* Improve feed and add more randomness

* Fix tests

* Fix test score calc

* Modify home page test criteria
2019-01-16 16:01:14 -05:00
rhymes
a0c9576bec Export comments (#1471)
* Use name attribute

* Export comments

* Update copy

* Fix time-dependent test

* Remove reactions_count from the export

* Only select needed attributes from the DB

* Add the path of the commentable to the export

Comments are attached to something but from the export that is not easily identifiable. We add the "commentable_path" to give some context.
2019-01-16 12:54:45 -05:00
Ben Halpern
f1e7f12e1d
Reduce queries in bulk follow (#1568) 2019-01-16 12:21:15 -05:00
Jess Lee
5bacb4e8c1 Removed bug reports from app (#1565)
* remove bug report form and add github link

* update abuse report email templates

* remove bug-report logic

* remove emoji from form

* remove revised500 page
2019-01-16 11:28:59 -05:00
Ben Halpern
9736d411d3
Fix get_all_articles in RssReader (#1566) 2019-01-15 22:25:30 -05:00
rhymes
dee7429883 Replace each with find_each for AR queries (#1557) 2019-01-15 16:38:03 -05:00
Ben Halpern
7f7a35048a
Find by title or feed source URL in rss fetch (#1560) 2019-01-15 15:34:13 -05:00
Ben Halpern
47e8fbc9ec
Add feed_fetched_at for users to not refetch unnecessarily (#1555)
* Fix RSS issues by not refetching users as often

* Make rss fetch not forced in rake task

* Remove unnecesary schema line
2019-01-15 13:29:11 -05:00
Ben Halpern
0dac3b9662
Fix search page reading time issue (#1544) 2019-01-14 19:04:02 -05:00
Anna Buianova
53e8490e75 Refactor redirect from the old username or organization slug (#1527) 2019-01-14 18:10:57 -05:00
Ben Halpern
d988bc71f9
Add reading time to articles (#1538)
* add comment template

* merge upstream

* Initial work

* make sure the template re-appears for top level comments after submission

* Small fix

* Fix git issues

* Account for missing reading times

* Add minimal score on sidebar

* Test for page to include min read

* rubocop cleanup

* Mess with test

* Add .to_i after score

* Modify search_score var
2019-01-14 15:58:33 -05:00
Andy Zhao
7726acf157 Update notification's request specs (#1450)
Fixes all the notification request specs that were xited. This should help us feel more comfortable making changes to notifications.

Also made a small (performance?) improvement by using an already defined variable.
2019-01-14 15:20:04 -05:00
Mac Siri
f780e5fbc9 Refactor RssReader (#1537)
* Update RssReader::get_all_articles

* Move RssReader to services

* Create RssReader::Assembler

* Improve RssReader's spec
2019-01-14 14:25:49 -05:00
Andy Zhao
e3f9792b21 Add logging info in case sign in fails (#1519)
* Add logging info in case sign in fails

* Use string interpolation instead

* Remove logger from auth service
2019-01-14 10:01:17 -05:00
Anna Buianova
8610d503a4 Rubocop fixes (#1528) 2019-01-14 09:17:01 -05:00
Jess Lee
aecb0409a2 update unmatched mentor query (#1521) 2019-01-13 16:04:12 -05:00
Arun Kumar
a0d39e15bd Fix braces around hash params Rubocop offense (#1453) 2019-01-11 13:08:45 -05:00
M. Bellucci
a52af3da8b Avoid using meta-programming for solving code duplication. (#1457)
* Add feature spec for twitter login

* Avoid using class eval for solving code duplication.

This change make code easier to change in the future.

* Fix codeclimate issues

* Introduce explanatory methods
2019-01-11 12:00:09 -05:00
Ben Halpern
2fd314e40b
Fix chat css and banish logic (#1515) 2019-01-10 18:09:42 -05:00
Mario See
6ade962480 connect message spacing fix (#1259)
* style changes

* removed detail already in parent class

* Update chat.scss

width assertions

* mobile
2019-01-10 14:33:25 -05:00
Andy Zhao
68807c6df7 Allow Organizations to Update Slug/Username (#1411)
* Close anchor tag typo

* Remove confusing message in profile

* Fix typo in spec

* Add old_slug and old_old_slug fields to org

* Test for check_for_slug_change method

* Add ability for orgs to change slug

* Update copy to match new org language

* Add redirect for organizations with old slugs

* Use less queries for handling org/user redirect

* Use consistent syntax for user creation

* Test for organization slug redirects

* Refactor user article redirect
2019-01-10 14:16:43 -05:00
Andrew Bone
4673496830 SlideShare Liquid tag (#1485)
* Create slideshare_tag.rb

* Create slideshare_tag_spec.rb

* Add slide share

* rubocop compliance

* Still learning

https://ruby-doc.org/core-2.5.1/Regexp.html

* More secure match

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Strip whitespace

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Strip before regex

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Remove latter strip

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
2019-01-10 12:58:16 -05:00
Anna Buianova
8f348f9831 Fix comment cancel button url (#1508) 2019-01-10 12:25:11 -05:00
Ben Halpern
b4384867ad
Remove access_token key for twitter dump (#1510) 2019-01-10 11:48:27 -05:00
Jess Lee
5e4508ebe1 Remove callbacks from banisher + specs! (#1501)
* wip remove callbacks from banisher

* remove pry
2019-01-09 15:12:38 -05:00
Ben Halpern
ebc859f574
Fix user-select issue in comments (#1502) 2019-01-08 19:38:13 -05:00
Andy Zhao
08e01b2c2a Fix Podcast Liquid Tag (#1500)
* Test for podcast tag properly rendering

* Include CL helper
2019-01-08 18:45:42 -05:00
Mario See
8bb1716935 connect chat message markdown styling (#1487)
* remove inline markdown rule

* broaden evaluate_inline_markdown

basically same as evaluate_markdown but without class attributes

* remove inline markdown parser

* change code block color and background

* even out code padding top/bottom
2019-01-08 17:48:12 -05:00
Ben Halpern
d187795603
Update dashboard_show admin permissions (#1496)
* Update dashboard_show admin permissions

* Add :admin access to update posts
2019-01-08 17:46:31 -05:00
Ben Halpern
f626a3a2ad
Modify display and style of API tokens (#1490)
* Modify display and style of API tokens

* Delete accidentally-included slideshare tag
2019-01-08 16:17:00 -05:00
Ben Halpern
7333aa5436
Fix comment creation (#1495) 2019-01-08 14:29:49 -05:00
Andy Zhao
a612730b6b Remove extraneous slash for path (#1489) 2019-01-08 13:25:08 -05:00
Ben Halpern
7c8f71251d
Add details to toggles and modify some styling (#1484)
* Add details to toggles and modify some styling

* Add details to child comments

* Finalize comment collapse in nested comments

* Modify styling on comment <details>
2019-01-08 12:53:48 -05:00
Timothy Ng
84bd3a69d7 ApiSecret model for Developer API (#1369)
* Add ApiSecret model scaffold

* Add relationships between ApiSecret, User, Organization

* Add placeholder template to account tab

* Add description column to ApiSecrets

* Add very basic access token generation

* Add basic access token deletion

* Show access token on success flash

* Add placeholder message when user has no secrets

* Use cta style on token generation button

* Add presence validation for ApiSecret description

* Add ApiSecrets factory

* Add pundit policy for ApiSecret

* Nest form field within api_secret hash to allow rails strong params

* Use pundit to authorize ApiSecretController actions

* Add error message flash for ApiSecretsController actions

* Add specs for ApiSecretsController

* Add length validation to api secret description

* Flash model error instead of generic message on save failure

* Truncate ApiSecret factory objects descriptions to prevent validation error

* Remove length restriction on ApiSecret.description

* Use darker font color for token creation date

* Consolidate ApiSecret migrations
2019-01-08 12:30:54 -05:00
Andrew Bone
9ea53d5669 Add --theme-container-color (#1479)
* Add --theme-container-color

Add --theme-container-color for theming all containing elements

* Add --theme-container-color

Add --theme-container-color for theming all containing elements

* Add --theme-container-color

Add --theme-container-color for theming all containing elements

* Add --theme-container-color

Add --theme-container-color for theming all containing elements

* Add --theme-container-color

Add --theme-container-color for theming all containing elements

* Add --theme-container-color

Add --theme-container-color for theming all containing elements

* Add --theme-container-color

Add --theme-container-color for theming all containing elements
2019-01-07 15:56:01 -05:00
Mac Siri
f4ca4a15e5 Fix liquid tag parsing error (#1481)
* Fix liquid tag parsing error

* Update spec
2019-01-07 15:54:57 -05:00
Andrew Bone
abc8aaf793 Missed --theme-container-border (#1480)
* Missed --theme-container-border

Adding --theme-container-border for missed elements

* Missed --theme-container-border

Adding --theme-container-border for missed elements

* Missed --theme-container-border

Adding --theme-container-border for missed elements
2019-01-07 11:27:02 -05:00
Andrew Bone
8cccc03b9a Add --theme-container-box-shadow places missed (#1420)
* Add --theme-container-box-shadow to footer

Add the --theme-container-box-shadow variable to the footer box shadow

* Add --theme-container-box-shadow to dashboard-analytics-header-wrapper

Add the --theme-container-box-shadow variable to the dashboard-analytics-header-wrapper

* Add --theme-container-box-shadow to query

Add the --theme-container-box-shadow variables to the no results query page

* Add --theme-container-box-shadow to widgets

Add the --theme-container-box-shadow variables to widgets
2019-01-06 15:15:38 -05:00
Ben Halpern
9af401ad09
Remove user signed in difference in article show comment form (#1468) 2019-01-05 22:27:34 -05:00
Ben Halpern
69b90272a9
Improve caching on article show view (#1467) 2019-01-05 21:42:10 -05:00
Vinicius Brasil
583160532c Improve User profile form labels capitalization (#1464) 2019-01-05 21:40:57 -05:00
Ben Halpern
e79f3bfbc1
Fix linting (#1463) 2019-01-04 21:13:12 -05:00
Andrew Bone
6b4b8b9c6a Add --theme-container-border (#1421)
* Add --theme-container-border

Add the --theme-container-border variable for styling.

* Add --theme-container-border

Add the --theme-container-border variable for styling.

* Add --theme-container-border

Add the --theme-container-border variable for styling.

* Add --theme-container-border

Add the --theme-container-border variable for styling.
2019-01-04 20:37:53 -05:00
Mac Siri
8e50e58844 Add list-style to Widget (#1448)
* Add list

* Remove retry
2019-01-04 17:48:12 -05:00
rhymes
de5b889445 Fix Rubocop Style/MixinUsage and cleanup prefix_all_images (#1451)
* Use sanitizer to strip HTML tags

* Fix Style/MixinUsage

* Cleanup prefix_all_images

* Stay under 25 lines of code
2019-01-04 14:20:53 -05:00
Abraham Williams
67e9ba223d Remove debug line (#1462) [ci skip] 2019-01-04 13:10:09 -05:00
Jess Lee
4214bcbbf6 Add user status to internal/users (#1444)
* wip

* add indiviual user partial

* remove unnecessary attributes

* wip

* add indiviual user partial

* remove unnecessary attributes

* remove mentorship matching from view

* fix linting

* add mentor matching method back and refine test

* remove duplicate mentee descriptions

* Update app/controllers/internal/users_controller.rb

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>
2019-01-03 16:44:43 -05:00
Arun Kumar
80a23ba403 Fix rubocop offenses (#1452) 2019-01-03 09:23:38 -05:00