Commit graph

675 commits

Author SHA1 Message Date
Ben Halpern
92a541a517
Add a couple specs for notifications and pages (#522)
* Add a couple specs

* Remove stream VCR from notifications_spec

* Add github readme spec

* Add notifications count specs

* Add guards in notifications controller

* Fix test

* Fix test
2018-06-29 14:14:36 -04:00
Andy Zhao
62352fe6d6 Authorize admin after checking csrf (#523) 2018-06-29 13:59:03 -04:00
Ben Halpern
71c94b6546
Fix boosted posts and add spec (#521) 2018-06-28 17:22:02 -04:00
Mac Siri
6bae46fbbf Remove escaping of user_params (#500)
* Remove the need to escape user_params

* Fix lint

* Permit password and password_confirmation

* Fix lint
2018-06-28 15:56:24 -04:00
Ben Halpern
799aa16378
Fix /live for workshop (#516) 2018-06-28 14:28:24 -04:00
Tiffany Wismer
414d259c0d Fixed errors in last pull request (#502) 2018-06-28 12:11:04 -04:00
Ben Halpern
7e9280390c
Add /survey and modified several page titles (droped the the) (#515)
* Add /survey and modified several page titles (droped the the)

* Add emojis to page title
2018-06-28 11:07:42 -04:00
Edem Attikese
0ad8cd9eab Edem/improvements/pundit coverage (#498)
* added organization policy + spec

* user specs for is_org_admin?

* added authroize to organization controller

* admin policy + specs

* deleted enforce admin due to pundit policy redundancy

* applied admin policy to entire admin namespace

* refactoring analytics controller WIP - wanna test codeship

* Add protection against reactions to unpublished articles (#473)

* Add chat channel policy and spec (#474)

* Add comment policy and specs (#475)

* Fix edge case with apostrophes

* Add comment policy and specs

* Add login for deleting comment spec

* Change test to raise pundit error instead of 404

* Clean up comment destroy request specs

* Remove redundant raise

* Whitelist columns on to_json call (#477)

* Add pundit policy for several controllers (#476)

* Add pundit policy for several controllers

* Adjust video spec

* Fix tag request specs

* Add proper twilio tokens request specs

* Remove puts statements

* Add a couple basic request specs (#478)

* Add a few tests and fix user tag color bug (#482)

* Refactor handle_tag_index in stories_controller (#481)

* Modify valid_request_origin? (#483)

* Add misc specs and remove banned attribute from user model (#484)

*  Fix missing Cloudinary tags and misc specs (#486)

* removing current_user_is_admin? to use .is_admin? method

* added missing org policy routes

* Add comment for all public controllers

* Fix edge case for test

* Authorize mod controller and add specs

* Refactor methods via inheritance and use only super_admin role

* Create policy method for analytics via article_policy and refactor

* Capitalize all buttons in dashboard page

* Fix org tests and remove old admin test

* Use only happy path for analytics

* Fix tests to use Pundit error

* Update org_policy spec
2018-06-28 09:38:20 -04:00
Andy Zhao
cd9f6d9ada [Done] Add BDEFGI Policies and Specs (#487)
* Add comment for public controllers

* Add block policy and specs

* Add policy for authorizing dashboard

* Add follow policy and specs

* Refactor a tiny bit

* Prevent banned users from following anything

* Add a note for email sub controller about auth

* Add image upload policies

* Add policy for github repos

* Fix typo and use correct github repo variable

* Fix image uploader and use regular params

* Add authenticate_user before action back in

* Rename test

* Update slack bot message formatting and fix reported URL
2018-06-26 09:23:07 -04:00
Mac Siri
dd5a22dc80 Create UserPolicy (#480)
* Fix lint

* Create User#settings_tab_list

* Remove UsersController#finish_signup

* Remove UsersController#index

* Create UserPolicy WIP

* Replace UsersController's spec with request spec

* Fix broken specs

* Fix broken specs

* Remove comment

* Upgrade UserPolicy

* Fix specs
2018-06-22 20:40:08 -04:00
Ben Halpern
5a59b4c8a9
Fix missing Cloudinary tags and misc specs (#486) 2018-06-22 16:29:17 -04:00
Ben Halpern
b44a3eecc2
Modify valid_request_origin? (#483) 2018-06-22 13:38:19 -04:00
Tiffany Wismer
7f0f2328c0 Refactor handle_tag_index in stories_controller (#481) 2018-06-22 10:40:11 -04:00
Ben Halpern
03e4f6531f
Add a few tests and fix user tag color bug (#482) 2018-06-22 10:22:53 -04:00
Ben Halpern
13a92d17cb
Add a couple basic request specs (#478) 2018-06-21 18:35:34 -04:00
Ben Halpern
c60268b76f
Add pundit policy for several controllers (#476)
* Add pundit policy for several controllers

* Adjust video spec

* Fix tag request specs

* Add proper twilio tokens request specs

* Remove puts statements
2018-06-21 18:26:35 -04:00
Ben Halpern
2b4749bf11
Whitelist columns on to_json call (#477) 2018-06-21 17:43:56 -04:00
Andy Zhao
0785720908 Add comment policy and specs (#475)
* Fix edge case with apostrophes

* Add comment policy and specs

* Add login for deleting comment spec

* Change test to raise pundit error instead of 404

* Clean up comment destroy request specs

* Remove redundant raise
2018-06-21 17:20:34 -04:00
Ben Halpern
8b53f68574
Add chat channel policy and spec (#474) 2018-06-21 16:58:21 -04:00
Mac Siri
ff36271108 Improve ArticlesController's authorization (#466)
* Fix lint

* Add pundit-matchers gem

* Strengthen ArticlePolicy & create spec

* Change ApplicationPolicy to a closed system

* Globally handle pundit's NotAuthorizedError

* Fix lint

* Adjust /new's authorization
2018-06-21 14:18:32 -04:00
Andy Zhao
263a74bcb6 Add more request specs (#460)
* Remove email blank onboarding redirect

* Add authorization specs for video upload

* Add registration spec

* Remove skip before actions for signup complete

* Use new param for abuse reports

* Remove else because it never runs

* Add more dashboard request specs

* Use let with no bang in case there are errors
2018-06-20 17:46:23 -04:00
Ben Halpern
0941b2e4fb
Add some tests around model validations (#459)
* Modify sample_application.yml and write test

* Add ahrefs verification

* Add some tests around model validations

* Indent an end

* Add a few tests

* Add tests and reserved words

* Fix live articles spec typo

* Modify ga_events_controller
2018-06-20 17:14:08 -04:00
Andy Zhao
ecbb9d4ab1 [Done] New Reporting System MVP (#408)
* Move validations from controller to model

* Add new columns to feedback message model

* Use polymorphic notes relationship

* MVP of ticketing system

* Use new URL for reported_url param

* Add missing files

* Add validations and tests for feedback_messages

* Clean up some html

* Update create spec and add update spec

* Add mail tests and lint

* Add link to user profile
2018-06-19 16:41:31 -04:00
Mac Siri
ec264bf802 Clean up spec outputs (#450)
* Improve BadgeAchievementSpec

* Create specs for PushNotificationSubscription

* Clean-up specs for VideoStatesController

* Refactor spec
2018-06-19 16:27:15 -04:00
Ben Halpern
914102f19f Add basic github support to /connect 2018-06-19 13:46:10 -04:00
Ben Halpern
da585b5f83 Merge branch 'ben/adjust-timestamps' into ben/video 2018-06-18 12:54:47 -04:00
Ben Halpern
74d098f580 Fix bugs and add video 2018-06-18 12:53:43 -04:00
Andy Zhao
cfd95a65af Update "Connect Twitter acct" in settings with new callback url (#439)
* Update "Connect Twitter acct" in settings with new callback url

* Remove name from comments (#437)
2018-06-15 12:52:14 -04:00
Ben Halpern
277739609e
Adjust location of timestamps (#447) 2018-06-14 19:08:19 -04:00
Ben Halpern
6e35875f2c Adjust location of timestamps 2018-06-14 18:54:40 -04:00
Ben Halpern
ad733aa9fe
Add top bar Connect icon 😱 (#443) 2018-06-14 13:50:55 -04:00
Ben Halpern
e124decabc
Adjust messages_controller to send message before it is persisted if it is valid (#434) 2018-06-13 17:35:17 -04:00
Ben Halpern
4d9019f8a1 Remove raise oooofffff 2018-06-12 23:19:46 -04:00
Ben Halpern
66cb24dddf Fix callback issue 2018-06-12 22:19:44 -04:00
Ben Halpern
cb4340819e Change Twitter callback_url 2018-06-12 21:40:55 -04:00
Ben Halpern
dc7f8f03b1
Fix connect issue (#425)
* Add status to chat_channels

* Add allowance for updating existing chat_channel

* Fix index issue
2018-06-12 18:47:04 -04:00
Ben Halpern
87c6a758bb
Add top bar indicator and other Connect features (#424)
* Add algolia public search key

* Add status to chat_channels
2018-06-12 18:24:57 -04:00
Ben Halpern
cfb0bff881
Fix /live and codemirror stuff (#417) 2018-06-11 14:56:52 -04:00
Ben Halpern
fb20b8adf7
Add content sidecar for chat (#413)
* Rearchitect chat channel subscriptions

* Add browser push notifications (attempt)

* Add content sidecar for chat

* Add live code basics

* Add content features to chat

* Fix chat_channels test
2018-06-11 11:00:51 -04:00
Ben Halpern
7bc3e60283
Add browser push notifications (attempt) (#412) 2018-06-09 17:33:58 -04:00
Ben Halpern
bf56ad5cb4
Add message HTML and other goodies (#411) 2018-06-08 23:15:21 -04:00
Ben Halpern
1a85bddd2c
Make pusher channels private (#410) 2018-06-08 18:49:59 -04:00
Ben Halpern
645de032df
Rearchitect chat channel subscriptions (#409)
* Update chat and add precompilation paths

* Update chat and add precompilation paths

* Adjust assets.rb

* Remove inconsistent test

* Fix check for pathname in chat

* Rearchitect chat channel subscriptions
2018-06-08 18:38:53 -04:00
Mac Siri
923e1acbda Create Suggester service object (#372)
* Create Suggester::Article::Boosted

* Fix lint & Remove .compact

* Expand Suggester service-object WIP

* Create Suggester::Users

* Remove ClassicArticle

* Replace old refactored classes

* Move Suggester specs into appropriate folder

* Fix broken spec & Fix lint

* Fix lint

* Fix lint

* Fix broken code
2018-06-08 17:17:20 -04:00
Ben Halpern
98d84d2456
Update chat and add precompilation paths (#406)
* Update chat and add precompilation paths

* Update chat and add precompilation paths

* Adjust assets.rb
2018-06-08 15:31:48 -04:00
Ben Halpern
9729bc8d0d Handle open for open channels 2018-06-07 16:55:15 -04:00
Andy Zhao
d6a7102f3b [Done] Fix update and create events (#404)
* Close out a div properly

* Rename file to .html.erb

* Move new event form back to index page

* Update test to use index view
2018-06-07 15:35:09 -04:00
Ben Halpern
04aa888d5c
Add inline moderation buttons (#401) 2018-06-07 12:47:31 -04:00
Ben Halpern
39ecf7d70d
Fix live and adjust coming soon (#400) 2018-06-07 11:42:41 -04:00
Ben Halpern
ab85216621
Update chat and modify article score calc indexing (#395) 2018-06-06 16:08:12 -04:00