cyrillefr
4fd66372dc
Enable Layout/AlignParameters ( #2340 )
...
Check if the parameters on a multi-line method call or definition are aligned.
Resolves : #2021
2019-04-08 18:47:34 -04:00
Mac Siri
73127aca01
Remove controller specs ( #2224 )
...
* Create more request specs
* Update wording
* Update guard to work with requests
* Fix broken spec
* Remove rails-controller-testing gem
* Move article_specs
* Move last controller spec out
* Remove controller spec config
* Fix broken spec
* Remove all use of render_template
* Refactor spec
* Tweak User#remember_me
* Create ArticleAnalyticFetcher spec
* Undo User#remember_me
* Use srand in rspec
* Create FeedbackMessagesHelper spec
* Add DigestMailer spec
* Fix broken test
2019-03-29 19:05:02 -04:00
Ben Halpern
d1e73dceba
Clean up new chat channel functionality and add tests ( #2220 )
2019-03-26 13:35:32 -04:00
Tim Lange
3494264404
Enabled rubocop/lint ( #2130 )
...
* WIP: Enabled rubocop/lint
* FIX: Fixed failing test
* FIX: Small change to return
* FIX: Changed indent
2019-03-21 10:53:44 -04:00
rhymes
27213bf6da
Use ActiveRecord::RecordNotFound instead of ActionController::RoutingError for 404s ( #2118 )
2019-03-19 20:54:25 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Ben Halpern
e2dbd7cfcc
Remove beta label on /connect and other small changes ( #589 )
...
* Remove beta label on /connect and other small changes
* Add better placeholder for narrow screens
* Adjust comma/bracket placement
* Add description to chat channels
2018-07-16 14:48:38 -04:00
Ben Halpern
94e5154668
Add initial invitation framework for chat channels ( #528 )
...
* Add initial invitation framework for chat channels
* Update chat_channel specs
* Add DIY concept of accepting invite
* Add some js and fix spec
* Add full invite accept functionality
* Remove console.log from chat
2018-07-02 16:31:20 -04:00
Ben Halpern
5a59b4c8a9
Fix missing Cloudinary tags and misc specs ( #486 )
2018-06-22 16:29:17 -04:00
Ben Halpern
03e4f6531f
Add a few tests and fix user tag color bug ( #482 )
2018-06-22 10:22:53 -04:00
Ben Halpern
8b53f68574
Add chat channel policy and spec ( #474 )
2018-06-21 16:58:21 -04:00
Mac Siri
ff36271108
Improve ArticlesController's authorization ( #466 )
...
* Fix lint
* Add pundit-matchers gem
* Strengthen ArticlePolicy & create spec
* Change ApplicationPolicy to a closed system
* Globally handle pundit's NotAuthorizedError
* Fix lint
* Adjust /new's authorization
2018-06-21 14:18:32 -04:00
Ben Halpern
0941b2e4fb
Add some tests around model validations ( #459 )
...
* Modify sample_application.yml and write test
* Add ahrefs verification
* Add some tests around model validations
* Indent an end
* Add a few tests
* Add tests and reserved words
* Fix live articles spec typo
* Modify ga_events_controller
2018-06-20 17:14:08 -04:00
Ben Halpern
3a623993d4
Modify sample_application.yml and write test ( #456 )
...
* Modify sample_application.yml and write test
* Add ahrefs verification
2018-06-19 19:06:22 -04:00
Ben Halpern
cfb0bff881
Fix /live and codemirror stuff ( #417 )
2018-06-11 14:56:52 -04:00
Ben Halpern
fb20b8adf7
Add content sidecar for chat ( #413 )
...
* Rearchitect chat channel subscriptions
* Add browser push notifications (attempt)
* Add content sidecar for chat
* Add live code basics
* Add content features to chat
* Fix chat_channels test
2018-06-11 11:00:51 -04:00
Mac Siri
0f35939906
Update chat app's features ( #204 )
...
* Update chat.scss --skip-ci
* Fix height issue
* Add highlighting
* Implement bannged user handling for chat
* Add scroll obsever
* Limit initial messages load count & max messages
* Add new message alert when scrolled
* Add link to usernames in chat
* Implement channel clearing feature
* Update parserOptions
* Implement banning feature for chat app WIP
* Add policy for ChatChannelsController
* Fix arugment error
* Update user_not_authorized to handle JSON request
* Update specs for updated user_not_authorized
* Update font-weight for windows os
2018-04-16 13:20:12 -07:00
Mac Siri
8003191a4e
Create Chat app ( #175 )
...
* Setup Pusher gem
* Create ChatChannel and Message model
* Create ChatChannelController
* Add back fix-db-schema-conflicts gem
* Add pusher-js package
* Add validations on Message & ChatChannel models
* Update Route
* Create MessageController
* Update ChatChannelController
* Create Chat app WIP
* Extract messenger render to Message Component
* Implement live chat WIP
* Implement live chat WIP (2)
* Add style and scrollToBottom feature for chat
* Create getUserDataAndCsrfToken function
* Add feature toggle to the new live chat
* Clean up ChatChannelsController & create spec
* Update ChatChannel spec
* Update Message spec
* Create MessagesController spec & refactor
* Clean up Chat app
* Fix lint
* Add character limit to Message
2018-04-04 14:19:57 -07:00
