Commit graph

83 commits

Author SHA1 Message Date
Kohei Sugi
7760a8d196 Fix Lint/UselessAssignment (#388) 2018-08-23 15:03:29 -04:00
Ben Halpern
992c95ff25 Add healthy debate flare tag and sidebar widget (#449) 2018-08-23 14:57:43 -04:00
Mac Siri
69fc87a67d Refactor CacheBuster (#286) 2018-08-08 17:45:14 -04:00
rhymes
e588fa7ece Code cleanups (#659)
* Initial automatic cleanup with rubocop

* Fix syntax error introduced by rubocop

* Cleanup seeds file

* Cleanup lib folder

* Exclude bin folder because it contains auto generated files

* Make Rubocop a little bit more chatty

* Block length should not include comments in the count

* Cleanup config folder

* Cleanup specs

* Updated Rubocop version and generated a todo file

* Fix broken ArticlesApi spec

* Fix tests

* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Arun Kumar
52486a4edd Update instance methods to module methods (#613) 2018-07-23 12:13:42 -07:00
Arun Kumar
0a0e9fd294 Refactor (#596) 2018-07-23 11:49:27 -04:00
Mac Siri
40f488d991 Migrate to Travis CI (part 2) (#591)
* Update Travis.yml

* Update README

* Update README

* Adjust test to not rely on env vars

* Update encryption

* Refactor

* Update env key

* Stub AWS calls

* Create ApplicationConfig

* Fix specs

* Fix lint

* Update ApplicationConfig

* Remove travis env vars

* Fix lint

* Extend character limit to 100

* Add env to travis

* Take out auto-restart after deploy

* Immediately discarded test cache

* Stub GA in request specs

* Stub Pusher

* Fix broken specs

* Update fixture

* Add CodeClimate id

* Change CodeClimate key

* Remove merge mistakes

* WIP

* Add Envied gem & Change README

* Add missing keys

* Add missing key

* Update fixture

* Fix broken spec

* Add Slack Notification for Travis

* Fix wording

* Fix typo
2018-07-20 20:17:18 -04:00
Ben Halpern
e995e081ad
Add rich links to /connect and remove auto sidecar opening (#582) 2018-07-13 16:56:26 -04:00
Yechiel Kalmenson
37e0059ade open markdown links in new tab (take 2) (#512)
* open links in chats in new tabs

* fixed target_blank vulnerability

* add test to make sur links are being generated with target _blank

* add test for target blank vulnerability

* add rel and target to the whitelisted attributes

* add the link attributes to HTMLRouge#link
2018-07-11 15:04:03 -04:00
Andy Zhao
6dfcf2e856 Fix adding quotes and dashes in codeblocks (#557)
* Fix adding quotes and dashes in codeblocks

* Use find_by for all remove_from_feed methods (#558)

* Destroy memberships when chat channel is destroyed
2018-07-10 13:41:54 -04:00
Ben Halpern
424be43865
Add chat_channel_membership roles and invite functionality (#541) 2018-07-03 13:16:48 -04:00
Ben Halpern
92a541a517
Add a couple specs for notifications and pages (#522)
* Add a couple specs

* Remove stream VCR from notifications_spec

* Add github readme spec

* Add notifications count specs

* Add guards in notifications controller

* Fix test

* Fix test
2018-06-29 14:14:36 -04:00
Yechiel Kalmenson
f7a826cc17 open links in chats in new tabs (#492) 2018-06-26 14:40:05 -04:00
Andy Zhao
cd9f6d9ada [Done] Add BDEFGI Policies and Specs (#487)
* Add comment for public controllers

* Add block policy and specs

* Add policy for authorizing dashboard

* Add follow policy and specs

* Refactor a tiny bit

* Prevent banned users from following anything

* Add a note for email sub controller about auth

* Add image upload policies

* Add policy for github repos

* Fix typo and use correct github repo variable

* Fix image uploader and use regular params

* Add authenticate_user before action back in

* Rename test

* Update slack bot message formatting and fix reported URL
2018-06-26 09:23:07 -04:00
Ben Halpern
75d3a79c12
Add search_keywords record and associated functionality (#494)
* Add search_keywords record and associated functionality

* Fix test and add badge rewarder method
2018-06-25 11:58:07 -04:00
Ben Halpern
da585b5f83 Merge branch 'ben/adjust-timestamps' into ben/video 2018-06-18 12:54:47 -04:00
Ben Halpern
74d098f580 Fix bugs and add video 2018-06-18 12:53:43 -04:00
Andy Zhao
cfd95a65af Update "Connect Twitter acct" in settings with new callback url (#439)
* Update "Connect Twitter acct" in settings with new callback url

* Remove name from comments (#437)
2018-06-15 12:52:14 -04:00
Mac Siri
82dfc57b63 Fix broken spec (#423) 2018-06-12 17:23:16 -04:00
Mac Siri
8d36c74d3c Move HTMLRouge into lib (#403)
* Move HTMLRouge into lib

* Fix lint
2018-06-12 16:53:58 -04:00
Mac Siri
8739a9a59b Remove verbose registration of Liquid & ReverseMarkdown's extensions (#416)
* Add autoreload for ReverseMarkdown converters

* Change how custom liquid tags are registered

* Apply autreload logic to test
2018-06-11 17:33:03 -04:00
Ben Halpern
fb20b8adf7
Add content sidecar for chat (#413)
* Rearchitect chat channel subscriptions

* Add browser push notifications (attempt)

* Add content sidecar for chat

* Add live code basics

* Add content features to chat

* Fix chat_channels test
2018-06-11 11:00:51 -04:00
Ben Halpern
bf56ad5cb4
Add message HTML and other goodies (#411) 2018-06-08 23:15:21 -04:00
Mac Siri
923e1acbda Create Suggester service object (#372)
* Create Suggester::Article::Boosted

* Fix lint & Remove .compact

* Expand Suggester service-object WIP

* Create Suggester::Users

* Remove ClassicArticle

* Replace old refactored classes

* Move Suggester specs into appropriate folder

* Fix broken spec & Fix lint

* Fix lint

* Fix lint

* Fix broken code
2018-06-08 17:17:20 -04:00
Mac Siri
dd958ba40c Move custom TagParser into lib (#399) 2018-06-08 13:44:52 -04:00
Ben Halpern
dfe93e5509
Fix twitter length issue in bufferizer (#390) 2018-06-05 12:29:25 -04:00
Ben Halpern
7b6d188e40
Flush users after badge reward (#386) 2018-06-05 10:21:48 -04:00
Ben Halpern
fd4390983c
Add badge achievemnt context message markdown (#382)
* Add badge achievemnt context message markdown

* Add badge rewarder method for beloved comments
2018-06-04 17:31:01 -04:00
Ben Halpern
3afb158ed2
Add additional boosted tags to articles (#371) 2018-05-31 15:28:05 -04:00
Ben Halpern
f1256646da
Modify Github Readme so it parses images properly (#369) 2018-05-31 12:45:30 -04:00
Ben Halpern
0d82c50a3d
Add BadgeRewarder class and rake for auto badging (#367) 2018-05-30 17:37:34 -04:00
Ben Halpern
a6cc5e4669
Fix Github Readme tag and add Glitch tag (#357) 2018-05-29 14:09:47 -04:00
Ben Halpern
a8d6de0dc4
Fix cache bust for social images (#356) 2018-05-27 12:41:11 -04:00
Ben Halpern
ce255ba900
Add speakerdeck liquid tag (#343)
* Take darker of user colors

* Add speakerdeck liquid tag

* Modify speakerdeck test
2018-05-22 17:31:07 -04:00
Ben Halpern
c36c7d8d28
Update default social cards (#341) 2018-05-22 15:40:42 -04:00
Andy Zhao
c9c02ef3c0 [Done] Fix div in li issue (#320)
* Lint and clean up github issue styles

* Use heredoc HTML for easier formatting

* Add better error handling for 404 github issues

* Use custom sanitizer for markdown render

* Refactor unless to ternary

* Rename file and tighten up sanitization

* Fix codepen and instagram tag styling
2018-05-21 17:35:03 -04:00
Ben Halpern
e21544be52
Modify onboarding suggestions to make more relevant for suggestee (#330)
* Take darker of user colors

* Modify onboarding suggestions to make more relevant for suggestee

* Make user follower suggestions work for tests
2018-05-19 19:23:16 -04:00
Andy Zhao
95891897b7 Use URI.join to join relative paths (#329) 2018-05-19 10:53:13 -04:00
Ben Halpern
f073eb5754
Add badges and org cta (#324)
* Make org proof a required field

* Fix color picker and other minor org adjustments

* Add MVP of org add'l sidebar

* Add proof to org factory

* Fix org create action and fix tests

* Add new org fields to admin panel & lint

* Add proof to org edit for backward compatibility

* Add org info to edit preview

* Move preview edit notice to inside article div

* MVP of badge "final" steps

* Add info to user sidebar and clean up badge commit

* Modify sidebar for data

* Add organization decorator

* Add conditional so only users have new swipe nav, not orgs

* Add cloudinary prefix to badges

* Disallow duplicate badges
2018-05-17 18:22:37 -04:00
Ben Halpern
e54f160084
Add video thumbnail to social hierarchy (#309) 2018-05-11 13:56:17 -04:00
Mac Siri
5d1902f65f Remove new line replacement (#285) 2018-05-07 17:55:11 -04:00
Ben Halpern
524052234a
Add email_digest_eligible check to non-following emails (#278) 2018-05-03 17:34:31 -04:00
Ben Halpern
f2101410ea
[WIP] Improve article boosting abilities and insights (#237)
* Update email subjects split test

* Create alternate editor

* Add proof of concept to emails

* Add utm for internal nav

* Add ability to boost in DEV Digest

* Adjust articles.scss

* Adjust article_form.scss

* Remove unnecessary files

* Remove files from PR

* Adjust boosted email settings

* Conditionally include organization in additional box

* Modify schema.rb
2018-05-02 12:24:54 -04:00
Ben Halpern
e713710c4c Fix who to follow issues 2018-05-01 11:36:35 -04:00
Andy Zhao
d6e3344da7 [Updated] Suggested Follows Sidebar (#240)
* MVP of follow sidebar

* Prettier linted stuff

* More prettier lint

* Load only one widget

* fix github issue comment liquid tag (#242)

* Adjust Flatiron school copy/link (#241)

Per Flatiron School request, updating the homepage copy and link

* Add sticky sidebar to article show page (#243)

* Add sidebar sticky elements

* Add sticky sidebar to article show page

* Add saved changes check to user

* Fix missing CSS variable in sticky nav file

* Add date joined as default summary

* Remove accidentally-included file

* Add check for published on article sidebar

*  Fix styling issues on side nav (#244)

* Add sidebar sticky elements

* Add sticky sidebar to article show page

* Add saved changes check to user

* Fix missing CSS variable in sticky nav file

* Add date joined as default summary

* Remove accidentally-included file

* Add check for published on article sidebar

* Fix styling issues on side nav

* Ben/article show redesign (#245)

* Add sidebar sticky elements

* Add sticky sidebar to article show page

* Add saved changes check to user

* Fix missing CSS variable in sticky nav file

* Add date joined as default summary

* Remove accidentally-included file

* Add check for published on article sidebar

* Fix styling issues on side nav

* Modify article order

* Fix issue in side bar

* Fix issue in side bar

* Ben/article show redesign (#246)

* Add sidebar sticky elements

* Add sticky sidebar to article show page

* Add saved changes check to user

* Fix missing CSS variable in sticky nav file

* Add date joined as default summary

* Remove accidentally-included file

* Add check for published on article sidebar

* Fix styling issues on side nav

* Modify article order

* Fix issue in side bar

* Fix issue in side bar

* Not show author image as other images

* Remove current article id from potential queried articles (#247)

* Add optimistic rendering for follow buttons

* Remove redundant line

* Fix inline stylesheet issue (#248)

* Remove current article id from potential queried articles

* Fix inline stylesheet issue

* Modify sticky_articles source to be more similar to post

* Move assign sticky nav around

* Modify sticky articles

* Attempt to fix sticky

* Fix article show to call 404

* Fix

* Conditional

* Add tag_line to org admin and add conditional on hiring post (#250)

* Modify sticky_article criteria (#251)

* Add tag_line to org admin and add conditional on hiring post

* Modify sticky_article criteria

* Move suggestions to single route

* Exclude self and already followed from suggestions

* Update readme with new API key instructions (#252)

* Modify query to be more performant and correct

* Add br instead of hr for last element

* Remove code for development woops

* Add user articles to sidebar (#253)

* Add user articles to sidebar

* Add organization save-all functionality

* Adjust articles that show up in side sticky bar (#254)

* Add user articles to sidebar

* Add organization save-all functionality

* Adjust articles that show up in side sticky bar

* Add conditional for @user_stickies to show up

* Misc change to styles (#255)

* Add user articles to sidebar

* Add organization save-all functionality

* Adjust articles that show up in side sticky bar

* Add conditional for @user_stickies to show up

* Misc change to styles

* Slight change

* Modified footer center show stuff

* Remove current article author from sticky sidebar (#256)

* Fix article preview issue (#257)

* Update blackbox's API endpoint (#259)

* Modify user tag follow suggestions
2018-04-30 17:45:01 -04:00
Ben Halpern
8ec9991bd8 Merge branches 'master' and 'andy/feature/suggested-follows-sidebar' of github.com:thepracticaldev/dev.to_core 2018-04-30 14:39:40 -04:00
Mac Siri
e3a270d317 Update blackbox's API endpoint (#259) 2018-04-30 12:24:32 -04:00
Zhao-Andy
a0a9d654f0 Remove code for development woops 2018-04-27 17:33:15 -04:00
Zhao-Andy
70e0329f5a Modify query to be more performant and correct 2018-04-27 17:04:09 -04:00
Zhao-Andy
c25cd81d15 Exclude self and already followed from suggestions 2018-04-26 16:54:31 -04:00