Commit graph

481 commits

Author SHA1 Message Date
Kohei Sugi
ac0d49cbd6 Fix Lint/ShadowingOuterLocalVariable (#455) 2018-08-24 09:11:13 -04:00
Kohei Sugi
7760a8d196 Fix Lint/UselessAssignment (#388) 2018-08-23 15:03:29 -04:00
Ben Halpern
992c95ff25 Add healthy debate flare tag and sidebar widget (#449) 2018-08-23 14:57:43 -04:00
Loïc Vernet
bbd9aef3cc Remove extra quote in html (#447) 2018-08-23 12:12:50 -04:00
Andy Zhao
79d8661ccc Increase #cache_tag_list limit (#436)
* Update error message for single tag length

* Increase cached_tag_list length to match tag length limit
2018-08-22 14:17:58 -04:00
Andy Zhao
fb22171267 Update ORLY Pages (#432) 2018-08-21 18:27:47 -04:00
Kohei Sugi
3343998391 Fix Naming/MemoizedInstanceVariableName lint (#389) 2018-08-21 16:35:57 -04:00
Shawn McElroy
318f1b28d5 link to the new repo (#416) 2018-08-21 15:27:38 -04:00
Andy Zhao
b1f6587a3a Fix #valid_link for CodePen and Gist Liquid tags (#425) 2018-08-21 14:16:56 -04:00
Ben Halpern
f609cfc2fc Remove thumbsdown slack ping (#421) [ci skip] 2018-08-21 14:09:25 -04:00
Kohei Sugi
5927b13667 Fix Style/DateTime Lint (#385) [ci skip] 2018-08-20 16:23:06 -04:00
dgolant
82f99c6c8b Add figcaption to _editor_guide_text.html.erb (#402) 2018-08-20 15:33:58 -04:00
Josh Cheek
4a2a003a98 Feature/vimeo tag (#409)
* Add liquid tag for vimeo

* VimeoTag works when Markdown makes its input HTML

* VimeoTag documentation
2018-08-20 14:26:18 -04:00
Monica Powell
d303692bc0 #260 increase mentee-mentor description length (#405)
* increase mentee-mentor description length and fix linting errors

* fix char limit issue and refactor tests
2018-08-20 10:20:23 -04:00
Kohei Sugi
83c9196704 Fix Style/IfInsideElse (#386) 2018-08-19 19:38:30 -04:00
Kohei Sugi
2e0eb0e0ef Fix Naming/VariableName (#387) 2018-08-19 19:37:57 -04:00
Andy Zhao
4b3951cfb2 Silence cache logs and fix a small bug (#370)
* Test that async_score_calc only changes ratings if published

* Run async_score_calc only if an article is published

* Turn delaying jobs back on after tests run
2018-08-18 16:57:57 -04:00
rhymes
c4802218ff Fix LinkedIn accepted urls (#390)
* Add support for country specific Linkedin urls

Closes #343

* Add tests to make sure three letters country codes are prohibited
2018-08-17 17:25:23 -04:00
Andy Zhao
24e663c131 Update YouTube liquid tag with better example (#392) 2018-08-17 17:24:11 -04:00
Andy Zhao
de25d33ce9 Delay all destroys and bust old username path (#391) 2018-08-17 17:23:33 -04:00
Kohei Sugi
fc49fc002c Fix Style/Semicolon Lint (#376) [ci skip] 2018-08-17 12:15:38 -04:00
Peter Frank
2419c6c335 Add user liquid tag to editor guide (#379)
Added the DEV user embed instructions to the editor guide
2018-08-17 10:49:11 -04:00
rhymes
14fb6e4a8d Fix images button style in new editor (#381) 2018-08-17 10:48:33 -04:00
Kohei Sugi
33086d47f0 Fix Style/NumericPredicate lint (#367) [ci skip] 2018-08-16 15:27:11 -04:00
Kohei Sugi
808655e2f3 Fix Layout/SpaceInsideArrayLiteralBrackets lint (#368) 2018-08-16 15:22:59 -04:00
Araslanov Evgeny
8095c8fc4d Added ArticleWithVideoCreationService (#344) 2018-08-15 17:19:54 -04:00
Araslanov Evgeny
4ba8296298 API: Fix find tags by name (#359) 2018-08-15 17:01:43 -04:00
Kohei Sugi
91c3eef1e1 Fix Layout/EndAlignment lint (#349) [skip ci] 2018-08-15 15:49:38 -04:00
Andy Zhao
dc901999a7 Remove Algolia logo in search (#323)
* Update Algolia logo in search

* Remove algolia logo
2018-08-13 17:38:32 -04:00
Tsukuru Tanimichi
73d73f49c6 Remove require 'nokogiri' (#316) 2018-08-13 17:16:41 -04:00
Kayla
899e6e00a1 Show employment title without an employer (#291) 2018-08-13 17:01:49 -04:00
Kohei Sugi
36d2dfd122 Apply rubocop some rule (#295)
* Fix FactoryBot/StaticAttributeDefinedDynamically and Metrics/LineLength

* Fix RSpec/NotToNot: Prefer not_to over to_not

* Fix RSpec/NotToNot: Prefer not_to over to_not and Metrics/LineLength

* Fix Layout/MultilineMethodCallIndentation and Metrics/LineLength

* Fix Naming/PredicateName

* Fix Style/ConditionalAssignment

* Avoid code climate error
2018-08-13 16:32:11 -04:00
Ben Halpern
f7de30828e
Fix mentorship page typo (#330) 2018-08-11 02:59:08 -04:00
Hiroyuki Morita
2f495c9be0 Fix tag mismatch (#308) 2018-08-09 13:21:34 -04:00
Ben Halpern
78d9aefafc
Remove OSS countdown gifs (#294) 2018-08-08 21:54:50 -04:00
Jonny Buchanan
34efec4b5d Stop using the Fake Notifications Dark Pattern (#288) 2018-08-08 18:31:35 -04:00
Ernesto Tagwerker
c564e2c2e0 Prefer pluck over map (#283) 2018-08-08 18:24:54 -04:00
Jack Harner
c29e6a59e5 Adding Anchor To Comments Section from Article (#284) 2018-08-08 17:48:26 -04:00
Mac Siri
69fc87a67d Refactor CacheBuster (#286) 2018-08-08 17:45:14 -04:00
Ben Halpern
524d8a8aea
Add open source moment gif (#673) 2018-08-08 11:33:21 -04:00
Peter Frank
c46efc8623 Add Trademark info to Terms (#664) [ci skip]
Also swapped DEV > The DEV Community.
2018-08-08 10:35:58 -04:00
Peter Frank
59b20adee6 Fix small typo on code of conduct page (#669)
Making it more clear that they should email us
2018-08-08 10:33:06 -04:00
Andy Zhao
770d2c04a6 WIP - Minor fixes to org settings page (#663)
* Allow org colors to be blank and lint

* Add limits for each field in placeholder
2018-08-07 12:55:58 -04:00
rhymes
e588fa7ece Code cleanups (#659)
* Initial automatic cleanup with rubocop

* Fix syntax error introduced by rubocop

* Cleanup seeds file

* Cleanup lib folder

* Exclude bin folder because it contains auto generated files

* Make Rubocop a little bit more chatty

* Block length should not include comments in the count

* Cleanup config folder

* Cleanup specs

* Updated Rubocop version and generated a todo file

* Fix broken ArticlesApi spec

* Fix tests

* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Ben Halpern
2cae371044
Remove event ping tracking because it was confusing us (#662) 2018-08-06 13:53:22 -04:00
Jess Lee
33f590ecc8 Jess/mentorship form updates (#653)
* add timestamps for mentroship form updates

* update placeholder text

* Add tests for mentee description change
2018-08-06 13:04:11 -04:00
Andy Zhao
468ffd5fc2 Temporarily remove email notification and status page (#657) 2018-08-06 10:53:43 -04:00
Ben Halpern
05789f6ef6
Add client-side /connect maxlength and add badge setting on model only (#660) 2018-08-06 10:45:01 -04:00
Andy Zhao
1dd95b636b Fix old typo (#655) 2018-08-03 10:17:12 -04:00
Andy Zhao
885cdb5941 Make internal events descending order (#648) 2018-08-02 09:22:02 -04:00