Commit graph

171 commits

Author SHA1 Message Date
Ben Halpern
7e48a23afa
Ben/add more recent posts to home feed (#775)
* Add meta to sidebar and adjust ranking algo

* Update home feed to show more recent posts from folks you follow

* Only show recent posts on home feed if user signed in
2018-09-30 14:05:59 -04:00
Ben Halpern
4205d50bd8
Make home feed more relevant and varied (#757) 2018-09-27 13:21:51 -04:00
38elements
e9cbbae5c5 Fix FOLLOWING button (#728) 2018-09-24 11:38:48 -04:00
Ben Halpern
160056a19d
Add organization users to sidebar and other org ajustments (#707) 2018-09-20 15:43:43 -04:00
Ben Halpern
2545b8d77f
Modify styling and classes for iOS safari /connect (#701) 2018-09-19 18:25:36 -04:00
Ben Halpern
e0c7ac970d
Modify reaction bar style (#665) 2018-09-15 13:25:38 -04:00
Ben Halpern
8074113663
Revert linting issues (#651) 2018-09-13 15:18:19 -04:00
Den McHenry
cf15295771 Fix table layout in posts (#429)
Three rules overriding table and cell defaults reduce readability of tables by

1. forcing full width irrespective of actual table contents, and
2. setting an arbitrary width of 1000px on each cell.

This seems to be the result of tinkering to improve table aesthetics by filling horizontal space, but this is a common error that seriously [degrades the readability of tabular data](https://alistapart.com/article/web-typography-tables#section2).

The first issue above is a bit confused: the width has been set to `100%`, and display has been set to `block`.

Setting a default table to 100% width will cause the children to adapt accordingly, achieving the desired result. But changing `table` to `block` breaks the relationship so that the children of the table no longer adapt to the full width. (They behave as though an anonymous parent table of the correct display type has been inserted, while the `table` element behaves like a generic block level element. They no longer will the table, though the table is technically full width.)

This probably explains the arbitrary width on data cells. It's set larger than the container, forcing the browser to resolve it against the available space and thus approximate the expected result of a default table with 100% width.

Rather than trying to fill horizontal space, it's better for readability to allow data cells to adapt to the size of their contents. A better option for aesthetics in blog posts on Dev.to is to remove the three rules deleted here that affect table layout and instead set left and right margins to `auto`, so that narrow tables are centered in posts, but wide tables can still extend beyond the normal content width of paragraphs as they do now.
2018-09-13 14:20:33 -04:00
Ben Halpern
dd32580ab1
Make article actions bar sticky (#648)
* Make article actions bar sticky

* Fix article load edge case

* Fix logic check
2018-09-13 13:52:35 -04:00
Ben Halpern
eeb408511a
Add extra caching to home query (#643)
* Update home feed logic and display

* Remove console log

* Add extra caching to home query

* Fix conflict
2018-09-12 16:34:10 -04:00
Ben Halpern
91f99036df
Update feed for slightly more customized top articles (#642)
* Update home feed logic and display

* Remove console log
2018-09-12 15:27:54 -04:00
Andy Zhao
a4c3d97aa9 Fix Liquid Filters and Fix DevComment Tag (#608)
* Update standard filters

* Update comment tag and rename devcomment tag

* Update tests with new file name

* Refactor liquid tags into null tag

* Fix renaming issue and refactor

* Fix useless assignment via codeclimate

* Add test for null tag

* Update LiquidTags.scss with new file name
2018-09-05 17:42:47 -04:00
Ben Halpern
9009a1a977 Fix button height and modify video styling (#609) 2018-09-05 16:51:01 -04:00
Gaurav Shankar
99d98d75b4 Fix long username in navbar (#588)
* Fixed the overflowing user name in the top bar under profile thumbnail

* Fixed by adding hidden and ellipsis
2018-09-05 11:58:07 -04:00
Ben Halpern
044be9e162
Modify instantclick to follow 404/500/302 statuses etc. (#593) 2018-09-04 17:20:13 -04:00
Andy Zhao
7d7863da1f Add nofollow to /moderate links (#592) 2018-09-04 17:09:28 -04:00
Yash Ghelani
9795b192a3 Upgrade to a font stack that uses better system fonts (#512) 2018-09-01 12:17:05 -04:00
Andy Zhao
ceb8a70103 Fix typo on offline page (#553) 2018-08-30 12:01:14 -04:00
Edison Yap
ee5efe4c4a Fix chat channels being blocked by footer (#513) 2018-08-29 18:24:17 -04:00
Ben Halpern
0bc9a8d306 Remove open source announcement box (#534) 2018-08-29 11:40:11 -04:00
AshWhitear
ce45d0ef81 Update all necessary follow buttons on click (#433) 2018-08-28 15:34:09 -04:00
Ben Halpern
95908ddde1
Fix /live styling issues (#519) 2018-08-28 11:50:25 -04:00
Ali Spittel
f509607eb9 Create new offline page (#463)
* Update offline.html

* Update serviceworker.js.erb
2018-08-24 15:09:00 -04:00
Andy Zhao
fb22171267 Update ORLY Pages (#432) 2018-08-21 18:27:47 -04:00
rhymes
14fb6e4a8d Fix images button style in new editor (#381) 2018-08-17 10:48:33 -04:00
Jonny Buchanan
34efec4b5d Stop using the Fake Notifications Dark Pattern (#288) 2018-08-08 18:31:35 -04:00
Ben Halpern
524d8a8aea
Add open source moment gif (#673) 2018-08-08 11:33:21 -04:00
Ben Halpern
2cae371044
Remove event ping tracking because it was confusing us (#662) 2018-08-06 13:53:22 -04:00
Ben Halpern
e943087405
Add open source countdown and 30 second on-site ping (#645)
* Add open source countdown and 30 second on-site ping

* Add condition to not ping on first loop
2018-08-01 11:41:57 -04:00
Andy Zhao
e9f2aa3250 Fix events sidebar date pills' CSS (#641)
* Align utc_date text to center

* Move styles from inline to css file
2018-08-01 11:22:07 -04:00
Dídac Sabatés
2142d7a222 Break word on notification title (#643)
Add word-wrap: break-word; in the class .notification-new-post-title in notifications.scss

Resolves: #615
2018-08-01 10:15:47 -04:00
Andy Zhao
2e0929f438 Scroll to typing cursor to prevent weird skipping (#644) 2018-08-01 10:10:49 -04:00
Andy Zhao
92e7e109f2 Remove resizing function from old editor (#640)
* Remove resizing function from old editor

* Move return statement to only jump function
2018-07-31 15:33:46 -04:00
Ben Halpern
1181a952ed
Fix small caching issues and adjust serviceworker logic (#632)
* Fix small caching issues and adjust serviceworker logic

* Assign state to follow buttons to avoid refetch

* Modify serviceworker push issue

* Change asset_path to javascript_pack_path in serviceworker

* Change javascript_pack_path to javascript_path in serviceworker

* Remove javascript_path for now
2018-07-30 10:43:29 -07:00
Andy Zhao
6c937df21c Filter out user input name (#633) 2018-07-30 07:55:45 -07:00
Mac Siri
0f3342bcec [WIP] Implement non front-matter editor (#415)
* Create alternate editor

* Install linkstate (?)

Not sure how it disappear in the first place

* Run yarn install

* Modulize ArticleForm component

* Refactor

* Isolating css WIP

* Implement simplified frontmatter-less editor

* Modulize individual form element

* Ajust props names

* Transform json params to snakecase

* Remove codes

* Update /new, almost there for release

* Fix editor resize issues

* Change defaultvalue to value in article form tag element

* Modify html buttons in article form
2018-07-27 20:12:33 -07:00
Mac Siri
9e19593559 Change mods-actions' display logic (#630)
* Add username to deploy-track

* Change mod-actions' show logic

* Remove comment
2018-07-27 11:55:14 -07:00
Ben Halpern
749d61a5c1
Remove fetch polyfill and other misc small fixes (#629)
* Remove fetch polyfill and other misc small fixes

* Remove fetch polyfill and other misc small fixes
2018-07-27 10:13:38 -07:00
Arun Kumar
a4de2fd0b1 Open social links inside comment in a new tab (#616) 2018-07-26 09:27:49 -07:00
Mac Siri
379829719f Misc DX improvement (#621)
* Add updated rack env keys

* Tone-down rack-timeout config

* Avoid cl_image_path in development

* Update README & create env var template

* Update Travis notification config

* Expand Seed file

* Manually-set Rack-timeout config vars

* Fix lint

* Fix Typo(?)

* Add ChatChannel to Seed

* Disable fbq when not in production

* Tweak after_deploy script

* Fix condition

* Change fbq clause
2018-07-25 22:08:17 -07:00
Ben Halpern
cd17261963 Fix small css issue on /live 2018-07-23 12:37:11 -07:00
Ben Halpern
7edb371cba
Remove ENV var for algolia and make global var (#609)
* Remove ENV var for algolia and make global var

* Add :: and give test value to ALGOLIASEARCH_PUBLIC_SEARCH_ONLY_KEY
2018-07-21 12:09:14 -04:00
Mac Siri
40f488d991 Migrate to Travis CI (part 2) (#591)
* Update Travis.yml

* Update README

* Update README

* Adjust test to not rely on env vars

* Update encryption

* Refactor

* Update env key

* Stub AWS calls

* Create ApplicationConfig

* Fix specs

* Fix lint

* Update ApplicationConfig

* Remove travis env vars

* Fix lint

* Extend character limit to 100

* Add env to travis

* Take out auto-restart after deploy

* Immediately discarded test cache

* Stub GA in request specs

* Stub Pusher

* Fix broken specs

* Update fixture

* Add CodeClimate id

* Change CodeClimate key

* Remove merge mistakes

* WIP

* Add Envied gem & Change README

* Add missing keys

* Add missing key

* Update fixture

* Fix broken spec

* Add Slack Notification for Travis

* Fix wording

* Fix typo
2018-07-20 20:17:18 -04:00
Nick Taylor
18980034d3 Nick/feature/search to preact (#532)
* Works, but lots of cleanup/questions.

* Fixed comment.

* Only want the search script to load once with InstantClick active.

* Removed unnecessary DOMContentLoaded from copy paste.

* 🔧 Enabled (P)React Devtools.

* Updated comment about reactToEvent.

* Removed unnecessary server-side generated JS for search.

* <Search /> component now has component state.

* Search functions are in there own module now.

* 👷Refactor

* Render propped it up.

* Fixed issue with encoding of search term.

* Removed data-no-instant attr from script.

* 👷Refactor

* Now flash of search loading is avoided..

* Moved search under components folder.

* Tests

* fixedEncodeURIComponent does not need to be exported.

* Tests

* Folders to ignore from the VS Code Local History extension.

* Tests

* Snapshot test for <Search /> component.

* Tests

* Now the <SearchContainer /> handles the '/' key shortcut.

* Made the search box ID a prop defaulting to 'nav-search'

* Excluded barrel files from code coverage.

* Componentized search CSS.

* Storybook stories for <Search /> component.

* Removed extension folders to ignore.

* Fixed logic for "/" key triggering search.

* updated jest snapshot for <Search /> component.

* updated package.json lock file.

* Disabled the import/prefer-default-export rule.

* Now search term clears if not on a non-search results page.

* removed comment that is no longer valid.

* No longer using render prop for Search. Doesn't make sense as it's not stuff that is reused.

* Added preact-render-spy do dev deps.
2018-07-19 17:02:48 -04:00
Ben Halpern
e2dbd7cfcc
Remove beta label on /connect and other small changes (#589)
* Remove beta label on /connect and other small changes

* Add better placeholder for narrow screens

* Adjust comma/bracket placement

* Add description to chat channels
2018-07-16 14:48:38 -04:00
Ben Halpern
5a2c549927
Add reactions to /connect content (#585) 2018-07-13 20:05:47 -04:00
Jess Lee
d407d9bc52 Allow members to add other social links to profile (#555)
* add social icons to profile

* fix spacing

* add validations

* update user spec

* check for user in profile settings

* fix regex validation

* refactor regex to multiple lines
2018-07-13 19:51:56 -04:00
Ben Halpern
e995e081ad
Add rich links to /connect and remove auto sidecar opening (#582) 2018-07-13 16:56:26 -04:00
Andy Zhao
41d028cc5a Use non-prettiered JS file instead (#563) 2018-07-10 14:54:31 -04:00
Andy Zhao
e7466fc436 [Done] Add Reaction Policy Spec (#547)
* Delete old files and combine into one spec

* Write new reaction request spec

* Use a single route for logged in/out reaction count

* Refactor a bit

* Remove unused file

* Add reaction policy and spec

* Fix eslint issue

* Remove dead route
2018-07-10 14:12:04 -04:00