Commit graph

142 commits

Author SHA1 Message Date
Andy Zhao
a4c3d97aa9 Fix Liquid Filters and Fix DevComment Tag (#608)
* Update standard filters

* Update comment tag and rename devcomment tag

* Update tests with new file name

* Refactor liquid tags into null tag

* Fix renaming issue and refactor

* Fix useless assignment via codeclimate

* Add test for null tag

* Update LiquidTags.scss with new file name
2018-09-05 17:42:47 -04:00
Kohei Sugi
1ccfdd4651 Fix Naming/UncommunicativeMethodParamName lint (#501)
* Fix Naming/UncommunicativeMethodParamName

* code climate
2018-09-04 18:00:26 -04:00
Andy Zhao
22c9714919 V2 of Reports System (#441)
* Fix weird breakpoint top-nav issue

* Fix error handling when submitting blank note

* Change status closed to invalid

* Add ability to sort between status

* WIP

* Add working views for new report page

* Add mailer WIP

* Add MVP of new reports system

* Move collapse to the right & add show page link

* Fix buttons for index page

* Change collapse to collapse/expand

* Remove email functionality from new report

* Update copy of report abuse responses

* WIP of showing emails in reports

* Fix notes for user_role_service.rb

* Remove unused scripts from internal.html.erb

* Update tests for reports dashboard

* Add missing migration file

* Add finishing touches to reports dashboard

* Remove deprecated methods

* Update view with better timestamps

* Update and write new tests

* Add .codeclimate.yml

* Remove commented out editor thing

* Undo commented out code for recaptcha method

* Undo comment out code for development

* Use new comment path instead of old comment path
2018-09-04 17:08:41 -04:00
Andy Zhao
d9b6941537 Fix user profile additional links (#587)
* Fix user profile additional links

* Update user model and user spec
2018-09-04 13:06:48 -04:00
Araslanov Evgeny
97d9b836a7 Improve DogFoodController's querying (#350)
query with INNER JOIN and COUNT
2018-08-31 15:54:33 -04:00
Andy Zhao
c888fd6faa Add ability to prevent comment creation (#554) 2018-08-31 12:11:21 -04:00
Ben Halpern
01e43a99e7
Fix /connect bug and add email-if-inactive functionality (#482)
* Add basic functionality for connect message emails

* Fix lint

* Add connect messages email permission
2018-08-27 14:29:53 -04:00
Andy Zhao
79d8661ccc Increase #cache_tag_list limit (#436)
* Update error message for single tag length

* Increase cached_tag_list length to match tag length limit
2018-08-22 14:17:58 -04:00
Monica Powell
d303692bc0 #260 increase mentee-mentor description length (#405)
* increase mentee-mentor description length and fix linting errors

* fix char limit issue and refactor tests
2018-08-20 10:20:23 -04:00
Kohei Sugi
83c9196704 Fix Style/IfInsideElse (#386) 2018-08-19 19:38:30 -04:00
Andy Zhao
4b3951cfb2 Silence cache logs and fix a small bug (#370)
* Test that async_score_calc only changes ratings if published

* Run async_score_calc only if an article is published

* Turn delaying jobs back on after tests run
2018-08-18 16:57:57 -04:00
rhymes
c4802218ff Fix LinkedIn accepted urls (#390)
* Add support for country specific Linkedin urls

Closes #343

* Add tests to make sure three letters country codes are prohibited
2018-08-17 17:25:23 -04:00
Araslanov Evgeny
4ba8296298 API: Fix find tags by name (#359) 2018-08-15 17:01:43 -04:00
Kohei Sugi
91c3eef1e1 Fix Layout/EndAlignment lint (#349) [skip ci] 2018-08-15 15:49:38 -04:00
Tsukuru Tanimichi
73d73f49c6 Remove require 'nokogiri' (#316) 2018-08-13 17:16:41 -04:00
Kohei Sugi
36d2dfd122 Apply rubocop some rule (#295)
* Fix FactoryBot/StaticAttributeDefinedDynamically and Metrics/LineLength

* Fix RSpec/NotToNot: Prefer not_to over to_not

* Fix RSpec/NotToNot: Prefer not_to over to_not and Metrics/LineLength

* Fix Layout/MultilineMethodCallIndentation and Metrics/LineLength

* Fix Naming/PredicateName

* Fix Style/ConditionalAssignment

* Avoid code climate error
2018-08-13 16:32:11 -04:00
Ernesto Tagwerker
c564e2c2e0 Prefer pluck over map (#283) 2018-08-08 18:24:54 -04:00
Andy Zhao
770d2c04a6 WIP - Minor fixes to org settings page (#663)
* Allow org colors to be blank and lint

* Add limits for each field in placeholder
2018-08-07 12:55:58 -04:00
rhymes
e588fa7ece Code cleanups (#659)
* Initial automatic cleanup with rubocop

* Fix syntax error introduced by rubocop

* Cleanup seeds file

* Cleanup lib folder

* Exclude bin folder because it contains auto generated files

* Make Rubocop a little bit more chatty

* Block length should not include comments in the count

* Cleanup config folder

* Cleanup specs

* Updated Rubocop version and generated a todo file

* Fix broken ArticlesApi spec

* Fix tests

* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Jess Lee
33f590ecc8 Jess/mentorship form updates (#653)
* add timestamps for mentroship form updates

* update placeholder text

* Add tests for mentee description change
2018-08-06 13:04:11 -04:00
Ben Halpern
05789f6ef6
Add client-side /connect maxlength and add badge setting on model only (#660) 2018-08-06 10:45:01 -04:00
Ben Halpern
a3788dfbd1
Fix TwitterBot arguments (#634)
* Fix TwitterBot arguments

* Fix ::random_identity
2018-07-30 10:51:10 -07:00
Mac Siri
0f3342bcec [WIP] Implement non front-matter editor (#415)
* Create alternate editor

* Install linkstate (?)

Not sure how it disappear in the first place

* Run yarn install

* Modulize ArticleForm component

* Refactor

* Isolating css WIP

* Implement simplified frontmatter-less editor

* Modulize individual form element

* Ajust props names

* Transform json params to snakecase

* Remove codes

* Update /new, almost there for release

* Fix editor resize issues

* Change defaultvalue to value in article form tag element

* Modify html buttons in article form
2018-07-27 20:12:33 -07:00
Ben Halpern
749d61a5c1
Remove fetch polyfill and other misc small fixes (#629)
* Remove fetch polyfill and other misc small fixes

* Remove fetch polyfill and other misc small fixes
2018-07-27 10:13:38 -07:00
Mac Siri
379829719f Misc DX improvement (#621)
* Add updated rack env keys

* Tone-down rack-timeout config

* Avoid cl_image_path in development

* Update README & create env var template

* Update Travis notification config

* Expand Seed file

* Manually-set Rack-timeout config vars

* Fix lint

* Fix Typo(?)

* Add ChatChannel to Seed

* Disable fbq when not in production

* Tweak after_deploy script

* Fix condition

* Change fbq clause
2018-07-25 22:08:17 -07:00
Arun Kumar
876c70d2bb Minimize creation of CacheBuster objects (#599) 2018-07-24 10:30:30 -07:00
Arun Kumar
478dcabdf1 Refactor GithubRepo model (#583) 2018-07-23 15:23:53 -04:00
Mac Siri
40f488d991 Migrate to Travis CI (part 2) (#591)
* Update Travis.yml

* Update README

* Update README

* Adjust test to not rely on env vars

* Update encryption

* Refactor

* Update env key

* Stub AWS calls

* Create ApplicationConfig

* Fix specs

* Fix lint

* Update ApplicationConfig

* Remove travis env vars

* Fix lint

* Extend character limit to 100

* Add env to travis

* Take out auto-restart after deploy

* Immediately discarded test cache

* Stub GA in request specs

* Stub Pusher

* Fix broken specs

* Update fixture

* Add CodeClimate id

* Change CodeClimate key

* Remove merge mistakes

* WIP

* Add Envied gem & Change README

* Add missing keys

* Add missing key

* Update fixture

* Fix broken spec

* Add Slack Notification for Travis

* Fix wording

* Fix typo
2018-07-20 20:17:18 -04:00
Ben Halpern
b2b1068715
Add minimum name length for users (#594) 2018-07-19 15:36:29 -04:00
Ben Halpern
6f9248c97e Fix comment 2018-07-19 12:43:56 -04:00
Ben Halpern
e4bb8d7823
Modify timeout and make some queries more efficient (#593)
* Modify timeout and make some queries more efficient

* Only query podcasts if user signed in

* Remove unnecessary columns selected in boosted query etc.
2018-07-19 11:55:59 -04:00
Arun Kumar
e407e1ff91 Minor guard clause refactor (#576) 2018-07-16 15:39:24 -04:00
Ben Halpern
e2dbd7cfcc
Remove beta label on /connect and other small changes (#589)
* Remove beta label on /connect and other small changes

* Add better placeholder for narrow screens

* Adjust comma/bracket placement

* Add description to chat channels
2018-07-16 14:48:38 -04:00
Arun Kumar
9b753a4e9c Refactor channel permission method (#584) 2018-07-16 10:55:18 -04:00
Arun Kumar
e950028f1d Extract compound conditional to a method (#579) 2018-07-15 18:02:27 -04:00
Arun Kumar
35eddd5131 Replace if..else with hash lookup (#578) 2018-07-14 17:42:56 -04:00
Jess Lee
d407d9bc52 Allow members to add other social links to profile (#555)
* add social icons to profile

* fix spacing

* add validations

* update user spec

* check for user in profile settings

* fix regex validation

* refactor regex to multiple lines
2018-07-13 19:51:56 -04:00
Ben Halpern
e995e081ad
Add rich links to /connect and remove auto sidecar opening (#582) 2018-07-13 16:56:26 -04:00
Arun Kumar
b7a52b425b Fix typos (#580) --skip-ci 2018-07-13 12:48:47 -04:00
Arun Kumar
2400908b9d Refactor render_rewarding_context_message_html method with a guard (#569)
clause
2018-07-12 10:58:37 -04:00
Mac Siri
889f813991 Create ReservedWords class (#562) 2018-07-11 11:53:04 -04:00
Andy Zhao
6dfcf2e856 Fix adding quotes and dashes in codeblocks (#557)
* Fix adding quotes and dashes in codeblocks

* Use find_by for all remove_from_feed methods (#558)

* Destroy memberships when chat channel is destroyed
2018-07-10 13:41:54 -04:00
Andy Zhao
3bbfa03114 Fix bad query when deleting users (#556) 2018-07-09 17:46:08 -04:00
Andy Zhao
a920d6cf1c Add dependent destroys to automate some deletion tasks (#554)
* Add dependent destroys for dependency-less models

* Add before destroy for empty dm channels

* Fix typo

* Add new tests for new dependent destroys

* Remove failing test b/c rethinking relationships later

* Use find_by to return nil instead of erroring out

* Add before_destroy to destroy follows
2018-07-09 15:54:09 -04:00
Jess Lee
6b53c01762 Collect Mentorship Info (#551)
* add basic mentorship info

* add missing comma

* migrate test env
2018-07-06 10:56:24 -04:00
Ben Halpern
926991f5fc
Fix timezone issues and small adjustment to connect features (#548) 2018-07-05 16:39:04 -04:00
Ben Halpern
fcac6575d1 Merge branch 'master' of github.com:thepracticaldev/dev.to_core 2018-07-03 19:06:39 -04:00
Ben Halpern
eaa13a53fb Update serviceworker notficiations 2018-07-03 19:06:23 -04:00
Ben Halpern
4638768d79
Remove channel member count limit (#545)
* check for dataset content in triggeractive

* Remove channel member count limit
2018-07-03 16:50:53 -04:00
Ben Halpern
50bc2f259c
Add max channel members (#542)
* Add max channel members

* Change number

* Remove console.log
2018-07-03 13:54:57 -04:00