rhymes
a4b73373e7
rubocop -a ( #11674 )
2020-11-30 14:50:13 +01:00
Molly Struve
fd97007364
Bug Fix:Remove nil cached_tag_lists when Collecting Tags ( #11648 )
2020-11-30 07:18:19 -06:00
Nick Taylor
df31a94f2e
Prep work to sync mobile search in #10424 ( #11525 )
...
* Prep work to sync mobile search in #10424
* Added a comment about the custom search event.
* Refactor to fix already defined error caused by const and InstantClick.
* Moved <SearchFormSync /> out of the pack file.
* Fixed broken tests.
* Renamed getInitialSearchTerm utility function to getSearchTermFromUrl
* Added some API docs to getSearchTermFromUrl
* Fixed a typo.
* Added some more API docs.
* Switched to a custom event so a custom payload can be passed.
* Added some API docs.
* Fixed bad destructuring statement.
* wip for some more tests.
* Refactored getSearchTermFromUrl to use URLSearchParams
* lazy loaded state for search term initial value.
* test broken still. Need to think on it.
* filterXSS is now set up in testSetup.js
* Fixed tests.
* Added the @utilities alias to Storybooks webpack config.
* Almost 100% coverage with two useful tests.
* Added some comments explaining document.body usage in the tests.
* Fixed issue where search attemps to get results on first load.
* Small refactor for setting the window.location in tests.
* Clarified an explanation in a comment.
2020-11-30 06:13:06 -05:00
Michael Kohl
06fd95f93f
Move LogWorkerQueueStats from labor to services ( #11642 )
2020-11-30 09:31:15 +07:00
Akash Srivastava
ebd7712829
fix: Parsing of preamble with escaped content in runkit tags ( #11466 )
2020-11-27 16:56:52 -05:00
rhymes
68b320a1de
Add contact email to SiteConfig and replace default where appropriate ( #11630 )
...
* Add a new contact email to use in place of default
* Replace :default with :contact email in all non transactional emails
* Add missing expectation
2020-11-27 16:39:38 +01:00
Thomas Bnt
97d34247f0
Edited URLs settings/ux to settings/customization ( #11632 )
...
* Edited URLs settings/ux to settings/customization
* Oops missed one for tab: ux to tab: customization
2020-11-27 16:37:14 +01:00
Michael Kohl
1ce8a762b7
Move HtmlCleaner from app/labor into service ( #11609 )
...
* Move HtmlCleaner from app/labor into service
* Move to Feeds:: namespace
2020-11-27 08:21:57 +07:00
Nick Taylor
6feb2351e7
Fixed Error: Not implemented: window.computedStyle(elt, pseudoElt) console error in frontend tests. ( #11633 )
2020-11-26 16:55:33 -05:00
Nick Taylor
d623157eee
Fixed some frontend tests causing unhandled rejection errors ( #11627 )
...
* Fixed unhandled rejection in <ImageUploader /> test.
* Fixed <FollowUsers /> tests.
* Fixed the tests for the <RequestManager /> component.
* Fixed unhandled rejection in search utilities.
* Added an unhandledRejection listener so tests will fail if a Promise fails.
* Added a comment about why you might get an unhandled rejection exception.
2020-11-26 06:11:25 -05:00
Ben Halpern
d759ac4627
Add implicit points to follows to improve feed relevancy (in all algorithms) ( #11513 )
...
* Fix menu dropdown disable issue
* Initial base work
* Add real algorithm
* Add working object and test
* Fix schema
* Fix schema
* Fix schema
* Finalize
* Add update script and explict_points
* Proper implicit/explicit points
* Fix tests
* Add docs
* Fix tests
* Fix data update script test
* Fix data update script test
* Fix typo
* Improve efficiency and add more logic
* Changed to find_each
* Change to bulk insert
* Update tests and refactor logic
* Various improvements
* Fix typo
* Fix tests
* Remove extra line
* Fix tests
* Fix test typo
* Cache site-wide tag names
2020-11-25 16:09:51 -05:00
Nick Taylor
779551916a
Fix frontend test setup file ( #11623 )
2020-11-25 15:27:06 -05:00
Thomas Bnt
3d8049697a
Edited URLs settings/ux to settings/customization ( #11618 )
2020-11-25 12:29:12 -05:00
rhymes
ba91a3e9e7
Restore fieldsets in Settings/Customization ( #11617 )
2020-11-25 17:42:27 +01:00
Ben Halpern
a98665fdde
Use content-visibility: auto for small render performance boost ( #11560 )
...
* Use content-visibility: auto for small render performance boost
* Remove all but footer
2020-11-25 11:36:36 -05:00
Ben Halpern
a229cfa174
Preserve internal navigation indicator on redirect ( #11476 )
...
* Preserve internal navigation indicator on redirect
* Fix test
* Refactor for cleaner reusability
* Add docs
2020-11-25 11:04:19 -05:00
rhymes
369d6e2206
Fix Settings/Customization page ( #11615 )
2020-11-25 16:47:38 +01:00
Michael Kohl
82108ea8b5
Remove app/labor/random_gif.rb ( #11611 )
2020-11-25 14:58:32 +00:00
Arit Amana
845e00797b
[EOY 2020] Replace "ban" with "suspend" in Admin ( #11581 )
...
* Implement changes
* display "Suspended" if user role.name is banned
* Correct equality symbol
Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: Michael Kohl <me@citizen428.net>
2020-11-25 09:15:07 -05:00
Spencer
de3d62bc40
API: Endpoint to get an organization's users ( #11514 )
...
* add tests
* add route
* add users action to organizations controller
* add jbuilder file
* update api docs
* add recource routes
* make updates to organizations controller
* remove org_users from api docs
* update spec
* add users show jbuilder
* bug fix for user show
2020-11-25 12:50:57 +01:00
Ben Halpern
d5546d6d6b
Don't do serviceworker asset caching in development ( #11605 )
2020-11-24 19:48:48 -05:00
Molly Struve
dc7d9d5843
Refactor/Optimization:Use more_comments_minimal_weight_randomized_at_end for Signed In Feed ( #11604 )
2020-11-24 15:36:55 -06:00
Lisa Sy
fc4f6e3b1c
Improve information architecture of Settings ( #11347 )
...
* WIP Rename categories and make consistency card titles
* Add rest of sections to Extensions page
* icons
* Reshuffle Integrations and remove unnecessary Integrations tab in controller
* Update rspec tests
* Fix specs
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-11-24 12:26:06 -08:00
Molly Struve
c3b0103eb1
Bug Fix:Remove Score Filter From Tag Mod Index ( #11599 )
2020-11-24 14:18:14 -06:00
rhymes
1741e52e83
Add missing features to new feed importer ( #11501 )
...
* Add explanatory comment to how RssReaderFetchUserWorker works
* Add Feeds::ImportWorker worker
* Enable Feeds::Import for single user feed fetching behind a feature flag
* Add Feeds::ValidateUrl service
* Add feature flag to user's validate feed URL feature
* Remove todo notices
* Add feature flag to fetch_all_rss task
* Add feature flag to RssReaderWorker
* Bring back short-circuit for Articles::RssReaderWorker
2020-11-24 18:11:13 +01:00
Mac Siri
5ef6106045
Update JS dependencies with yarn upgrade ( #11589 )
2020-11-24 11:17:25 -05:00
rhymes
d49c00aa84
Fix email messages link in admin's user page ( #11595 )
2020-11-24 16:35:14 +01:00
Jacob Herrington
e2f33a37b7
Restore some context in comment ( #11587 )
...
rhymes mentioned that this context might be useful regarding this comment.
I removed some of this info in https://github.com/forem/forem/pull/11480 , so this commit adds that context along with a link that rhymes shared with me.
2020-11-24 16:08:41 +01:00
Julianna Tetreault
2dff7c2877
Rewords Public checkbox warning message in SiteConfig ( #11580 )
2020-11-24 09:52:43 -05:00
Mac Siri
c4fdeeb944
Make Images::Optimizer nil-safe ( #11584 )
2020-11-24 09:39:34 -05:00
Ben Halpern
575449b890
Include core assets in serviceworker cache ( #11559 )
2020-11-24 08:58:06 -05:00
Michael Kohl
2fd724d191
Update empty reading list copy ( #11565 )
...
* Change wording
* Add icon
* Update app/javascript/readingList/readingList.jsx
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-24 09:40:04 +07:00
Nick Taylor
bf7780cd2c
Ran prettier on *.js, *.jsx and *.md files. ( #11586 )
2020-11-23 20:45:50 -05:00
Nick Taylor
8c22bbd17b
filterXSS is now set up in testSetup.js ( #11579 )
2020-11-23 14:08:13 -05:00
Ben Halpern
7aca8ac337
Add comment about canonical url ( #11574 )
2020-11-23 11:35:30 -05:00
Molly Struve
abbc29dafe
Bug Fix:User >= when filtering by SiteConfig.home_feed_minimum_score ( #11567 )
2020-11-23 09:13:03 -06:00
Michael Kohl
894b1b94c7
Remove UnreadNotificationsEmailer ( #11561 )
2020-11-23 14:15:07 +00:00
Rafi
f88bf5a0b1
Fixing overflow of comment button ( #11562 )
2020-11-23 12:17:30 +01:00
Oskar Janusz
39daa21add
Update Copy for Orgs Call-to-action Box ( #11534 )
2020-11-23 10:15:34 +01:00
Marcy Sutton
b9ae58816f
Accessibility: initial onboarding fixes ( #11408 )
...
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-20 11:13:39 -05:00
Molly Struve
e454772128
Update trusted role email Subject ( #11519 )
2020-11-20 09:54:21 -06:00
Mac Siri
07287fa2bb
Replace podcast bar helpers with image_tag ( #11502 )
2020-11-20 09:45:56 -05:00
Molly Struve
a07070e8bc
Update copy and links in Mod Sidebar ( #11507 )
2020-11-19 19:15:04 -06:00
Andy Zhao
827c9aa77c
Fix Facebook Login profile image download failure ( #11478 )
...
* Send a new request and use link in response for profile img
* Use fallback option and make method private
* Refactor and use constant template string
* Stub image_url method for tests
* Fix tests and mock response object properly
* Fix tests and mock response object properly
* Stub response for tests
* Refactor a bit and move into helper method
* Undo everything I did. today I will watch facebook burn.
* Use more foolproof string to gsub
2020-11-19 16:18:09 -05:00
Molly Struve
cd0b90c67b
Update Trusted User Email Copy ( #11505 )
2020-11-19 14:54:06 -06:00
Ben Halpern
4ecb7121e8
Fix menu dropdown disable issue ( #11498 )
...
* Fix menu dropdown disable issue
* Initial base work
* Remove wrongfully-included files
2020-11-19 13:55:29 -05:00
Ben Halpern
c837834d6a
Remove under-used growth tab ( #11495 )
2020-11-19 10:53:36 -05:00
Jacob Herrington
77a35b378f
Fix seed values for ProfileFields ( #11481 )
...
These were all defaulting to "left_sidebar" which interfered with my
work some and doesn't really reflect how these will probably be used.
2020-11-19 09:13:49 -06:00
Manasa
b015690f4f
Podcast ownership join table (MLH Fellowship #81 ) ( #11410 )
...
* added podcast_ownership route
* added podcast_ownership table
* added podcast_ownership controller and pundit policy
* fixed codeclimate
* removed controller and pundit policy
* codeclimate
* codeclimate
* schema.rb
* schema.rb
* schema.rb
* user.rb
* made the suggested changes
* added validations
* fixed build error
* changed name to owned_podcasts
* added validation and tests
* added tests
* added tests
* changed spec
* added factory
* added factory
* merge conflict
* factory
* factory
* factory
* modified spec file
* modified spec file
* fix build error
* added class_name
* adjusted m2m relations
* made suggested changes
* fixed build error
* added subject
* schema
* ran migration
* removed index:true from singular fields
* changed schema file
* set index: false
2020-11-19 12:41:17 +01:00
Jacob Herrington
24b47029dd
Fix comment phrasing ( #11480 )
2020-11-18 21:52:33 -06:00
