Commit graph

3824 commits

Author SHA1 Message Date
Alex
9ee024f9d0
UserSubscription backend refactor (#9060)
* Refactor controller validations to model

* Update specs and move current email validation back

* Refactor #subscribed

* Cleanup UserSubscriptions::Create service

* Refactor service

* Move source inside of call for clarity

* Specs for UserSubscription::Create

* Cleanup spec

* Fix Article spec

* Updated for subscriber_email

* Add comment for explicitness of subscriber_email

* Fix reference in comment...oops!

* I know what I'm doing...sometimes...maybe

* Rename CachChecker - Subscription to IsSubscribed

* Use include vs eq in specs for error messages

* attr_accessor --> attr_reader

* Don't explicitly set nil

* Rename Create service to CreateFromService

* Use errors_as_sentence

* Rename service to CreateFromControllerParams

* Assign Struct to a new constant
2020-07-02 12:08:37 -04:00
Danielle Heberling
4f31a8ac46
[deploy] Add Stackery liquid tag (#9063)
* Add stackery liquid tag

* Refactor stackery liquid tag

* Docs for stackery liquid tag

* Add stackery liquid tag tests

* Remove Github API check from stackery liquid tag

* Minor PR comment tweaks
2020-07-02 11:59:45 -04:00
Michael Kohl
cb973d5edd
[deploy] Add secondary_logo_url to SiteConfig (#9068) 2020-07-02 11:55:28 -04:00
Nick Taylor
a6cdef4f04
Fixed <RequestManager /> skipped test (#9073) 2020-07-02 10:08:40 -04:00
ludwiczakpawel
82d99f5834
[deploy] Add collapsible panel to markdown help in editor (#9050) 2020-07-02 07:58:07 -05:00
Michael Kohl
25622fa1ff
Show org dropdown for postless users (#9069)
* Show org dropdown for postless users

* sorting and gap

* Fix typo

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-07-02 14:46:20 +02:00
Sarthak Sharma
586874d252
[deploy] 🐞Hotfix: Connect page is showing discoverable channels (#9071) 2020-07-02 07:44:26 -05:00
Mac Siri
1662473174
Add null safety to handleLoggedOut() (#9062) 2020-07-02 10:51:37 +02:00
Molly Struve
7a8e77cbf3
[deploy] Refactor Flare Tag Class (#9064) 2020-07-01 16:57:03 -04:00
Ben Halpern
2a31f7b9de
[deploy] Remove report-abuse link from base HTML document into JavaScript (#9059) 2020-07-01 16:29:22 -04:00
Arit Amana
43d860717b
[deploy] Make formatDate function more robust for intl date-time formats (#9033) 2020-07-01 12:49:42 -04:00
Ben Halpern
5c18f8cb67
[deploy] Only include community sponsors header if sponsors truly exist (#8942) 2020-07-01 10:37:41 -04:00
Lisa Sy
997d5c1b88
Update styling of user subscription liquid tag (#9003) [deploy]
* Update user subscription user tag styling

* Update notice styling

* Refactor toggle visibility

* Update profile image styling

* Refactor JS & CSS updates

* Show  state in Preview of liquid tag
2020-07-01 07:35:42 -07:00
OmarElKhatib
b44c0f5c0e
Fixing scrollbar for small screens in the profile page (#9047)
* Remove legacy code

* add crayons-card to index-comments

the deleted legacy code , is handled in crayons-card

* Revert change to home class

because it's used maaaaaaany times in the project , so it's better not modify it.

* OmarElKhatibCS/fixing issue #9016 , fixing scrollbar for small screens
2020-07-01 10:35:28 -04:00
ludwiczakpawel
de358f8eec
[deploy] Word-break utility-first class (#9049)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .
2020-07-01 10:26:15 -04:00
Nick Taylor
9fc79cf034
Added pragmaFrag so terse Fragment syntax,<></>, can be used in Preact. (#9051) 2020-07-01 09:19:33 -04:00
Jacob Herrington
83ba6b64c9
Stop allowing accented characters in tags (#9006)
* Stop allowing accented characters in tags

This commit will add strict frontend and backend validation for tags
disallowing accented characters.

* Update tags validation error message

* Add more character sets to tag validation spec
2020-07-01 11:48:25 +02:00
Michael Kohl
db17e98804
Unique IDs for hidden article_archived fields (#9048) 2020-07-01 11:35:29 +02:00
Nick Taylor
3833b17a66
Added upload spinner for cover image in editor (#9041)
* Added the cover image upload spinner.

* Fixed skipped test for changing cover image.

* Added tests.
2020-07-01 11:18:26 +02:00
Raphael Noriode
1a4dba2475
API: Fetch article by slug (#8929)
* Add check to id param to use slug if passed

* modify to use slug in a different action

* wrote test for this api endpoint

* update test to check array equality
the test also checks if the first tag in the parsed list is the same as the first tag in the article
2020-07-01 10:58:45 +02:00
Veggier
92a6b99446
change the connect Scrolling CSS (#9042) 2020-06-30 21:50:59 -05:00
Ben Halpern
0de6e7db5e
[deploy] Add slash back for root link (#9043) 2020-06-30 19:17:18 -04:00
Vaidehi Joshi
b8e2d36d36
Optimize WelcomeNotification::Generator by only querying when necessary (#9039) [deploy] 2020-06-30 14:35:45 -07:00
ludwiczakpawel
2c0245dd5c
[deploy] Bringing back the original progress bar (#9019)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* .
2020-06-30 17:18:38 -04:00
Molly Struve
dba270f02e
[deploy] Optimization: Default Delete Notifications Older than 3 months (#9038) 2020-06-30 16:15:21 -05:00
A.D. Faris
ab1afd94b0
Fix listing card view reactions formatting (#8988)
* Fix the listing card view reactions format

* Update test to reflect change made in the code base
2020-06-30 16:39:10 -04:00
Alberto Pérez de Rada Fiol
9b6ab40572
[deploy] Allow internal chat channels to be searched by their name (#9020)
* Allow internal chat channels to be searched by their name

* Add tests

* Fix test
2020-06-30 14:43:25 -05:00
Alex
347a4bbc75
[deploy] Add contexts and permissions to liquid tags (#8917)
* Make liquid tags adhere to context and permission

* Undo updates to all liquid tags and update error

* ACTUALLY update errors this time

* Typo

* Refactor error handling and add support for Comment

* Fix specs

* Code cleanup

* Prettify error message

* Add comment clarifying error

* parsed --> parse

* Use a policy for validating roles

* Fix pretty error message

* Return early if valid source

* Get rid of duplicate current_user

* Add comment to Pundit.authorize

* LiquidTagPolicy specs

* Update liquid tag docs

* Update docs

* Use parse_context argument for clarity

* Remove duplicate guard clause for VALID_ROLES

* Update docs
2020-06-30 14:53:18 -04:00
Ben Lesh
e364a6ad19
Hide secret code from input history (#9032)
Currently, the secret code will show up in the input history. That, I think, means that anyone that can open that page in a shared browser instance could join the org.
2020-06-30 14:26:18 -04:00
Mac Siri
0e2fc110b2
[deploy] Delete hello-dev.js (#9025) 2020-06-30 14:13:04 -04:00
Fernando Valverde
2233952ceb
[deploy] Discoverable channel will open CTA to request join if not available (#8999) 2020-06-30 13:03:41 -05:00
Nick Taylor
efc3a124a0
Added spinner/upload message when uploading an image to a post's content (#8986) 2020-06-30 13:52:47 -04:00
Molly Struve
0cd40f5ffb
Refactor: Remove Unused UserSimilarity Class and Spec (#9030) 2020-06-30 12:39:34 -05:00
Molly Struve
9d18246875
[deploy] Refactor: Remove Unused Article Suggester Services and Specs (#9031) 2020-06-30 12:06:56 -05:00
Fernando Valverde
336cf119d9
[deploy] Fixes triggerSwitchChannel on channel list load (#8996) 2020-06-30 10:09:36 -06:00
Molly Struve
d9fd170a85
[deploy] Optimization: Dont Use Redis For Flare Tag IDs, Load Them On Boot (#8987) 2020-06-30 09:48:08 -05:00
OmarElKhatib
f3501d32f5
fix Issue #9013 , badge responsivity (#9014)
* fix Issue #9013 , badge responsivity

* remove d- prefix from d-block

* remove block because it behave the same without it
2020-06-30 12:52:47 +02:00
Mac Siri
d0b0944b32
Disable UserSubscriptionTag::script (#9005) 2020-06-30 09:13:44 +02:00
ludwiczakpawel
3a69f349be
[deploy] Refactor code blocks styling (#8975)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* missing bit

* document

* .

* little fix

* btn--highlight
2020-06-29 21:15:11 -04:00
Jacob Herrington
c0fc10ec1d
Override header padding for internal (#8992) 2020-06-29 20:27:30 -04:00
Ben Halpern
aa855e5f9b
[deploy] Remove dead styling code (#8991) 2020-06-29 20:26:49 -04:00
Molly Struve
4e0fee644c
[deploy] Feature: Setup Admin Area to Update Vault Secrets (#8935) 2020-06-29 15:08:09 -05:00
Mac Siri
50a7c2ffe0
Rename dir _tests to __tests__ & update .codeclimate.yml (#8982) 2020-06-29 15:18:39 -04:00
Vaidehi Joshi
38ae790183
Do not render active announcements in iframes (#8981) [deploy]
* Do not render active announcements in mod tools

* Add a TODO around refactoring broadcast initialization

* Refactor initializeBroadcast to short-circuit on window.frameElement
2020-06-29 11:15:27 -07:00
narender2031
09e70896fa
[deploy] 🚀 Bug: Fix iframe flashes on re render (#8974)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* fix flashes on re-render chat ui

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-06-29 12:20:21 -04:00
Lisa Sy
c627086d74
Update Connect responsiveness on smaller viewports (#8829) [deploy]
* Improve responsive experience for Connect

- Create single-screen experience for channels list & chat container on
  small screens
- Remove `expanded` and `contracted` functionality
- Make small UI updates to channels-list
- Update tests accordingly

https://github.com/thepracticaldev/dev.to/issues/8442

* Iterate per first review

- Delete unnecessary conditional for displaying side filters
- Improve width display
- Use different animation for responsive experience
- Add top-border stroke to composer input

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/assets/stylesheets/chat.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* layout fix

* Update test to reflect markup updates

* Fix channels position issue

* Use constants

* Lower coverage threshold

* Update line coverage threshold

https://github.com/thepracticaldev/dev.to/pull/8829#issuecomment-650140589

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-06-29 09:08:18 -07:00
Nick Taylor
b9c64e57f1
Added a comment mentioning that index.js overrides are for barrel files (#8978) 2020-06-29 10:52:35 -04:00
rhymes
14c346c8ed
[deploy] Remove dead code in chat-channels-controller (#8943) 2020-06-29 09:32:20 -04:00
rhymes
d3a7f64d2b
Tell the service worker to skip /rss (#8944) 2020-06-29 09:30:56 -04:00
Nick Taylor
2130269f91
Documentation Improvements to Storybook (#8947) 2020-06-29 08:25:57 -05:00