Anna Buianova
d711897cb4
Accessibility improvements for hide comments modal ( #15462 )
2021-11-24 09:50:27 +03:00
Anna Buianova
4cab190285
Hiding comments: an option to hide or keep children ( #15178 )
...
* Optional hiding child comments (start)
* Changed confirm button in comments hide form
* Hide children comments if hide_children was passed
* Added a spec for hidden child comment notifications
* Hide only explicitly hidden comments
* Hide comment modal on article page
* Prevent default behaviour for hide comment link
* Improved hide comments modal looks
* Improved hide comments modal looks
* Removed unused code
* Send hide comment form via fetch
* Hide comment descendants when hide_children was passed
* Don't hide hidden comments descendants on permalink
* Removed unnecesary span
* Improved hide comments modal styling
* Removed unused styles and js, improved styling
* Clickable label
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
* Fixed showing hidden comments spoiler for article author
* Fixed hideArticleComments.spec.js
* Fixed displaying hidden comments text for artice author, added specs
* Target hide comments modal inside the modal when adding a listener
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Replaced hide comment link with a button
* Refactored adding hide_children url param
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Fixed cypress hide comments test
* Removed aria-label for submit on the hide comments modal
* Fixed formatting
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-11-18 11:57:40 +03:00
Alex
795cf7b10a
Don't show articles from blocked users in the feed ( #13752 )
...
* Update element identifier for blocked articles
* Update confirmation wording
* Add specs
2021-05-14 09:41:50 +02:00
Katie Davis
76453b41fb
Updates ESLint rules to error on default imports ( #12512 )
...
* add rule
* add named imports
* more missed files
* so many files
2021-02-02 10:24:03 -05:00
Ben Halpern
472c3d2922
Fix and refactor hide user content ( #12307 )
2021-01-18 11:08:23 -05:00
rhymes
f9506affb5
Use faster JS selection methods ( #11409 )
...
* Add JS tips section to frontend documentation
* Replace document.getElementsByTagName('body') with document.body
* Replace querySelectorAll with faster selecting methods where appropriate
* Replace querySelector with faster selecting methods where appropriate
* Fix typo
* Fix forEach and getElementsByClassName
* Change querySelector* to faster methods in erb files
* Change querySelector* to faster methods in ruby files
* Fix runkit tag
* Various fixes
* Update app/assets/javascripts/initializers/initializeEllipsisMenu.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update app/assets/javascripts/utilities/slideSidebar.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Commenting out flaky spec
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2020-11-16 17:35:50 +01:00
Nick Taylor
30bfe1adfd
More frontend lint fixes ( #8931 )
2020-06-29 08:19:13 -04:00
Michael Kohl
359f2cb2c5
Style hide link with Crayons ( #8820 )
2020-06-22 08:27:38 -04:00
Ben Halpern
630c1b7425
Migrate to streaming app shell via serviceworkers ( #5020 ) [deploy]
...
* Initial work for streaming app shell way of using serviceworkers
* Close in on serviceworker adjustment finalization
* Add docs and loading indicator
* Remove useless code
* Don't run on API
* Update app/javascript/contentDisplayPolicy/hideBlockedContent.js
* Fix small details
* Don't run serviceworker.js code in test env
* Fix JS in serviceworker
* Move private keyword to proper place in async controller
* Change shell_version to HEROKU_SLUG_COMMIT
* Update caching config
* Add test for async_info/shell_version
2019-12-16 12:21:33 -05:00
Andy Zhao
71157c993e
Hide comment feature ( #4944 )
...
* Add MVP of hide comment feature
* Slight copy adjustments
* Remove unused file oops
* Fix strange styling issues
* Add hide/unhide comment specs
* Authenticate user for hide/unhide
* Add tests for hide/unhide functionality
* Remove opacity CSS for hidden comments
* Fix hidden comment explanation logic
* Fix some styling issues
* Fix hiding top level comment logic
* Show only hidden comments in permalink and not thread
* Hide subtree properly if hidden comment
* Fix weird CSS issue
* Properly hide comments for permalink view
* Show children comments in permalink view
* Add tests for comment hiding visibility
* Remove superfluous code and adjust copy
* Remove some more logical duplication
* Add dedicated article column for any comments hidden
* Add reload in test
2019-12-10 15:09:47 -05:00
Andy Zhao
85d8f52789
Hide a blocked user's content [deploy] ( #4678 )
...
* Hide blocked users' content appropriately
* Use RESTful create route
* Update functionality to block the user
* Fix specs for new route
* Use const instead of var
* Add noopener and noreferrer
* Remove caching for blocked user ids
* Add new rule for lack of noopener noreferrer
* Update snapshot
2019-11-04 14:47:26 -05:00