Commit graph

7345 commits

Author SHA1 Message Date
Ben Halpern
e998e5bcac
Do not show suspended followers in aggregated siblings for notification (#20174) 2023-09-27 20:23:25 -04:00
Ben Halpern
f50e3e7511
Add out-of-date notice to admin overview (#20172) 2023-09-27 10:13:47 -04:00
Ridhwana
ae9d1b5ace
Hide the buttons on the tag page (#20148)
* feat: step 1 - add the buttons to the html template

* refactor: renamed the class to be prepended with js-

* feat: add the js-tag-card class to the entire tag-card div

* feat: add the relevant data elements and tag-id to the tag-card div

* feat: add the required data elements for the top level js-tag-card

* feat: use @tag instead of tag

* refactor: rename the tag pack file

* refactor: rename the Tag file component

* feat: add a snackzone so that the snackbar can be added there

* feat: remove the follow-actions-button and the hide-actions-button from the tag pages so that it doesn't conflict with the 'followButtons' pack whne we need to add it

* spec: update the specs for tags

* chore: follow-action-button renamed to follow-tag-button and hide-action-button to hide-tag-button

* refactor: js-classes

* chore: add some comments

---------

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2023-09-26 19:49:57 -04:00
Thomas Bnt
484821fe5e
fix: removed z-index on .reaction-button (#20165) 2023-09-26 19:08:06 -04:00
Rajat Talesra
b707712d73
Removed ordering of co-authors by id (#20162)
* Removed ordering of co-authors by id

* Updated logic

* Revert code

* Update app/decorators/article_decorator.rb

Co-authored-by: PJ <pj@forem.com>

---------

Co-authored-by: PJ <pj@forem.com>
2023-09-26 14:21:33 -04:00
PJ
1d4bcf5ca8
account for weirdly parsed code blocks in styling (#20167) 2023-09-26 14:20:10 -04:00
Joshua Wehner
8216700858
Trusted user _can_ use moderator comment (#20158)
* Trusted user _can_ use moderator comment

* Update spec to confirm cannot create

* Trusted user is trusted

* Better mod template access
2023-09-26 10:24:37 -04:00
Joshua Wehner
2c138d86ef
Add or remove limited role via API (#20136)
* Refactor API user suspend, make room for more roles

* Handle adding limited

* Handle remove limited

* And swagger docs

* Update & refactor roles spec

* Remove old route

* Remove old specs
2023-09-26 09:57:14 -04:00
Dambar Pun
e5b4f6a7d0
rename to new name to avoid confusion (#20163)
Co-authored-by: Dambar Pun <dambarpun@Dambars-MacBook-Pro.local>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-09-26 08:29:05 -04:00
Joshua Wehner
6a48b486ca
Onboarding: custom newsletter opt-in settings (#20114)
* Settings can process markdown into html

* Update Settings with new onboarding settings

* Async render onboarding newsletter step

* Tweak onboarding design

* Fix broken spec

* Better rendered component test

* Tweaks to match design

* Try to tweak design

* Try having a default state

* Tweak placeholder content

* Better await componentDidMount

* Continue to tweak the design

* ContentRenderer#process should always return Result

* Try more clarity in the partial

* Rubocop
2023-09-26 06:34:19 -04:00
Rajat Talesra
7110c69bb5
Minor gradient fix in onboarding tags step (#20169)
* Minor gradient fix

* Gradient update

* Code optimisation
2023-09-26 15:30:59 +05:30
PJ
47deeefe57
Optionally limit new users based on admin setting (#20149)
* create admin setting for new user status

* limiting on signup working 🎉

* update registration specs

* sort out OAuth registrations
2023-09-26 10:46:36 +01:00
Rajat Talesra
5fb94d372b
Reset password design and Signup page update for invite-only forems. (#20145)
* Private forem signup issue fix

* Minor design fixes

* Added click on logo

* Reset password design

* UX fix

* Updated dynamic contact

* Padding fix and test fix

* Complete translations

* Skipped flay test 'should show Feature Post button on an unfeatured post'
2023-09-22 14:49:31 +05:30
Anna Buianova
61f3c517e1
Display post languages in the dashboard (#20137)
* Display post languages in the dashboard

* Added languages locales to several languages variations
2023-09-21 14:42:44 +03:00
Rajat Talesra
1d73f871f2
Janky bug fix (#20147) 2023-09-21 16:37:44 +05:30
Joshua Wehner
13f4aaa0fb
Username inputs for admin (#20123)
* Support username inputs on /admin/articles

* Support username input on tag admin moderator

* Support username input on admin community settings

* Support username input on admin mascot settings
2023-09-20 09:25:38 -04:00
Rajat Talesra
54131cd94c
Move the digest email opt-in to the follow tags onboarding step (#20133)
* Removed intro slide and updated sequence

* Revert db change

* Initial save

* Design changes

* Mobile designs

* Added functionality

* Added tests

* Gradient effect added

* Added API call test
2023-09-20 17:55:29 +05:30
PJ
da73343540
Skip round robin mod notifications for limited users (#20128)
* return early if user is limited

* fix worker specs
2023-09-19 15:03:20 +01:00
PJ
67bb7a6e76
Revert "Bump sidekiq and sidekiq-unique-jobs dependencies in tandem" (#20132) 2023-09-18 13:27:08 -04:00
PJ
2a1c20b57f
Bump sidekiq and sidekiq-unique-jobs dependencies in tandem (#20131)
* bump sidekiq and sidekiq-unique-jobs in tandem

* ensure Articles::UpdatePageViewsWorker arg is a hash
2023-09-18 12:22:35 -04:00
PJ
90944bb36b
Skip feed events e2e specs (#20124) 2023-09-15 17:36:08 +01:00
Ben Halpern
cadebde66f
Add feed_success_score and other count tallies (#20106)
* Add initial feed events score

* Add feed events score

* Clean up code styles

* Adjust how tests are run

* Fix conflicts

* Update app/javascript/articles/Feed.jsx

* Add additional feed events tabulation queries for more reliable eventual consistency

* Add additional feed events tabulation queries for more reliable eventual consistency

* Fix test logic

* Updates from feedback
2023-09-15 12:02:26 -04:00
PJ
84a65f0a26
remove blocking attribute (#20116) 2023-09-15 10:35:35 -04:00
Ridhwana
aa201060e8
Override Tag Moderation Actions (#20088)
* feat: remove the validation for the article_id and tag_name to be unique on a tag_adjustment

* chore: remove unique index

* feat: update the validate_tag method to align with the removal of unique indexes on the table

* feat: do not allow removal and addition of tags that were added/removed by admins

* spec: add tests for the tag_adjustment_spec

* fix: update the validation of tags

* spec: article validation

* spec: test the action_panel helper

* chore: amend language

* add styles

* Empty commit
2023-09-15 15:06:58 +02:00
Joshua Wehner
c91a652245
Allow trusted users to see whether a user is suspended (#20061)
* Async append user suspended status pill

* Rubocop

* Relocate JS tests, for build & coverage

* Better error-handling for this controller

* Refactor HTML to render pill outside h1

* Continuing to tweak design

* JS class prepended
2023-09-15 08:44:31 -04:00
Joshua Wehner
6fe9d7d7a6
Allow org admins to add members as co-authors (#20008)
* Basics might be working?

* Stop propagating button clicks in autocomplete pills

* Better blank slate

* Better location to stop propagation

* Remove author_id from org co-authors

* Move UserStore and try testing it

* Remove extraneous comments

* OH... that's what that does!

* Very basic testing

* Re-organize javascripts

* Rename & re-org for testing

* Cleanup

* More tests

* Remove unnecessary nesting

* Coninuing to try to bump coverage

* Include /packs/ in code coverage metric

* Try tweaking jest coverage more?

We probably can't collect coverage from all of packs/* (because coverage is too low) but maybe we can try to opt-in for newer areas as we go?

* Relocate JS tests, for build & coverage

* User ID exception on search, not fetch

* Remove commented-out console.log

---------

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2023-09-15 08:12:41 -04:00
Ben Halpern
612c402887
Fix onboarding with implicit terms acceptance (#20117) 2023-09-14 16:02:34 -04:00
Rajat Talesra
c72c52dfdb
Removed intro slide and updated sequence (#20011)
* Removed intro slide and updated sequence

* Revert db change
2023-09-14 20:26:47 +05:30
Ridhwana
fb2978149d
Remove section from digest mailer (#20110)
* chore: remove listing related text

* feat: remove post-a-job

* Revert "feat: remove post-a-job"

This reverts commit e1c4cd449c328a43cc658882064a8312b71a18f1.
2023-09-14 14:31:15 +02:00
Duke Greene
7d1d0ff80b
comment out flaky specs and add comments for exploration/refactor (#20103)
* comment out flaky specs and add commments for exploration/refactor context

* comment out only the specs which call reload for now

* use it.skip rather than commenting out
2023-09-14 06:25:27 -04:00
Ben Halpern
a079434397
Add new invitation params (#20074)
* Add new invitation fields

* SMTP enabled check

* Update spec/requests/api/v1/admin/users_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add devise_mailer spec

* Add devise_mailer spec

* Update spec/mailers/devise_mailer_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/mailers/devise_mailer_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/mailers/devise_mailer_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-13 13:01:39 -04:00
Rajat Talesra
a679486572
Redesign sign-up and login pages (#20065)
* Signin Signup screen update

* Design for signin signup finished

* On hover effect

* Fixed few tests

* Fixed rSpec tests

* Minor design fixes

* Design changes suggested by Anuj

* Test fixes

* Updated test

* Nit fixes

* Path changes and footer and topbar hidden

* A bit simplified css

* Removed custom css

* Updated tests

* Nit css fixes

* Updates as per Ridhwana's review

* CSS fixes

* Used js-registration
2023-09-13 21:46:57 +05:30
Ben Halpern
d6d7eeeb59
Add proper follow-user class to liquid when passed UserDecorator (#20101)
* Add proper follow-user class to liquid

* Adjust test
2023-09-13 11:36:21 -04:00
Joshua Wehner
dfe71c15a1
Record feed event for article comments (#20087) 2023-09-13 11:14:27 -04:00
Anna Buianova
56f2a58e95
Default content language for forems (#20089)
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2023-09-13 13:26:45 +03:00
Narender Singh
da7c25c987
add new org button in settings (#20014)
* add new org button in settings

* add support for mobile view

* remove varible for new org check

* fix design suggestions

* fix org settings test

* remove the settings for test since this text does not exists in user settings

* remove un-used copy

* Update class name

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Fix follow user spec

* fix the rspec test case

---------

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-09-13 11:52:57 +02:00
PJ
3f922921e5
Admin setting to control enabled countries for billboard geotargeting (#20083)
* use instance setting for enabled target geolocations

* add validation for enabled geolocations setting

* a start on the UI?

* backend tweaks for UI

* proper crack at autocomplete component

* fix region targeting toggle

* e2e spec
2023-09-12 12:06:00 -04:00
PJ
95ca9d37c5
Record feed events for public reactions (#20079)
* create feed event on feed reaction

* move feed event creation to feed event model

* tiny whoops

* fix failing specs

* slightly less flaky e2e spec (maybe)

* tiny fixes (couldn't resist)
2023-09-12 08:36:10 -04:00
Duke Greene
bf4c34636e
display tag moderation history in article's mod panel (#20041)
* logic and markup to display tag adjustment history on article mod panel

* add tag adjustment reason to markup

* add specs for article's tag adjustment association and ordered tag adjustments

* style tag adjustment history

* sketch out cypress test for visible tag moderation history

* tweak spacing and sizing of adjustment history heading

* adjust cypress tests, tag adjustments still coming back empty in spec

* get past first cypress snag by waiting for request and reloading

* add spec for viewing multiple tag adjustments in a post history

* restore defer: true in actions panel js packs call

* add e2e tests for remaining mod views with tag adjustment UI
2023-09-12 07:08:44 -04:00
Anna Buianova
aa5cb535fa
Add languages to User model (#20059) 2023-09-11 11:44:19 -04:00
PJ
3f7d1fbc1a
Create feed impression and click events (#20043)
* getting started: model setup

* basic controller action & spec

* somewhat working click events

* pick up on impressions

* there was an attempt at batching without duplicates

* (better) bulk upsert service

* fix specs?

* touch up feed events JS

* end-to-end specs??

* workers wip

* fix failing user delete spec
2023-09-11 13:32:36 +01:00
Ridhwana
789907d289
Tags Dashboard Error Handling (#20051)
* feat: add an error modal for the dashboard page tags

* spec: add the tests for the tags dashboard pages

* spec: add the tests for the hiding tags dashboard pages
2023-09-11 11:41:56 +02:00
Ben Halpern
ed853f7e1e
Fix "register" bugs in invitations (#20071)
* Fix registered bugs in invitations

* Update spec/requests/api/v0/admin/users_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Move to v1 spec

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-08 17:00:37 -04:00
Rajat Talesra
07b5202ee5
Order badges in ascending order (#20068) 2023-09-08 21:23:19 +05:30
Anna Buianova
d6a273146b
Replace SiteConfig with Settings::General in the comments (#20066) 2023-09-08 15:17:09 +03:00
Jerin K C
6b996cfc61
Image auto orient (#20018) 2023-09-07 15:38:34 -04:00
Ridhwana
3c34de120b
Add snackbars to /tags (#20046)
* feat: add snackbars to /tags

* chore: update the props for the component"

* feat: update snackbar for following

* feat: add tests for snackbars

* feat: add error handling and show error on snackbar

* chore: tweaks to syntax

* refactor: abstract out the details

* fix: check for null explicitly

* refactor: use hidden instead of assigning a var
2023-09-07 12:03:41 +02:00
Ridhwana
4a8dc9abf6
Unhiding a tag should unfollow it too (#20040)
* feat: update the logic for hiding adn unhidng a tag on /tags

* feat: update the logic for hiding and unhidng a tag on /dashboard/following_tags|hidden_tags

* spec: update the tests for the /tags dashboard

* spec: removes the nav item count spec
2023-09-07 10:35:17 +02:00
Ridhwana
5951beebcb
Polish tag UI (#20038)
* feat: update the buttons

* chore: update the buttons to use c-btn

* feat: update the following tag to be crayons-btn crayons-btn--outlined

* feat: update the gap between the buttons

* feat: style for moile

* Empty commit
2023-09-07 10:32:53 +02:00
ktmouk
40e63a16c9
Set reaction's z-index to show the tooltip in front of other comments (#20035) 2023-09-06 11:48:12 +02:00