Commit graph

5410 commits

Author SHA1 Message Date
Mac Siri
5b8b651b67
Allow sign up without email smtp config (#13650) 2021-05-14 11:43:49 -04:00
Alex
795cf7b10a
Don't show articles from blocked users in the feed (#13752)
* Update element identifier for blocked articles

* Update confirmation wording

* Add specs
2021-05-14 09:41:50 +02:00
rhymes
1901ac9573
[15 min fix] Update Publishing from RSS guide with correct instructions (#13756)
* Update Publishing from RSS guide with correct instructions

* Use colons, not arrows

* Update app/views/pages/publishing_from_rss_guide.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-13 17:00:35 +02:00
Michael Kohl
f7293c3544
Fix wrong SiteConfig mentions (#13739) 2021-05-13 09:36:36 +00:00
Vaidehi Joshi
ba972b2c1d
Remove any preexisting mention notifications when article is unpublished (#13749)
Also add specs for this behavior, as well as specs for removing preexisting comment notificaitons when an article is unpublished
2021-05-12 11:48:12 -07:00
Alex
e53b6bff85
Auto-subscribe to comments on articles from feed (#13717)
* Auto-subscribe to comments on articles from feed

* Change specs

* Update spec again
2021-05-12 12:18:32 -04:00
Fernando Valverde
2463ac7194
Expose aasa for non-private Forems (#13729)
* Expose aasa non-private forems + small tweak to aasa

* Tests

* Update spec/requests/universal_links_spec.rb

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Check empty array with be_empty

* Include Universal Links context

Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-12 10:13:46 -06:00
Andrew Bone
f6e222f12e
Fix layout shift on active crayons-tabs change. (#13300) 2021-05-12 11:45:36 -04:00
Vaidehi Joshi
5e6aad98e3
Replace MAX_USER_MENTIONS with Settings::RateLimit.mention_creation (#13736)
* Replace MAX_USER_MENTIONS with Settings::RateLimit.mention_creation

* Remove Vaidehi-specific TODOs

* Remove unnecessary constant stubs

* Remove rate_limit_mention_creation from SiteConfig
2021-05-12 08:16:38 -07:00
Vaidehi Joshi
8f0c24c167
Expand @-mention functionality to posts (#13367)
* Initial work for @-mention notifications from posts

* Revert article.published changes to article updater, add clarifying comments

* Extract article preview into reusable partial for notification views

* Clean up Article Updater

* Address + remove some FIXMEs

* Add a whole buncha specs for @-mention functionality in posts YAY

* Refactor create all spec to use shared examples, add clarifying comments

* Add guard clause to create all service

* Update new mention and notifiable action specs

* Some additional cleanup

* Add specs + shared examples to SendEmailNotificationWorker spec

* Use aggregate_failures where applicable

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Cleanup and address code review comments

* Add MentionDecorator + relevant specs

* Address comments/issues flagged by @rhymes

* Optimize plucking user_ids when checking for article followers

Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-12 07:33:33 -07:00
Suzanne Aitchison
cdcb3b9be3
add accessibility section to editor guide (#13727)
* add accessibility section to editor guide

* Update app/views/pages/_editor_guide_text.html.erb

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-05-12 10:19:34 +01:00
Michael Kohl
fa2ff578ab
Add documentation for Profiles::Update (#13723) 2021-05-12 09:59:39 +07:00
Michael Kohl
867d9a1a2f
Move services from Suggester::Users (#13699) 2021-05-11 12:57:12 -04:00
Jamie Gaskins
1649d14891
Pass a FlareTag instead of a string to URL.tag (#13732) 2021-05-11 12:10:42 -04:00
Jamie Gaskins
bcc42a130d
Sanitize tag urls (#13720)
* Sanitize tag URLs

For tags with non-ASCII names, we were generating busted URLs, which
would then cause errors. This commit fixes that particular error by
generating usable URLs.

* Use URL generator that will sanitize tag names

* Remove path prefix when using a URL generator
2021-05-11 11:21:03 -04:00
Michael Kohl
111b7316d9
Remove mascot footer image (#13642)
* Remove footer mascot image

* Move remaining mascot settings back to SiteConfig

* Add data update script

* Update usages

* Fix path

* Remove dead route

* Update tests

* Fix view and spec

* Fix e2e test

* Fix DUS
2021-05-11 13:55:18 +02:00
Anna Buianova
ce46ea2378
Organizations delete optimizations and refactoring (#13610)
* Delete org notifications in batches before org destroy

* Moved on destroy callbacks to a service for org delete

* Be consistent with org_id in specs

* Removed irrelevant code

* Moved article_ids to initializer for Organizations::Delete

* Update articles cached_organization explicitly after deleting an org
2021-05-11 12:14:55 +03:00
Suzanne Aitchison
2829c7f848
stop adding a false class (#13710) 2021-05-10 13:54:23 +01:00
Olawale Oyeyipo
5107844251
Make comment box shrink on submit (#13686)
* Make comment box shrink on submit

* Add missing semicolon

* Reset height on both comment textboxes
2021-05-10 09:06:49 +01:00
Rafi
8ef1313e71
Fixing preview button text in comment section (#13627) 2021-05-07 10:48:33 -05:00
Suzanne Aitchison
783fb6fa24
Accessibility enhancements to navigation tabs (#13559)
* update storybook example and docs

* update desktop home feed tabs with a11y enhancements

* update storybook to reflect buttons usage, update post editor buttons

* update admin html variants tabs

* update admin sponsorships tabs

* re-add flex to the crayons-tab class to prevent regression in tab components not updated

* Revert "update admin sponsorships tabs"

This reverts commit d9e4a5e4b0d362e38a11c795b35ceb4442bc4d90.

* Revert "update admin html variants tabs"

This reverts commit 3d9f119e88dc2f2f102d664c57a1f56413490a36.

* update search tabs

* update v2 form erb html

* update tag index tabs

* update notifications tabs

* label the notifications nav

* update mod sidebar tabs

* update main analytics page tabs

* add cypress tests for home feed tabs

* add tab tests for the post editor

* add cypress tests for tags index navigation

* fix UI issue with search tabs, add search cypress tests

* add tests for the analytics dashboard tabs

* add mod nav tests

* add notifications navigation tests

* get new handles after view switch

* replace hardcoded mod paths

* apply review suggestions
2021-05-07 15:24:34 +01:00
Siddharth
f669907a8f
Updated replit url from repl.it to replit.com (#13680)
* Updated replit url from repl.it to replit.com

* Changed repl.it to replit

* Changed repl.it to replit
2021-05-07 08:00:45 -04:00
Nick Taylor
c48e31731d
[15 min fix] Fixed broken share button on article page. (#13688) 2021-05-07 06:33:30 -04:00
Siddharth
5462e0a1f9
Update badge CSS (#13659) 2021-05-07 10:47:25 +02:00
arunkc
47908d7a87
Update format specifiers in readable_publish_date (#13660)
* Update format specifiers in readable_publish_date

* Trigger Travis manually

* Update format specifiers in readable_publish_date

* Update format specifiers in readable_publish_date

Co-authored-by: rhymes <rhymes@hey.com>
2021-05-07 08:51:49 +02:00
rhymes
cf9f6094cd
Have specs run without Redis and refactor ConsumerApp and Device (#13647)
* Add fakeredis gem

* Mock Pusher::PushNotifications in specs

* Remove Redis from Travis

* Add Android tests to ConsumerApp specs

* Use mock for push notification tests and refactor ConsumerApp and Device code

* Fix remaining broken specs

* Use symbols

* Cleanup rpush helpers

* Pusher::PushNotifications is no more

* Use human friendly platform in Admin::ConsumerApps index page
2021-05-07 08:03:16 +02:00
Daniel Uber
d7f9a18199
Clarify article link copy title (#13682)
Incorporating aitchiss's suggestion from https://github.com/forem/forem/pull/13668/
2021-05-06 09:04:14 -05:00
Thomas Bnt
7ad3aeb7ac
Edited the title on id="article-copy-link-input" (#13668) 2021-05-06 08:19:58 -05:00
Andrew Bone
2a05955092
🐛 Fix new comment dropdown issue (#13661) 2021-05-06 09:06:30 -04:00
Nick Taylor
d59b8ba0ee
[15-min-fix] Set opacity-0 CSS utility class to 0.00001 for ChromeVox (#13666)
* Set opacity-0 CSS utility class to 0.00001 for ChromeVox.

* Update app/assets/stylesheets/config/_generator.scss

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Added a SASS variable as it's being used in #13435.

* Revert "Added a SASS variable as it's being used in #13435."

This reverts commit ec1eaa17387b8e050ca6dae73b083823bc44f6e9.

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2021-05-06 07:57:22 -04:00
Andrew Bone
38214380dd
Fix a bug with moderator dropdowns and add aria tags (#13623) 2021-05-06 07:56:28 -04:00
Nick Taylor
058c70e9c3
[15 min fix] Fixed app code that was causing flaky E2E test (#13674)
* Fixed app code that was causing flaky E2E test.

* Added a comment about adding the click to the comments container.
2021-05-06 11:30:26 +01:00
dependabot[bot]
9066de9b65
Bump rubocop-rails from 2.9.1 to 2.10.0 (#13655)
* Bump rubocop-rails from 2.9.1 to 2.10.0

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.9.1...v2.10.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Add new cops and fix violations

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
2021-05-05 14:16:44 -07:00
Mac Siri
cf538f83c8
Fix invalid form during Creator onboarding. (#13673) 2021-05-05 16:14:48 -04:00
Andy Zhao
ebbbcee41a
[15-min-fix] Remove badge slug field b/c auto-gen by title (#13649)
* Make explicit that badge slug is auto generated

* Remove slug from new form

* Remove unused disabled form field

* Remove link and Crayonsify form

* Add badge's path
2021-05-05 13:49:43 -04:00
Jamie Gaskins
a2da070ca4
Handle GitHub "Repository access blocked" error (#13648)
* Handle GitHub "Repository access blocked" error

We've been seeing a lot of these errors on DEV, and it's a pretty
reasonable expectation that if we're being blocked from seeing them
using the user's OAuth access token that this isn't temporary.

* Re-raise so we don't swallow this error

* Constant name != company name???!?!?!
2021-05-05 12:48:46 -04:00
Andy Zhao
9970b1c2d5
Auto generate profile image for email signups (#13635)
* Add required tooltips and asterisks to fields

* Generate profile image for email signups

* Use be over eq

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Use path helpers over hard-coded paths

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Add labels to make it more accessible

* Stub it all... eek

* stub some more stuff

* stub stub stub

* Move aria label to proper label and fix tests

Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-05 12:08:24 -04:00
Fernando Valverde
121603a44b
Replace Pusher Beams with Rpush PN delivery ✂️ ✂️ (#13588)
* Remove feature flag

* Remove Pusher Beams implementation

* Remove Pusher Beams require from initializer

* Adds consumer apps to sidebar + consider :admin_restructure

* Fix routes + PN target URL

* Remove old file that sneaked in

* Adds docs

* docs tweaks

* Apply suggestions from code review

Co-authored-by: rhymes <rhymes@hey.com>

Co-authored-by: rhymes <rhymes@hey.com>
2021-05-05 08:37:20 -06:00
Ridhwana
355d510f88
refactor: inline the ERB template instead of passing via a data-path (#13657) 2021-05-05 16:00:39 +02:00
Alex
a0ddb6a848
Cleanup search classes and serializers (#13645) 2021-05-05 09:20:59 -04:00
Rafi
41cc771839
Refactoring help component (and fragmenting it too) (#10895)
* Refactoring Help component

* Fixing typo

* Adding missing prop types

* Removing setCommonProps

* Moving show to parent component

* Renaming Format component

* Converting help component to functional component

* Removing html from state

* Fixing modal toggle and eslint errors

* Adding arria hidden

* Using optional chaining

* Fixing variable names

* Renaming state variable

* Adding jsdoc

Co-authored-by: Nick Taylor <nick@dev.to>
2021-05-05 12:58:40 +07:00
Jacob Herrington
e8df3b0915
Add safe navigation operator to stop 500 errors (#13646) 2021-05-04 11:37:37 -04:00
Suzanne Aitchison
ad43dbe0b3
Add prefer object destructuring lint rule (#13183)
* add prefer object destructuring lint rule

* fix typo

* sweep up lint errors missed in config controller

* Revert "fix typo"

This reverts commit 44f9d57e3f0dc4007ab9020c8c659c2f770230c2.

* Revert "sweep up lint errors missed in config controller"

This reverts commit 3f8d5d782fe110607c2172b713c74c08c883eda3.

* make this a warning rather than error for now

* undo auto change
2021-05-04 12:10:32 +01:00
Michael Kohl
aee05b4597
Retain registration form data on failed submission (#13614)
* Retain registration form data on failed submission

* Remove unnecessary command

* Apply suggestions from code review

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Fix e2e test

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-04 10:52:20 +07:00
Jacob Herrington
198f778b32
Rename profile header partial (#13639)
This partial is not actually rendered on the user profile, it is only
used by organizations. Moving it to the directory where other
organization-specific partials live!
2021-05-03 18:36:24 -05:00
Daniel Uber
4225819ae0
Fixes flaky spec (#13637)
When we call Hash.dup the values pointed to by the keys are not
duplicated (the hash is, but the keys and values are the same).

Because the FeatureFlag enabled path is mutating the values, this is
interacting during tests.

`deep_dup` the ITEMS hash before mutating when the either of the two
menu item feature flags are enabled.
2021-05-03 15:06:18 -05:00
Suzanne Aitchison
ef70d1f92b
fix accessible names of sign up options (#13620) 2021-05-03 11:06:45 -07:00
Alex
f071691b37
Add no-op Search::IndexWorker (#13630) 2021-05-03 12:45:41 -04:00
Rafi
ca50e5750e
Fixing dom structure of Tags to follow (#13184)
* Using buttons instead of checkbox

* Adding svg icon

* Update app/javascript/onboarding/components/FollowTags.jsx

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Adding condition for crayons-btn-icon-left

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-03 17:20:26 +01:00
Jacob Herrington
bb9780ff3d
Remove references to social link profile fields (#13252)
* Remove references to social link profile fields

* Add some dummy data

* Remove special display social links

* Remove unnecessary tests

* Add tests for profile social icons

* PR feedback

* Remove nil check from erb

* Move view method into helper

* Don't render links in user settings
2021-05-03 10:16:02 -05:00