* Initial work for @-mention notifications from posts
* Revert article.published changes to article updater, add clarifying comments
* Extract article preview into reusable partial for notification views
* Clean up Article Updater
* Address + remove some FIXMEs
* Add a whole buncha specs for @-mention functionality in posts YAY
* Refactor create all spec to use shared examples, add clarifying comments
* Add guard clause to create all service
* Update new mention and notifiable action specs
* Some additional cleanup
* Add specs + shared examples to SendEmailNotificationWorker spec
* Use aggregate_failures where applicable
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Cleanup and address code review comments
* Add MentionDecorator + relevant specs
* Address comments/issues flagged by @rhymes
* Optimize plucking user_ids when checking for article followers
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Sanitize tag URLs
For tags with non-ASCII names, we were generating busted URLs, which
would then cause errors. This commit fixes that particular error by
generating usable URLs.
* Use URL generator that will sanitize tag names
* Remove path prefix when using a URL generator
* Delete org notifications in batches before org destroy
* Moved on destroy callbacks to a service for org delete
* Be consistent with org_id in specs
* Removed irrelevant code
* Moved article_ids to initializer for Organizations::Delete
* Update articles cached_organization explicitly after deleting an org
* update storybook example and docs
* update desktop home feed tabs with a11y enhancements
* update storybook to reflect buttons usage, update post editor buttons
* update admin html variants tabs
* update admin sponsorships tabs
* re-add flex to the crayons-tab class to prevent regression in tab components not updated
* Revert "update admin sponsorships tabs"
This reverts commit d9e4a5e4b0d362e38a11c795b35ceb4442bc4d90.
* Revert "update admin html variants tabs"
This reverts commit 3d9f119e88dc2f2f102d664c57a1f56413490a36.
* update search tabs
* update v2 form erb html
* update tag index tabs
* update notifications tabs
* label the notifications nav
* update mod sidebar tabs
* update main analytics page tabs
* add cypress tests for home feed tabs
* add tab tests for the post editor
* add cypress tests for tags index navigation
* fix UI issue with search tabs, add search cypress tests
* add tests for the analytics dashboard tabs
* add mod nav tests
* add notifications navigation tests
* get new handles after view switch
* replace hardcoded mod paths
* apply review suggestions
* Update format specifiers in readable_publish_date
* Trigger Travis manually
* Update format specifiers in readable_publish_date
* Update format specifiers in readable_publish_date
Co-authored-by: rhymes <rhymes@hey.com>
* Add fakeredis gem
* Mock Pusher::PushNotifications in specs
* Remove Redis from Travis
* Add Android tests to ConsumerApp specs
* Use mock for push notification tests and refactor ConsumerApp and Device code
* Fix remaining broken specs
* Use symbols
* Cleanup rpush helpers
* Pusher::PushNotifications is no more
* Use human friendly platform in Admin::ConsumerApps index page
* Set opacity-0 CSS utility class to 0.00001 for ChromeVox.
* Update app/assets/stylesheets/config/_generator.scss
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Added a SASS variable as it's being used in #13435.
* Revert "Added a SASS variable as it's being used in #13435."
This reverts commit ec1eaa17387b8e050ca6dae73b083823bc44f6e9.
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Make explicit that badge slug is auto generated
* Remove slug from new form
* Remove unused disabled form field
* Remove link and Crayonsify form
* Add badge's path
* Handle GitHub "Repository access blocked" error
We've been seeing a lot of these errors on DEV, and it's a pretty
reasonable expectation that if we're being blocked from seeing them
using the user's OAuth access token that this isn't temporary.
* Re-raise so we don't swallow this error
* Constant name != company name???!?!?!
* Add required tooltips and asterisks to fields
* Generate profile image for email signups
* Use be over eq
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Use path helpers over hard-coded paths
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Add labels to make it more accessible
* Stub it all... eek
* stub some more stuff
* stub stub stub
* Move aria label to proper label and fix tests
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Refactoring Help component
* Fixing typo
* Adding missing prop types
* Removing setCommonProps
* Moving show to parent component
* Renaming Format component
* Converting help component to functional component
* Removing html from state
* Fixing modal toggle and eslint errors
* Adding arria hidden
* Using optional chaining
* Fixing variable names
* Renaming state variable
* Adding jsdoc
Co-authored-by: Nick Taylor <nick@dev.to>
* add prefer object destructuring lint rule
* fix typo
* sweep up lint errors missed in config controller
* Revert "fix typo"
This reverts commit 44f9d57e3f0dc4007ab9020c8c659c2f770230c2.
* Revert "sweep up lint errors missed in config controller"
This reverts commit 3f8d5d782fe110607c2172b713c74c08c883eda3.
* make this a warning rather than error for now
* undo auto change
This partial is not actually rendered on the user profile, it is only
used by organizations. Moving it to the directory where other
organization-specific partials live!
When we call Hash.dup the values pointed to by the keys are not
duplicated (the hash is, but the keys and values are the same).
Because the FeatureFlag enabled path is mutating the values, this is
interacting during tests.
`deep_dup` the ITEMS hash before mutating when the either of the two
menu item feature flags are enabled.
* Remove references to social link profile fields
* Add some dummy data
* Remove special display social links
* Remove unnecessary tests
* Add tests for profile social icons
* PR feedback
* Remove nil check from erb
* Move view method into helper
* Don't render links in user settings