Commit graph

451 commits

Author SHA1 Message Date
Kayla
899e6e00a1 Show employment title without an employer (#291) 2018-08-13 17:01:49 -04:00
Kohei Sugi
36d2dfd122 Apply rubocop some rule (#295)
* Fix FactoryBot/StaticAttributeDefinedDynamically and Metrics/LineLength

* Fix RSpec/NotToNot: Prefer not_to over to_not

* Fix RSpec/NotToNot: Prefer not_to over to_not and Metrics/LineLength

* Fix Layout/MultilineMethodCallIndentation and Metrics/LineLength

* Fix Naming/PredicateName

* Fix Style/ConditionalAssignment

* Avoid code climate error
2018-08-13 16:32:11 -04:00
Ben Halpern
f7de30828e
Fix mentorship page typo (#330) 2018-08-11 02:59:08 -04:00
Hiroyuki Morita
2f495c9be0 Fix tag mismatch (#308) 2018-08-09 13:21:34 -04:00
Ben Halpern
78d9aefafc
Remove OSS countdown gifs (#294) 2018-08-08 21:54:50 -04:00
Jonny Buchanan
34efec4b5d Stop using the Fake Notifications Dark Pattern (#288) 2018-08-08 18:31:35 -04:00
Ernesto Tagwerker
c564e2c2e0 Prefer pluck over map (#283) 2018-08-08 18:24:54 -04:00
Jack Harner
c29e6a59e5 Adding Anchor To Comments Section from Article (#284) 2018-08-08 17:48:26 -04:00
Mac Siri
69fc87a67d Refactor CacheBuster (#286) 2018-08-08 17:45:14 -04:00
Ben Halpern
524d8a8aea
Add open source moment gif (#673) 2018-08-08 11:33:21 -04:00
Peter Frank
c46efc8623 Add Trademark info to Terms (#664) [ci skip]
Also swapped DEV > The DEV Community.
2018-08-08 10:35:58 -04:00
Peter Frank
59b20adee6 Fix small typo on code of conduct page (#669)
Making it more clear that they should email us
2018-08-08 10:33:06 -04:00
Andy Zhao
770d2c04a6 WIP - Minor fixes to org settings page (#663)
* Allow org colors to be blank and lint

* Add limits for each field in placeholder
2018-08-07 12:55:58 -04:00
rhymes
e588fa7ece Code cleanups (#659)
* Initial automatic cleanup with rubocop

* Fix syntax error introduced by rubocop

* Cleanup seeds file

* Cleanup lib folder

* Exclude bin folder because it contains auto generated files

* Make Rubocop a little bit more chatty

* Block length should not include comments in the count

* Cleanup config folder

* Cleanup specs

* Updated Rubocop version and generated a todo file

* Fix broken ArticlesApi spec

* Fix tests

* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Ben Halpern
2cae371044
Remove event ping tracking because it was confusing us (#662) 2018-08-06 13:53:22 -04:00
Jess Lee
33f590ecc8 Jess/mentorship form updates (#653)
* add timestamps for mentroship form updates

* update placeholder text

* Add tests for mentee description change
2018-08-06 13:04:11 -04:00
Andy Zhao
468ffd5fc2 Temporarily remove email notification and status page (#657) 2018-08-06 10:53:43 -04:00
Ben Halpern
05789f6ef6
Add client-side /connect maxlength and add badge setting on model only (#660) 2018-08-06 10:45:01 -04:00
Andy Zhao
1dd95b636b Fix old typo (#655) 2018-08-03 10:17:12 -04:00
Andy Zhao
885cdb5941 Make internal events descending order (#648) 2018-08-02 09:22:02 -04:00
lianafelt
95e5bd6a9d Change Countdown "open source" to "Open Source" (#650) 2018-08-02 08:34:30 -04:00
Ben Halpern
c9714c370b
Add August sponsors (#646)
* Add August sponsors

* Change Timber utm_campaign from May to Aug
2018-08-01 16:00:03 -04:00
Ben Halpern
e943087405
Add open source countdown and 30 second on-site ping (#645)
* Add open source countdown and 30 second on-site ping

* Add condition to not ping on first loop
2018-08-01 11:41:57 -04:00
Andy Zhao
e9f2aa3250 Fix events sidebar date pills' CSS (#641)
* Align utc_date text to center

* Move styles from inline to css file
2018-08-01 11:22:07 -04:00
Dídac Sabatés
2142d7a222 Break word on notification title (#643)
Add word-wrap: break-word; in the class .notification-new-post-title in notifications.scss

Resolves: #615
2018-08-01 10:15:47 -04:00
Andy Zhao
2e0929f438 Scroll to typing cursor to prevent weird skipping (#644) 2018-08-01 10:10:49 -04:00
Andy Zhao
92e7e109f2 Remove resizing function from old editor (#640)
* Remove resizing function from old editor

* Move return statement to only jump function
2018-07-31 15:33:46 -04:00
Ben Halpern
57d1bc48d5
Fix navigation issue in connect and allow leaving channels (#635)
* Fix navigation issue in connect and allow leaving channels

* Fix chat channel memberships request spec
2018-07-30 18:40:30 -04:00
Ben Halpern
a3788dfbd1
Fix TwitterBot arguments (#634)
* Fix TwitterBot arguments

* Fix ::random_identity
2018-07-30 10:51:10 -07:00
Ben Halpern
1181a952ed
Fix small caching issues and adjust serviceworker logic (#632)
* Fix small caching issues and adjust serviceworker logic

* Assign state to follow buttons to avoid refetch

* Modify serviceworker push issue

* Change asset_path to javascript_pack_path in serviceworker

* Change javascript_pack_path to javascript_path in serviceworker

* Remove javascript_path for now
2018-07-30 10:43:29 -07:00
Andy Zhao
6c937df21c Filter out user input name (#633) 2018-07-30 07:55:45 -07:00
Ben Halpern
1c3331d77f Add proper body_markdown back in 2018-07-27 21:02:14 -07:00
Mac Siri
0f3342bcec [WIP] Implement non front-matter editor (#415)
* Create alternate editor

* Install linkstate (?)

Not sure how it disappear in the first place

* Run yarn install

* Modulize ArticleForm component

* Refactor

* Isolating css WIP

* Implement simplified frontmatter-less editor

* Modulize individual form element

* Ajust props names

* Transform json params to snakecase

* Remove codes

* Update /new, almost there for release

* Fix editor resize issues

* Change defaultvalue to value in article form tag element

* Modify html buttons in article form
2018-07-27 20:12:33 -07:00
Mac Siri
9e19593559 Change mods-actions' display logic (#630)
* Add username to deploy-track

* Change mod-actions' show logic

* Remove comment
2018-07-27 11:55:14 -07:00
Ben Halpern
749d61a5c1
Remove fetch polyfill and other misc small fixes (#629)
* Remove fetch polyfill and other misc small fixes

* Remove fetch polyfill and other misc small fixes
2018-07-27 10:13:38 -07:00
Mac Siri
ce965bcedf Reduce Airbrake's error output (#628)
* Remove chmod for after_deploy

* Fix lint

* Ignore Pundit::NotAuthorizedError

* Update Travis config

* Turn off Travis' pr notification

* Add CommonsChunkPlugin to Webpacker
2018-07-27 09:04:52 -07:00
Arun Kumar
a4de2fd0b1 Open social links inside comment in a new tab (#616) 2018-07-26 09:27:49 -07:00
Mac Siri
379829719f Misc DX improvement (#621)
* Add updated rack env keys

* Tone-down rack-timeout config

* Avoid cl_image_path in development

* Update README & create env var template

* Update Travis notification config

* Expand Seed file

* Manually-set Rack-timeout config vars

* Fix lint

* Fix Typo(?)

* Add ChatChannel to Seed

* Disable fbq when not in production

* Tweak after_deploy script

* Fix condition

* Change fbq clause
2018-07-25 22:08:17 -07:00
Nick Taylor
9a387660a9 Fixed bug where + in querystring didn't decode to a space. (#623) 2018-07-25 11:06:00 -07:00
Arun Kumar
876c70d2bb Minimize creation of CacheBuster objects (#599) 2018-07-24 10:30:30 -07:00
Ben Halpern
cd17261963 Fix small css issue on /live 2018-07-23 12:37:11 -07:00
Arun Kumar
478dcabdf1 Refactor GithubRepo model (#583) 2018-07-23 15:23:53 -04:00
Arun Kumar
52486a4edd Update instance methods to module methods (#613) 2018-07-23 12:13:42 -07:00
Arun Kumar
0a0e9fd294 Refactor (#596) 2018-07-23 11:49:27 -04:00
Ben Halpern
fd9653079d Merge branch 'master' of github.com:thepracticaldev/dev.to_core 2018-07-21 19:05:31 -04:00
Ben Halpern
faf36b7053 Fix non-published index policy logic 2018-07-21 19:05:24 -04:00
Ben Halpern
0327585b03
Add nofollow metatag to untrusted pages (#611) 2018-07-21 13:15:38 -04:00
Ben Halpern
7edb371cba
Remove ENV var for algolia and make global var (#609)
* Remove ENV var for algolia and make global var

* Add :: and give test value to ALGOLIASEARCH_PUBLIC_SEARCH_ONLY_KEY
2018-07-21 12:09:14 -04:00
Ben Halpern
83afef4c74
Adjust noindex logic (#608)
* Add Google noindex to possible spam articles

* Add further noindex conditions

* Adjust noindex logic
2018-07-21 11:32:41 -04:00
Ben Halpern
76b9313e3a
Add Google noindex to possible spam articles (#607)
* Add Google noindex to possible spam articles

* Add further noindex conditions
2018-07-21 11:16:57 -04:00