Joshua Wehner
230e77e5cd
Update FilteredAdsQuery and user settings for opting-out of Billboards ( #19208 )
...
* Users can only opt-out of external ads
* Move random sampling out of FilteredAdsQuery
* Refactor filtered_ads_query_spec
* Add test for new permit_adjacent setting
* Rubocop
* Use permit_adjacent_sponsors on article sidebar and post-comments
* Remove, unused
* Update copy
* type_matched -> type_of_ads
* Remove non-applicable test
---------
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2023-03-16 15:23:02 +02:00
Lawrence
cfad413ca1
Display Rules for In house and Community Billboards ( #19189 )
...
* init
* Update app/queries/display_ads/filtered_ads_query.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/queries/display_ads/filtered_ads_query.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* add display ad query and update caller
* set as keyword args and add org id to callers
* Update app/queries/display_ads/filtered_ads_query.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/queries/display_ads/filtered_ads_query.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/queries/display_ads/filtered_ads_query.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/views/articles/_sticky_nav.html.erb
Co-authored-by: Joshua Wehner <joshua@forem.com>
* Update app/views/articles/show.html.erb
Co-authored-by: Joshua Wehner <joshua@forem.com>
* Update app/queries/display_ads/filtered_ads_query.rb
Spacing
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/queries/display_ads/filtered_ads_query.rb
More spacing
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/queries/display_ads/filtered_ads_query.rb
Co-authored-by: Joshua Wehner <joshua@forem.com>
* Update app/queries/display_ads/filtered_ads_query.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix some broken specs
* add updated spec for billboard rules
* missing comma
* Update spec/queries/display_ads/filtered_ads_query_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* add placement in spec
* fix external spec
* cleanup
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-03-06 14:15:14 -08:00
Ridhwana
2da1b45c32
Move a portion of the Display Ads tests alongside the query ( #19017 )
...
* Remove jQuery
* Added jquery back to videos
* Removed jquery code
* Nit fix
* Revert incorrect code
* Updated jquery code to javascript
* Removed jquery from comments
* refactor: move the spec to test the query
---------
Co-authored-by: rt4914 <rajattalesra4914@gmail.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
2023-01-30 10:57:34 +02:00
