Mac Siri
842e6880b8
Routine rubocop fix on /spec ( #19217 )
...
* Softrun rubocop
* Hardrun rubocop (-A)
* Change a rubocop rule
* Add missing cops
* Undo & redo rubocop -A
2023-03-21 09:55:26 -04:00
Jeremy Friesen
b56ae3acbb
Extracting constants and tidying tests ( #15946 )
...
Prior to this commit, we had a couple of references to magic strings
regarding DisplayAdEvent objects. This commit seeks to consolidate that
behavior.
In a handful of cases we had javascript variables, but as these JS files
are `erb` templates, we can inject the constant as well. This reduces
repetition of knowledge.
2022-01-05 09:19:39 -05:00
Josh Soref
0403e78f08
Spelling ( #15702 )
...
* spelling: access
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: additional
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: administrative
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: aggregate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: assigns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: attributes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: autocomplete
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: because
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: between
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: bootstrap
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: calculating
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: captcha
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: character
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: chosen
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: commenter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: competitor
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: componentize
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contrast
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: corresponding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: description
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: destroyed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: destroys
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: discussion
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: episode
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: escaped
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: evaluates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: expired
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: explicitly
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: facebook
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fragment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: functionality
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: improper
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: incentive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interfere
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: latest
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: message
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: minimum
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: moderator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mouseover
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mutual
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: notification
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occasionally
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occurrence
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occurs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: octokit
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: offset
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: omitted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: opacity
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organizations
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: overridden
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: override
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: overriding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: prefill
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: previous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: profile
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recycling
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: registered
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: rescuing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: returns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: second
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: separator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: services
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: subscriber
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: subscription
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: success
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successfully
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: suppress
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: test
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: thought
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: uniqueness
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unproductive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unreachable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unsuccessful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utilities
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utility
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: valid
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: voluntarily
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: vomited
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: website
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: withholding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-12-07 06:59:10 -07:00
Molly Struve
b40af82b66
Flaky Spec Fix:Remove let_it_be Test Prof Helper ( #9556 )
...
* Flaky Spec Fix:Remove let_it_be Test Prof Helper
* Spec cleanup and fixes
2020-07-29 11:31:01 +02:00
rhymes
9c05e618db
Improve speed of model tests by around 50/60 seconds ( #5016 )
2019-12-09 16:33:48 -05:00
Fabbri Paolo
89e893f157
Fix rubocop detected offenses ( #4552 )
...
* Run Inspecting 1050 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....................................................................................................................................................................................................................................................................................................
Offenses:
spec/models/article_spec.rb:195:7: C: RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups )
context "when description is empty" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1050 files inspected, 1 offense detected to fix autofixable errors
* Refactor to correct test
it was braking the rule RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups )
* Run `rubocop --auto-gen-config` to regenrate `.rubocop_todo.yml`
2019-10-24 11:53:03 -04:00
Ben Halpern
5d380f93cb
Track success of DEV Shop ads ( #3589 )
...
* Add basic display ad event tracking
* Finalize client-side eventlistening functionality
2019-07-31 13:44:47 -04:00
