Joshua Wehner
7a9d71666f
Refactor for_display to pass article instead of params ( #19376 )
...
* Refactor for_display to pass article instead of params
* Refactor: use options in FilteredAdsQuery, deconstruct article in DisplayAd.for_display
* Typo
* Restore applicable comments
2023-04-26 16:57:10 +02:00
Peter Frank
3d53351b8f
Update issue templates and automatic comment on new issues ( #19357 )
...
* Update issue templates
Adding a new issue template as part of an effort to clean up the way we use GitHub / GitHub Discussions
* Update config.yml
* Update issue.yml
2023-04-24 13:15:40 -07:00
Mac Siri
531f15566d
Track Deploys with Honeybadger ( #19338 )
2023-04-17 11:14:58 -04:00
Ridhwana
0771a5cd2e
Load post_comments billboard asynchronously ( #19285 )
...
* feat: add a route to the async_info for display ads
* feat: load the billboard asyncronously
* feat: move the methods to the display_ads controller
* feat: handle params better
* feat: cache control headers
* feat: test fastly caching headers on display ads
* fix: surrogate key test
* feat: use safe navigation operator to handle cases where there is no article id
* fix: article id present then find the article
* feat: add a response test
* Fragment caching
* feat: update the article decorator
* feat: update cache keys for fragment
* feat: remove an empty line
* feat: add article id
* feat: bust cache
* feat: setup dropdown for billboard
* chore: add chunk to same line
* feat: add to safe params for caching
* Update app/controllers/display_ads_controller.rb
Co-authored-by: Joshua Wehner <joshua@forem.com>
* feat: remove the cache deletion
* feat: update the routes to follow a new scope
* feat: update the cache params
---------
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-04-12 18:15:15 +02:00
Mac Siri
f88a861125
Keep rubocop's usage consistent ( #19293 )
2023-04-06 07:53:59 -04:00
Mai Irie
3775f2b06c
PR Template cleanup ( #19277 )
...
* PR Template cleanup
Removed some sections we've been using less often to streamline the PR review process.
2023-04-05 11:58:57 -04:00
Mac Siri
e3b6e5b08d
[CI] Make CodeCov less noisy ( #19286 )
2023-04-03 15:56:20 -04:00
Mac Siri
f368a4ce7f
Fix broken cypress code coverage ( #19282 )
2023-03-30 12:36:12 -04:00
Mac Siri
64c10957e3
Update CODEOWNERS ( #19276 )
2023-03-29 17:20:41 -04:00
Mac Siri
88108b3037
Implement code coverage for Cypress ( #19250 )
2023-03-29 15:37:50 -04:00
Mac Siri
1e1064de0b
Undo changes to Sprockets::UglifierWithSourceMapsCompressor ( #19261 )
2023-03-24 12:48:59 -04:00
Mac Siri
b7f00706bd
[CI] Adjust cancel-in-progress concurrency ( #19244 )
...
* [CI] Adjust cancel-in-progress concurrency
* Revert "[CI] Lock setup-ruby to v1.144.0 (#19243 )"
This reverts commit 44a3527983
2023-03-21 10:05:31 -04:00
Mac Siri
44a3527983
[CI] Lock setup-ruby to v1.144.0 ( #19243 )
2023-03-20 11:17:18 -04:00
Mac Siri
047a68cc66
[CI] Add concurrency & remove slack alert ( #19237 )
...
* Remove CI's slack report
* Add concurrency to per branch
* Dynamic cancel-in-progress
2023-03-20 08:59:14 -04:00
Mac Siri
bfe797f44d
Create cleanup-cache.yml ( #19232 )
2023-03-17 12:18:51 -04:00
Mac Siri
2e759c823d
Merge bundle-audit and rubocop into CI & add precompile step ( #19228 )
2023-03-16 15:34:38 -04:00
Mac Siri
61bd41930d
Add build steps and expand CI node ( #19220 )
...
* Add build step
* Use retrieve cache instead for tests
* Add assets_precompile step
* Rename method
* Forgot ruby
* Typo
* Try exit early
* Speed up yarn_install
* Try again
* why
* Oops
* debug echo
* Move order
* Refine lookup process
* Synxtax error
* Remove redundant yarn install
* Separate Storybook
* Simplify
* Revert "Simplify"
This reverts commit 2e07724dcc4d08d03b9f50c41669f9ee94045002.
* Expand node counts
* Experimental bypass
* Remove verbose cypress install
* Revert "Remove verbose cypress install"
This reverts commit 5ace028feb91f44358a384bfaa8d3da1cdf68c07.
* Provide precompiled asset to RSpec
* lets try 10 nodes
* Only cache webpack
* Test speed with 8 node counts
* No need for assets precompile
2023-03-15 09:36:30 -04:00
Mac Siri
09291b4205
Update CI node count ( #19174 )
2023-02-27 12:54:05 -05:00
Adam Vollrath
4668e11dcc
Improvements to Uffizzi Preview Workflows ( #19029 )
2023-02-24 12:34:02 -05:00
Mac Siri
ff3c3c9324
[CI] Collect RSpec artifacts ( #19128 )
...
Co-authored-by: Lawrence <lawrence@forem.com>
2023-02-22 12:52:52 -05:00
Aramayis
c758272aec
Fix Uffizzi sign in bug( #19100 )
2023-02-20 16:21:05 -05:00
Joshua Wehner
048f0cff2a
[CI] Specifying node version explicitly ( #19154 )
2023-02-20 09:01:20 -05:00
depfu[bot]
624240a348
[js] Upgrade cypress: 10.11.0 → 12.5.1 (major) ( #19119 )
...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-02-16 17:06:25 -05:00
Mac Siri
83dbca39ff
[CI] Capture Cypress logs on failure ( #19114 )
2023-02-14 09:53:47 -05:00
Mac Siri
cb3b12feaa
Expand CI nodes ( #19073 )
2023-02-06 15:15:26 -05:00
Mac Siri
45e292463e
Add proper CodeCov flags ( #19044 )
2023-02-02 15:41:42 -05:00
Mac Siri
14b28a1a9c
Use upload-artifact in CI ( #18980 )
2023-01-19 07:30:59 -05:00
Mac Siri
aaf4339b46
Expand CD to include staging ( #18966 )
2023-01-16 14:20:38 -05:00
Mac Siri
68c7308c59
Add Github CD (2nd attempt) ( #18960 )
2023-01-13 15:51:08 -05:00
Aramayis
12e37330c7
Integrate Uffizzi ( #18792 )
...
Co-authored-by: Aramayis <>
2023-01-09 10:49:39 -05:00
Mac Siri
f13a1ec0c2
Actually get buildpulse to work with rspec and jest ( #18859 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-12-19 14:31:29 -05:00
Mac Siri
db39270539
Integrate BuildPulse ( #18740 )
2022-11-18 09:54:11 -05:00
Mac Siri
4aa053201c
Fix yarn postcss ( #18711 )
...
* Remove postcss-cssnext
* Remove redundant code
* Update postcss-preset-env
* Account for fingerprinting
2022-11-11 08:57:11 -06:00
Mac Siri
a3dbf5d5e3
Fix CI-status-report ( #18679 )
...
* Test CI status report
* Fail both regardless
* that wasn't suppose to work
* Test using conclusion
* Test alls-green
* Add back report
* Add or case?
* Remove success()
* Only send message on main
2022-11-04 07:06:22 -04:00
Mac Siri
d98eee3b08
Remove CD workflow ( #18671 )
2022-11-01 18:57:23 -04:00
Mac Siri
74553f6f88
Specify branch on CD ( #18666 )
2022-11-01 15:24:19 -04:00
Mac Siri
be7a779f36
Add CD workflow ( #18648 )
2022-11-01 10:50:48 -04:00
Mac Siri
e9d4f18f1e
Remove cURL header from bundle-audit ( #18652 )
2022-10-28 09:37:59 -04:00
Mac Siri
c23b269410
Use Github action for CI ( #18617 )
2022-10-27 09:51:27 -04:00
Mac Siri
1beb2ae942
Remove dependabot.yml ( #18310 )
2022-08-10 16:32:14 -04:00
Allison McMillan
eec6488c78
update CODEOWNERS ( #18040 )
...
updating codeowners to point to fewer review groups
2022-07-05 11:58:38 -04:00
Kirtan Soni
debdf1f804
updated dead link and added an example gif ( #17756 )
...
* updated dead link and added an example gif
replaced CONTRIBUTING.md#create-a-pull-request with the current one.
* Update PULL_REQUEST_TEMPLATE.md
resolved the change previously made
* Update .github/PULL_REQUEST_TEMPLATE.md
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2022-06-02 15:30:46 +02:00
Julianna Tetreault
8efdf51c02
Updates the Contributing Guide link in issue.yml ( #17773 )
2022-05-26 10:05:22 -06:00
Naveen
0a96b7f0ae
chore: Set permissions for GitHub actions ( #17535 )
...
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ )
Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
2022-05-03 10:54:51 -06:00
YOSHIDA Katsuhiko
89fcd84f9f
Replace git.io URL ( #17501 )
2022-04-28 07:34:33 -06:00
dependabot[bot]
b0f1452666
Bump github/codeql-action from 1 to 2 ( #17421 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/v1...v2 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-25 13:29:57 -06:00
Takuya N
aec2349ea7
Use label bug instead of type: bug ( #17159 )
...
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2022-04-07 13:12:03 +01:00
Julianna Tetreault
ced3933932
Updates the github-actions bot feature request link and team tag ( #17044 )
2022-03-29 08:38:58 -06:00
dependabot[bot]
0db3770959
Bump peter-evans/create-or-update-comment from 1.4.5 to 2 ( #16969 )
...
Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment ) from 1.4.5 to 2.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases )
- [Commits](https://github.com/peter-evans/create-or-update-comment/compare/v1.4.5...v2 )
---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-23 12:26:06 -06:00
dependabot[bot]
01c6445a11
Bump actions/checkout from 2 to 3 ( #16739 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-02 09:51:43 -05:00
