rhymes
3a53d5797e
Upgrade Rails to 5.2.3 ( #1408 )
2019-04-03 13:08:59 -04:00
Ben Halpern
c90be27677
Ignore unnecessary airbrake notices ( #2283 )
2019-04-01 17:40:50 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Anna Buianova
58b2013377
Fix delayed job errors related to follows #1621 ( #1835 )
...
* Add delayed_job_web to dev environment for debugging
* Add specs for the current Follow callbacks implementation
* Move follower touching to ActiveJob
* Spec for the touch followers job
* Move Follow#create_chat_channel to ActiveJob and make the job safe
* Add ActiveJob to send email notifications about follows
* Enqueue SendEmailNotificationJob after the follow is created
* Specs to wnsure jobs are enqueued on Follow creation
* Make CreateChatChannelJob queue name more specific
2019-02-23 18:16:20 -08:00
Jess Lee
49e3878239
Add Stripe Cancellation Webhook ( #1682 )
2019-02-13 15:56:19 -05:00
Mac Siri
1137d6fba4
Improve specs ( #1693 )
...
* Lock erb_lint
* Refactor moderation spec
* Remove & replace RequestSpecHelper
* Update uid to sequence
* Lower the need for persistence in specs
* Update moderation spec
* Update shoulda-matchers
* Enable backgroundjobs and update commenct spec
* Fix fail specs
* Update comment's validations
* Remove redundent specs
* Actually turn off DJ
* Apply run_background_jobs_immediately
* Remove giveawy specs
* Create Identity spec
2019-02-04 15:56:00 -04:00
Mac Siri
338ad0a6b5
Enable require_dependency for Liquid tags in prod ( #1613 )
2019-01-22 14:57:17 -05:00
rhymes
d09e8e481f
Log ActiveRecord queries in development ( #1549 ) [ci skip]
2019-01-15 10:35:55 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Mac Siri
06e0cbabbb
Revert "Replace Flipflop with Sail ( #841 )"
...
This reverts commit 21870e805a
2018-12-18 13:44:40 -05:00
Vinicius Stock
21870e805a
Replace Flipflop with Sail ( #841 )
...
* Replace Flipflop with Sail
* Address PR comments
* Bump sail version to latest
* Bump Sail to latest version
* Move setting creation to config/sail.yml
* Bump Sail to latest version
* Use correct limit for cast_type in schema
* Update Sail's route
2018-12-18 12:42:30 -05:00
Christine Yen
cff6b5d589
Add Honeycomb gem and initial instrumentation ( #695 )
...
* Add basic Honeycomb initializers
* Add some basic instrumentation, capture basic IDs
* Correctly alphabetize Gemfile, embed env in dataset names
* Actually reorder Gemfile because I can read
* Add custom tracing instrumentation to RssReader
* Improve timing/tracing info in RssReader
* Even make sure Errors show up in trace if possible
* Make sure we capture this as Rails traffic
* Swap in dev/test Libhoney::Clients as appropriate
* Move context-snagging bits into lib/instrumentation.rb
* Merging Gemfile lines seems to be my Achilles heel
2018-11-28 10:08:27 -05:00
Ben Halpern
db6232adf3
Add initial ios push notifications to server ( #1207 )
...
* Add initial push notification logic for iOS
* Adjust notification form css
* Clean up schema.rb
* Add mark-all-as-read functionality for ios notifications
* Update app/models/notification.rb
Fix `find` to `find_by`
Co-Authored-By: benhalpern <bendhalpern@gmail.com>
2018-11-27 17:40:43 -05:00
Andy Zhao
a1010201f2
Notifications part 2 ( #1156 )
...
* Remove stream and add new notification views
* Actually remove Stream
* Move followers query to async method
* Remove unused tests and fix query
* Try using without delay instead
* Add without delay and escape HTML
* Make all tests pending for now
2018-11-19 18:14:24 -05:00
Andy Zhao
e1fd5b38ba
Update reserved words ( #1035 )
...
* Update reserved words and add test
* Update user_spec
* Remove unreliable spec
2018-10-30 13:43:49 -04:00
Mac Siri
5287d4a03b
Create DelayedJob config and misc DX changes ( #979 )
...
* Change from #after_save to #after_create
* Update .babelrc
* Update cloud_name for test
* Update SlackBot's RssReader channel
* Update helpful-hints.md
* Create .gitdocs.json
* Remove serve-docs script
* Update docs/helpful-hints.md
* Update approval
* Revert "Change from #after_save to #after_create"
This reverts commit 548ee0d2c0d56a1aa67316468f4106ac9f437662.
* Create delayed_job.rb
* Bump ancestry gem to 3.0.3
* Fix broken spec
* Remove manual Delayed::Job config in test
* Update spec_helper.rb
* Fix broken specs
* Mute SlackBot in test
* Remove weekly-dgiest.yml
* Create PodcastEpisodeDecorator
2018-10-26 13:15:14 -04:00
Michael
cfda390845
Adds optional support for Docker/Compose ( #296 )
...
* Adds optional support for Docker/Compose
* Upgrades Dockerfile to use a multi-stage build
* Gets rest of stack running in Docker
* Renames queue to jobs, uses jobs namespace command
* Reverts file
* Adds webpacker
* Fixes yarn check issue
* Adds Database URL default connection string
* Remove daemons gem
* Update huskyhook config
* Update seed.rb
* Create .dockerignore
* Increase RackTimeout's config
* Simplify Docker config
* Update README
* Remove postgres url default
* Change docker entry point to 3000
* Remove duped integrity setting
2018-10-12 11:48:53 -04:00
Ben Halpern
0b2ecd44b3
Add pull-to-refresh for index views ( #859 )
2018-10-08 14:26:21 -04:00
Maksim Litvinov
33db32e5f4
Fix rubocop lints ( #794 )
2018-10-03 13:00:09 -04:00
Andy Zhao
6d7466e80c
Silence cache logs ( #507 )
2018-08-27 16:03:11 -04:00
Monica Powell
d303692bc0
#260 increase mentee-mentor description length ( #405 )
...
* increase mentee-mentor description length and fix linting errors
* fix char limit issue and refactor tests
2018-08-20 10:20:23 -04:00
Andy Zhao
183976fde0
Unmute cache silencer temporarily ( #324 )
...
* Unmute cache silencer temporarily
* Update .travis.yml
2018-08-14 12:29:35 -04:00
Ben Halpern
16d301d013
Remove unused delayed_job_web ( #273 )
...
* Remove unused delayed_job_web
* Remove initializer file for delayed_job_web
2018-08-08 13:15:58 -04:00
Andy Zhao
e899cbbfae
Remove unused secret key from config ( #666 ) [ci skip]
2018-08-08 10:36:17 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Mac Siri
c05ae7583e
Make Algolia a requirement ( #636 )
...
* Make algolia a requirement
* Remove algolia defaults
* Fix Envfile issue
2018-08-01 11:27:04 -04:00
Mac Siri
0f3342bcec
[WIP] Implement non front-matter editor ( #415 )
...
* Create alternate editor
* Install linkstate (?)
Not sure how it disappear in the first place
* Run yarn install
* Modulize ArticleForm component
* Refactor
* Isolating css WIP
* Implement simplified frontmatter-less editor
* Modulize individual form element
* Ajust props names
* Transform json params to snakecase
* Remove codes
* Update /new, almost there for release
* Fix editor resize issues
* Change defaultvalue to value in article form tag element
* Modify html buttons in article form
2018-07-27 20:12:33 -07:00
Mac Siri
ce965bcedf
Reduce Airbrake's error output ( #628 )
...
* Remove chmod for after_deploy
* Fix lint
* Ignore Pundit::NotAuthorizedError
* Update Travis config
* Turn off Travis' pr notification
* Add CommonsChunkPlugin to Webpacker
2018-07-27 09:04:52 -07:00
Mac Siri
379829719f
Misc DX improvement ( #621 )
...
* Add updated rack env keys
* Tone-down rack-timeout config
* Avoid cl_image_path in development
* Update README & create env var template
* Update Travis notification config
* Expand Seed file
* Manually-set Rack-timeout config vars
* Fix lint
* Fix Typo(?)
* Add ChatChannel to Seed
* Disable fbq when not in production
* Tweak after_deploy script
* Fix condition
* Change fbq clause
2018-07-25 22:08:17 -07:00
Ben Halpern
7edb371cba
Remove ENV var for algolia and make global var ( #609 )
...
* Remove ENV var for algolia and make global var
* Add :: and give test value to ALGOLIASEARCH_PUBLIC_SEARCH_ONLY_KEY
2018-07-21 12:09:14 -04:00
Mac Siri
40f488d991
Migrate to Travis CI (part 2) ( #591 )
...
* Update Travis.yml
* Update README
* Update README
* Adjust test to not rely on env vars
* Update encryption
* Refactor
* Update env key
* Stub AWS calls
* Create ApplicationConfig
* Fix specs
* Fix lint
* Update ApplicationConfig
* Remove travis env vars
* Fix lint
* Extend character limit to 100
* Add env to travis
* Take out auto-restart after deploy
* Immediately discarded test cache
* Stub GA in request specs
* Stub Pusher
* Fix broken specs
* Update fixture
* Add CodeClimate id
* Change CodeClimate key
* Remove merge mistakes
* WIP
* Add Envied gem & Change README
* Add missing keys
* Add missing key
* Update fixture
* Fix broken spec
* Add Slack Notification for Travis
* Fix wording
* Fix typo
2018-07-20 20:17:18 -04:00
Ben Halpern
e4bb8d7823
Modify timeout and make some queries more efficient ( #593 )
...
* Modify timeout and make some queries more efficient
* Only query podcasts if user signed in
* Remove unnecessary columns selected in boosted query etc.
2018-07-19 11:55:59 -04:00
Yechiel Kalmenson
6bf23854a1
Update deprecated methods in rack-timeout gem ( #564 )
...
* update depracated methods in rack-timeout gem
* bump the version of the rack-timeout gem
2018-07-13 16:44:12 -04:00
Mac Siri
889f813991
Create ReservedWords class ( #562 )
2018-07-11 11:53:04 -04:00
Andy Zhao
b45dd391b6
Disable rack timeout logs ( #530 )
2018-07-03 13:09:11 -04:00
Andy Zhao
a3aa5b5bd2
Silence cache log outputs from dalli gem ( #527 )
2018-07-02 15:51:14 -04:00
Ben Halpern
0941b2e4fb
Add some tests around model validations ( #459 )
...
* Modify sample_application.yml and write test
* Add ahrefs verification
* Add some tests around model validations
* Indent an end
* Add a few tests
* Add tests and reserved words
* Fix live articles spec typo
* Modify ga_events_controller
2018-06-20 17:14:08 -04:00
Mac Siri
d31e1b0594
Remove Sendbird ( #421 )
...
* Remove Sendbird
* Remove more remnant of sendbird
* Remove puts
2018-06-19 17:51:10 -04:00
Ben Halpern
937e87918c
Adjust sample_application.yml and env_checker.rb
2018-06-19 15:15:15 -04:00
Ben Halpern
87c6a758bb
Add top bar indicator and other Connect features ( #424 )
...
* Add algolia public search key
* Add status to chat_channels
2018-06-12 18:24:57 -04:00
Mac Siri
8739a9a59b
Remove verbose registration of Liquid & ReverseMarkdown's extensions ( #416 )
...
* Add autoreload for ReverseMarkdown converters
* Change how custom liquid tags are registered
* Apply autreload logic to test
2018-06-11 17:33:03 -04:00
Mac Siri
8d38fe56fd
Remove precompilation related codes ( #414 )
2018-06-11 11:54:38 -04:00
Ben Halpern
7bc3e60283
Add browser push notifications (attempt) ( #412 )
2018-06-09 17:33:58 -04:00
Ben Halpern
98d84d2456
Update chat and add precompilation paths ( #406 )
...
* Update chat and add precompilation paths
* Update chat and add precompilation paths
* Adjust assets.rb
2018-06-08 15:31:48 -04:00
Ben Halpern
ab85216621
Update chat and modify article score calc indexing ( #395 )
2018-06-06 16:08:12 -04:00
Ben Halpern
a6cc5e4669
Fix Github Readme tag and add Glitch tag ( #357 )
2018-05-29 14:09:47 -04:00
Mac Siri
9cbc209d62
Monkey-patched ReverseMarkdown's :text & :pre ( #353 )
2018-05-25 14:03:59 -04:00
Ben Halpern
ce255ba900
Add speakerdeck liquid tag ( #343 )
...
* Take darker of user colors
* Add speakerdeck liquid tag
* Modify speakerdeck test
2018-05-22 17:31:07 -04:00
Ben Halpern
bc947bbacc
Modify chat styling ( #314 )
2018-05-14 18:16:42 -04:00
