Commit graph

674 commits

Author SHA1 Message Date
Ben Halpern
f124c2f65a
Fix html variant image prefix issue + other small fixes (#1005) 2018-10-24 17:44:59 -04:00
lianafelt
61ef3bdd8e Update sponsors.html.erb (#1006)
Remove StickerMule
2018-10-24 17:44:45 -04:00
Ben Halpern
ae3ec2e237
Add/fix org call-to-action box/copy (#1000) 2018-10-24 13:49:57 -04:00
Mac Siri
801043ab0d
Mute Pusher errors (#993) 2018-10-24 11:12:34 -04:00
Ben Halpern
d5ceff4b12
Update/fix org settings (#992)
* Update/fix org settings

* Small adjustment to an unrelated rake task

* Update app/views/users/_org_non_member.html.erb
2018-10-23 17:21:17 -04:00
Ben Halpern
735a96432c
Add usability features to html_variants (#991) 2018-10-23 16:23:48 -04:00
Ben Halpern
90861366df
Add additional config to v2 editor (#980)
* Add additional config to v2 editor

* Fix typo
2018-10-23 12:41:19 -04:00
Ben Halpern
8661fe44d5
Fix sidebar caching issue for articles (#981) 2018-10-22 17:49:59 -04:00
Ben Halpern
302e8f202d
Add HTML variants for cta optimization and other nav bar adjustments (#970)
* Add HTML variants for cta optimization and other nav bar adjustments

* Fix 1==1 non-random mistake

* Spruce up org call-to-action

* Change default text color

* Add html variant trial and success request specs

* Fix article sidebar caching issue

* One line adjustment

* Modify schema

* Add include ActionView::Helpers::TagHelper to user_tag_spec

* Modify follow_button to remove session context

* Dummy commit

* Change Edit Article to Edit Post

* Dummy commit

* Fix rubocop concerns

* Fix rubocop style
2018-10-22 17:03:57 -04:00
Jess Lee
80339dd573 Fix internal article query (#964)
* update abuse report subject template

* fix internal/article top month filters

* update resolution email spec with proper subject line
2018-10-19 16:16:43 -04:00
Nick Karnik
2136b105a3 Implement ability to style text in comments using hotkeys (#959)
* Resolves #891
    * This is applied to root level comments as well as nested replies.
    * We are handling latest browsers and special cases for FF, IE8/9/10
    * All newer browser except FF support undo/redo functionality in the exact reverse order of text insertion
    * Refactored some code
    * Support for Bold & Italic text
    * Support for Text Links
    * In a subsequent change, we can consider adding hotkey for image URL
        * Didn't add this feature at the moment since there's no universally accepted key-combination for image URL's that I know of
    * IE 8-11 is not supported because it is a bit convoluted and I don't have a way to test it reliably
        * We can revisit this if it is really needed and find a jQuery plugin to handle it
2018-10-19 15:39:22 -04:00
rhymes
7fe6777c75 Support links with trailing slash for link tag (#950)
The previous implementation of the link tag didn't support links with a trailing slash. It was also based on an internal and undocumentented function in Rails.

https://github.com/rails/rails/issues/28331#issuecomment-285440151
2018-10-19 15:25:58 -04:00
Nihad Abbasov
4995a4af21 Performance: replace ruby methods with their faster alternatives (#949)
- Array#select.first is slower than Array#detect.

  - Array#shuffle.first is slower than Array#sample.
2018-10-19 13:21:18 -04:00
Jérôme Pott
04968214ce Fix typo (#958)
Add missing verb "controls"
Capitalize first letter "English"
2018-10-19 13:13:18 -04:00
Mac Siri
c35544a154 Replace sprocket-es6 with new uglifier feature (#928) 2018-10-19 13:12:07 -04:00
Thomas Bnt
16dc2fb903 Adding Font Awesome (#953)
* Adding Font Awesome

* Update copy
2018-10-18 17:25:37 -04:00
rhymes
1b60ee5009 Use timezone aware methods (#893)
* Use timezone aware datetime methods

* Use timezone aware date parse for GitHub issue tag

* Introduce a bit of chaos programming using Zonebie

Zonebie uses a random timezone to run tests, it's a really good way to see if the code is timezone dependent or not.

* Convert GitHub issue date as UTC
2018-10-18 16:26:29 -04:00
Ben Halpern
ca403ee01e
Adjust article show view css (revert sticky css) (#954)
* Adjust article show view css

* Change color subtly
2018-10-18 16:02:54 -04:00
Juan Manuel Ramallo
6ada73136b [Article Actions] Using position sticky (#945) 2018-10-18 12:27:58 -04:00
Ben Halpern
8184baed83
Adjust analytics styling and accuracy (#951)
* Adjust analytics styling and accuracy

* Add video button back in
2018-10-18 12:19:49 -04:00
lianafelt
40f09e4b77 Fix Typo in Internal/users (#948)
Update link to mentor internal user profile
2018-10-18 12:12:02 -04:00
Ryan
95b2e181ff Add Medium URL to User's Profile (#943) 2018-10-18 11:39:39 -04:00
Jess Lee
7bf9a8ce89 Delayed Jobs Investigation (#929)
* disallow nil reactables to be saved

* investigation wip

* passes deleted comment info to async bust cache

* fixes failing cache buster spec

* Create user_delete_a_comment_spec.rb

* Fix broken spec

* Binstub RuboCop

* Do not save comments when they are getting destroyed

* break update_reactable into smaller methods
2018-10-17 17:03:20 -04:00
Ben Halpern
305492c2c8
Add similarity score for users (#942) 2018-10-17 11:53:28 -04:00
Ben Halpern
7d783c2b9f
Change default <from> in notifymailer mentor emails (#940)
* Change default <from> in notifymailer mentor emails

* Change to dev.to for consistency + spec
2018-10-16 17:02:02 -04:00
Kyle Galbraith
f9c19f6b81 Feature/add parler.io liquid tag for audio embed (#828)
* initial parler liquid tag

* fix eqaulity in test

* update parler tag to parse out url since it is coming in as <ahref>
2018-10-16 16:54:02 -04:00
Ben Halpern
3bf42edd17
Add summary to select fields in sidebar follow suggestions (#934) 2018-10-16 16:50:26 -04:00
lianafelt
0d23ec1faf Update Mentor Email (#938)
* Update mentor_email.html.erb

Update copy to original mentor email from mailchimp

* Update mentor_email.text.erb
2018-10-16 16:43:03 -04:00
lianafelt
747cf04bfb Update Mentee Email (#935)
* Update Mentee Email

Mentee email with copy from original mailchimp emails.

* Update mentee_email.html.erb

* Update mentee_email.text.erb
2018-10-16 16:42:39 -04:00
Sergey Kislyakov
ac4b9b39db Fixed badge page not having a title (#939) 2018-10-16 16:41:58 -04:00
Sergey Kislyakov
dd8fcd1e39 Fixed /feedback_messages not having a title (#930) 2018-10-16 13:41:32 -04:00
Ben Halpern
fcb68b4f29
Add automatic random mentee show page after quick match (#931) 2018-10-16 13:41:14 -04:00
Ben Halpern
af4e6932fa
Adjust org size labels in settings form (#933) 2018-10-16 13:41:00 -04:00
Ben Halpern
dee58c0dce
Update mentorship area of user internal view (#926)
* Update mentorship area of user internal view

* Update mentorship backend
2018-10-15 18:04:29 -04:00
Andy Zhao
0dab93bdad Allow Giphy links to be used and not from Cloudinary (#927)
* Test for giphy images

* Allow giphy images to be used as-is
2018-10-15 17:35:09 -04:00
Albert Alises
63acc9b72a CSS height fix for Read Post button [Fixes #921] (#922)
* [Fix #909] [ci skip] Added links to testing libraries on testing.md, fixed typo

* Fixed height for READ POST button

* Fixed heigth for READ POST button
2018-10-15 15:21:52 -04:00
Adam Lombard
92645d6062 Fix indentation in articles_controller.rb (#908) [ci skip] 2018-10-15 12:30:08 -04:00
Ben Halpern
8b12c1fb04
Fix logic in StickyArticleCollection (#906) 2018-10-14 12:37:49 -04:00
Ben Halpern
79bc96e1ca
Simplify article show view/remove queries (#905) 2018-10-14 11:18:06 -04:00
Ben Halpern
57fff54cd8
Remove es6 code from non-es6 area (#904) 2018-10-13 20:02:49 -04:00
Ben Halpern
221c363af0
Reduce queries in typical stories#show response + small fixes (#903)
* Reduce queries in typical stories#show response + small fixes

* Change const to git in non-es6 code
2018-10-13 19:38:38 -04:00
Ryan Palo
588ffeef09 Fix #848. Code inside Markdown inside Gist displays. (#902) 2018-10-13 14:28:39 -04:00
Nick Karnik
a3649b8d09 Added the ability to press Ctrl+Enter Or Command+Enter to submit comments. (#885)
* Resolves #245
    * This is applied to root level comments as well as nested replies.
    * We are ensuring that user has commented at least once which means
      they have accepted the code of conduct before

Style changes as per suggestions in code review
2018-10-13 14:24:53 -04:00
Ben Halpern
75c4388e53
Add mentorship automation (#896) 2018-10-12 16:37:32 -04:00
Andy Zhao
7c4396d535 Handle flash messages that are not arrays (#895) 2018-10-12 11:56:45 -04:00
Sheldon Nunes
8c70c95cea Fix on-boarding typo (#892) 2018-10-12 09:06:44 -04:00
Ben Halpern
b13c09583f
Adjust modal to not interfere with pull-to-refresh (#888)
* Remove unnecessary code from onboarding

* Adjust pull-to-refresh button to account for open modal scenario
2018-10-11 16:45:43 -04:00
Andy Zhao
c3322be9ce Improve Sign In/Up Error Handling (#832)
* Add registration view to sign_in page

* Add better sad path for failed sign ins/ups

* Ensure email is downcased for authorization

* Remove .downcase for emails

* Use partial for styles
2018-10-11 13:31:37 -04:00
dgolant
c3c420defd Update codepen tag to accept links with trailing /'s (#886) 2018-10-11 10:54:44 -04:00
Ben Halpern
85a7c97b9b
Remove unnecessary queries from onboarding (#884) 2018-10-10 17:34:54 -04:00