Ben Halpern
66f3ae71b5
Adjust comment notification logic ( #20534 )
...
* Adjust comment notification logic
* Update spec/models/comment_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/models/comment_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/models/comment_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-17 12:22:50 -05:00
Anna Buianova
539844165f
Avoid sending follow notifications from spammers ( #20526 )
2024-01-15 16:50:21 +00:00
Philip How
33fd9836be
Add CSS as pages template option ( #20512 )
...
* add css as pages option
* don't forget schema
* fix test
* add api support
2024-01-12 15:35:38 +00:00
Ben Halpern
b0e3a512bb
Delay and modify follow logic to remove spammers ( #20505 )
...
* Delay and modify follow logic to remove spammers
* Fix tests
* Change comment
* Update spec/models/notification_spec.rb
Co-authored-by: Anna Buianova <lightallloy@gmail.com>
* Update spec/models/notification_spec.rb
Co-authored-by: Anna Buianova <lightallloy@gmail.com>
---------
Co-authored-by: Anna Buianova <lightallloy@gmail.com>
2024-01-10 14:35:12 +00:00
Ben Halpern
8e532c848a
Nullify published_at if absurdly far in the future ( #20504 )
2024-01-08 16:57:38 +00:00
Ben Halpern
04d4b2340d
Add downstream score effects from spam role ( #20498 )
...
* Add downstream score effects from spam role
* Move async score calc down low
* Add tests
* Add stub
* Fix typo
* No need for guard
* No need for guard
2024-01-08 16:25:28 +00:00
Anna Buianova
473594f192
Match spam role with existing suspended actions ( #20477 )
...
* Started matching spam and suspended roles
* Match spam and suspended roles in most cases
* Fixed check_suspended for unauthenticated users
2023-12-27 20:12:50 +00:00
Ben Halpern
f0673648c2
Add preferred_article_ids to billboards ( #20437 )
...
* Add preferred_article_ids to billboards
* Adjust query
* Refactor method
* Refactor method
* Fix input type
* Add feature flag
2023-12-18 19:20:56 +00:00
Anna Buianova
1eeaa34e98
Added spam role ( #20434 )
...
* Added spam role
* Fixed role spec
2023-12-11 14:27:22 +00:00
Ben Halpern
347fd6d112
Recommended articles list ( #20383 )
...
* Add recommended articles list
* Adjust tests
* Adjust tests
2023-11-24 17:57:55 +00:00
Ben Halpern
aedeaede84
Tweak billboard image quality to 100 ( #20314 )
2023-11-03 14:07:24 -04:00
Anna Buianova
41ab84a25d
Remove feature flag and use consistent rendering by default ( #20305 )
2023-11-03 11:42:12 -04:00
Ben Halpern
587a11d490
Adjust image optimization for billboards ( #20309 )
...
* Adjust image optimization for billboards
* Fix test typo
* Adjust default
2023-11-02 16:12:20 -04:00
Ben Halpern
b0cb5540c0
Add new render mode and template options for billboards ( #20282 )
...
* Add new render and template modes for billboards
* Add new fields to /admin
* Adjust test
* Adjust markup in form
* Add tests for script execution
* Add two script test
* Adjust scripts
* Adjust scripts
* Add new test
* Add new explicit tests
* Move JS functionaity around
2023-10-30 14:56:09 -04:00
Daniel M Brasil
479a09f77b
Improve organizations's slug validator ( #20265 )
2023-10-26 13:08:11 -04:00
Ben Halpern
c6377ab607
Backfill dark theme for iOS app compatibility ( #20269 )
2023-10-23 16:36:44 -04:00
Ben Halpern
1da43d9027
Add language when new user visit context is detected ( #20263 )
...
* Add language when new user visit context is detected
* Finalize tests
2023-10-20 15:35:41 -04:00
Anna Buianova
20e242af0d
Rubocop fixes ( #20254 )
...
* Fixed redundant alls for rubocop
* Fixed rubocop violations in spec/requests
* Fixed rubocop violations in spec/models
* Fixed Performance/MapMethodChain
* Fixed rubocop violations in spec/requests
* Revert changes to FastlyConfig::Update spec
2023-10-18 17:24:28 -04:00
Mac Siri
20faec4899
Support chromedriver in container ( #20224 )
2023-10-16 15:12:53 -04:00
Ben Halpern
bc89cf3e38
Store browser accept language header on users ( #20212 )
...
* Store browser accept language header on users
* Change to tracking via user context
* Remove async info code
* First draft of spec
* Work out tests
* Delete dependents
2023-10-16 11:59:30 -04:00
Mac Siri
341f64c0d3
Bump with_model ( #20222 )
2023-10-06 11:24:25 -04:00
Narender Singh
2a489210a2
Remove unique article title validation ( #20031 )
2023-10-05 14:59:50 -04:00
Ben Halpern
044fe88230
Follow on adjustments to flag counts ( #20207 )
2023-10-02 17:23:37 +07:00
Ben Halpern
f811f17830
Fix irrelevant flag numbers ( #20204 )
...
* Fix irrelevent numbers in admin display
* Remove unused possible_spam_users_count
* Fix tab styles
2023-10-02 15:01:50 +07:00
Ben Halpern
8268a59ae5
Add feed event for extended page view ( #20198 )
2023-10-02 10:28:31 +07:00
Ben Halpern
c5201ca888
Remove dead code associated with old roles ( #20175 )
...
* Remove dead code associated with old roles
* Remove test references
* Removed from seeds
* Removed unused roles from locales
---------
Co-authored-by: lightalloy <lightallloy@gmail.com>
2023-10-01 09:33:25 +07:00
Ben Halpern
e998e5bcac
Do not show suspended followers in aggregated siblings for notification ( #20174 )
2023-09-27 20:23:25 -04:00
Joshua Wehner
6a48b486ca
Onboarding: custom newsletter opt-in settings ( #20114 )
...
* Settings can process markdown into html
* Update Settings with new onboarding settings
* Async render onboarding newsletter step
* Tweak onboarding design
* Fix broken spec
* Better rendered component test
* Tweaks to match design
* Try to tweak design
* Try having a default state
* Tweak placeholder content
* Better await componentDidMount
* Continue to tweak the design
* ContentRenderer#process should always return Result
* Try more clarity in the partial
* Rubocop
2023-09-26 06:34:19 -04:00
PJ
47deeefe57
Optionally limit new users based on admin setting ( #20149 )
...
* create admin setting for new user status
* limiting on signup working 🎉
* update registration specs
* sort out OAuth registrations
2023-09-26 10:46:36 +01:00
Ben Halpern
cadebde66f
Add feed_success_score and other count tallies ( #20106 )
...
* Add initial feed events score
* Add feed events score
* Clean up code styles
* Adjust how tests are run
* Fix conflicts
* Update app/javascript/articles/Feed.jsx
* Add additional feed events tabulation queries for more reliable eventual consistency
* Add additional feed events tabulation queries for more reliable eventual consistency
* Fix test logic
* Updates from feedback
2023-09-15 12:02:26 -04:00
Ridhwana
aa201060e8
Override Tag Moderation Actions ( #20088 )
...
* feat: remove the validation for the article_id and tag_name to be unique on a tag_adjustment
* chore: remove unique index
* feat: update the validate_tag method to align with the removal of unique indexes on the table
* feat: do not allow removal and addition of tags that were added/removed by admins
* spec: add tests for the tag_adjustment_spec
* fix: update the validation of tags
* spec: article validation
* spec: test the action_panel helper
* chore: amend language
* add styles
* Empty commit
2023-09-15 15:06:58 +02:00
Anna Buianova
56f2a58e95
Default content language for forems ( #20089 )
...
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2023-09-13 13:26:45 +03:00
PJ
3f922921e5
Admin setting to control enabled countries for billboard geotargeting ( #20083 )
...
* use instance setting for enabled target geolocations
* add validation for enabled geolocations setting
* a start on the UI?
* backend tweaks for UI
* proper crack at autocomplete component
* fix region targeting toggle
* e2e spec
2023-09-12 12:06:00 -04:00
PJ
95ca9d37c5
Record feed events for public reactions ( #20079 )
...
* create feed event on feed reaction
* move feed event creation to feed event model
* tiny whoops
* fix failing specs
* slightly less flaky e2e spec (maybe)
* tiny fixes (couldn't resist)
2023-09-12 08:36:10 -04:00
Duke Greene
bf4c34636e
display tag moderation history in article's mod panel ( #20041 )
...
* logic and markup to display tag adjustment history on article mod panel
* add tag adjustment reason to markup
* add specs for article's tag adjustment association and ordered tag adjustments
* style tag adjustment history
* sketch out cypress test for visible tag moderation history
* tweak spacing and sizing of adjustment history heading
* adjust cypress tests, tag adjustments still coming back empty in spec
* get past first cypress snag by waiting for request and reloading
* add spec for viewing multiple tag adjustments in a post history
* restore defer: true in actions panel js packs call
* add e2e tests for remaining mod views with tag adjustment UI
2023-09-12 07:08:44 -04:00
Anna Buianova
aa5cb535fa
Add languages to User model ( #20059 )
2023-09-11 11:44:19 -04:00
PJ
3f7d1fbc1a
Create feed impression and click events ( #20043 )
...
* getting started: model setup
* basic controller action & spec
* somewhat working click events
* pick up on impressions
* there was an attempt at batching without duplicates
* (better) bulk upsert service
* fix specs?
* touch up feed events JS
* end-to-end specs??
* workers wip
* fix failing user delete spec
2023-09-11 13:32:36 +01:00
Ben Halpern
22f836edc2
Add priority weight to billboards ( #20019 )
...
* Add priority weight to billboards
* Rewrite query as activerecord
* Change naming from priority_weight to just weight
2023-09-05 16:04:18 -04:00
Ridhwana
a6d8767aaa
Use explicit points for following and hidden tags ( #20032 )
2023-09-05 19:17:27 +02:00
Ben Halpern
3324bf47f1
Add http_header to FastText for Fastly compatibility ( #19999 )
...
* Add http_header to FastText for Fastly compatibility
* Update app/services/articles/enrich_image_attributes.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/html/parser.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/models/display_ad_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix rubocop
* Also accept canges to main image for this re-calc
* Rename display_ad_spec for compatibility with main
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-08-28 09:34:59 -04:00
Anna Buianova
2d6b740940
Renamed DisplayAd model to Billboard ( #19993 )
...
* Renamed Resource Admin: DisplayAd to Billboard
* Renamed DisplayAd to Billboard
* Added a data update script for roles
2023-08-28 08:09:36 -04:00
Rajat Talesra
5ef0f43636
Added limited role ( #19969 )
...
* Added limited role
* Nit fix
* Updated tetss
* Added spec tests
* Attempt at 100% code coverage
* Rollback DB migration
* Revert timestamp
2023-08-25 14:41:17 +05:30
Helio Cola
de1e79e722
Improve SVG regexp validation to use \A and \z ( #19953 )
2023-08-24 09:29:28 -04:00
Ben Halpern
98cccdf0ef
Change MAX_TAG_LIST_SIZE for billboards to 25 ( #19981 )
2023-08-23 12:35:07 -04:00
Duke Greene
288206a2b4
speed up organization creation by removing some presence validations ( #19952 )
...
* remove presence validation for summary/url/proof, update UI
* simplify everything! use AR validation syntax
* Update app/models/organization.rb
revert reordering of url validation arguments. I had overcomplicated the work with a custom validation, and then upon resetting it, I changed the order unnecessarily
2023-08-22 06:36:16 -04:00
Ben Halpern
3f07d43e72
Safer inputs to billboard ENV vars ( #19938 )
...
* Safer inputs to billboard ENV vars
* Update app/models/display_ad.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/models/display_ad.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/models/display_ad.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/models/display_ad.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/models/display_ad_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/models/display_ad_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/models/display_ad_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/models/display_ad_spec.rb
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-08-16 08:43:27 -04:00
Ben Halpern
33b11f1eac
Use direct relative path to access assets in minimagick ( #19933 )
...
* Use direct relative path to access assets in minimagick
* Skip Hairtrigger spec
* Add a test to get more coverage
2023-08-15 09:36:16 -04:00
Ben Halpern
c0b65c248c
Limit billboard user_tags number and weight towards preferred tags ( #19923 )
...
* Limit billboard user_tags number and weight towards preferred tags
* Fix styles
2023-08-11 15:54:42 -04:00
Anna Buianova
9c9663a5b5
Renamed display_ads to billboards: variables and descriptions in tests ( #19920 )
...
* Renamed display ad variables and descriptions in tests
* Renamed api docs display_ads => billboards
* Updated billboard cypress seeds
* Fixed api billboards specs
* Update db/schema.rb
Co-authored-by: Duke Greene <dukegreene@gmail.com>
---------
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
Co-authored-by: Duke Greene <dukegreene@gmail.com>
2023-08-11 15:00:07 -04:00
Ben Halpern
c9af090af0
Prefer Minimagick for social image generation ( #19826 )
...
* Prefer Minimagick for social image generation
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Reformat main file
* Fix user tests
* Finish up tests
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Change asset path syntax
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Refactor magickally file
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix style issues
* Remove pure black
* Test color swap
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Add more test coverage to service
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix doubled spec name
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Add upload spec
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update spec/services/images/generate_social_image_magickally_spec.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Swap out magickally in social image worker
* Add test stub and rescue
* Update spec/rails_helper.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix regex
* Add cache busting and error logging
* Update app/services/images/generate_social_image_magickally.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix style issues
* Add more test coverage
* Add feature flag
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-08-11 08:22:06 -04:00
