Commit graph

1878 commits

Author SHA1 Message Date
Anna Buianova
5248a781b5 Rescue InvalidURIError when busting cache (#3938) 2019-09-06 13:07:24 -04:00
Andy Zhao
8a4030c25d Revert changes as a hotfix (#3964) 2019-09-06 11:54:35 -04:00
Andy Zhao
aadd376f9c Use explicit email domain for badge email links and minor cleanup (#3943)
* Set domain for badge email links

* Add credits + listings info to plain text badge email

* Update environment variable setting

* Use ENV when ApplicationConfig has not been init
2019-09-06 10:20:48 -04:00
rhymes
69c8b24c34 Send JSON 404 response to API error routes (#3959)
* Fix an issue where API 404 calls got the HTML 404 page in response

* Use keyword for consistency
2019-09-06 10:18:50 -04:00
rhymes
3a0dc13fc7 Replace "access token" with "API Key" (#3960) [ci skip] 2019-09-06 09:08:39 -04:00
Almenon
1a99e9bf1a Hide scrollbars in the editor textarea (#3897)
* Hide scrollbars

There is no need for scrollbars in the textarea given the scrollbar at the edge of the browser and that `preact-textarea-autosize` used for the textarea already increases the height of the textarea when needed. Getting rid of scrollbars would solve #2939 and #3330

* add documentation
2019-09-05 18:04:24 -04:00
Jacob Herrington
287bc4432c Make report notification use theme colors (#3896) [ci skip] 2019-09-04 15:22:29 -04:00
rhymes
2e5a847ab8 API: /api/articles/me defaults to published articles (#3937)
* /api/articles/me defaults to published articles

We want to make it explicit to retrieve unpublished articles, this change defaults `/api/articles/me` to only published articles, also adds `/api/articles/me/published`, `/api/articles/me/unpublished` and `/api/articles/me/all` to make requests more explicit.

* Refactor /me logic into a case switch
2019-09-04 14:02:13 -04:00
Jacob Herrington
4293a00544 Update notifications reply form to use theme colors (#3894) [ci skip] 2019-09-04 08:42:54 -04:00
Andy Zhao
e25d2eaec9 Escape raw tags in codeblocks properly (#3790) 2019-09-04 08:33:46 -04:00
rhymes
78f22c3682 Simplify the images uploading code (#3907) [ci skip] 2019-09-04 08:14:59 -04:00
Ben Halpern
07ba4d8b2b
Modify headers to allow embed (#3935) 2019-09-03 16:38:04 -04:00
Jacob Herrington
81f7f73575 Format console copy (#3888) [ci skip] 2019-09-03 15:59:12 -04:00
Akshay Mahajan
c5577f68a3 Reading list: set default reading time to 1 minute (#3927)
* fixes 0 min reading time in reading list by setting the default reading time to 1 min

* Updated PropTypes for article_reading_time & reading_time to number.isRequired. Updated the relevant tests.
2019-09-03 15:50:40 -04:00
Jess Lee
3c4dce0521 remove homepage placement for bronze and silver (#3934) 2019-09-03 13:26:36 -04:00
rhymes
676cf002bd Webhooks: API fixes and docs (#3901)
* Fix webhook API and add POST /api/webhooks docs

* Document GET /api/webhooks/:id

* Fix DELETE /api/webhooks/{id} and document it

* Add proper 404 specs
2019-09-03 10:41:23 -04:00
Mac Siri
5e75bf3aaa
Update PingAdmins to show triggering event (#3853) 2019-09-03 10:23:25 -04:00
rhymes
e1334e3625 Use a self explanatory name to render chat channel (#3902) [ci skip] 2019-09-03 10:19:36 -04:00
tyronasaurus-rex
c9a4ae7f6d Add pixel limit to Editors Guide (#3903) [ci skip] 2019-09-03 10:18:48 -04:00
Jacob Herrington
07944755ff Fix rubocop lints (#3922) [ci skip] 2019-09-03 10:09:48 -04:00
Jacob Herrington
099b188530 Rename uncommunicative variables (#3890)
* Clarify uncommunicative variables in labor classes

Single letter variable names are largely a question of preference, in
some cases I think that convention mitigates the opaque nature of single
letter variable names (e.g., e for error, i for index, etc).

However, in some cases they can be unclear and there isn't much reason
to use single letter variables unless for some reason character length is
really important.

In this case, I would prefer clarity in variable names over brevity of
code so I've used Reek to identify short variable names and I'm changing
them.

It's pretty boring, but hopefully incremental code love changes like
this one add up and improve readability and accessibility for those
interested in reading this codebase.

* Remove commented code from 2 years ago

* Clarify uncommunicative naming in services classes

There is some context for this change in 6b81880f

* Clarify uncommunicative naming in models

There is some context for this change in 6b81880f

* Clarify uncommunicative naming in liquid_tags

There is some context for this change in 6b81880f
2019-09-02 13:05:07 -04:00
Mario See
fda048dc12 Listing Drafts and Deletion (#3540)
* wip init handle draft class and styling

* add draft button

* start splitting up listing row into multile files

* separate tag links

* split location

* fix location

* separate listing row action buttons

* update listing row proptypes to describe listing object

* contact via connect to jsx

* fix default checked

* init draft creation and first publish charge

* fix first publish logic and credit charging

* handle drafts in dashboard filtering

* adjust isDraft bool statement

* hide drafts from main listings feed

* fix expired and draft bools in listing row

* adjust create listing org credits

* internally handle drafts

* adjust listing row

* break down update method

* remove unnecessary logic and shorten lines

* fix logic again woops

* convert input hidden value + submit into one form button submit with corresponding name and value

also adds clear message that drafts do not cost credits

* handle insufficient org credits on first publish

- uses user credits to publish
- similar to bump implementation

* fix sorting for personal and all orgs

* space out some elements

* don't spend original users credit for them

* add delete buttons and delete_confirm and destroy methods

* remove notification removal since listings dont trigger notifications

* move draft message and add draft_params to tests

* Update classified_listings_controller.rb

* update tests

* update snapshot

* add del tests

* add guard preventing free draft publish

* fix draft filter

* update from master and resolve merge conflict in listing preact

* Revert "update from master and resolve merge conflict in listing preact"

This reverts commit 0a34fccf334a2ca0902644b486cb26ead6bef664.

* update column spec

instead of setting and saving

* separate two expectations into their own tests

* split more tests into single expectations

* change to unless bumped_at? instead of if nil

* Fix listing draft edge cases and styling

* Add title tags to listings pages
2019-09-01 13:54:54 -04:00
Mario See
3cf6a2d4bc Add singleListing specs (#3883) [ci skip] 2019-08-30 14:49:20 -04:00
Michael Tharrington
5cdd3e2f10 Update Email Copy for internal/reports (#3867) 2019-08-30 09:58:30 -04:00
Ben Halpern
81bff4da35
Fix internal mods interactivity and improve layout (#3879) 2019-08-29 19:00:22 -04:00
Tiger Oakes
92e107e82e Use maskable icons for PWA (#3875) [ci skip] 2019-08-29 18:44:26 -04:00
Jean-Michel Fayard
4af02c8a48 Support for runnable kotlin snippets #3776 (#3801) 2019-08-29 16:06:17 -04:00
Anna Buianova
bfdf636dcf Implement webhook & API endpoints #3715 (#3783) 2019-08-29 10:23:41 -04:00
Ben Halpern
917bc14eae
Update mod internal backend to be safer and more intuitive (#3869) 2019-08-28 23:26:32 -04:00
Mac Siri
c9e1f1fcf3 Add listings to DEV digests (#3854)
* Add listings to digest emailers

* Update app/views/mailers/digest_mailer/digest_email.html.erb

Co-Authored-By: Ben Halpern <bendhalpern@gmail.com>

* Remove margins
2019-08-28 21:28:46 -04:00
AJ Johnson
00ed11fca7 Fix page scroll bug on /connect page (#3856) [ci skip] 2019-08-28 15:05:27 -04:00
Ben Halpern
67a8dbcd04
Add hashtags to linkedin body (#3866) 2019-08-28 14:49:31 -04:00
Ben Halpern
9259a70ab8
Modify onboarding slides (#3864) 2019-08-28 11:05:57 -04:00
Andrew Bone
2969e3d091 Mod page "suggest a tweet" width (#3863)
* Fix tweet box width

* Fix tweet box width

* Moved rule to right selector
2019-08-28 11:04:44 -04:00
Ben Halpern
abfdb8787b
List badges count instead of reactions (more relevant) (#3862) 2019-08-28 08:39:13 -04:00
Ben Halpern
b09fa26efa
Fix up a couple mods backend things (#3861) 2019-08-28 08:09:29 -04:00
Ben Halpern
9ad383c00e
Fix commenter issue for roundrobin notification (#3857) 2019-08-27 23:01:30 -04:00
Feruz Oripov
560e171fd8 Refactoring chat_channels_controller.rb. (#3823) 2019-08-27 22:13:01 -04:00
Ben Halpern
208bbb3757
Improve mod roundrobin notification and internal tooling (#3855)
* Improve mod roundrobin notification and internal tooling

* Fix tests
2019-08-27 21:54:09 -04:00
cyrillefr
369aeb9130 Fix comment deletion bug (#3732)
Fix bug where deleted comment still appears on user's profile
2019-08-27 17:07:09 -04:00
Feruz Oripov
0ccc62ffa3 Refactoring possible unprotected redirect. (#3825)
* Refactoring possible unprotected redirect.

* Security refactoring tag_adjustments_controller.rb.

* Security refactoring tag_adjustments_controller.rb.

* Security refactoring articles_controller.rb.

* Security refactoring internal/welcome_controller.rb

* Security refactoring tags_controller.rb.

* Security refactoring comments_controller.rb.

* Security refactoring stories_controller.rb.
2019-08-27 10:13:38 -04:00
Feruz Oripov
ee498ad9ef Refactor VideosController (#3806) [ci skip] 2019-08-26 18:59:31 -04:00
Nick Taylor
45368132b0 Fix JS Lints (#3815) 2019-08-26 18:01:12 -04:00
Ben Halpern
cbe599e2eb
Adjust internal page logic and add credits copy to notifications (#3843)
* Adjust internal page logic and add credits copy to notifications

* Adjust badge email copy
2019-08-26 13:41:13 -04:00
Feruz Oripov
4cc517d1c2 Refactoring models/article.rb. (#3835) 2019-08-26 13:32:28 -04:00
Feruz Oripov
c9d91e1552 Refactoring social_previews_controller.rb. (#3818) 2019-08-24 16:24:20 -04:00
John Curcio
c81ff56d13 Fix encoding of special characters in org (#3779) (#3817) 2019-08-24 15:08:31 -04:00
Ben Halpern
3443fdf2bd
Create endpoint for liquid tag embed (#3813) 2019-08-23 17:42:04 -04:00
Mario See
47c2885810 Listings set custom expiry date (#3770)
* add expire_on column to classified_listings

* add expire_on to valid listing params

* add expire_on to model

* add expire date to new listing form

* add field in edit form

* add expiry dates to dashboard

* update expiry date in listing toolkit

* WIP unpublish job and test

test still has to run properly

* add job to class name

* change job to rake task

* revert snap change

* delete migration file

will add new one and revert schema changes to rename column

* reset schema

* add new migration to schema 'expires_at'

* change expire_on to expires_at
2019-08-23 17:33:50 -04:00
Feruz Oripov
352a09e82f Refactoring chat_channels_controller.rb. (#3808)
* Refactoring chat_channels_controller.rb.

* Use %i or %I for an array of symbols
2019-08-23 17:16:35 -04:00