Abraham Williams
|
9cb40e546b
|
Enables Rails cops (#2186)
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
|
2019-03-25 09:25:55 -04:00 |
|
Keshav Biswa
|
8d57d45ecc
|
Rubocop Style cops enabled (#2056)
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
|
2019-03-15 18:33:54 -04:00 |
|
rhymes
|
6553f08d94
|
Rubocop cleanups (#1415)
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
|
2019-01-02 11:20:02 -05:00 |
|
Ben Halpern
|
011e267769
|
Update mentor matching page (#1218)
* Update mentor matching page
* Update mentorship relationship spec
|
2018-11-28 19:02:47 -05:00 |
|
Ben Halpern
|
fcb68b4f29
|
Add automatic random mentee show page after quick match (#931)
|
2018-10-16 13:41:14 -04:00 |
|
Ben Halpern
|
75c4388e53
|
Add mentorship automation (#896)
|
2018-10-12 16:37:32 -04:00 |
|
Jess Lee
|
4451e5eb38
|
Update User Dashboard With Mentorship Admin Features (#440)
* create mentor relationship table and begin dashboard
* add missing files from previous commit
* add mentorship relationship status
* remove uniqueness validation
* add multiple notes
* ban from mentorship deactives all relationships
* add untracked files
* fix logic issue and add specs
* add model specs
* add request specs
* add request specs and fix linting
* fix internal users spec
* remove phantom columns
* remove bizzaro character
* move all attr_accessor to one line
|
2018-09-11 15:59:25 -04:00 |
|