Commit graph

708 commits

Author SHA1 Message Date
Ben Halpern
652ec00f73
Fix typo and remove sustaining membership (#1107) 2018-11-12 19:08:00 -05:00
Ben Halpern
8b1755a2b3
Add organization to feed and adjust page styling (#1089)
* Add organization to feed and adjust page styling

* Add conditional indexing to article agolia

* Early return in algolia org logic

* Make org optional in algolia

* Modify org cta styling
2018-11-12 12:28:51 -05:00
rhymes
72ce2f0e6d Url encode article's title for Twitter sharing (#1092) 2018-11-12 11:58:20 -05:00
Gautam krishna.R
b63380ba74 Disable reaction buttons until fetch completes (#989) 2018-11-12 10:38:01 -05:00
Ben Halpern
b9c7aa8508
Ben/modify home page sidebar (#1088)
* Modify number of posts in home sidebar tags

* Fix copy/paste error of last commit
2018-11-08 17:55:09 -05:00
Ben Halpern
ec00df4ea4
Modify number of posts in home sidebar tags (#1087) 2018-11-08 17:19:18 -05:00
Ben Halpern
1d69b56bc2 Add delay to slackbot ping (#1086) 2018-11-08 14:10:13 -05:00
Ben Halpern
1ae463b708
Adjust look of bottom article actions (#1085) 2018-11-08 11:10:06 -05:00
Ben Halpern
119b86c655
Fix action bar issue and adjust cache_buster (#1082) 2018-11-07 18:55:07 -05:00
Nathan Sebhastian
76f6a8f9df codepen embed add default-tab param (#880)
* codepen embed add default-tab param

* add codepen default-tab documentation in help tab
2018-11-07 13:31:20 -05:00
Jess Lee
94e55558f1 Add slack message for warned user activity (#1077)
* add slack messsages for warned user activity

* make slack messages async

* add spec for warned user article creation

* refactor observers

* add specs

* fix specs

* enable and create observer specs
2018-11-07 13:29:05 -05:00
Gatlee
b865ad9f69 Improve optimistic rendering to article reactions (#681)
* Refactor article reactions for increased readability and to insert optimistic rendering later. No functional changes

* Added optimistic rendering

* Fixed comments to fit with style

* Reverts state on error as well
2018-11-07 12:24:55 -05:00
Jasmeet Singh Saini
908e82cf9e Implement cancel button comment edit (#331) 2018-11-05 13:48:56 -05:00
Meg Gutshall
6b42ff6501 Add readonly attribute to input on link select (#1059) 2018-11-05 11:47:20 -05:00
Jess Lee
295b30ce3e Add Fab Five BadgeRewarder + Rake Task (#1048)
* adds method and rake task

* Improve BadgeRewarder spac
2018-11-05 11:46:08 -05:00
Mac Siri
fb231339e5
Addresses similar blocks of lint (#1054) 2018-11-02 14:14:10 -04:00
Andy Zhao
61011daa61 Fix typo for codesandbox and replit (#1056) 2018-11-02 13:29:50 -04:00
Ben Halpern
3bc1d8cf5b
Ben/add code sandbox (#1053)
* Add codesandbox support

* Fix codesandbox hastiness
2018-11-02 10:31:20 -04:00
Ben Halpern
ad25882ea7
Add codesandbox support (#1052) 2018-11-02 10:28:53 -04:00
Ben Halpern
5043e3fcc5
Add Raygun sponsor (#1050)
* Add Raygun sponsor

* Fixing typo
2018-11-01 16:13:47 -04:00
Ben Halpern
299e6aeb3b
Fix issue where Instantclick navigation fails (#1047) 2018-10-31 16:31:48 -04:00
Andy Zhao
ebd4b50f3f Use Preact for asynchronous rendering for /settings/integrations (#986)
* Set default styles and move button style out of form

* Add MVP of Preact /settings/integrations

* Change background color on hover and focus

* Remove unused constructor

* Improve optimistic rendering

* Add display name

* Use loading indicator for optimistic rendering

* WIP test

* Add basic snapshot tests
2018-10-31 15:51:07 -04:00
Florin Ionce
56ee5835e4 Fix spacing issue for the close button in the podcast bar (#1039) 2018-10-31 11:16:41 -04:00
juniordevlearning
565d63e0ac Fix cognitive complexity lint (#1032) [ci skip] 2018-10-30 14:20:15 -04:00
Andy Zhao
e1fd5b38ba Update reserved words (#1035)
* Update reserved words and add test

* Update user_spec

* Remove unreliable spec
2018-10-30 13:43:49 -04:00
Mario See
b5446e18f3 Add tests for Dev Connect (#988) 2018-10-30 13:42:04 -04:00
Frédéric Planté
4a50c418c6 Automatically add contributor badges (#1016)
* Basic proof of concept

* Use Octokit instead of HTTParty

* add rake task

* DEV Community iOS App should be checked too

* This only need to be computed once

* Add spec

* for consistency sake
2018-10-29 20:21:37 -04:00
Ben Halpern
1aa8e70a5b
Allow removal of collection element (#1036)
* Allow removal of collection element

* Update tests
2018-10-29 15:14:13 -04:00
Ben Halpern
359cc71b64
Add ability for users to publish series (#1034) 2018-10-29 13:04:42 -04:00
Ben Halpern
f4f4af776c
Fix issue where only approved orgs could make CTAs (#1017)
* Fix issue where only approved orgs could make CTAs

* Adjust articles api
2018-10-27 13:03:56 -04:00
Andy Zhao
db9c16db4d 404 comments for unpublished posts (#1013) 2018-10-26 13:37:34 -04:00
Mac Siri
5287d4a03b Create DelayedJob config and misc DX changes (#979)
* Change from #after_save to #after_create

* Update .babelrc

* Update cloud_name for test

* Update SlackBot's RssReader channel

* Update helpful-hints.md

* Create .gitdocs.json

* Remove serve-docs script

* Update docs/helpful-hints.md

* Update approval

* Revert "Change from #after_save to #after_create"

This reverts commit 548ee0d2c0d56a1aa67316468f4106ac9f437662.

* Create delayed_job.rb

* Bump ancestry gem to 3.0.3

* Fix broken spec

* Remove manual Delayed::Job config in test

* Update spec_helper.rb

* Fix broken specs

* Mute SlackBot in test

* Remove weekly-dgiest.yml

* Create PodcastEpisodeDecorator
2018-10-26 13:15:14 -04:00
Frédéric Planté
2b2a7afb03 Correctly handle trying to edit not existing settings tab (#1011) 2018-10-26 13:06:55 -04:00
Ryan Palo
3160473896 Add aria-label to articles page's CTA (#1004)
In the main articles page CTA for signing in via Twitter or Github, previously, screen readers say "Twitter" and "GitHub."  I added an `aria-label` attribute so that screen readers will say "Sign in with Twitter" and "Sign in with GitHub."  Tested on Windows 7, in Chrome, using Chrome Vox extension, and works well!
2018-10-25 16:24:40 -04:00
Ben Halpern
f124c2f65a
Fix html variant image prefix issue + other small fixes (#1005) 2018-10-24 17:44:59 -04:00
lianafelt
61ef3bdd8e Update sponsors.html.erb (#1006)
Remove StickerMule
2018-10-24 17:44:45 -04:00
Ben Halpern
ae3ec2e237
Add/fix org call-to-action box/copy (#1000) 2018-10-24 13:49:57 -04:00
Mac Siri
801043ab0d
Mute Pusher errors (#993) 2018-10-24 11:12:34 -04:00
Ben Halpern
d5ceff4b12
Update/fix org settings (#992)
* Update/fix org settings

* Small adjustment to an unrelated rake task

* Update app/views/users/_org_non_member.html.erb
2018-10-23 17:21:17 -04:00
Ben Halpern
735a96432c
Add usability features to html_variants (#991) 2018-10-23 16:23:48 -04:00
Ben Halpern
90861366df
Add additional config to v2 editor (#980)
* Add additional config to v2 editor

* Fix typo
2018-10-23 12:41:19 -04:00
Ben Halpern
8661fe44d5
Fix sidebar caching issue for articles (#981) 2018-10-22 17:49:59 -04:00
Ben Halpern
302e8f202d
Add HTML variants for cta optimization and other nav bar adjustments (#970)
* Add HTML variants for cta optimization and other nav bar adjustments

* Fix 1==1 non-random mistake

* Spruce up org call-to-action

* Change default text color

* Add html variant trial and success request specs

* Fix article sidebar caching issue

* One line adjustment

* Modify schema

* Add include ActionView::Helpers::TagHelper to user_tag_spec

* Modify follow_button to remove session context

* Dummy commit

* Change Edit Article to Edit Post

* Dummy commit

* Fix rubocop concerns

* Fix rubocop style
2018-10-22 17:03:57 -04:00
Jess Lee
80339dd573 Fix internal article query (#964)
* update abuse report subject template

* fix internal/article top month filters

* update resolution email spec with proper subject line
2018-10-19 16:16:43 -04:00
Nick Karnik
2136b105a3 Implement ability to style text in comments using hotkeys (#959)
* Resolves #891
    * This is applied to root level comments as well as nested replies.
    * We are handling latest browsers and special cases for FF, IE8/9/10
    * All newer browser except FF support undo/redo functionality in the exact reverse order of text insertion
    * Refactored some code
    * Support for Bold & Italic text
    * Support for Text Links
    * In a subsequent change, we can consider adding hotkey for image URL
        * Didn't add this feature at the moment since there's no universally accepted key-combination for image URL's that I know of
    * IE 8-11 is not supported because it is a bit convoluted and I don't have a way to test it reliably
        * We can revisit this if it is really needed and find a jQuery plugin to handle it
2018-10-19 15:39:22 -04:00
rhymes
7fe6777c75 Support links with trailing slash for link tag (#950)
The previous implementation of the link tag didn't support links with a trailing slash. It was also based on an internal and undocumentented function in Rails.

https://github.com/rails/rails/issues/28331#issuecomment-285440151
2018-10-19 15:25:58 -04:00
Nihad Abbasov
4995a4af21 Performance: replace ruby methods with their faster alternatives (#949)
- Array#select.first is slower than Array#detect.

  - Array#shuffle.first is slower than Array#sample.
2018-10-19 13:21:18 -04:00
Jérôme Pott
04968214ce Fix typo (#958)
Add missing verb "controls"
Capitalize first letter "English"
2018-10-19 13:13:18 -04:00
Mac Siri
c35544a154 Replace sprocket-es6 with new uglifier feature (#928) 2018-10-19 13:12:07 -04:00
Thomas Bnt
16dc2fb903 Adding Font Awesome (#953)
* Adding Font Awesome

* Update copy
2018-10-18 17:25:37 -04:00