Mac Siri
842e6880b8
Routine rubocop fix on /spec ( #19217 )
...
* Softrun rubocop
* Hardrun rubocop (-A)
* Change a rubocop rule
* Add missing cops
* Undo & redo rubocop -A
2023-03-21 09:55:26 -04:00
Josh Puetz
629c7114da
Login with Google ( #15986 )
2022-01-13 10:25:52 -06:00
Fernando Valverde
c384755bae
Enable Forem (Passport) Auth ( #15141 )
...
* Enable Forem (Passport) Auth
* Remove feature flag DUS
* Add prompt for Forem Passport in admin
* Add spec & fix broken one
* Link to docs instead of passport site
2021-11-23 14:59:00 -06:00
Suzanne Aitchison
5069cd681a
Markdown editor toolbar ( #14876 )
...
* rough starting point, roving tabindex in toolbar, bold and italic buttons
* refactor, add link
* add ul
* add ordered list
* core formatters in place, wip
* overflow options
* add keyboard shortcuts
* tidy up some dodgy classes
* add mocks for runtime in test and storybook, use correct modifier key for tooltip
* style tweaks
* refactor tooltips
* add markdown formatters tests
* add tests for toolbar component, fix mistake in overflow menu tooltips
* undo change no longer needed to button
* fix issue accessing runtime in formatters file
* only show darkened buttons and tooltips when focus-visible is true
* mobile view
* fix for responsive buttons & roving tabindex
* tweaks from PR review
* update cursor position on link insertion
* add a new line after block selection formatting
* align icons in center
* tidy up overflow menu listeners
* small refactors
* test for new text area util
* tidy up new lines after syntaxes
* fix logic in cursor offsets for links
* prevent scroll jumps after inserting syntax
* some style tweaks
* insert level 2 heading with new lines above and below
* update icons
* use margin instead of gap
2021-10-19 09:22:54 +01:00
Fernando Valverde
16ddcb74dc
Avoid showing social login options in ForemWebView ( #14260 )
...
* Minimal diff commit
* Add helper specs for display_social_login?
* Fixing some specs
* Fixing specs
* Add system specs for flow A vs flow B
* Add aria-live polite
* revert unnecessary change to spec
* Update spec/system/authentication/conditional_registration_spec.rb
Co-authored-by: rhymes <github@rhymes.dev>
* Tweaks to fix specs
* Apply review feedback
* Apply suggestions from code review
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Extract helper function + refactor Regexp from display_social_login?
* Small tweak to condition
Co-authored-by: rhymes <github@rhymes.dev>
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-07-21 09:59:12 -06:00
Michael Kohl
7fe5c54161
Consistently use ForemInstance.private? ( #14021 )
2021-06-22 08:16:19 +07:00
Michael Kohl
5406b0576e
Split Settings::Authentication from SiteConfig ( #13095 )
...
* Split Settings::Authentication from SiteConfig
* Move specs
* Sort fields
* Update settings usages
* Update recaptcha usages
* Add data update script
* Update spec
* Rename SiteConfigParams concern
* Fixes, new route, new controller
* Controller and service refactoring
* More controller and service updates
* Spec updates
* More spec fixes
* Move file
* Fix FeedbackMessagesController
* Update admin/configs_spec
* Fix remaining specs in admin/configs_spec
* Fix configs API
* Formatting
* Clean up old service object
* Various fixes
* Update DUS
* Add model argument to admin_config_label
* Fix key name
* Fix specs
* Add distinct request caches for settings classes
* Fix e2e tests
* Fix remaining system spec
* Make DUS idempotent
* Move routes block
* Cleanup
* Switch to ActiveSupport::CurrentAttributes
* Pinned rails-settings-cached
* Update e2e test
* Update lib/data_update_scripts/20210316091354_move_authentication_settings.rb
Co-authored-by: rhymes <rhymes@hey.com>
* Add guard to DUS
* Temporarily re-add two SiteConfig fields
* Fix config show view
Co-authored-by: rhymes <rhymes@hey.com>
2021-04-12 09:41:09 +02:00
Vaidehi Joshi
7e583be9ed
[15 Minute Fix]: Update email footer copy to account for email authentication ( #12877 )
...
* Update email footer copy to account for email authentication
Fixes https://github.com/forem/forem/issues/12546 .
2021-03-03 08:36:40 -08:00
Fernando Valverde
88bd3a1069
Replace authentication_enabled_providers.include? with helper method ( #12379 )
...
* Replaces authentication_enabled_providers.include? with helper authentication_provider_enabled?
* Fix typo
2021-01-22 07:54:10 -06:00
Arit Amana
3a984c8ee7
[2020 EOY Issue] Modal alert when enabling Auth Provider without keys ( #12135 )
...
* Start hooking things up
* further generalize adminModal, hook up relevant code
* Complete implementation
* remove comments
* Address QA suggestions
* Address QA suggestions
* Use object parameter for adminModal
* starting the admin cypress tests
* Code review suggestions
* remove incomplete test
* rename data attributes to make more sense
* complete the work
* use destructuring
* edit warning modal text
2021-01-13 13:54:39 -05:00
Arit Amana
42e10e7b42
[EOY2020 Issue] Default new forems to Email Authentication only ( #11696 )
...
* Set default Auth Providers to empty array
* complete implementation; tests remain
* tests
* fix failing specs authenticator_spec.rb
* Fix failing specs
* fix more failing specs
* fix more failing specs 2
* update failing spec
* Update app/views/admin/configs/_auth_provider_settings.html.erb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/assets/stylesheets/admin.scss
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-12-02 16:49:07 -05:00
Fernando Valverde
494af84e83
Refactor reCaptcha code and bypass in report abuse for trustworthy users only ( #10502 )
...
* Bypass recaptcha for authenticated users abuse reports
* Moves bypass_recaptcha? to helper method to have one definition of the criteria for this
* User must be 1 month old at least in order to bypass_recaptcha?
* Fixes test
* Better spec message
* Bypasses auditable users
* Adds better test coverage over recaptcha bypass cases
* include Helper removed from FeedbackMessagesController
* Adds some inline comments for clarity and banned check
2020-12-02 08:55:47 -06:00
Josh Puetz
2223e5468b
Email login always on ( #11307 )
...
* Starting out
* Building away...
* Hooking buttons up
* Hook Auth Provider buttons to Array Field
* trying to fix NoNameError
* Remains InviteOnlyMode disable and tests
* Smashing remaining tasks
* Last of tasks
* add tests
* Complete specs and tests 😅
* Fix bug
* Additional guard
* pass event to functions
* Position Email Auth first
* Fix bug in Email Auth Modal
* Fix spacing issue
* Update docs for adminModal.js
* Show/hide Enabled Indicator with Enable/Undo buttons
* Complete Auth Providers functionality
* Only update `allow_email_password_registration` from admin
* Remove duplicated methods
* Some refactoring around fact that Email Login is now always on (#11382 )
* Fix merge (again!)
Co-authored-by: Arit Amana <msarit@gmail.com>
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
2020-11-12 09:32:58 -06:00
Arit Amana
08796b5cee
[Team Email Login] Refactor Authentication Provider Enable/Disable ( #11185 )
...
* Starting out
* Building away...
* Hooking buttons up
* Hook Auth Provider buttons to Array Field
* trying to fix NoNameError
* Remains InviteOnlyMode disable and tests
* Smashing remaining tasks
* Last of tasks
* add tests
* Complete specs and tests 😅
* Fix bug
* Additional guard
* pass event to functions
* Position Email Auth first
* Fix bug in Email Auth Modal
* Fix spacing issue
* Update docs for adminModal.js
* Show/hide Enabled Indicator with Enable/Undo buttons
* Complete Auth Providers functionality
* Update app/javascript/admin/controllers/config_controller.js
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/javascript/admin/controllers/config_controller.js
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/controllers/admin/configs_controller.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update helper names
* better implementation of EnabledIndicator show/hide
* Small copy changes
* Update spec/helpers/authentication_helper_spec.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/views/admin/configs/show.html.erb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/helpers/authentication_helper.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-11-06 18:19:34 -05:00
Arit Amana
8e57cf17ad
[Team Email Login] Admin enable/disable recaptcha during email signup ( #10846 )
...
* Initial Implementation
* Complete hookup of recaptcha guard
* Write tests for recaptcha during email signup
* Addressing PR changes 1
* Create helper method and write specs
* fix bug
2020-10-19 16:20:18 -04:00
rhymes
eddcb4953e
Display all authentication providers in mailer footer ( #9961 )
...
* Display all authentication providers in mailer footer
* Refactor into Authentication::Providers.enabled_for_user
2020-08-24 21:02:05 +02:00
