Commit graph

424 commits

Author SHA1 Message Date
Ben Halpern
57d1bc48d5
Fix navigation issue in connect and allow leaving channels (#635)
* Fix navigation issue in connect and allow leaving channels

* Fix chat channel memberships request spec
2018-07-30 18:40:30 -04:00
Ben Halpern
a3788dfbd1
Fix TwitterBot arguments (#634)
* Fix TwitterBot arguments

* Fix ::random_identity
2018-07-30 10:51:10 -07:00
Ben Halpern
1181a952ed
Fix small caching issues and adjust serviceworker logic (#632)
* Fix small caching issues and adjust serviceworker logic

* Assign state to follow buttons to avoid refetch

* Modify serviceworker push issue

* Change asset_path to javascript_pack_path in serviceworker

* Change javascript_pack_path to javascript_path in serviceworker

* Remove javascript_path for now
2018-07-30 10:43:29 -07:00
Andy Zhao
6c937df21c Filter out user input name (#633) 2018-07-30 07:55:45 -07:00
Ben Halpern
1c3331d77f Add proper body_markdown back in 2018-07-27 21:02:14 -07:00
Mac Siri
0f3342bcec [WIP] Implement non front-matter editor (#415)
* Create alternate editor

* Install linkstate (?)

Not sure how it disappear in the first place

* Run yarn install

* Modulize ArticleForm component

* Refactor

* Isolating css WIP

* Implement simplified frontmatter-less editor

* Modulize individual form element

* Ajust props names

* Transform json params to snakecase

* Remove codes

* Update /new, almost there for release

* Fix editor resize issues

* Change defaultvalue to value in article form tag element

* Modify html buttons in article form
2018-07-27 20:12:33 -07:00
Mac Siri
9e19593559 Change mods-actions' display logic (#630)
* Add username to deploy-track

* Change mod-actions' show logic

* Remove comment
2018-07-27 11:55:14 -07:00
Ben Halpern
749d61a5c1
Remove fetch polyfill and other misc small fixes (#629)
* Remove fetch polyfill and other misc small fixes

* Remove fetch polyfill and other misc small fixes
2018-07-27 10:13:38 -07:00
Mac Siri
ce965bcedf Reduce Airbrake's error output (#628)
* Remove chmod for after_deploy

* Fix lint

* Ignore Pundit::NotAuthorizedError

* Update Travis config

* Turn off Travis' pr notification

* Add CommonsChunkPlugin to Webpacker
2018-07-27 09:04:52 -07:00
Arun Kumar
a4de2fd0b1 Open social links inside comment in a new tab (#616) 2018-07-26 09:27:49 -07:00
Mac Siri
379829719f Misc DX improvement (#621)
* Add updated rack env keys

* Tone-down rack-timeout config

* Avoid cl_image_path in development

* Update README & create env var template

* Update Travis notification config

* Expand Seed file

* Manually-set Rack-timeout config vars

* Fix lint

* Fix Typo(?)

* Add ChatChannel to Seed

* Disable fbq when not in production

* Tweak after_deploy script

* Fix condition

* Change fbq clause
2018-07-25 22:08:17 -07:00
Nick Taylor
9a387660a9 Fixed bug where + in querystring didn't decode to a space. (#623) 2018-07-25 11:06:00 -07:00
Arun Kumar
876c70d2bb Minimize creation of CacheBuster objects (#599) 2018-07-24 10:30:30 -07:00
Ben Halpern
cd17261963 Fix small css issue on /live 2018-07-23 12:37:11 -07:00
Arun Kumar
478dcabdf1 Refactor GithubRepo model (#583) 2018-07-23 15:23:53 -04:00
Arun Kumar
52486a4edd Update instance methods to module methods (#613) 2018-07-23 12:13:42 -07:00
Arun Kumar
0a0e9fd294 Refactor (#596) 2018-07-23 11:49:27 -04:00
Ben Halpern
fd9653079d Merge branch 'master' of github.com:thepracticaldev/dev.to_core 2018-07-21 19:05:31 -04:00
Ben Halpern
faf36b7053 Fix non-published index policy logic 2018-07-21 19:05:24 -04:00
Ben Halpern
0327585b03
Add nofollow metatag to untrusted pages (#611) 2018-07-21 13:15:38 -04:00
Ben Halpern
7edb371cba
Remove ENV var for algolia and make global var (#609)
* Remove ENV var for algolia and make global var

* Add :: and give test value to ALGOLIASEARCH_PUBLIC_SEARCH_ONLY_KEY
2018-07-21 12:09:14 -04:00
Ben Halpern
83afef4c74
Adjust noindex logic (#608)
* Add Google noindex to possible spam articles

* Add further noindex conditions

* Adjust noindex logic
2018-07-21 11:32:41 -04:00
Ben Halpern
76b9313e3a
Add Google noindex to possible spam articles (#607)
* Add Google noindex to possible spam articles

* Add further noindex conditions
2018-07-21 11:16:57 -04:00
Mac Siri
40f488d991 Migrate to Travis CI (part 2) (#591)
* Update Travis.yml

* Update README

* Update README

* Adjust test to not rely on env vars

* Update encryption

* Refactor

* Update env key

* Stub AWS calls

* Create ApplicationConfig

* Fix specs

* Fix lint

* Update ApplicationConfig

* Remove travis env vars

* Fix lint

* Extend character limit to 100

* Add env to travis

* Take out auto-restart after deploy

* Immediately discarded test cache

* Stub GA in request specs

* Stub Pusher

* Fix broken specs

* Update fixture

* Add CodeClimate id

* Change CodeClimate key

* Remove merge mistakes

* WIP

* Add Envied gem & Change README

* Add missing keys

* Add missing key

* Update fixture

* Fix broken spec

* Add Slack Notification for Travis

* Fix wording

* Fix typo
2018-07-20 20:17:18 -04:00
Nick Taylor
18980034d3 Nick/feature/search to preact (#532)
* Works, but lots of cleanup/questions.

* Fixed comment.

* Only want the search script to load once with InstantClick active.

* Removed unnecessary DOMContentLoaded from copy paste.

* 🔧 Enabled (P)React Devtools.

* Updated comment about reactToEvent.

* Removed unnecessary server-side generated JS for search.

* <Search /> component now has component state.

* Search functions are in there own module now.

* 👷Refactor

* Render propped it up.

* Fixed issue with encoding of search term.

* Removed data-no-instant attr from script.

* 👷Refactor

* Now flash of search loading is avoided..

* Moved search under components folder.

* Tests

* fixedEncodeURIComponent does not need to be exported.

* Tests

* Folders to ignore from the VS Code Local History extension.

* Tests

* Snapshot test for <Search /> component.

* Tests

* Now the <SearchContainer /> handles the '/' key shortcut.

* Made the search box ID a prop defaulting to 'nav-search'

* Excluded barrel files from code coverage.

* Componentized search CSS.

* Storybook stories for <Search /> component.

* Removed extension folders to ignore.

* Fixed logic for "/" key triggering search.

* updated jest snapshot for <Search /> component.

* updated package.json lock file.

* Disabled the import/prefer-default-export rule.

* Now search term clears if not on a non-search results page.

* removed comment that is no longer valid.

* No longer using render prop for Search. Doesn't make sense as it's not stuff that is reused.

* Added preact-render-spy do dev deps.
2018-07-19 17:02:48 -04:00
Ben Halpern
b2b1068715
Add minimum name length for users (#594) 2018-07-19 15:36:29 -04:00
Ben Halpern
6f9248c97e Fix comment 2018-07-19 12:43:56 -04:00
Ben Halpern
e4bb8d7823
Modify timeout and make some queries more efficient (#593)
* Modify timeout and make some queries more efficient

* Only query podcasts if user signed in

* Remove unnecessary columns selected in boosted query etc.
2018-07-19 11:55:59 -04:00
Arun Kumar
e407e1ff91 Minor guard clause refactor (#576) 2018-07-16 15:39:24 -04:00
Ben Halpern
e2dbd7cfcc
Remove beta label on /connect and other small changes (#589)
* Remove beta label on /connect and other small changes

* Add better placeholder for narrow screens

* Adjust comma/bracket placement

* Add description to chat channels
2018-07-16 14:48:38 -04:00
Arun Kumar
9b753a4e9c Refactor channel permission method (#584) 2018-07-16 10:55:18 -04:00
Arun Kumar
e950028f1d Extract compound conditional to a method (#579) 2018-07-15 18:02:27 -04:00
Arun Kumar
35eddd5131 Replace if..else with hash lookup (#578) 2018-07-14 17:42:56 -04:00
Ben Halpern
1b68c284b0
Add cloudinary prefix to articles/show (#586) 2018-07-13 20:40:47 -04:00
Ben Halpern
5a2c549927
Add reactions to /connect content (#585) 2018-07-13 20:05:47 -04:00
Jess Lee
d407d9bc52 Allow members to add other social links to profile (#555)
* add social icons to profile

* fix spacing

* add validations

* update user spec

* check for user in profile settings

* fix regex validation

* refactor regex to multiple lines
2018-07-13 19:51:56 -04:00
Ben Halpern
e995e081ad
Add rich links to /connect and remove auto sidecar opening (#582) 2018-07-13 16:56:26 -04:00
Arun Kumar
b7a52b425b Fix typos (#580) --skip-ci 2018-07-13 12:48:47 -04:00
Mac Siri
14551ea827 Indicate /live issue with Safari (#571)
* Update copy

* Update Rails and Ruby versions
2018-07-12 13:19:13 -04:00
Arun Kumar
2400908b9d Refactor render_rewarding_context_message_html method with a guard (#569)
clause
2018-07-12 10:58:37 -04:00
Yechiel Kalmenson
37e0059ade open markdown links in new tab (take 2) (#512)
* open links in chats in new tabs

* fixed target_blank vulnerability

* add test to make sur links are being generated with target _blank

* add test for target blank vulnerability

* add rel and target to the whitelisted attributes

* add the link attributes to HTMLRouge#link
2018-07-11 15:04:03 -04:00
Mac Siri
889f813991 Create ReservedWords class (#562) 2018-07-11 11:53:04 -04:00
Edem Attikese
6e3b64f060 Apply bundler-audit fix & Update gems (#472)
* added bundler workaround so git repos are accessed via https

* Use forked version of fix-db-schema-conflicts gem

* Update #update_stripe_plan_for_subscription

* Update stripe version

This was actually already done but not reflexed in the Gemfile

* Pessimize Gemfile

* Fix lint

* Fix lint
2018-07-11 11:01:47 -04:00
Andy Zhao
aab350f02b Return false to maybe prevent early form submit (#531) 2018-07-10 15:37:07 -04:00
Andy Zhao
41d028cc5a Use non-prettiered JS file instead (#563) 2018-07-10 14:54:31 -04:00
Andy Zhao
e7466fc436 [Done] Add Reaction Policy Spec (#547)
* Delete old files and combine into one spec

* Write new reaction request spec

* Use a single route for logged in/out reaction count

* Refactor a bit

* Remove unused file

* Add reaction policy and spec

* Fix eslint issue

* Remove dead route
2018-07-10 14:12:04 -04:00
Andy Zhao
6dfcf2e856 Fix adding quotes and dashes in codeblocks (#557)
* Fix adding quotes and dashes in codeblocks

* Use find_by for all remove_from_feed methods (#558)

* Destroy memberships when chat channel is destroyed
2018-07-10 13:41:54 -04:00
Jess Lee
2a38f14fb7 add copy and pasted language (#546) 2018-07-10 10:51:57 -04:00
Andy Zhao
9fa9a22d54 Add a comment for more public controllers (#553) 2018-07-09 18:14:34 -04:00
Andy Zhao
3bbfa03114 Fix bad query when deleting users (#556) 2018-07-09 17:46:08 -04:00