Feruz Oripov
c9b40326ac
Refactoring chat_channels_controller.rb. Adding set_channel private ( #3787 )
...
method for not repeating query code.
2019-08-21 19:08:16 -04:00
Anna Buianova
0ecb937875
Added rubocop-rails ( #3059 )
...
* Added rubocop-rails
* Update rubocop version in the CodeClimate config
2019-06-06 09:47:57 -04:00
Mario See
19b46a86e2
Add messaging option in listings ( #2854 )
...
* add prop for message modal method
* clean up comments from open inbox method
* add inbox type to listing model author
* add sample methods for opening message modal in listings and listing modal
* only show for users with open inbox and hide for self
* use contact_via_connect instead of inbox_type
* fix edit listing to include contact via connect attribute
* wip send message method
* adjust message styling
* change id name
* update destination
* remove unused methods
2019-05-31 13:48:45 -04:00
Ben Halpern
70580d0265
[WIP] Connect misc improvements/debugs ( #2880 )
...
* WIP Connect misc improvements/debugs
* Modify tests and update snapshots
* Change GitHub sidecar copy
2019-05-20 10:08:51 -04:00
Andy Zhao
8ef611f879
Remove Honeycomb from the app ( #2366 )
...
* Remove Honeycomb related gems
* Remove Honeycomb related code from controllers
* Remove Honeycomb from RSS Reader
* Remove Honeycomb related files
* Remove Honeycomb related tests
* Remove leftover Honeycomb methods
2019-04-11 10:49:35 -04:00
cyrillefr
4fd66372dc
Enable Layout/AlignParameters ( #2340 )
...
Check if the parameters on a multi-line method call or definition are aligned.
Resolves : #2021
2019-04-08 18:47:34 -04:00
Ben Halpern
d1e73dceba
Clean up new chat channel functionality and add tests ( #2220 )
2019-03-26 13:35:32 -04:00
Mario See
91968e3860
block/report abuse in dev-connect ( #2074 )
...
* block chat method
* block and report buttons
* styling
* more styling
* add id redirect
* remove whitespace
* authorize channel in block_chat method
* remove trailing whitespace
* make variable local
* validate using policy
* check channel direct
* fix comparison in chat_channel model
* fix channel variable
2019-03-26 11:53:30 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
cyrillefr
a2fcbdc4a4
Enable performance rubocop cops ( #2140 )
2019-03-21 16:01:45 -04:00
Mario See
d8709c0334
Implement open inbox for dev-connect ( #1563 )
2019-03-15 14:39:57 -04:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Christine Yen
cff6b5d589
Add Honeycomb gem and initial instrumentation ( #695 )
...
* Add basic Honeycomb initializers
* Add some basic instrumentation, capture basic IDs
* Correctly alphabetize Gemfile, embed env in dataset names
* Actually reorder Gemfile because I can read
* Add custom tracing instrumentation to RssReader
* Improve timing/tracing info in RssReader
* Even make sure Errors show up in trace if possible
* Make sure we capture this as Rails traffic
* Swap in dev/test Libhoney::Clients as appropriate
* Move context-snagging bits into lib/instrumentation.rb
* Merging Gemfile lines seems to be my Achilles heel
2018-11-28 10:08:27 -05:00
Kohei Sugi
91c3eef1e1
Fix Layout/EndAlignment lint ( #349 ) [skip ci]
2018-08-15 15:49:38 -04:00
Kohei Sugi
36d2dfd122
Apply rubocop some rule ( #295 )
...
* Fix FactoryBot/StaticAttributeDefinedDynamically and Metrics/LineLength
* Fix RSpec/NotToNot: Prefer not_to over to_not
* Fix RSpec/NotToNot: Prefer not_to over to_not and Metrics/LineLength
* Fix Layout/MultilineMethodCallIndentation and Metrics/LineLength
* Fix Naming/PredicateName
* Fix Style/ConditionalAssignment
* Avoid code climate error
2018-08-13 16:32:11 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Ben Halpern
05789f6ef6
Add client-side /connect maxlength and add badge setting on model only ( #660 )
2018-08-06 10:45:01 -04:00
Mac Siri
40f488d991
Migrate to Travis CI (part 2) ( #591 )
...
* Update Travis.yml
* Update README
* Update README
* Adjust test to not rely on env vars
* Update encryption
* Refactor
* Update env key
* Stub AWS calls
* Create ApplicationConfig
* Fix specs
* Fix lint
* Update ApplicationConfig
* Remove travis env vars
* Fix lint
* Extend character limit to 100
* Add env to travis
* Take out auto-restart after deploy
* Immediately discarded test cache
* Stub GA in request specs
* Stub Pusher
* Fix broken specs
* Update fixture
* Add CodeClimate id
* Change CodeClimate key
* Remove merge mistakes
* WIP
* Add Envied gem & Change README
* Add missing keys
* Add missing key
* Update fixture
* Fix broken spec
* Add Slack Notification for Travis
* Fix wording
* Fix typo
2018-07-20 20:17:18 -04:00
Ben Halpern
926991f5fc
Fix timezone issues and small adjustment to connect features ( #548 )
2018-07-05 16:39:04 -04:00
Ben Halpern
424be43865
Add chat_channel_membership roles and invite functionality ( #541 )
2018-07-03 13:16:48 -04:00
Ben Halpern
94e5154668
Add initial invitation framework for chat channels ( #528 )
...
* Add initial invitation framework for chat channels
* Update chat_channel specs
* Add DIY concept of accepting invite
* Add some js and fix spec
* Add full invite accept functionality
* Remove console.log from chat
2018-07-02 16:31:20 -04:00
Ben Halpern
5a59b4c8a9
Fix missing Cloudinary tags and misc specs ( #486 )
2018-06-22 16:29:17 -04:00
Ben Halpern
8b53f68574
Add chat channel policy and spec ( #474 )
2018-06-21 16:58:21 -04:00
Ben Halpern
914102f19f
Add basic github support to /connect
2018-06-19 13:46:10 -04:00
Ben Halpern
74d098f580
Fix bugs and add video
2018-06-18 12:53:43 -04:00
Ben Halpern
ad733aa9fe
Add top bar Connect icon 😱 ( #443 )
2018-06-14 13:50:55 -04:00
Ben Halpern
dc7f8f03b1
Fix connect issue ( #425 )
...
* Add status to chat_channels
* Add allowance for updating existing chat_channel
* Fix index issue
2018-06-12 18:47:04 -04:00
Ben Halpern
87c6a758bb
Add top bar indicator and other Connect features ( #424 )
...
* Add algolia public search key
* Add status to chat_channels
2018-06-12 18:24:57 -04:00
Ben Halpern
cfb0bff881
Fix /live and codemirror stuff ( #417 )
2018-06-11 14:56:52 -04:00
Ben Halpern
fb20b8adf7
Add content sidecar for chat ( #413 )
...
* Rearchitect chat channel subscriptions
* Add browser push notifications (attempt)
* Add content sidecar for chat
* Add live code basics
* Add content features to chat
* Fix chat_channels test
2018-06-11 11:00:51 -04:00
Ben Halpern
7bc3e60283
Add browser push notifications (attempt) ( #412 )
2018-06-09 17:33:58 -04:00
Ben Halpern
bf56ad5cb4
Add message HTML and other goodies ( #411 )
2018-06-08 23:15:21 -04:00
Ben Halpern
1a85bddd2c
Make pusher channels private ( #410 )
2018-06-08 18:49:59 -04:00
Ben Halpern
645de032df
Rearchitect chat channel subscriptions ( #409 )
...
* Update chat and add precompilation paths
* Update chat and add precompilation paths
* Adjust assets.rb
* Remove inconsistent test
* Fix check for pathname in chat
* Rearchitect chat channel subscriptions
2018-06-08 18:38:53 -04:00
Ben Halpern
9729bc8d0d
Handle open for open channels
2018-06-07 16:55:15 -04:00
Ben Halpern
ab85216621
Update chat and modify article score calc indexing ( #395 )
2018-06-06 16:08:12 -04:00
Ben Halpern
10c3b52b0a
Add chat channel indicator ( #379 )
...
* Add new message indicator to chat
* Add indicator switch to chat
* Add chat switch indicator
2018-06-01 18:16:10 -04:00
Mac Siri
b4292ade33
Implement chatroom ( #308 )
...
* Fix multiple chat loading bug
* Open profile links in chat via new tab
* Add unmount handling for chat
* Add overscroll property to chat
* Add channel_name to ChatChannel model
* Create route and page for chatroom WIP
* Expose ChatChannel id to live page
* Implement multichannel support WIP
* Implement chatroom page WIP
* Add css for chatroom
* Update chat's moderation
* Refactor chat's message type
* Swap the use of :message_markdown & :message_html
* Add channel permissions WIP
* Fix failing specs
* Adjust json reponses
* Add empty message prevention
* Update participant error message
* Change Workshop channel to General
2018-05-14 12:50:32 -04:00
Mac Siri
0f35939906
Update chat app's features ( #204 )
...
* Update chat.scss --skip-ci
* Fix height issue
* Add highlighting
* Implement bannged user handling for chat
* Add scroll obsever
* Limit initial messages load count & max messages
* Add new message alert when scrolled
* Add link to usernames in chat
* Implement channel clearing feature
* Update parserOptions
* Implement banning feature for chat app WIP
* Add policy for ChatChannelsController
* Fix arugment error
* Update user_not_authorized to handle JSON request
* Update specs for updated user_not_authorized
* Update font-weight for windows os
2018-04-16 13:20:12 -07:00
Mac Siri
8003191a4e
Create Chat app ( #175 )
...
* Setup Pusher gem
* Create ChatChannel and Message model
* Create ChatChannelController
* Add back fix-db-schema-conflicts gem
* Add pusher-js package
* Add validations on Message & ChatChannel models
* Update Route
* Create MessageController
* Update ChatChannelController
* Create Chat app WIP
* Extract messenger render to Message Component
* Implement live chat WIP
* Implement live chat WIP (2)
* Add style and scrollToBottom feature for chat
* Create getUserDataAndCsrfToken function
* Add feature toggle to the new live chat
* Clean up ChatChannelsController & create spec
* Update ChatChannel spec
* Update Message spec
* Create MessagesController spec & refactor
* Clean up Chat app
* Fix lint
* Add character limit to Message
2018-04-04 14:19:57 -07:00
