Thai Pangsakulyanont
|
5d97ca86c5
|
Improve docker setup script (#7378)
* Add set -e to docker-setup script
* Add error handling for db setup stage
* Sometimes Elasticsearch takes time to boot up
* Also delete docker_data
* search:setup must come first
* Revert "Sometimes Elasticsearch takes time to boot up"
This reverts commit e975f6e5c3edad084d4f2c4d8718675bf5c8d07c.
Reason for revert:
Instead of using wait-on, we can use Docker’s health check instead
See review comment:
https://github.com/thepracticaldev/dev.to/pull/7378#discussion_r411839255
* Use wait-on without installing into package.json
* Add /usr/src/app/node_modules to volumes
Otherwise, webpacker will not run in docker-compose.
See: https://stackoverflow.com/questions/30043872/docker-compose-node-modules-not-present-in-a-volume-after-npm-install-succeeds
|
2020-04-24 18:45:27 -04:00 |
|
