Molly Struve
39033e33d9
Flaky Spec Fix: Ensure submit requests finish before checking status of user ( #5265 )
2019-12-27 14:47:08 -05:00
rhymes
d61f8a36a6
Remove Chrome version from Travis.yml ( #4555 ) [ci skip]
2019-10-23 09:15:23 -04:00
Tudor Pavel
d54442f17e
Bump Chrome Driver version to fix Travis CI builds ( #4554 ) [ci skip]
2019-10-23 08:20:31 -04:00
Mac Siri
5f85250220
Update to Chromedriver 76 ( #3587 ) [ci skip]
2019-07-30 17:58:21 -04:00
dependabot-preview[bot]
ebefca6a8a
Bump capybara from 3.26.0 to 3.27.0 ( #3556 )
2019-07-30 16:47:08 -04:00
Ben Halpern
df44cbd254
Change design of main feed CTA and remove from tag pages ( #3050 )
...
* Change design of main feed CTA and remove from tag pages (to prevent complexity)
* Lock Chromedriver to 74.0.3729.6
* Fix tests and modify reserved words (tack on)
* Removed less useful shared examples from rspec
* Remove references to file that no longer exists in test
* Remove unneeded tests
2019-06-05 14:33:22 -04:00
Mac Siri
6d1638ed68
Unskip all skipped specs ( #2941 )
...
* Change all login_as to sign_in
* Unskip comment spec
* Create new specs
* Turn on Webdriver caching
* Set logger for Omniauth in test
* Update editor system spec
* Fix editor approval file
* Update video_controller
* Update TagAdjustmentUpdateService's spec
* Update users api spec
* Update stories_index_spec
* Remove redundant spec file
* Remove residual code
* Change ClassifiedListing spec
* Update NotificationsIndex spec
2019-05-25 11:04:38 -04:00
rhymes
8e6ca966ed
Switch from chromedriver-helper to webdrivers ( #2465 ) [ci skip]
2019-04-16 13:46:23 -04:00
cyrillefr
4fd66372dc
Enable Layout/AlignParameters ( #2340 )
...
Check if the parameters on a multi-line method call or definition are aligned.
Resolves : #2021
2019-04-08 18:47:34 -04:00
Mac Siri
fc39f24ee3
Migrate feature test to system test ( #2301 )
...
* Move all features to system
* Remove database_cleaner & apply use_transactional_fixtures
* Move rspec-retry to :test
* Update Capybara config
* Update rails_helper
* Fix user_visits_a_comments_page_spec.rb
* Fix lint
2019-04-04 12:15:10 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Mac Siri
32d15f2820
Update test suite configuration ( #702 )
...
* Update DatabaseCleaner
* Only retry in CI
* Update rubocop precommit hook
* Update spec
* Restructure spec configs WIP
* Restructure spec configs WIP
* Create OmniauthMacros
* Fix broken spec
* Update spec
2018-09-24 14:40:22 -04:00
