This commit solves two problems:
1. Redis cache usage is tracked under `redis-rpush` because they use the
same Redis URL and `redis-rpush` overrides `redis`.
2. Sidekiq jobs can enqueue an unbounded number of other Sidekiq jobs.
The instrumentation cost alone of enqueuing hundreds of thousands of
other Sidekiq jobs can be prohibitive, similar to DEBUG-level
logging. This commit wraps it in a conditional so it must be enabled
explicitly and can be turned on and off at will without a code
change.
* Fix autoloading for RateLimitChecker
* Fix autoloading for ForemStatsClient
* Fix autoloading for middlewares
* Move things to their proper place
* Move middleware usage to the proper place
* Re-add rest-client in datadog driver correctly
* Already required in config/initializers/middlewares.rb
* Bring that back
* Fix Honeybadger spec
* Load HTTPClient before Datadog
The instrumentation needs it to be loaded before it can patch the
request methods.
* Don't split HTTPClient traces on domains yet
After the service explosion in Datadog APM last time, let's take a more
cautious approach.
* Turns out, we aren't even using the aws-sdk gems
This was added because we use Fog's AWS adapter, but Fog uses Excon
(which we're already instrumenting) instead of the AWS SDK directly.
Splitting by domain caused an explosion in "services" tracked in Datadog
because it was counting each podcast platform and each blog as being
another service. Noramlly this would be what we want, but that's a lot
to ask for such a broad range of user-supplied domains.
Since each of these requests is made via HTTParty, which uses Net::HTTP
by default, this commit stops splitting in that library.
We'll need to come up with a better way of tracking this.
* This change abstracts the DatadogStatsClient into a ForemStatsClient.
The purpose of this abstraction is to set the foundation for a subsequent PR that will allow one to use New Relic for recording Forem stats, instead of Datadog, if there is a New Relic configuration found.
This specific change creates an abstraction layer that can be built upon, without changing any actual default behavior. All specs still pass.
* Use delegate instead of explicit methods.
* Delegate instead of explicit methods.
* Fix the error.
* Refactor according to the suggestions in the comments.
* Ooops. Stats work better when all of the code is committed.
* Removing the alias of count to increment since that was done in error.
