Ben Halpern
cbae624b5e
Add billboards to digest emails ( #20862 )
...
* Initial bb work
* Add billboards to digest
* Clean up tests and formatting
* Clean up tests and formatting
2024-04-15 12:01:00 -04:00
Ben Halpern
b6fa936e36
Customize ahoy email to track clicks async without redirect ( #20809 )
...
* Initial controller creation
* Ahoy custom clicks initial WIP
* Add test for success and failure
* Adjust some tests
* Adjust test
* Adjust tests and some code
* Update app/views/mailers/digest_mailer/digest_email.html.erb
* Remove s/t/u from safe params
* Add simple test
* Update app/controllers/ahoy/custom_email_clicks_controller.rb
Co-authored-by: Mac Siri <mac@forem.com>
* Change to just email clicks
* Email clicks controller test
---------
Co-authored-by: Mac Siri <mac@forem.com>
2024-04-01 15:05:04 -04:00
Alex Gwartney
75b7121b12
prevent switchHelpContext from triggering if the preview is open. ( #20744 )
...
Co-authored-by: Mac Siri <mac@forem.com>
2024-04-01 16:53:43 +00:00
Makar
069530052f
typo fix on PR #20762 ( #20804 )
...
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-28 13:06:10 +00:00
Makar
ec32a8e7cc
skip unnecessary history pushes and preserve intuitive forward/back ( #20762 )
2024-03-27 17:54:50 +00:00
Philip How
b0086c9171
Add mark as spam button on user profile for admins ( #20794 )
2024-03-25 10:30:16 -04:00
Philip How
6b8c363487
Prioritize spam label over suspended, add to async profile check ( #20790 )
...
* Prioritize spam label over suspended, add to async profile check
* fix jest
2024-03-25 10:15:35 -04:00
Ben Halpern
a22172ec20
Add safe navigation to billboard.js conditionals ( #20769 )
2024-03-13 10:29:13 -04:00
Ben Halpern
f4b94ce7f2
Early return from org follow check ( #20761 )
...
* Early return from org follow check
* Adjust podcast follow button
* Move early return to later
2024-03-11 18:24:19 -04:00
Ben Halpern
0d4f7c7e19
Add new simple a/b test for Digest subject and adjust config and design details ( #20754 )
...
* Adjust Digest Email design and configuration
* Adjust some tests
* Update tests
* More adjustments to markup and tests
* More adjustments to markup and tests
* Digest email feature flag
* Test title variants
2024-03-11 13:02:19 -04:00
Ben Halpern
fad28a1707
Allow feed billboards to be dismissable if dismissal_sku is present ( #20737 )
2024-03-06 15:16:23 -05:00
Ben Halpern
f263e17a1f
Fix dataset check in JS ( #20733 )
...
* Fix dataset check in JS
* Email opt in quick fix
* Change test
2024-03-05 17:11:07 -05:00
Philip How
7a873bd14c
Add a link icon to Mod Center to open article in new tab/window ( #20672 )
...
* add link icon to open article in new tab/window
* add label to icon
* add label to icon
2024-03-05 15:16:20 -05:00
Philip How
45a1bb20aa
Use request utility on actionsPanel ( #20725 )
2024-03-04 19:02:35 -05:00
Ian Lourenço
bb6954bfb6
Fix: visual glitch with autocomplete component ( #20611 )
...
* fix: add display:block style to span and correct minor typo
* refactor: change posisiton and max-heigh on scss
* refactor: adapt message with conditional
---------
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 19:47:32 +00:00
Gabriel Quaresma
ed584ff5dc
Fix successfully passing incorrect tests in actionsPanel.test.js ( #20674 )
...
* first commit
Co-authored-by: Guilherme Nunes <guilherme.nunes.lopes@gmail.com>
* feat: implementt rollbackReactionButtonsState
* test: write new test cases
* refactor: update rollbackReactionButtonsState
---------
Co-authored-by: Guilherme Nunes <guilherme.nunes.lopes@gmail.com>
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 16:58:38 +00:00
Ben Halpern
0140a7631c
Adjust menu popup behavior contextually ( #20718 )
2024-03-01 17:27:50 -05:00
Ben Halpern
f2968baadb
Add optional client-side dismissal SKU for closable billboards ( #20716 )
...
* Add optional client-side dismissal SKU for closable billboards
* Safe nav
2024-03-01 16:13:19 -05:00
Ben Halpern
229c3fc3c0
Go to page you came from after onboarding when coming through billboard ( #20675 )
...
* Add proper location memory for onboarding
* Get test dates working as expected
2024-02-26 16:21:05 -05:00
Ben Halpern
f88784cc35
Add configuration for admins to specify compliant email strategies ( #20663 )
...
* Add configuration for admins to specify compliant email strategies
* Add keys for test
2024-02-21 08:27:26 -08:00
Makar
c6cef39694
Persist selectedTag filtering of the reading list ( #20601 )
...
* persist selectedTag filtering of the reading list when coming back after reading an article
* bugfix -- could not filter back by all tags in mobile
* e2e tests for persisted filtering
---------
Co-authored-by: Mac Siri <mac@forem.com>
2024-02-16 13:06:21 +00:00
Ben Halpern
8eb41eef8e
Record billboard signup conversions ( #20629 )
...
* Record billboard signup conversions
* Update app/models/billboard_event.rb
* Modify click tracking
2024-02-14 14:18:57 -05:00
Ben Halpern
13c105a6b4
Use new_comment as the intersection object for delayed billboard ( #20627 )
2024-02-14 11:48:04 -05:00
Ben Halpern
205aee8c78
Add billboard for bottom of page with allowance to delay until after reading is finished. ( #20616 )
...
* Add delayed behavior
* Add special behavior to billboards
* Fix order for test
* Test clicking outside element when close event is present
* Update app/javascript/packs/billboardAfterRenderActions.js
2024-02-13 11:56:32 -05:00
Ben Halpern
2f9769a89d
Add new sidebar billboard locations and remove legacy campaign area ( #20562 )
...
* Add new sidebar billboard locations
* Remove some specs
* Remove campaign tests
* Adjust tag-allowed billboards
* Fix up targeting functionality
* Fix sidebar third render
2024-02-08 16:55:48 +00:00
Mac Siri
afa73e06e3
Replace Webpacker with Esbuild ( #20470 )
...
* Migrate to esbuild WIP
* Add exclude
* Remove redundant file
* Move file
* Move to javascript_include_tag
* Lint fix
* WIP
* WIP
* Add watch mode to esbuild WIP
* Get jest working
* Remove babel
* Revert "Remove babel"
This reverts commit 6da35260aa19d6f97f586deb66c0ecaf48433b73.
* More WIP
* Got image to load
* WIP
* Resolve audit
* Lint fix
* WIP
* Fix jest spec
* [CI] Remove asset-restore for test build stage
* Production compliant
* Temp disable sourcemap
* Update glob
* Add esbuild helper to stimulus
* Import fragment
* Temp disable coverage to see failing tests
* Fix broken spec
* Address lint
* Set proper es6 target
* Use esbuild for everything
* wait what
* Revert "Set proper es6 target"
This reverts commit 98f5278093421baa8ffe2ca580845b01c1a1eadf.
* Revert "Use esbuild for everything"
This reverts commit 0ac46738f07ffcb6af095ccb1ffa5e439b7fefa3.
* Replace uglifier with terser
* New compiled assets version
* Remvoe honeybadger-io/webpack
* Remove cypress coverage checks for now
* Update jsconfig.json
* Update docker-compose
* Remove public/packs-test from ci cache
2024-01-25 20:29:21 +00:00
Philip How
d615fcef56
Add new members filter to mod center ( #20542 )
...
* fix jest
* Update safe_params_list.vcl
---------
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2024-01-23 16:07:45 -05:00
Ben Halpern
ae2371d9a4
Add configuration for admins to determine whether to show cookie banner ( #20517 )
...
* Cookie banner admin config (wip)
* GA4 consent mode based on cookie acceptance
* Fix i18n
* Merge upstream
* Adjust heading
2024-01-15 18:22:17 +00:00
Philip How
4be6df8baf
Show tips on the post help content + update styles ( #20415 )
...
* change in article help content + styles
* some attempt at keyboard navigation
* fix v1 editor
2024-01-11 14:55:14 +00:00
Ben Halpern
f4081b2e24
Functionality to allow admins to add a cookie consent notice (part 2) ( #20488 )
...
* Initial work on base cookie modal
* Update app/assets/stylesheets/components/modals.scss
2024-01-04 16:20:03 -05:00
Anna Buianova
40d1208b46
Removed github/time-elements ( #20480 )
2023-12-28 13:37:14 +00:00
Ben Halpern
fd77c7671d
Track article id on billboard clicks ( #20447 )
2023-12-12 22:21:32 +00:00
Ben Halpern
55997ffba8
Hide images if error on billboards to fix blocking page ( #20419 )
...
* Hide images if error on billboards
* Update app/javascript/packs/billboard.js
2023-12-05 09:02:27 -05:00
Ben Halpern
9eaff67318
Update styling and refine features for analytics page ( #20410 )
...
* Update styling and refine features for analytics page
* Remove follower reference from js
* Update html
* Adjust test
2023-11-30 16:07:16 -05:00
ktmouk
1e0d70b530
Fix an error message not showing on the onboarding page ( #20313 )
...
* Fix an error message not showing on the onboarding page
* Add a test
* Fix a test
2023-11-20 20:29:23 +00:00
Ben Halpern
e7fc1bb0ce
Add article id and geolocation info to billboard events ( #20329 )
...
* Add article id and geolocation info to billboard events
* Confirm destroyed in rollup
2023-11-09 12:43:23 -05:00
Ben Halpern
0ddb133c49
Add ability for admins to request specific billboards for inspection ( #20311 )
2023-11-02 16:58:28 -04:00
Lucas Mateus Batista Polles
59860df04a
fix: tool editor disappears when dragging words ( #20271 )
...
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Anna Buianova <lightallloy@gmail.com>
2023-10-31 17:38:39 -04:00
Julia Undeutsch
9df24fc1f7
Add title="Check" to svg icon ( #20285 )
2023-10-30 17:04:54 -04:00
Ben Halpern
b0cb5540c0
Add new render mode and template options for billboards ( #20282 )
...
* Add new render and template modes for billboards
* Add new fields to /admin
* Adjust test
* Adjust markup in form
* Add tests for script execution
* Add two script test
* Adjust scripts
* Adjust scripts
* Add new test
* Add new explicit tests
* Move JS functionaity around
2023-10-30 14:56:09 -04:00
ktmouk
8963e185f8
Fix username combobox tries to load all users ( #20227 )
...
* Fix username combobox tries to load all users
* Add the limit param to the users_query
* Add a comment
2023-10-25 15:53:53 -04:00
Ben Halpern
3bc1b242ce
Fix the data passed into the email newsletter ( #20277 )
...
* Fix the data passed into the email newsletter
* Add check for element existing
2023-10-24 15:29:10 -04:00
ktmouk
2314043432
Fix anchors not working ( #20255 )
2023-10-19 15:32:52 -04:00
ktmouk
3b37658df5
Fix lint:frontend warnings ( #20256 )
2023-10-19 12:59:54 -04:00
ktmouk
1beb221531
Fix tests that fail when developer uses a non-en locale ( #20230 )
2023-10-11 09:39:25 -04:00
ktmouk
282004c72a
Fix the sidebar not desplayed when the path contains /locale ( #20030 )
...
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-10-06 17:24:19 +07:00
Lucas Mateus Batista Polles
799043abea
Fix flag user modal on mod page ( #20189 )
2023-10-04 18:49:21 -04:00
Ridhwana
ae9d1b5ace
Hide the buttons on the tag page ( #20148 )
...
* feat: step 1 - add the buttons to the html template
* refactor: renamed the class to be prepended with js-
* feat: add the js-tag-card class to the entire tag-card div
* feat: add the relevant data elements and tag-id to the tag-card div
* feat: add the required data elements for the top level js-tag-card
* feat: use @tag instead of tag
* refactor: rename the tag pack file
* refactor: rename the Tag file component
* feat: add a snackzone so that the snackbar can be added there
* feat: remove the follow-actions-button and the hide-actions-button from the tag pages so that it doesn't conflict with the 'followButtons' pack whne we need to add it
* spec: update the specs for tags
* chore: follow-action-button renamed to follow-tag-button and hide-action-button to hide-tag-button
* refactor: js-classes
* chore: add some comments
---------
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2023-09-26 19:49:57 -04:00
Joshua Wehner
6a48b486ca
Onboarding: custom newsletter opt-in settings ( #20114 )
...
* Settings can process markdown into html
* Update Settings with new onboarding settings
* Async render onboarding newsletter step
* Tweak onboarding design
* Fix broken spec
* Better rendered component test
* Tweaks to match design
* Try to tweak design
* Try having a default state
* Tweak placeholder content
* Better await componentDidMount
* Continue to tweak the design
* ContentRenderer#process should always return Result
* Try more clarity in the partial
* Rubocop
2023-09-26 06:34:19 -04:00
Rajat Talesra
1d73f871f2
Janky bug fix ( #20147 )
2023-09-21 16:37:44 +05:30
