Tim Lange
3494264404
Enabled rubocop/lint ( #2130 )
...
* WIP: Enabled rubocop/lint
* FIX: Fixed failing test
* FIX: Small change to return
* FIX: Changed indent
2019-03-21 10:53:44 -04:00
Ben Halpern
c901c7138d
Fix possible race condition with page view tracking ( #2103 )
...
* Fix possible race condition with page view tracking
* Change min number to check for html variant calculation
2019-03-18 15:53:13 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Ben Halpern
8149a72efb
Nevertheless, She Coded ( #2000 )
2019-03-07 18:52:09 -08:00
Ben Halpern
e5a2b25871
Add additional streak badge rewarding ( #1896 )
2019-02-25 15:37:16 -08:00
Ben Halpern
92b24a9978
Add html_variant split testing to /badge ( #1763 )
...
* Add /badge html_variant
* Fix some of the linting
2019-02-08 12:45:14 -04:00
Ben Halpern
560d633327
Modify memcache hardcoded limit ( #1718 )
2019-02-03 01:43:57 -04:00
Ben Halpern
561882d9d5
Add writing streak badge rewarding algorithm ( #1670 )
...
* Add 4 week streak badge rewarding algorithm
* Modify badge message
* Fix typo
2019-01-28 13:46:00 -05:00
Ben Halpern
47e8fbc9ec
Add feed_fetched_at for users to not refetch unnecessarily ( #1555 )
...
* Fix RSS issues by not refetching users as often
* Make rss fetch not forced in rake task
* Remove unnecesary schema line
2019-01-15 13:29:11 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Jess Lee
295b30ce3e
Add Fab Five BadgeRewarder + Rake Task ( #1048 )
...
* adds method and rake task
* Improve BadgeRewarder spac
2018-11-05 11:46:08 -05:00
Frédéric Planté
4a50c418c6
Automatically add contributor badges ( #1016 )
...
* Basic proof of concept
* Use Octokit instead of HTTParty
* add rake task
* DEV Community iOS App should be checked too
* This only need to be computed once
* Add spec
* for consistency sake
2018-10-29 20:21:37 -04:00
Ben Halpern
359cc71b64
Add ability for users to publish series ( #1034 )
2018-10-29 13:04:42 -04:00
Ben Halpern
d5ceff4b12
Update/fix org settings ( #992 )
...
* Update/fix org settings
* Small adjustment to an unrelated rake task
* Update app/views/users/_org_non_member.html.erb
2018-10-23 17:21:17 -04:00
Ben Halpern
302e8f202d
Add HTML variants for cta optimization and other nav bar adjustments ( #970 )
...
* Add HTML variants for cta optimization and other nav bar adjustments
* Fix 1==1 non-random mistake
* Spruce up org call-to-action
* Change default text color
* Add html variant trial and success request specs
* Fix article sidebar caching issue
* One line adjustment
* Modify schema
* Add include ActionView::Helpers::TagHelper to user_tag_spec
* Modify follow_button to remove session context
* Dummy commit
* Change Edit Article to Edit Post
* Dummy commit
* Fix rubocop concerns
* Fix rubocop style
2018-10-22 17:03:57 -04:00
rhymes
1b60ee5009
Use timezone aware methods ( #893 )
...
* Use timezone aware datetime methods
* Use timezone aware date parse for GitHub issue tag
* Introduce a bit of chaos programming using Zonebie
Zonebie uses a random timezone to run tests, it's a really good way to see if the code is timezone dependent or not.
* Convert GitHub issue date as UTC
2018-10-18 16:26:29 -04:00
Ben Halpern
c98e97d5a2
Change harcoded memcache limit ( #785 )
2018-10-01 14:40:13 -04:00
Kohei Sugi
f34c717027
Fix rubocop lint ( #583 )
...
* $ rm .rubocop_todo.yml && rubocop --auto-gen
* 👮 Layout/AlignHash
* 👮 Layout/IndentationConsistency
* 👮 Layout/TrailingBlankLines
* 👮 Lint/UnusedBlockArgument
* 👮 Style/TrailingCommaInHashLiteral
* Fix rubocop.yml setting
* Delete last conma
* Style/TrailingCommaInArguments and Style/TrailingCommaInArrayLiteral are comma style
2018-09-10 11:19:11 -04:00
Ben Halpern
f1abd283f9
Expand BadgeRewarder functionality ( #540 )
...
- Refactor badge rewarder
- Add contributor badge functionality
- Create BadgeRewarder rake tasks
2018-08-30 16:03:38 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Arun Kumar
876c70d2bb
Minimize creation of CacheBuster objects ( #599 )
2018-07-24 10:30:30 -07:00
Arun Kumar
52486a4edd
Update instance methods to module methods ( #613 )
2018-07-23 12:13:42 -07:00
Ben Halpern
fd4390983c
Add badge achievemnt context message markdown ( #382 )
...
* Add badge achievemnt context message markdown
* Add badge rewarder method for beloved comments
2018-06-04 17:31:01 -04:00
Ben Halpern
0d82c50a3d
Add BadgeRewarder class and rake for auto badging ( #367 )
2018-05-30 17:37:34 -04:00
Ben Halpern
99fd30fa25
Modify email digest and create rake task ( #151 )
2018-03-27 15:21:59 -04:00
Mac Siri
301c6080e3
Initial commit
2018-02-28 16:11:08 -05:00
