rhymes
1f562783fc
Fix new Rubocop violations ( #10808 )
...
* Fix new Rubocop violations
* Use the latest minor version of 0.93
2020-10-20 09:28:53 -04:00
rhymes
10efa25c0a
Add missing presence validators to models ( #10495 )
...
* Add missing presence validator for Tag
* Add missing presence validators to Follow
* Add missing presence validators to ProfileField
* Add missing presence validators to Comment
* Add missing presence validators to Profile
* Add missing presence validators to Organization
* Add missing presence validators to Badge
* Add missing presence validators to Webhook::Endpoint
* Add missing presence validators to NotificationSubscription
* Add missing presence validators to PodcastEpisode
* Add missing presence validators to Sponsorship
* Add missing presence validators to PollOption
* Add missing presence validators to Poll
* Add missing presence validators to Article
* Add missing presence validators to EmailAuthorization
* Add missing presence validators to AuditLog
* Add missing presence validators to DataUpdateScript
* Add missing presence validators to User
* Add missing presence validators to SiteConfig
* Fix specs
2020-10-01 16:15:32 +02:00
rhymes
5a2cae4fbb
Rubocop: enable and fix new Rails cops ( #9537 )
...
* Enable new Rails/* cops and use autocorrect on them
* Fixed Rails/PluckInWhere leftovers
* Fix Rails/DefaultScope
* Enable and fix Rails/PluckId
* Fix manual mistake with forcing autocorrection on Rails/PluckId
* Apply PR feedback to remove Rails/PluckId inline disables
* Apply PR feedback to get rid of Rails/PluckInWhere inline
2020-07-29 11:14:19 +02:00
rhymes
696c712883
Rubocop: routine fixes ( #9345 )
...
* rubocop -A
* Fix Style/HashLikeCase
* regenerated todo file
2020-07-16 18:18:13 +02:00
rhymes
f1ec04a0c9
Rubocop: move dot in multi-line calls to leading position ( #9262 )
2020-07-16 15:51:11 +02:00
Molly Struve
fad259b1c8
[deploy] Bug Fix: Remove Rails Validation for Follow Uniqueness, Guard against dup Follow Jobs ( #9222 )
2020-07-09 09:50:06 -05:00
rhymes
8afc9bb0c3
[deploy] Add unique indexes to follows - part 7 ( #8215 )
2020-07-06 11:15:56 -05:00
rhymes
01e4a0b0f1
API: add docs for /followers/users and remove organizations endpoint ( #6551 )
...
* Use api-key for api tests
* Remove /api/followers/organizations endpoint
* Add more tests
* Add documentation for /api/followers/users
2020-03-11 10:56:43 +01:00
rhymes
145d5e610e
Use scopes for Follow instead of where all the time ( #6149 ) [deploy]
2020-02-25 19:29:52 -05:00
Alain Mauri
18b2b2cb4c
Add Follows::CreateChatChannelWorker for Sidekiq ( #5458 )
...
* Added a new worker to create chat channels after a follow
* Moved the chat channe creation to after_create_commit hook
2020-01-20 08:23:44 -05:00
Molly Struve
7c939dc2c5
Remove TouchFollowerJob and do user update inline ( #5391 ) [deploy]
2020-01-08 14:12:04 -05:00
Lud
df042d6b0b
Refactors ActiveJob to SidekiqWorker: Follows::SendEmailNotificationWorker ( #5322 ) [deploy]
...
* Refactors ActiveJob to SidekiqWorker: Follows::SendEmailNotificationWorker
* improves naming of User#receives_follower_email_notifications?
* adjust expect count for spec SendEmailNotificationWorker
2020-01-02 13:35:09 -05:00
Andy Zhao
1e61634499
Add backend functionality for muting users you follow ( #3240 )
...
* Add backend func. for muting users you follow
* Remove comment
* Add validations and update default value
* Send notifications to followers with all_articles
2019-06-20 11:28:50 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Anna Buianova
96de5a4f60
Don't send new follower notification when followable is a tag #2041 ( #2050 )
...
* Enable djs to confirm follow spec fail
* Don't send new follower notification when followable is a tag
2019-03-13 08:16:20 -07:00
Anna Buianova
32b20c6d95
Remove unused Follow methods ( #1915 ) [ci skip]
2019-02-27 10:38:30 -05:00
Anna Buianova
58b2013377
Fix delayed job errors related to follows #1621 ( #1835 )
...
* Add delayed_job_web to dev environment for debugging
* Add specs for the current Follow callbacks implementation
* Move follower touching to ActiveJob
* Spec for the touch followers job
* Move Follow#create_chat_channel to ActiveJob and make the job safe
* Add ActiveJob to send email notifications about follows
* Enqueue SendEmailNotificationJob after the follow is created
* Specs to wnsure jobs are enqueued on Follow creation
* Make CreateChatChannelJob queue name more specific
2019-02-23 18:16:20 -08:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Ben Halpern
115e52c748
Move follow and reaction aggregation into Notification model to avoid… ( #1164 )
...
* Move follow and reaction aggregation into Notification model to avoid re-compute
* Ugh. Fixing schema
* Update tests
* Skip some tests in notifications_spec
2018-11-20 15:00:21 -05:00
Andy Zhao
a1010201f2
Notifications part 2 ( #1156 )
...
* Remove stream and add new notification views
* Actually remove Stream
* Move followers query to async method
* Remove unused tests and fix query
* Try using without delay instead
* Add without delay and escape HTML
* Make all tests pending for now
2018-11-19 18:14:24 -05:00
Maksim Litvinov
33db32e5f4
Fix rubocop lints ( #794 )
2018-10-03 13:00:09 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Andy Zhao
a920d6cf1c
Add dependent destroys to automate some deletion tasks ( #554 )
...
* Add dependent destroys for dependency-less models
* Add before destroy for empty dm channels
* Fix typo
* Add new tests for new dependent destroys
* Remove failing test b/c rethinking relationships later
* Use find_by to return nil instead of erroring out
* Add before_destroy to destroy follows
2018-07-09 15:54:09 -04:00
Andy Zhao
cfd95a65af
Update "Connect Twitter acct" in settings with new callback url ( #439 )
...
* Update "Connect Twitter acct" in settings with new callback url
* Remove name from comments (#437 )
2018-06-15 12:52:14 -04:00
Ben Halpern
7d018f049e
Make adjustments and fixes to DEV Conncect ( #427 )
...
* Make adjustments and fixes to DEV Conncect
* Make various small changes and add settings icon
2018-06-13 14:46:30 -04:00
Ben Halpern
87c6a758bb
Add top bar indicator and other Connect features ( #424 )
...
* Add algolia public search key
* Add status to chat_channels
2018-06-12 18:24:57 -04:00
Ben Halpern
75c912c593
Auto create channels for mutual follows ( #419 )
2018-06-11 17:54:30 -04:00
Andy Zhao
f1571184bc
[Updated] Add aggregated follow notifications ( #327 )
...
* Fix sidebar issue for XL displays
* Remove grouping param for follows
* Add aggregated follow notification MVP
* Lint reaction model a bit
* Fix a few small css issues
* Remove puts statement and indent HTML
* Use activity id instead of time for cache key
2018-05-19 11:03:06 -04:00
Zhao-Andy
70e0329f5a
Modify query to be more performant and correct
2018-04-27 17:04:09 -04:00
Ben Halpern
c1b0d08c59
Update follow suggestions logic and add taggable to users ( #147 )
2018-03-26 13:14:24 -04:00
Ben Halpern
e3ed9f2f2b
Make follow unique (extra unique?) ( #137 )
...
* Add user constraint to follows query
2018-03-23 16:18:15 -04:00
Ben Halpern
b7ab8e931d
Adjust follow process ( #135 )
2018-03-23 14:49:20 -04:00
Ben Halpern
45b371e31b
Fix issue where unpublished article hangs in notifications ( #42 )
...
* Fix issue where unpublished article hangs in notifications
2018-03-05 11:56:32 -05:00
Mac Siri
301c6080e3
Initial commit
2018-02-28 16:11:08 -05:00
