Julianna Tetreault
f6478fb7cc
Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs ( #6454 )
...
* Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs
* Fix typo in reaction_spec
2020-03-04 11:39:48 -07:00
cyrillefr
cf3f997c98
Move HtmlVariantTrial.create delay calls to ActiveJob ( #3173 ) ( #3239 )
2019-06-20 18:14:20 -04:00
Mac Siri
1137d6fba4
Improve specs ( #1693 )
...
* Lock erb_lint
* Refactor moderation spec
* Remove & replace RequestSpecHelper
* Update uid to sequence
* Lower the need for persistence in specs
* Update moderation spec
* Update shoulda-matchers
* Enable backgroundjobs and update commenct spec
* Fix fail specs
* Update comment's validations
* Remove redundent specs
* Actually turn off DJ
* Apply run_background_jobs_immediately
* Remove giveawy specs
* Create Identity spec
2019-02-04 15:56:00 -04:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Ben Halpern
302e8f202d
Add HTML variants for cta optimization and other nav bar adjustments ( #970 )
...
* Add HTML variants for cta optimization and other nav bar adjustments
* Fix 1==1 non-random mistake
* Spruce up org call-to-action
* Change default text color
* Add html variant trial and success request specs
* Fix article sidebar caching issue
* One line adjustment
* Modify schema
* Add include ActionView::Helpers::TagHelper to user_tag_spec
* Modify follow_button to remove session context
* Dummy commit
* Change Edit Article to Edit Post
* Dummy commit
* Fix rubocop concerns
* Fix rubocop style
2018-10-22 17:03:57 -04:00
