Commit graph

1839 commits

Author SHA1 Message Date
cyrillefr
369aeb9130 Fix comment deletion bug (#3732)
Fix bug where deleted comment still appears on user's profile
2019-08-27 17:07:09 -04:00
Feruz Oripov
0ccc62ffa3 Refactoring possible unprotected redirect. (#3825)
* Refactoring possible unprotected redirect.

* Security refactoring tag_adjustments_controller.rb.

* Security refactoring tag_adjustments_controller.rb.

* Security refactoring articles_controller.rb.

* Security refactoring internal/welcome_controller.rb

* Security refactoring tags_controller.rb.

* Security refactoring comments_controller.rb.

* Security refactoring stories_controller.rb.
2019-08-27 10:13:38 -04:00
Feruz Oripov
ee498ad9ef Refactor VideosController (#3806) [ci skip] 2019-08-26 18:59:31 -04:00
Nick Taylor
45368132b0 Fix JS Lints (#3815) 2019-08-26 18:01:12 -04:00
Ben Halpern
cbe599e2eb
Adjust internal page logic and add credits copy to notifications (#3843)
* Adjust internal page logic and add credits copy to notifications

* Adjust badge email copy
2019-08-26 13:41:13 -04:00
Feruz Oripov
4cc517d1c2 Refactoring models/article.rb. (#3835) 2019-08-26 13:32:28 -04:00
Feruz Oripov
c9d91e1552 Refactoring social_previews_controller.rb. (#3818) 2019-08-24 16:24:20 -04:00
John Curcio
c81ff56d13 Fix encoding of special characters in org (#3779) (#3817) 2019-08-24 15:08:31 -04:00
Ben Halpern
3443fdf2bd
Create endpoint for liquid tag embed (#3813) 2019-08-23 17:42:04 -04:00
Mario See
47c2885810 Listings set custom expiry date (#3770)
* add expire_on column to classified_listings

* add expire_on to valid listing params

* add expire_on to model

* add expire date to new listing form

* add field in edit form

* add expiry dates to dashboard

* update expiry date in listing toolkit

* WIP unpublish job and test

test still has to run properly

* add job to class name

* change job to rake task

* revert snap change

* delete migration file

will add new one and revert schema changes to rename column

* reset schema

* add new migration to schema 'expires_at'

* change expire_on to expires_at
2019-08-23 17:33:50 -04:00
Feruz Oripov
352a09e82f Refactoring chat_channels_controller.rb. (#3808)
* Refactoring chat_channels_controller.rb.

* Use %i or %I for an array of symbols
2019-08-23 17:16:35 -04:00
Anna Buianova
9b04654e3b Refactor articles creation (#3797)
* Refactor articles creation

* Create article from /admin via a service for consistency

* Move articles destroy logic into Articles::Destroyer
2019-08-23 14:43:29 -04:00
Ben Halpern
76bedc6b23
Add onboarding variants and update variant display ratio (#3812) 2019-08-23 12:48:29 -04:00
Nick Taylor
39618f66a2 Fixed some more Frontend Lint Issues (#3792)
* Removed a file that is not used.

* Fixed some lint issues

* Fixed some more lint issues
2019-08-23 10:21:28 -04:00
not-a-patch
c6fc92b63c Replace magic number for reading speed with symbolic constant (#3809) 2019-08-23 10:04:17 -04:00
Andy Zhao
5754b4a169 Add comment markdown to warned_user_ping (#3750)
* Add comment markdown to warned_user_ping

* Add missing argument
2019-08-22 22:04:45 -04:00
John Curcio
6dbb588d37 Add android and ios apps download page (#3736) (#3798)
* Add android and ios apps download page (#3736)

* Adhere to Rubocob's style guide
2019-08-22 21:04:58 -04:00
Feruz Oripov
c0e1ad0e46 Refactoring organizations_controller.rb. Adding set_organization method (#3793)
for not repeating query code.
2019-08-22 20:54:53 -04:00
Feruz Oripov
8acd1dc638 Refactoring dashboards_controller.rb. (#3794) 2019-08-22 20:54:21 -04:00
Yash Dave
773982e210 Fixes some lint issues (#3786)
Fixes lint issues in /home/yash/GitHub/dev.to/app/assets/javascripts/utilities/
	- browserStoreCache.js
	- checkUserLoggedIn.js
	- createAjaxReq.js
	- getCurrentPage.js
	- getImageForLink.js
	- insertAfter.js
	- localDateTime.js
	- localStorageTest.js
	- preventDefaultAction.js

Signed-off-by: Amorpheuz <mail2ypd@gmail.com>
2019-08-22 15:59:13 -04:00
Jess Lee
d093667198 show single pinned article (#3803) 2019-08-22 15:57:31 -04:00
Mladen Ilić
50fe104ee7 Fix typo (#3789)
Fix a typo in flash message
2019-08-22 12:51:05 -04:00
Feruz Oripov
c9b40326ac Refactoring chat_channels_controller.rb. Adding set_channel private (#3787)
method for not repeating query code.
2019-08-21 19:08:16 -04:00
Ben Halpern
a287263875
Remove listings privileges from banned users (#3784) 2019-08-21 16:44:27 -04:00
Ben Halpern
a934968190
Add dropdown and report-abuse for users (#3788)
* Add dropdown and report-abuse for users

* Move script to JS area
2019-08-21 16:43:52 -04:00
Nick Taylor
0147d8bd26 Fixed some lint issues (#3782) 2019-08-21 10:44:23 -04:00
Ben Halpern
fe2d67eedc
Remove channel_users from chat_channel index (#3780) 2019-08-20 17:11:50 -04:00
Ben Halpern
04a810d739
Fix video image redirect issue (#3778) 2019-08-20 13:18:38 -04:00
Anna Buianova
5deb668ecd Rubocop fixes (#3774) 2019-08-20 10:32:26 -04:00
Andy Zhao
e0da0ac955 Fix for multi-image upload to handle single imgs for comments (#3771)
* Fix for multi-image upload to handle single imgs for comments

* Remove additional multiple oops
2019-08-19 18:15:35 -04:00
Ben Halpern
dd41f7ddf5
Redesign series style (#3768) 2019-08-19 15:26:21 -04:00
Ben Halpern
8b4dc85ee4
Add internal dashboard for growth (#3749) 2019-08-19 09:41:04 -04:00
Ben Halpern
9dd474d12e
Remove unnecessary imports from css (#3743)
* Remove unnecessary imports

* Remove unneeded shared.scss code and mixins

* Add kbd to top
2019-08-18 19:39:03 -04:00
Ben Halpern
40559a0457
Add random variants to onboarding for a/b testing (#3742)
* Add random variants to onboarding for a/b testing

* revert listings dashboard snapshot
2019-08-18 18:30:22 -04:00
Bolarinwa Balogun
41aff162cc Allow upload of multiple images at a time (#3599)
* Allow upload of multiple images at a time

* Update schema.rb
2019-08-18 15:03:14 -04:00
Yash Dave
0932d300a0 Adds border-right to the menu for displays with min-width 1250 or higher (#3738)
Modifies top-bar.scss to add 'border-right' and 'border-bottom-right-raidus' property
for '.menu' in media query 'mind-width: 1250px' to get even menu appearance on desktop
screens.

Signed-off-by: Yash Dave <mail2ypd@gmail.com>
2019-08-18 14:27:10 -04:00
Jess Lee
66a4424f5b Sponsorship Updates (#3719)
* show blurb for tag sponsors

* check that sponsorhip is live and account for expiration time

* automatically add expiration date to tags

* update tag offering

* rewrite tag auto expiration

* night mode compatibility for sponsor logos

* fix spec

* update specs

* Small css adjustment
2019-08-16 14:54:26 -04:00
Aurelio
df301c8290 3724 - Fix badges order on profile sidebar (#3729)
Make sure the layout is consistent when
rendering badges on the sidebar

fixes #3724
2019-08-16 14:27:59 -04:00
Ben Halpern
0b64407b81
Ensure anonymization of IP in GA (#3734) 2019-08-16 14:06:02 -04:00
cyrillefr
30828cf0f7 Move delayed calls for update analytics to Active job (#3603)
* Move delayed calls for update analytics to Active job

  - add job + job spec
  - refactoring

* update namings+specs due to requested changes after review

* Fixes on analytics job spec + minor refactor of service
2019-08-16 12:41:37 -04:00
Theau Poulat
e0a7c7cc6e Onboarding : fixed bug that prevented toggle by clicking on label (#3725)
* toggle click bug fixed

* updated snapshot
2019-08-16 11:41:00 -04:00
Luis Rogelio Hernández López
67004009f7 Fix/icons in dark mode (#3727)
* Add theme variables for series dots

* Use theme variables for article series icons

- The theme colour should only apply in night theme.
- The rest of the themes should remain intact.

* Refactor added styles to use themeable mixin
2019-08-15 17:59:37 -04:00
Jacob Eubanks
180935bd37 Delete unused, commented-out code (#3722) 2019-08-15 12:24:48 -04:00
Andy Zhao
0f46b0deed Add Stack Exchange Liquid tag (#3637)
* Add Stack Exchange Liquid tag

* Add Stack Exchange/Overflow tag

* Convert to integers

* Add better error handling

* Make all links open in new tab

* Adjust names and refactor a bit

* Use key for every API call

* Add new lines to end of svg files

* Add better error handling

* Fix edge case where input is not numeric

* Finalize Stackexhange tag design and functionality

* Fix css typo

* Update snapshots

* Fix snapshot back
2019-08-14 15:01:47 -04:00
Ben Halpern
d1760c4d08
Fix mention notification to mention proper user (#3721) 2019-08-14 14:43:21 -04:00
Andy Zhao
6316ea4b60 Allow admins to undo a tag adjustment (#3653)
* Add ability to delete a tag adjustment

* Fix confirm alert
2019-08-14 09:26:26 -04:00
rhymes
23961b1505 Remove /api/articles/onboarding (#3716) 2019-08-14 09:22:38 -04:00
Ben Halpern
321560b751
Fix linting (#3714) 2019-08-13 20:32:01 -03:00
Mario See
da79b443a6 allow nil assignment (#3711) 2019-08-13 17:19:57 -03:00
Mario See
657d88ca13 Direct listing links only show listing if published (#3645)
* displayed_classified_listing should be published

* remove redundant line

* Update classified_listings_controller.rb

* update get request tests
2019-08-13 11:53:53 -03:00