Tim Lange
3494264404
Enabled rubocop/lint ( #2130 )
...
* WIP: Enabled rubocop/lint
* FIX: Fixed failing test
* FIX: Small change to return
* FIX: Changed indent
2019-03-21 10:53:44 -04:00
rhymes
27213bf6da
Use ActiveRecord::RecordNotFound instead of ActionController::RoutingError for 404s ( #2118 )
2019-03-19 20:54:25 -04:00
Edison Yap
7a0a793a89
Redirect to 404 if badge not found ( #2066 )
2019-03-19 16:04:43 -04:00
Ben Halpern
7bf37108b1
Night theme improvements + small fixes ( #2114 )
2019-03-19 13:36:30 -04:00
Ben Halpern
90a44b1687
Add prefill text for /new ( #2108 )
2019-03-18 19:08:00 -04:00
Jess Lee
9c1e10cd9f
Improve Internal Dashboards features( #2043 )
2019-03-18 16:29:11 -04:00
Ben Halpern
c901c7138d
Fix possible race condition with page view tracking ( #2103 )
...
* Fix possible race condition with page view tracking
* Change min number to check for html variant calculation
2019-03-18 15:53:13 -04:00
Andy Zhao
8a3d3ae765
Enable Org Pro Dashboard View ( #2060 )
2019-03-18 11:58:44 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Mario See
d8709c0334
Implement open inbox for dev-connect ( #1563 )
2019-03-15 14:39:57 -04:00
Ben Halpern
d6ab255a45
Allow users to configure to use night mode (beta) and sans-serif article body ( #2072 )
...
* Initial work for config
* Add config for users
* Fix schema
2019-03-15 13:11:53 -04:00
Anna Buianova
96de5a4f60
Don't send new follower notification when followable is a tag #2041 ( #2050 )
...
* Enable djs to confirm follow spec fail
* Don't send new follower notification when followable is a tag
2019-03-13 08:16:20 -07:00
Andy Zhao
4e120b8a8e
Add more logging to sign in failures ( #2038 )
...
* Actually redirect when rescuing an error
* Use inspect to view class as string
* Use a slightly more descriptive flash message
2019-03-12 16:33:10 -07:00
Andy Zhao
1922a55739
Add initial charts implementation to pro dashboard ( #2037 )
...
* Refactor and optimize article ids a bit
* Add chartJS to package.json
* Add new queries for charts
* Add past week charts for rxns and comments
* Use real data oops
* Round followers percent to 2 decimals
Co-Authored-By: Zhao-Andy <andyzhao.zhao@gmail.com>
* Round all percentages to 2 decimals
Co-Authored-By: Zhao-Andy <andyzhao.zhao@gmail.com>
2019-03-12 10:21:12 -07:00
James Turner
a9254eac40
Fix typo in surrogate key header ( #2013 )
2019-03-11 17:40:45 -04:00
Ben Halpern
ecb9f6da3d
Remove some hardcoded shecoded stuff ( #2011 )
2019-03-08 18:08:48 -08:00
rhymes
3c6a7d4574
Display comment published timestamp according to user's locale ( #1970 )
2019-03-08 15:19:37 -05:00
Ben Halpern
27662eb924
Ben/shecoded tweaks ( #2007 )
...
* A few shecoded tweaks
* Refactor code
2019-03-08 08:16:10 -08:00
Ben Halpern
138278462a
Add shecoded sidebar/homepage decorations ( #2003 )
...
* Add shecoded sidebar/homepage decorations
* Add additional functioanlity to /shecoded
* Fix typo
2019-03-08 04:47:31 -08:00
Ben Halpern
8149a72efb
Nevertheless, She Coded ( #2000 )
2019-03-07 18:52:09 -08:00
Ben Halpern
825aa9be91
Add page_view model ( #1985 )
...
* Add page_view model
* Uncomment DJ routes
* Add time on site max and don't update article page views every time
2019-03-07 11:53:33 -08:00
Andy Zhao
5c116c4881
Update tag admin page( #1990 )
2019-03-06 14:28:30 -05:00
Andy Zhao
d94f11fbf7
Add ability to add pro role to internal ( #1980 )
...
* Add ability to add pro role in internal
* Remove debug statement
2019-03-05 10:44:56 -08:00
Ben Halpern
e491cf1f65
Allow non-logged-in proper redirect for template posts ( #1977 )
2019-03-04 15:50:36 -08:00
Ben Halpern
b271e96965
Add shecoded social preview template ( #1975 )
2019-03-04 13:18:32 -08:00
Ben Halpern
fd83b33603
Add shecoded template to v2 ( #1972 )
2019-03-04 12:41:37 -08:00
Ben Halpern
8d0f0946a0
Basics of pro dashboard ( #1971 )
2019-03-04 12:10:09 -08:00
Ben Halpern
263b698686
Add shecoded page ( #1968 )
...
* Add shecoded page
* Fix copy
2019-03-04 07:50:49 -08:00
Ben Halpern
044b088d4f
Switch satellite view to any: true for tags ( #1956 )
2019-03-03 18:55:39 -08:00
Ben Halpern
f280d9e266
Fix a couple things and modify dev digest logic ( #1954 )
2019-03-03 18:25:39 -08:00
Dmitrii Krasnov
9375d2436f
Fix articles feed not filtering articles by user/organization ( #1941 )
...
* Fix articles feed not filtering articles by user/organization
fix #1940
* add specs for articles fetching in articles#feed controller action
2019-03-02 07:48:55 -08:00
rhymes
996ca23ed1
Simplify ArticlesController#feed ( #1932 )
...
* Simplify ArticlesController#feed
There's unneeded complexity in the logic of the feed method, this way what separates each path should be clearer
* Update app/controllers/articles_controller.rb
Co-Authored-By: rhymes <rhymesete@gmail.com>
2019-03-01 07:32:59 -08:00
Ben Halpern
d33c607211
Add non-mod functionality to /mod ( #1930 )
2019-02-28 11:02:19 -08:00
Ben Halpern
b2e3320ea4
Slight modification in /mod for exp level stuff ( #1929 )
2019-02-28 10:22:30 -08:00
Ben Halpern
532903c688
Add experience level averaging to articles ( #1922 )
...
* Add experience level averaging to articles
* Adjust copy on /mod ratings page
2019-02-28 08:17:29 -08:00
Andy Zhao
1fc33cdd10
Add missing argument for reaction notification ( #1901 )
2019-02-26 09:14:31 -05:00
Ben Halpern
d9e1ab2caa
Fix typo in badge show page and fix unrelated badge missing word ( #1899 )
2019-02-25 16:06:27 -08:00
Andy Zhao
5ace9a5fc9
Organization Notifications ( #1762 )
...
* Add spec for org reaction notification
* Add organization_id to notifications
* Add validations for user and org IDs
* Move comment json_data out of loop
* Use actual column names instead
* Add organization filters
* Remove extra text-align
* Add organization filtering
* Refactor to reduce complexity
* Add receiver argument to handle orgs
* Add has_many notifications for orgs
* Add follow notifications for orgs
* Add comment notifications for orgs
* Rename some tests for specificity
* Add mark org notifications as read functionality
* Add radix to parseInt
* Define json_data outside of loop
* Notify org followers of a new post as well
* Move test to proper location
* Add test for aggregated method
* Make send org reaction notification more readable
* Test the rest of the notification model
* Refactor tag adjustment spec
* Fix extra html
2019-02-25 14:25:37 -08:00
Mac Siri
2e647cedb4
Add more test coverage ( #1829 )
...
* Create github repos request spec
* Create article_mutes_spec.rb
* Create moderation_service_spec.rb
* Create push notification subscriptions spec
* Add PodcastEpisodeDecorator specs
* Remove randomness in test
* Create specs for ArticleWithVideoCreationService
* Update spec/decorators/podcast_episode_decorator_spec.rb
Co-Authored-By: maestromac <krairit.siri@gmail.com>
2019-02-22 09:16:57 -08:00
Ben Halpern
bce0b4fff6
Remove harsh video restriction and add video duration ( #1811 )
...
* Remove harsh video restriction and add video duration
* Fix video meta data and tests
* Modify video tests
* Rescue video duration fetch error
* Change log to puts in test
2019-02-16 17:42:44 -04:00
Jess Lee
49e3878239
Add Stripe Cancellation Webhook ( #1682 )
2019-02-13 15:56:19 -05:00
Jess Lee
7b21a3a5db
Invalidate cache when updating role ( #1786 )
2019-02-13 15:02:20 -05:00
Ali Spittel
4f1a996e6f
Fix tag template issue on editor v1 ( #1793 )
2019-02-13 13:43:41 -05:00
Sean
1acd5b78ef
Display tag moderators on tag page ( #1739 )
2019-02-12 14:58:31 -05:00
Ben Halpern
92b24a9978
Add html_variant split testing to /badge ( #1763 )
...
* Add /badge html_variant
* Fix some of the linting
2019-02-08 12:45:14 -04:00
Ben Halpern
4bff494adc
Ping comments to pre-warm new comment trees ( #1755 )
2019-02-06 21:45:24 -04:00
Ben Halpern
71a419e5ee
Add profile_updated_at and github_repos_updated_at to avoid extra fet… ( #1754 )
...
* Add profile_updated_at and github_repos_updated_at to avoid extra fetches
* Fix variant_number issue
* Fix test
2019-02-06 20:39:15 -04:00
Ben Halpern
7d6c85a294
RSS feed optimizations ( #1752 )
...
* RSS feed optimizations
* Update app/views/articles/feed.rss.builder
Co-Authored-By: benhalpern <bendhalpern@gmail.com>
* Update app/controllers/articles_controller.rb
* Update app/controllers/articles_controller.rb
2019-02-06 20:31:58 -04:00
Ben Halpern
2d97a5d837
Improve performance for additional content boxes and tags index ( #1750 )
...
* Improve performance for additional content boxes and tags index
* Modify followed_articles endpoint with new classic article api
2019-02-06 16:50:35 -04:00
Jess Lee
009001272a
Allow dashboard view for admins and update permissions in internal/users ( #1742 )
...
* allow admins to see dashboards
* add more info to internal users
* add more info to internal users
* add video permission toggle
* specify banished user traits
2019-02-06 13:24:42 -04:00