Commit graph

587 commits

Author SHA1 Message Date
Maksim Litvinov
33db32e5f4 Fix rubocop lints (#794) 2018-10-03 13:00:09 -04:00
Ben Halpern
ff877ec2aa
Fix Stackoverflow regex (#796) 2018-10-02 19:02:25 -04:00
Jack Harner
2b0de7ee04 setting user-select to none on the top-bar profile image (#786) 2018-10-02 11:00:40 -04:00
Ben Halpern
97a8958a87
Rearrange some code to remove unnecessary queries (#787)
* Change harcoded memcache limit

* Rearrange some code to remove unnecessary queries
2018-10-02 10:59:51 -04:00
Frederik Creemers
d5341a9130 Add aria-label to moderation notification buttons. (#789) 2018-10-02 10:59:22 -04:00
Ben Halpern
fecb307bbe
Add ability to create trending tags (#784) 2018-10-01 08:33:53 -04:00
Ben Halpern
7e48a23afa
Ben/add more recent posts to home feed (#775)
* Add meta to sidebar and adjust ranking algo

* Update home feed to show more recent posts from folks you follow

* Only show recent posts on home feed if user signed in
2018-09-30 14:05:59 -04:00
Mac Siri
9f36295c40 Reduce member's page cache size (#764) 2018-09-29 22:20:37 -04:00
Ben Halpern
be11d8fda1
Add meta to sidebar and adjust ranking algo (#766) 2018-09-29 12:58:44 -04:00
Ben Halpern
dffd0218e1
Add user quota to Google Analytics fetch (#765)
* Add page_views_count to articles and track from analytics

* Modification in google analytics fetch

* Chunk article requests in analytics requests

* Fix test

* Fix test in analytics

* Add user quota to Google Analytics fetch
2018-09-28 18:15:33 -04:00
Ben Halpern
e8b05b3a41
Modify Article Analytics Fetch (#762)
* Add page_views_count to articles and track from analytics

* Modification in google analytics fetch

* Chunk article requests in analytics requests

* Fix test

* Fix test in analytics
2018-09-28 16:52:06 -04:00
Ben Halpern
18c5e8718d
Add page_views_count to articles and track from analytics (#761) 2018-09-28 14:33:25 -04:00
Ben Halpern
eae8b6332f
Change various admin pages (#758)
* Change int to float for more granular admin controls

* Change int to float for more granular admin controls

* Add details to /mod for admins
2018-09-27 18:03:49 -04:00
Ben Halpern
4205d50bd8
Make home feed more relevant and varied (#757) 2018-09-27 13:21:51 -04:00
Ben Halpern
b95f8ae028
Add tab for not-buffered today and this week for internal articles (#756) 2018-09-27 12:51:27 -04:00
Ben Halpern
a4ed6dd71a
Modify internal/articles and RSS feed rules/page (#754) 2018-09-26 18:33:37 -04:00
Mac Siri
75aac013bb Remove & replace Article::cached_find (#750)
* Fix lint

* Remove & replace Article::cached_find

with Reaction::count_for_reactable

* Update reaction.rb
2018-09-26 15:55:11 -04:00
Ben Halpern
2517bb555b
Add functionality for buffering to different accounts (#752)
* Create initial buffer updates logic

* Add UI functionality and test for sattelite tweets

* Add additional /mod functionality and re-use script partial in /internal
2018-09-26 15:51:39 -04:00
Peter Frank
90c6731184 Update sponsor' page (#751) 2018-09-26 12:40:02 -04:00
Ben Halpern
cf075d4a9f
Ben/fix authorization edge case (#748)
* Add top param to article tag api

* Fix user validation persistence bug
2018-09-25 18:46:17 -04:00
Ben Halpern
e80bf919fc
Add top param to article tag api (#741) 2018-09-25 15:13:49 -04:00
Andy Zhao
5814d0a263 Add slack notifications to notes for reports (#660)
* Remove extraneous string conversion

* Add slack message for new notes

* Move status and minimize buttons to the bottom

* Add note model spec

* Remove extraneous param for reported links
2018-09-25 14:36:54 -04:00
Mac Siri
c4ccba5691
Add try-catch to runkit (#731) 2018-09-24 18:18:50 -04:00
Andy Zhao
30c1134885 Fix runkit tag logic (#729)
* Fix runkit tag logic

* Remove extra bracket
2018-09-24 16:53:03 -04:00
Mac Siri
32d15f2820 Update test suite configuration (#702)
* Update DatabaseCleaner

* Only retry in CI

* Update rubocop precommit hook

* Update spec

* Restructure spec configs WIP

* Restructure spec configs WIP

* Create OmniauthMacros

* Fix broken spec

* Update spec
2018-09-24 14:40:22 -04:00
Andy Zhao
4456d55635 Add targets.children check for runkit tag(#727) 2018-09-24 12:42:42 -04:00
38elements
e9cbbae5c5 Fix FOLLOWING button (#728) 2018-09-24 11:38:48 -04:00
Andy Zhao
918171131e Add guard clause for loading runkit tag (#714) 2018-09-23 16:22:12 -04:00
Gabriel Lebec
4d673e9601 Support RunKit preamble (#696)
* feat(runkit-tag): support preamble

* chore(runkit-tag): remove unnecessary length check

* docs(editor guide text): add preamble to runkit snippet

* fix(spec/runkit-tag): add preamble code to spec

* fix(runkit-tag): prevent xss attacks

* fix(runkit-tag): prevent race condition
2018-09-21 11:27:42 -04:00
Ben Halpern
160056a19d
Add organization users to sidebar and other org ajustments (#707) 2018-09-20 15:43:43 -04:00
Ben Halpern
2545b8d77f
Modify styling and classes for iOS safari /connect (#701) 2018-09-19 18:25:36 -04:00
Mac Siri
6521545fb3 Improve Comment's email logic (#699)
* Improve comment's email logic

* Change #activity_notify logic

* Update comment_spec

* Remove focus

* Update should_send_email_notification?
2018-09-19 18:20:15 -04:00
Andy Zhao
d8db1be7bd Update billing page with special case (#700) 2018-09-19 17:36:22 -04:00
Andy Zhao
b33156a287 Fix runkit HTML encoding issue (#438) 2018-09-17 16:30:35 -04:00
38elements
69794dfacf Remove unnecessary code in .eslintrc.js (#672) [ci skip] 2018-09-17 16:24:57 -04:00
Peter Frank
b157e221ee Update sponsor page (#688) 2018-09-17 14:40:03 -04:00
Jess Lee
fa3e582973 add ga tracking to onboarding (#653)
* add ga tracking

* Add ga availability check
2018-09-17 12:09:03 -04:00
Benny Powers
ed13283568 Fix glitch embed bug (#683) 2018-09-17 11:40:21 -04:00
Benny Powers
95fe0eeb94 Add glitch embed options in liquid tag (#680)
* Add glitch embed options in liquid tag

* Add glitch embed options in liquid tag
2018-09-17 10:26:02 -04:00
Ben Halpern
e0c7ac970d
Modify reaction bar style (#665) 2018-09-15 13:25:38 -04:00
Peter Frank
9b2bea8576 WIP new sponsor stuff (#650)
New Qlik sponsor stuff
2018-09-13 16:01:59 -04:00
Mac Siri
48bfbf8f9a
Change notification caching logic (#652) 2018-09-13 15:59:51 -04:00
Ben Halpern
8074113663
Revert linting issues (#651) 2018-09-13 15:18:19 -04:00
Andy Zhao
da87fe2e0d Fix YouTube tag (#649)
* Fix YouTube tag

* Remove solargraph from VS Code recommendations

* Update editor guide for more clarity
2018-09-13 14:21:10 -04:00
Den McHenry
cf15295771 Fix table layout in posts (#429)
Three rules overriding table and cell defaults reduce readability of tables by

1. forcing full width irrespective of actual table contents, and
2. setting an arbitrary width of 1000px on each cell.

This seems to be the result of tinkering to improve table aesthetics by filling horizontal space, but this is a common error that seriously [degrades the readability of tabular data](https://alistapart.com/article/web-typography-tables#section2).

The first issue above is a bit confused: the width has been set to `100%`, and display has been set to `block`.

Setting a default table to 100% width will cause the children to adapt accordingly, achieving the desired result. But changing `table` to `block` breaks the relationship so that the children of the table no longer adapt to the full width. (They behave as though an anonymous parent table of the correct display type has been inserted, while the `table` element behaves like a generic block level element. They no longer will the table, though the table is technically full width.)

This probably explains the arbitrary width on data cells. It's set larger than the container, forcing the browser to resolve it against the available space and thus approximate the expected result of a default table with 100% width.

Rather than trying to fill horizontal space, it's better for readability to allow data cells to adapt to the size of their contents. A better option for aesthetics in blog posts on Dev.to is to remove the three rules deleted here that affect table layout and instead set left and right margins to `auto`, so that narrow tables are centered in posts, but wide tables can still extend beyond the normal content width of paragraphs as they do now.
2018-09-13 14:20:33 -04:00
Ben Halpern
dd32580ab1
Make article actions bar sticky (#648)
* Make article actions bar sticky

* Fix article load edge case

* Fix logic check
2018-09-13 13:52:35 -04:00
Mac Siri
f8c08f9325
Refactor StreamRails::Enrich (#647)
* Refactor StreamRails::Enrich

* Refactor StreamRails::Enrich

* Change expiration time

* Add #get_broadcast
2018-09-13 13:49:57 -04:00
Mac Siri
a1efd86e6d Fix typo (#644) 2018-09-12 17:31:47 -04:00
Ben Halpern
eeb408511a
Add extra caching to home query (#643)
* Update home feed logic and display

* Remove console log

* Add extra caching to home query

* Fix conflict
2018-09-12 16:34:10 -04:00
Ben Halpern
91f99036df
Update feed for slightly more customized top articles (#642)
* Update home feed logic and display

* Remove console log
2018-09-12 15:27:54 -04:00