Commit graph

11 commits

Author SHA1 Message Date
rhymes
879864a9bb Improve accessibility score on homepage and article show page (#2740) [ci skip]
* Increase loader text opacity

Low contrast text is not great in general, this also brings Lighthouse score from 88 to 96

* Add some alternative text to images

* Add some aria labels to controls
2019-05-07 09:56:34 -04:00
rhymes
f17d0f34e1 Update framework defaults to match those in Rails 5.1 (#2309)
* Enable all Rails 5.0 defaults, except for CSRF mitigations

* Enable all Rails 5.1 defaults

* Enable per_form_csrf_tokens

* Enable forgery_protection_origin_check

* Avoid replacing the CSRF in the comment form

Each form now has its own CSRF in addition to the global one.
I've left in place the setInterval

* Restore per_form_csrf_tokens to false
2019-04-17 12:21:15 -04:00
Glenn Carremans
d9ee35a421 Fix linting issues in app/views/comments (#1853) [ci skip] 2019-02-25 13:03:31 -05:00
Ben Halpern
d7665fcc3f
Add comment template to post (#1692)
* add myself to the core contributors

* add comment template

* merge upstream

* make sure the template re-appears for top level comments after submission

* make interface admin only

* Adjust comment template form

* Fix merge conflicts

* Remove unnecessary comment template from json
2019-01-30 13:32:34 -05:00
Anna Buianova
8f348f9831 Fix comment cancel button url (#1508) 2019-01-10 12:25:11 -05:00
Ben Halpern
9af401ad09
Remove user signed in difference in article show comment form (#1468) 2019-01-05 22:27:34 -05:00
Jasmeet Singh Saini
908e82cf9e Implement cancel button comment edit (#331) 2018-11-05 13:48:56 -05:00
Nick Karnik
a3649b8d09 Added the ability to press Ctrl+Enter Or Command+Enter to submit comments. (#885)
* Resolves #245
    * This is applied to root level comments as well as nested replies.
    * We are ensuring that user has commented at least once which means
      they have accepted the code of conduct before

Style changes as per suggestions in code review
2018-10-13 14:24:53 -04:00
Mac Siri
4bc9020956 Implement comment preview feature (#223)
* Create #preview endpoint for CommentController

* Create comment preview button WIP

* Implement preview feature for reply comment W

* Style preview button CSS WIP

* Style preview button CSS WIP

* Tweak markdown toggle logic and add styling

* Update comment feature spec

* Add error handling for comment preview & fix lint

* Extract handleCommentPreview into it's own file

* Adjust functionality for comment preview [WIP]

* Modify comment preview functionality and CSS

* Adjust code style based on linter
2018-04-24 14:30:52 -04:00
Mac Siri
18f0003187 Use JSON instead of FormData for comment-creation (#216)
* Use JSON instead of FormData for comment-creation

* Fix lint
2018-04-17 17:32:45 -07:00
Mac Siri
301c6080e3 Initial commit 2018-02-28 16:11:08 -05:00