Commit graph

931 commits

Author SHA1 Message Date
Andy Zhao
2ac05b4c9b Use safe navigation for edge cases (#1632) 2019-01-23 15:31:15 -05:00
Jess Lee
d0b17f2a77 Adds internal/articles input to update author (#1628)
* adds input to change article author

* remove link

* remove unnecessary attribute
2019-01-23 11:58:11 -05:00
Mario See
0a1454dc97 quick css hiccup fix (#1523)
* remove max-width cap on .home

* remove max-width cap on .home

* Revert "Merge branch 'master' into article-css-extra-wide"

This reverts commit 3eff6e456e11f5fc74e30d25d6e01c237c3b0d83, reversing
changes made to 5e064676029f9ce630b5580e46b9d64c6f43e838.

* revert max-width and add max-width to article-show

based on andrew bone's suggestion. looks good thus far both on home and article page in various screen sizes

* Removed a modified file from pull request

* Removed a modified file from pull request

* Removed a modified file from pull request

* Removed a modified file from pull request

* Removed a modified file from pull request

* Update article-show.scss
2019-01-22 16:23:15 -05:00
Michał Krzysztof Feiler
73b909a1fd Add "101010.pl" to Mastodon list (#1612) 2019-01-22 15:37:56 -05:00
Ben Halpern
ff405c0e90
Add occasional random fetches to article page_views_count (#1625) 2019-01-22 14:39:34 -05:00
Andy Zhao
300291ed70 Use proper formats for env hash variables (#1624)
* Use proper formats for env hash variables

* Use .to_s instead of .name
2019-01-22 14:15:50 -05:00
Andy Zhao
9f6d00118f Mute notifications for your own article (#1594)
* Use a slightly faster call for user_id

* Remove unused file

* Test receive notifications functionality

* Notify when receive_notifications is true

* Test receiving reaction notifications

* Do not notify if receive_notifications is false

* Fix test for parent comment notification

* Add article mute notifications feature

* Remove deprecated specs

* Prevent email when receive_notification is false

* Update button messaging

* Use RESTful /article_mutes patch request

* Use parent or root article instead
2019-01-22 13:12:48 -05:00
Ali Spittel
cfd84d73f8 Bug/v2 editor tag typing (#1614)
* Add myself to core contributors

* add myself to the core contributors

* fix to issue 1574 with the V2 editor

* fix tag bug in v2 editor

* fix v2 editor bug

* remove unused code
2019-01-21 18:23:20 -05:00
Andy Zhao
2c2bafa350 Add logging if oauth fails (#1619) 2019-01-21 18:17:36 -05:00
Michał Krzysztof Feiler
5ff204c4ed Add "bsd.network" to Mastodon list (#1611) 2019-01-21 17:39:32 -05:00
Dave Follett
03bdf63ce4 Added the 'initalpath' and 'module' options to the codesandbox embed (#1545)
* Added the 'initalpath' and 'module' options to the codesandbox embed and updated the help page.

* Fixed spelling errors.

* Rework from previous PR: Improved exception text. Improved regex for detecting invalid options. Changed logic to raise an exception if any invalid options are found by moving the exception raising to be inside the valid_option() method.

* Added unit tests for codesandbox_tag.rb.
2019-01-21 17:39:09 -05:00
Mac Siri
77dc803998 Update _article_followable_area.html.erb (#1618) 2019-01-21 16:57:22 -05:00
Ken Bellows
0ce46b637a Fix for issue #1608 (#1609)
Update the regexp in `def valid_option(option)` to match whole tab names in the `default-tab` option instead of just single characters.
2019-01-21 13:55:31 -05:00
Ben Halpern
fe26ad5778
Add additional home page caching (#1610) 2019-01-21 12:45:09 -05:00
Ben Halpern
cc8eaa1e68
Modify side stickies and comment.rb caching/touching (#1599) 2019-01-20 21:09:27 -05:00
Ben Halpern
84e2e79239
Add a couple cache optimizations and query guards (#1598)
* Add a couple cache optimizations

* Fix failed test, add a couple optimizations

* Move if statement inside proper div
2019-01-20 19:57:28 -05:00
Ben Halpern
865a1a6fdf
Remove article collection area caching (#1597) 2019-01-20 17:13:12 -05:00
Ben Halpern
6e4259baaf
Cache collection so it doesn't have to be re-fetched (#1576)
* Cache collection so it doesn't have to be re-fetched

* Update app/views/articles/show.html.erb

Co-Authored-By: benhalpern <bendhalpern@gmail.com>

* Update app/views/articles/show.html.erb

Co-Authored-By: benhalpern <bendhalpern@gmail.com>

* Update app/views/articles/show.html.erb

Co-Authored-By: benhalpern <bendhalpern@gmail.com>
2019-01-20 15:50:57 -05:00
Kyle Boe
36b42b2ccd Feature/spotify liquid tag (#1573)
* WIP spotify liquid tags and specs - #1546

* update naming for clarity

* update for rubocop styling

* drop url support - #1546

* bugfix and add correct heights - #1546

* update specs to reflect url removal - #1546

* update standard error message in spec - #1573
2019-01-20 14:01:33 -05:00
Ben Halpern
c28e3a4d54
Modify cache keys which have low hit rate. (#1596)
* Change worker line in procfile

* mod buildpacks

* Add bin/start-pgbouncer

* Modify procfile

* Remove bin/start-pgbouncer

* Make artice show caching more effective
2019-01-20 12:30:26 -05:00
Anna Buianova
9ccf0a07cb Refactored stories views (#1584) 2019-01-20 11:57:24 -05:00
rhymes
51a9e8be0a Order my tags by weight, popularity and name (#1583) 2019-01-20 11:29:37 -05:00
rhymes
c989cbf301 Super small queries optimizations (#1586)
* Replace find_by().nil? with exists?

find_by asks the DB and the ORM to load the entire object in memory, then it is discarded just know if it exists or not. Exists will just return true or false

* Use present? in lieu of any? when it is proper

A request for any? followed by each in a most likely full collection results in two SQL queries. present? preloads the objects, so it results in one single connection because the objects are already in memory.
2019-01-19 17:28:02 -05:00
Andrew Bone
b56865915c Jsfiddle LiquidTag (#1509)
* Create jsfiddle_tag.rb

Add liquid tag for jsfiddle

* Create jsfiddle_tag-spec.rb

Add liquid tag for jsfiddle

* Update _editor_guide_text.html.erb

Add liquid tag for jsfiddle

* Updates for rubocop

* Edit boilerplate

Change some of the boiler plate code.

* rubocop compliance

* Fixed name

Fixed file name

* Fixed boiler plate

Changed codepen to jsfiddle

* Update guide text

Change the Guide Text to be jsfiddle specific.

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Fixed typo in spec

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Update Valid Link

* Update jsfiddle_tag.rb

* Add Approved html

* Remove double slash

* Revert change

* Fix XSS error

* Remove extra line

* Remove extra slash

* Remove extra slash

* Make DRY

* rubocop compliance

* Change test logic

* Revert test to Approvals

* Fix HTML approved
2019-01-17 15:44:01 -05:00
38elements
c6b09939d9 Remove unnecessary CSS property (#1581) 2019-01-17 12:22:24 -05:00
Dave Follett
6c571e8bcd Fixed bug that allows XSS with the codepen embed. (#1578) 2019-01-17 11:38:39 -05:00
Jess Lee
38091ba486 Update twitter validation and internal/articles query (#1571)
* update validation and only show published articles

* update twitter satellite count

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>
2019-01-16 17:15:22 -05:00
rhymes
5ee725410b Replace data with content in export email copy (#1572) 2019-01-16 17:10:06 -05:00
Ben Halpern
b1f18f5bbc
Improve feed and add more randomness (#1570)
* Improve feed and add more randomness

* Fix tests

* Fix test score calc

* Modify home page test criteria
2019-01-16 16:01:14 -05:00
rhymes
a0c9576bec Export comments (#1471)
* Use name attribute

* Export comments

* Update copy

* Fix time-dependent test

* Remove reactions_count from the export

* Only select needed attributes from the DB

* Add the path of the commentable to the export

Comments are attached to something but from the export that is not easily identifiable. We add the "commentable_path" to give some context.
2019-01-16 12:54:45 -05:00
Ben Halpern
f1e7f12e1d
Reduce queries in bulk follow (#1568) 2019-01-16 12:21:15 -05:00
Jess Lee
5bacb4e8c1 Removed bug reports from app (#1565)
* remove bug report form and add github link

* update abuse report email templates

* remove bug-report logic

* remove emoji from form

* remove revised500 page
2019-01-16 11:28:59 -05:00
Ben Halpern
9736d411d3
Fix get_all_articles in RssReader (#1566) 2019-01-15 22:25:30 -05:00
rhymes
dee7429883 Replace each with find_each for AR queries (#1557) 2019-01-15 16:38:03 -05:00
Ben Halpern
7f7a35048a
Find by title or feed source URL in rss fetch (#1560) 2019-01-15 15:34:13 -05:00
Ben Halpern
47e8fbc9ec
Add feed_fetched_at for users to not refetch unnecessarily (#1555)
* Fix RSS issues by not refetching users as often

* Make rss fetch not forced in rake task

* Remove unnecesary schema line
2019-01-15 13:29:11 -05:00
Ben Halpern
0dac3b9662
Fix search page reading time issue (#1544) 2019-01-14 19:04:02 -05:00
Anna Buianova
53e8490e75 Refactor redirect from the old username or organization slug (#1527) 2019-01-14 18:10:57 -05:00
Ben Halpern
d988bc71f9
Add reading time to articles (#1538)
* add comment template

* merge upstream

* Initial work

* make sure the template re-appears for top level comments after submission

* Small fix

* Fix git issues

* Account for missing reading times

* Add minimal score on sidebar

* Test for page to include min read

* rubocop cleanup

* Mess with test

* Add .to_i after score

* Modify search_score var
2019-01-14 15:58:33 -05:00
Andy Zhao
7726acf157 Update notification's request specs (#1450)
Fixes all the notification request specs that were xited. This should help us feel more comfortable making changes to notifications.

Also made a small (performance?) improvement by using an already defined variable.
2019-01-14 15:20:04 -05:00
Mac Siri
f780e5fbc9 Refactor RssReader (#1537)
* Update RssReader::get_all_articles

* Move RssReader to services

* Create RssReader::Assembler

* Improve RssReader's spec
2019-01-14 14:25:49 -05:00
Andy Zhao
e3f9792b21 Add logging info in case sign in fails (#1519)
* Add logging info in case sign in fails

* Use string interpolation instead

* Remove logger from auth service
2019-01-14 10:01:17 -05:00
Anna Buianova
8610d503a4 Rubocop fixes (#1528) 2019-01-14 09:17:01 -05:00
Jess Lee
aecb0409a2 update unmatched mentor query (#1521) 2019-01-13 16:04:12 -05:00
Arun Kumar
a0d39e15bd Fix braces around hash params Rubocop offense (#1453) 2019-01-11 13:08:45 -05:00
M. Bellucci
a52af3da8b Avoid using meta-programming for solving code duplication. (#1457)
* Add feature spec for twitter login

* Avoid using class eval for solving code duplication.

This change make code easier to change in the future.

* Fix codeclimate issues

* Introduce explanatory methods
2019-01-11 12:00:09 -05:00
Ben Halpern
2fd314e40b
Fix chat css and banish logic (#1515) 2019-01-10 18:09:42 -05:00
Mario See
6ade962480 connect message spacing fix (#1259)
* style changes

* removed detail already in parent class

* Update chat.scss

width assertions

* mobile
2019-01-10 14:33:25 -05:00
Andy Zhao
68807c6df7 Allow Organizations to Update Slug/Username (#1411)
* Close anchor tag typo

* Remove confusing message in profile

* Fix typo in spec

* Add old_slug and old_old_slug fields to org

* Test for check_for_slug_change method

* Add ability for orgs to change slug

* Update copy to match new org language

* Add redirect for organizations with old slugs

* Use less queries for handling org/user redirect

* Use consistent syntax for user creation

* Test for organization slug redirects

* Refactor user article redirect
2019-01-10 14:16:43 -05:00
Andrew Bone
4673496830 SlideShare Liquid tag (#1485)
* Create slideshare_tag.rb

* Create slideshare_tag_spec.rb

* Add slide share

* rubocop compliance

* Still learning

https://ruby-doc.org/core-2.5.1/Regexp.html

* More secure match

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Strip whitespace

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Strip before regex

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Remove latter strip

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
2019-01-10 12:58:16 -05:00