Commit graph

5635 commits

Author SHA1 Message Date
Diego Castillo
ab62d8a0a6
fix(user-profile): remove duplicated 'display email on profile' checkbox (#14506) 2021-08-17 09:35:08 +07:00
Suzanne Aitchison
a6b4d8e91d
Create crayons mobile drawer components (#14495)
* add MobileDrawer component

* WIP begin navigation component

* rough working version complete

* update story to allow for actual navigation

* add component tests

* add docs

* add HTML variants

* add a max width to the drawer
2021-08-16 08:41:26 +01:00
Suzanne Aitchison
c16f94f8da
streamline hover delay for preview card (#14493) 2021-08-13 15:49:02 +01:00
payapula
52346188c4
Fixes #13601 - Storybook redirects off page (#14491) 2021-08-13 08:18:44 -04:00
Siddharth
c5c484408e
Navigation Link: fix regex to allow multiline SVG (#14481)
* Fix regex to check svg. Fixes #14334

* Add tests
2021-08-13 13:46:04 +07:00
dependabot[bot]
f0093c5338
Bump rubocop from 1.18.4 to 1.19.0 (#14489)
* Bump rubocop from 1.18.4 to 1.19.0

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.18.4 to 1.19.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.18.4...v1.19.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Rubocop autofixes

* Manually fix some Rubocop warnings/errors

* How about another coffee, Michael?

* Maybe Rubocop needs a coffee too

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Kohl <citizen428@forem.com>
2021-08-13 13:14:59 +07:00
Suzanne Aitchison
80096f63a7
Add author profile preview cards to feed (#14340)
* Add the preview card to logged out feed initial content

* initialise the initial dropdowns added on the logged out feed

* minor tweak to selector

* flip the follow button and the summary

* add minimal preview card to build article HTML

* WIP: data fetched an inserted into card on logged out feed

* WIP: cards added to logged in feed

* create separate profile preview card component

* small style tweak, import pack on each page that shows feed cards

* rename

* tweak some styling issues

* make sure follow buttons init in cards

* populate all matching metadata placeholders after fetch

* don't render full preview card upfront on logged out feed

* refactors from PR comments

* fix issue in person search results

* remove check for article author link that will be superseded by cypress test for preview card

* Revert "remove check for article author link that will be superseded by cypress test for preview card"

This reverts commit 9b42804ffd0f051891c87293d0b791ed2bb0367f.

* Revert "fix issue in person search results"

This reverts commit 04941e3520c0895212141193b60f2933faed5ca1.

* only show the preview cards on story cards for Posts (not users etc in search results)

* correct display on collections view

* remove link check that will be replaced by cypress test

* tweaks to small issues, add a test for the logged out feed

* add tests for logged in home feed, logged out tag index

* add search test and tag index logged in test

* fixes to preview profile spec

* tweak to followauthor spec

* add cypress test for preview on series page

* use a unique test user for series test

* correct the jsdoc comments

* tweaks following PR review

* allow feed preview cards to reposition

* move to separate file from pack
2021-08-13 10:55:43 +07:00
Thomasbnt.dev
a041e5996e
Edit buttons styles for Templates responses (Mod) (#14468)
* Edit buttons styles for Templates responses (Mod)

* Update comments.scss

* Edit classic CSS buttons to SCSS

* added m-1 to submit buttons

* Deleted CSS class for .response-templates-container and added mb-3 to header

* Add crayons-btn to personal and moderator buttons

* Update app/assets/stylesheets/views/comments.scss

Co-authored-by: rhymes <github@rhymes.dev>
2021-08-12 15:57:36 +01:00
Andy Zhao
517c70c20c
Remove discussion locks prior to deleting an article (#14488) 2021-08-12 10:50:01 -04:00
Richard Hao
228a16f90c
Fix reading list item count issue #14469 (#14471)
* Add cypress to reproduce the issue `Reading list is not reactive`

https://github.com/forem/forem/issues/14469

* Bug fixes: The reading list item count (in the title) isn't reactive

https://github.com/forem/forem/issues/14469

* Fix the cypress test cases

- to test reading list item count

* stylistic changeo

-  extract `itemsTotal` from `this.state`
2021-08-12 16:14:27 +02:00
Suzanne Aitchison
86e4c39e31
Make sure open preview cards don't collapse on scroll (#14482)
* don't close dropdown on scroll if already open

* fix minor alignment issue with author comments
2021-08-12 13:29:51 +01:00
Suzanne Aitchison
5efd72040b
change preview card dropdown position depending on viewport (#14473) 2021-08-11 18:40:11 +01:00
Mac Siri
443e852091
Remove button from allowed tags (#14434) 2021-08-11 10:48:07 -04:00
Suzanne Aitchison
e749626e71
Add horizontal padding on preview card trigger button (#14472)
* tweak trigger button padding on article byline

* tweak padding on comment preview triggers
2021-08-11 12:31:48 +01:00
zeotuan
991f8b4baa
Fix Analytics Dashboard Page missing "Back To Dashboard" button (#14310)
* fix analytic page have no back-to-dashboard button when user have no organization

* resolve conflict with main

* remove dump

* add test for back to dashboard button
2021-08-11 12:57:01 +02:00
Khadija Sidhpuri
3d1727b3a8
Delete tag colors cache on updating tags. (#14427)
* add: article cache on update tag

* minor styling fix

* add: published scope to fetch articles

* update: tag_spec:125 to not fetch articles

* modify: tag.rb:bust_cache to delete server cache

* add: tests to verify cache delete
2021-08-11 12:56:04 +02:00
Suzanne Aitchison
a884c56828
Reinstate skip link on search page (#14463)
* reinstate skip link on search page

* actually commit the tests this time

* use optional chaining

* Revert "use optional chaining"

This reverts commit 921677f425c2e90f272a6e21dc8a8d37f916e0da.
2021-08-11 11:50:49 +01:00
Aayush Gupta
71fd773cf3
Add separate section for article link to improve accessibility in the mod center (#14312)
* Initial structure for article heading insertion

* Fix clashing class names

* Draft: Switch to details element + some logic refactor, some specs failing

* Fix failing specs

* Fix compatibility issues with Safari

* Refactor code

* Shift app logic to id attribute

* Code improvements
2021-08-11 14:30:12 +07:00
Michael Kohl
7e0415c150
Make header fields in profile preview card dynamic (#14454)
* Make header fields in profile preview card dynamic

* Update comment
2021-08-11 09:34:30 +07:00
Jamie Gaskins
ad9f54dad4
Optimize tagged articles under feature flag (#14451) 2021-08-10 15:29:24 -04:00
Jamie Gaskins
4b640077e7
Fix readline key bindings for comments on macOS (#14423)
* Fix readline key bindings for comments on macOS

* Extract OS-specific modifier key check to Runtime

* Add the *actual* OS-specific modifier check

* Only operate on the event if it's a KeyboardEvent

It's the only type of event we care about here.

This commit also changes the `!= -1` to `>= 0` to be more clear about
intent. The `index != -1` is a double negative - it means the substring
"is not not found". Instead, the `>= 0` means "is found".
2021-08-10 12:42:27 -04:00
Jamie Gaskins
b2f529573d
Handle users in Reaction#skip_notifications_for (#14450)
This method previously assumed that a reaction's `reactable` had a
`user_id` attribute, but if the reactable was a User, it wouldn't have a
`user_id`. The user id would just be `reactable.id`.
2021-08-10 10:48:52 -04:00
Michael Kohl
231ce5d3cb
[15-minute fix] Add created_at to listings API response (#14437)
* Add created_at to listings API response

* Add created_at listing attribute to org controller
2021-08-10 08:53:03 -05:00
Ridhwana
940241ac03
chore: use optional chaining (#14460) 2021-08-10 15:39:20 +02:00
Keshav Biswa
b58fdd013b
Comment reaction button accessibility (#14256)
* added aria-pressed to comment buttons

* Added accessibility title

* updated set attribute and text content of aria-title

* removed 'x likes' from svg titles

* Added e2e tests to test behaviour of like toggle button

* changed reaction button's description to save instead of Saved

* Fixed cypress test
2021-08-10 10:20:14 +01:00
Daniel Uber
9f2130ce32
handle openssl errors when checking podcast episode for https (#14439) 2021-08-09 12:52:20 -05:00
Suzanne Aitchison
54e8fd8c8a
Refactor problematic markup for upload image (#13947) (#14431)
* refactor of ImageUploader

* refactor cover image uploader, update tests

* remove custom axe rules

* add cypress tests

* always render the hidden input

* tweaks
2021-08-09 16:00:01 +01:00
Jeferson S. Brito
b61dc606c3
Improve accessibility of top search bar (#14263)
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2021-08-09 09:55:41 -04:00
Suzanne Aitchison
2ccac74ad6
[15 min fix] Left align social icons in nav (#14430) 2021-08-06 13:24:17 +01:00
Fernando Valverde
0b809e1621
[15-min fix] Small tweaks for small screen usage in Admin (#14341)
* first changes

* Trigger CI
2021-08-04 12:21:57 -06:00
Arit Amana
c3eca46c97
Fix spacing of Nav Links in Admin (#14407)
* schema file undelete description

* update with main

* update with origin

* update

* fix nav link spacing in Admin

* fix alignment issues for large position numbers
2021-08-04 11:24:42 -04:00
Suzanne Aitchison
f95841cfbc
[15 min fix] Initialize follow buttons on comment index page (#14416)
* [15 min fix] Initialize follow buttons on comment index page

* add init for newly added comments
2021-08-04 13:05:43 +01:00
Fernando Valverde
e73afa22c7
Take Apple Authentication out of Beta (#12114)
* Removing :apple_auth feature flag and debugging

* Fix tests failing due to nil in Devise initializer

* Remove db/schema.rb changes

* Devise config tweak

* cleaning up

* Fix spec + delete debug logs

* Removes temporary beta_access_providers spec + remove feature flag DUS

* Add test to avoid connecting an existing user with SIWA

* Fix merge conflict mistake + more feature flag cleanups
2021-08-03 15:04:00 -06:00
Ridhwana
4966790512
Add Missing Class Name (#14404)
* fix: update the class name

* feat: update some css
2021-08-03 14:51:05 +02:00
Ridhwana
4337ce9d91
Creator Onboarding Confirmation Page (#14259)
* feat: add a first version of the confirmation page - still a wip

* feat: style the modal properly

* chore: update the text

* chore: update from master

* fix: add the correct text and layout for the feature flagged confirmation email

* feat: use the view_class functionality to assign some css styling to the confirmations class

* feat: add the Forem background

* feat: add some styling to "Click Here"

* feat: polish styles

* feat: the padding will be used for mobile

* chore: some blank lines

* feat: add some more styles

* feat; use media queries

* feat: add a callback to the modal

* feat: handle all javascript on the confirmation form

* feat: change back to a button

* feat; change from button to span for accessibility

* feat: add the callback in an if condition

* feat: add a main-content

* feat: update the confirmation page html

* feat: add Cypress test

* minimal seeded flows

* fix: rename the file

* feat: update confirm email spec

* fix: remove mistake

* refactor: rename the files appropriately

* feat: change some text

* fix: typo

* fix: update as per suggestions
2021-08-03 14:21:56 +02:00
Nicolas Lepage
3e3fd76360
Fix GitHub Readme liquid tag relative URLs (#14352)
* fix: github readme liquid tag broken links in HTML

The relative links contained in the README's HTML are replaced by absolute links.

These absolute links have broken URL's: https://raw.githubusercontent.com/forem/forem/main/#what-is-forem

This commit aims to fix the links with a correct URL: https://github.com/forem/forem#what-is-forem

* Add a test for GitHub Readme with relative URLs

* Fix test for GitHub Readme with relative URLs

* Fix test for GitHub Readme with relative URLs

* Revert "Fix test for GitHub Readme with relative URLs"

This reverts commit 1b38da9132baf72f88303316ab6116eb9175909b.

* Use new cassette for for GitHub Readme with relative URLs test

* Add cassette file for GitHub Readme with relative URLs test
2021-08-02 09:05:35 -05:00
Khadija Sidhpuri
7567e77132
Extract search from StoriesController (#14377) 2021-07-30 10:55:00 -04:00
Michael Kohl
43ccdb31f1
Remove duplicated work display from header / profile work (#14210)
* Remove duplicated work display from header

* Update work profile field handling

* Update DUS + spec

* Delegate more carefully

* Update delegation guard

* Adapt for removed delegation

* Undo accidental schema changes

* Fix seeds

* Remove accidentaly change

* Fix User#processed_website_url

* Update guard clause

* Update profile card content

* Add Organization#profile

* Be more conservative with profile fields

* Spec fixes round 1

* Fix typo

* Update spec

* Limit number of header fields and update card content

* Decorate correct model

* Update factory

* Update schema.rb

* Fix validation

* How bad could this possibly be?

* Pretty bad, nevermind

* Remove obsolete code

* Reset profile fields during test runs

* Move profile fields back to before(:suite)

* Spec fixes

* Remove accidentally re-added files

* More spec fixes

* Specs

* Change User#tag_keywords_for_search

* More spec fixes

* Add comment

* Undo accidental schema changes

* Attempt spec fix

* Remove fix attempt

* Fix e2e test

* Update spec

* Remove guard clause

* Remove outdated guard clause

* Re-add validation

* Update header field validation

* Fix auto-complete fail
2021-07-30 12:28:40 +02:00
Daniel Uber
27059865ca
hotfix comments with link tags (#14382)
* Add a failing test case

Currently fails with the reported error

  expected no Exception, got #<ArgumentError: Requires a Node, NodeSet or String argument, and cannot accept a NilClass.

* Only replace inner html if not nil

`sub!` can return nil and you can't set an XML::Element's content to
nil (coercion fails).

* Use sub rather than sub! since we'll be using assignment

The issue we were seeing was that sub! returns nil when no change was
made, while sub always returns a string (with modificationsn made).

Remove temp variable since it's not needed when we use the other method.
2021-07-30 12:27:51 +02:00
Andy Zhao
5c5d37d648
Update admin welcome checklist (#14261)
* Update admin welcome checklist

* Update invite link text in test

* Remove extraneous invite line and period

* Add overview tracking to all links in checklist

* Fix spec to check for proper link
2021-07-28 14:27:17 -04:00
zeotuan
2e21050f45
fix member dropdown does not remain open on mouseout when click (#14317)
* update-member-dropdown-to-remain-on-mouseout-when-click

* add test for topNavigation

* fix cypress test for member dropdown button

* fix typo, change file name

* use data-attribute isntead of empty class for clicked event

* refractor syntax

* remove unnecessary alias
2021-07-28 10:43:03 -04:00
zeotuan
989bc21b3f
Fix inappropriate landmark nesting dashboard 10873 (#14308)
* change dashboard landmark nesting

* switch to main db/schema.rb

* remove unnecessary div

* revert scema.rb to main

* fix user_visits_dashboard test

* change aside to nav, put nav back into main-content

* remove unnecessary file

* remove duplicate nav

* add id to main

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-07-27 16:03:59 -05:00
zeotuan
7cb42da627
fix nested interactive element (#14314)
* move onclick from div to each button

* remove old test workaround and outdated comment
2021-07-27 19:22:59 +02:00
Jeferson S. Brito
83a36cb80b
Add aria-live announcement to notify users of the route change (#14284)
* Add aria-live to search results

* Add aria-live inside page-content-inner

* Update title variable and aria-live attribute

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-07-27 14:14:45 +01:00
Michael Kohl
30552a5ed8
Update DiscussionLocksController (#14351) 2021-07-27 14:42:14 +02:00
Suzanne Aitchison
75b6c8ed96
Use a single listener for all follow buttons on a page (#14246)
* create new pack, handle user follow buttons, use pack on article page, remove initializeUserFollowButts

* init all follow button types, add pack to tag index and podcast episode pages

* add pack to all relevant pages, listen for newly inserted follow buttons

* change to searchParams to remove follow button initializer calls

* fix bug with tag page, add pack to notifications page

* fix issue with follow back inner text

* update cypress specs

* run the followbuttons code on sponsors page

* remove extra foreach

* add test for follow from article sidebar

* add test for follow and unfollow tag

* add test for the tag index page

* add spec for organisation profile follow

* add tests for follow buttons in search results

* add tests for notification follows

* commit missed file - woops

* show login modal if user is logged out when they click

* add cypress tests for logged out state

* change tag button initialization

* remove data-button-initialized

* init follow buttons from base pack

* handle the case where multiple follow buttons exist on a page for the same user

* account for instantclick and userdata not being defined, lower coverage for jest

* use getInstantClick

* fix issue with set initialisation

* only listen for mutations in areas we know follow buttons may be added dynamically

* small refactors
2021-07-27 10:45:50 +01:00
rhymes
0d58de830b
API: Add reading_time_minutes to /api/articles/me (#14318) 2021-07-26 17:47:50 +02:00
Michael Kohl
7a8f854d2c
Rename User.dev_account to User.staff_account (#14321) 2021-07-26 10:46:26 -04:00
Michael Kohl
813d83a854
Fix constant lookup in Admin::WelcomeController (#14320) 2021-07-26 08:12:47 -06:00
rhymes
e081551dc0
Revert "Clear recent articles cache on updating tags (#14298)" (#14330)
This reverts commit 7159199402.
2021-07-26 11:12:33 +02:00