rhymes
5b62811c98
[deploy] Rubocop: fix violations of Layout/LineLength ( #9197 )
2020-07-08 08:36:36 -05:00
Michael Kohl
fb27f52ed0
[deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) ( #8435 )
2020-07-07 07:37:04 -05:00
icncsx
d15290420f
replace hardcoded twitter hashtag ( #7895 )
...
* replace hardcoded DEVCommunity
* make sure # is a part of the string
* set site config explicity in test for twitter hashtag
2020-05-19 14:02:28 +02:00
rhymes
decae056f1
Routine rubocop fixes ( #7885 )
2020-05-18 10:27:51 +02:00
Ben Halpern
921b2e73b6
Line up params properly in Bufferizer ( #7521 )
2020-04-26 20:51:57 -04:00
Ben Halpern
d447d0cadf
[deploy] Update design and functionality of internal/articles ( #7517 )
...
* Update design and functionality of internal/articles
* Fix spec
* Update specs
* Fiddle with test
* Fix request spec
2020-04-26 18:27:09 -04:00
Ridhwana
a2f1a0049f
Removal of morrrre hardcoded dev.to links ( #7390 )
...
* feat: remove 90% of hardcoded dev.to links now
* chore: update tests
* chore: implement suggested changes
* chore: update url
* chore: update to use URL helper
2020-04-21 11:50:18 +02:00
Jacob Herrington
099b188530
Rename uncommunicative variables ( #3890 )
...
* Clarify uncommunicative variables in labor classes
Single letter variable names are largely a question of preference, in
some cases I think that convention mitigates the opaque nature of single
letter variable names (e.g., e for error, i for index, etc).
However, in some cases they can be unclear and there isn't much reason
to use single letter variables unless for some reason character length is
really important.
In this case, I would prefer clarity in variable names over brevity of
code so I've used Reek to identify short variable names and I'm changing
them.
It's pretty boring, but hopefully incremental code love changes like
this one add up and improve readability and accessibility for those
interested in reading this codebase.
* Remove commented code from 2 years ago
* Clarify uncommunicative naming in services classes
There is some context for this change in 6b81880f
* Clarify uncommunicative naming in models
There is some context for this change in 6b81880f
* Clarify uncommunicative naming in liquid_tags
There is some context for this change in 6b81880f
2019-09-02 13:05:07 -04:00
Ben Halpern
67a8dbcd04
Add hashtags to linkedin body ( #3866 )
2019-08-28 14:49:31 -04:00
Jess Lee
10674aed72
Buffer Listings ( #2956 )
...
* add share to buffer button
* wip
* wip
* adds listings to buffer via form
* create migration for buffered timestamp and update seed file
* display when listing was last buffered
* remove annoying spacing
* refactor article script for listings
* social preview wip
* add custom social card for indivdual listings
* add styling
* fix css
* tweak styling
* final css tweaks
* fix branch
* add buffer listings id
* update envfile
* add social previews spec
2019-06-14 19:33:19 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Jess Lee
38091ba486
Update twitter validation and internal/articles query ( #1571 )
...
* update validation and only show published articles
* update twitter satellite count
Co-Authored-By: jessleenyc <jessleenyc@gmail.com>
2019-01-16 17:15:22 -05:00
rhymes
dee7429883
Replace each with find_each for AR queries ( #1557 )
2019-01-15 16:38:03 -05:00
rhymes
1b60ee5009
Use timezone aware methods ( #893 )
...
* Use timezone aware datetime methods
* Use timezone aware date parse for GitHub issue tag
* Introduce a bit of chaos programming using Zonebie
Zonebie uses a random timezone to run tests, it's a really good way to see if the code is timezone dependent or not.
* Convert GitHub issue date as UTC
2018-10-18 16:26:29 -04:00
Ben Halpern
2517bb555b
Add functionality for buffering to different accounts ( #752 )
...
* Create initial buffer updates logic
* Add UI functionality and test for sattelite tweets
* Add additional /mod functionality and re-use script partial in /internal
2018-09-26 15:51:39 -04:00
Mac Siri
40f488d991
Migrate to Travis CI (part 2) ( #591 )
...
* Update Travis.yml
* Update README
* Update README
* Adjust test to not rely on env vars
* Update encryption
* Refactor
* Update env key
* Stub AWS calls
* Create ApplicationConfig
* Fix specs
* Fix lint
* Update ApplicationConfig
* Remove travis env vars
* Fix lint
* Extend character limit to 100
* Add env to travis
* Take out auto-restart after deploy
* Immediately discarded test cache
* Stub GA in request specs
* Stub Pusher
* Fix broken specs
* Update fixture
* Add CodeClimate id
* Change CodeClimate key
* Remove merge mistakes
* WIP
* Add Envied gem & Change README
* Add missing keys
* Add missing key
* Update fixture
* Fix broken spec
* Add Slack Notification for Travis
* Fix wording
* Fix typo
2018-07-20 20:17:18 -04:00
Ben Halpern
dfe93e5509
Fix twitter length issue in bufferizer ( #390 )
2018-06-05 12:29:25 -04:00
Mac Siri
301c6080e3
Initial commit
2018-02-28 16:11:08 -05:00
