* Fix Prop Types Error #14837
Fixed prop types errors for Button, ButtonGroup, Modal and articlePage
* #added some checks into default children props
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
* use the dropdown initializer in post editor options
* use dropdown initializer in comment subs dropdown
* use Dropdown component in listings
* show the dropdown button when it's focused
* update storybook notes and components
* add cypress tests for post options dropdown
* add comment subscription tests
* make sure page is properly initialized before setting button functionality
* add jsdoc comments, props types, rely on optional chaining
* Update app/javascript/crayons/Dropdown/__stories__/dropdowns.md
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/javascript/crayons/Dropdown/__stories__/dropdowns.md
Co-authored-by: rhymes <github@rhymes.dev>
Co-authored-by: rhymes <github@rhymes.dev>
* Add logic to subscribe button that shows login modal if user is not logged in
Pass in userstatus to CommentSubscription
Remove logic that loads comment subscription button for logged-in users only
* Modify test to account for new userStatus input in CommentSubscription
* Change UserStatus to isLoggedIn
Add propType to isLoggedIn
Remove preventDefault from click event
* Fix indentation and input on commentSubscription test
Create new isLoggedIn variable that returns boolean
Replace all instances of userStatus to isLoggedIn
Create test for showLoginModal when subscribing
* Convert index.jsx to index.js as they are just barrel files.
* Removed prop types and eslint configs from code coverage.
* Using <root_dir> in test ignore patterns now.
* Added app/javascript/storybook-static to eslint's ignore list.
* Now .storybook is excluded from code coverage.
* Bumped coverage thresholds
* Fixed to <rootDir>
* Added story sorting to Storybook.
* Added design system guidelines.
* Made Base in Storybook tree 2nd in the tree view.
* Now Components are 3rd in the treeview of Storybook.
* Now App Components are 4th in the treeview of Storybook.
* Froze node version to 12.16.0
* Revert "Froze node version to 12.16.0"
This reverts commit 093b119c7d7ca05ecb4e1c0234b24bcf8e7b10a4.
* wip
* Right aligned the comment subscription panel.
* Cleaned up the comment area on the article page so it uses crayon margin classes.
* Updated tests
* Removed old UI for comment subscriptions.
* Made Discussion text bigger and bolder.
* Fixed some layout issues as per PR comments.
* Fixed some layout issues as per PR comments.
* Updated Storybook stories, tests and snapshots
* wip
* Everything works now, just need to integrate snackbar.
* Removed setTimeout I was debugging with.
* Using the new utilities/http/request utility now.
* Added the <SnackbarPoller />
* Now when unsubscribed, the subscription type resets to all comments.
* Removed overflow hidden from .home CSS class so comment subscription component displays properly.
* Now unsuccessful subscribes/unsubscribes error properly.
* Changed button text from Done to Subscribe
* Merged the <SnackbarPoller /> component into the <Snackbar /> component.
* Fixed a propType issue.
* Fixed a test.
* Removed snackbar tests for now. Need to figure out polling in tests.
* Now comment subscription component is only loaded for logged on users.
* Added a comment.
* Updated some storybook stories.
* Fixed a small formatting issue.
* Reduced snackbar item lifespans to 3 seconds.
* Extracted <CogIcon /> to it's own file because other features are going to need it.
* Added some Storybook stories and tests for the <CogIcon /> component.
* Revert "Extracted <CogIcon /> to it's own file because other features are going to need it."
This reverts commit b30406a50e491c53c3dce5be03bcdf8112b043df.
* Put back <CogIcon /> component.
* Added some error handling if the component doesn't load.
* Moving some things around.
* Rename the article pack file.
* Changed wording from "article" to "post".
* Fixed false negative CSS issue. It was a dangling div tag.
* Add the option to add an optional close button to snackbar items.
* Fixed z-index of subscription type options panel so it is always visible on mobile.
* Reworked the comment subsciption utilities a bit.
* Added test for comment subscription utilities.
* Fixed a broken test from a refactor.
* Added more tests for comment subscription utiltities.
* Fixed comments footer bottom padding.
* Fixed issue with stale find in comment subscription test.
* Update app/javascript/packs/articlePage.jsx
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
* Update app/assets/stylesheets/article-show.scss
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
* Changed close button wording to Dismiss.
* Fixed padding to use utility variable instead.
* Added missing import for SASS file.
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
* Created the <RadioButton /> and <FormField /> components.
* wip
* Now variant for a <FormField /< is optional
* Added the name prop to the <RadioButton /> component.
* Added the onClick prop to the <RadioButton /> component.
* Updated <CommentSubscription /> component with new subscription functionality.
* Added some tests.
* Fixed a bug found be tests I added.
* Reenabled a skipped test.
* Replaced a string with a constant.