Fernando Valverde
7845423bb9
Remove :runtime_banner feature flag ( #13662 )
...
* Removes :runtime_banner feature flag + repositioning
* Switch to https://udl.forem.com + fix spec
* Fix URL specs
* Adds data_update_script to remove feature flag
* Fix banner overlay on reactions for small screens + iPad max width
* Append -only to Runtime Filter CSS
* Add import to fix assets:precompile
* Implement design update
* Apply suggestions from code review
Co-authored-by: Lisa Sy <lisasyis@gmail.com>
* Add ;
* Trigger Travis
Co-authored-by: Lisa Sy <lisasyis@gmail.com>
2021-05-28 15:10:15 -06:00
Michael Kohl
6dfabd578f
Rename SiteConfig to Settings::General ( #13573 )
...
* Rename SiteConfig
* More renaming
* Update spec
* Update mandatory settings mapping
* More renaming
* e2e test fixes
* You have a rename, and you have a rename
* Spec fix
* More changes
* Temporarily disable specs
* After-merge update
* Undo rename for migration
* undo rename of DUS
* Fix DUS
* Fix merge problem
* Remove redundant DUS
* Fix specs
* Remove unused code
* Change wrong class name
* More cleanup
* Re-add missing values to constant
* Fix constant
* Fix spec
* Remove obsolete fields
* Add accidentally removed field
* Update spec
* Move methods from Settings::General to ForemInstance
* Remove unneeded model
* Change mentions of 'site config'
2021-05-21 14:45:37 +02:00
Jamie Gaskins
bcc42a130d
Sanitize tag urls ( #13720 )
...
* Sanitize tag URLs
For tags with non-ASCII names, we were generating busted URLs, which
would then cause errors. This commit fixes that particular error by
generating usable URLs.
* Use URL generator that will sanitize tag names
* Remove path prefix when using a URL generator
2021-05-11 11:21:03 -04:00
Fernando Valverde
affc704c9b
Runtime Banner for Mobile Deep Linking ( #13190 )
...
* First version using custom schemes for iOS
* Starting to take shape with /r/mobile redirect page
* Wording and aasa
* Adds e2e tests
* Trigger CI
* Tweaks to AASA
* Uses external pivot domain to trigger Universal Links
* Add missing external domain deep link
* Fix test by enabling runtime_banner only in E2E tests
* Fix URL encoding mismatch in Cypress test
* banner sttyling
* Cleanup unrelated changes
* Add AASA tests + remove lingering Gemfile.lock changes
* Fix cypress test
* Remove unnecessary window global assignment
* Trigger Travis
* Replace querySelectorAll with querySelector
* Apply suggestions from code review
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Refactor inline comments, extract URL.deep_link logic and other review feedback
* Small tweaks
* Remove untrusted user-provided redirect (CodeQL suggestion)
* Fix failing tests
* Whoops - another test fix
* Use Forem's UDL server
* Extract timeoutDelay and add comment clarifying
* Add target='_blank' to deep link
* Add TODO comment for replacing hardcoded identifiers
* Apply suggestions from code review
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Add a11y attributes
Co-authored-by: Paweł Ludwiczak <ludwiczakpawel@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-04-23 15:45:34 -06:00
Alex
94cd9e246f
[deploy] Add default for main_social_image ( #11126 )
...
* Add default for main_social_image
* Fix image URL and add spec
* Fix spec
* Move image_url helper into image module
* Fix typo in comment
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Change URL helper logic
* Try something else
* Use ApplicationConfig
* Refactor
* Try again
* Try again with another approach
* Add specs for URL.local_image
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-10-29 10:07:14 -04:00
Jacob Herrington
d479834344
Do not set SiteConfig values in specs ( #11125 )
2020-10-27 15:56:31 -04:00
Ben Halpern
3a469a99e2
[deploy] Enable admin-configured app_domain ( #10206 )
...
* Move app_domain from env var to siteconfig *within app area*
* Fix SiteConfig
* Don't change URL.domain yet
* Not use in fastly cache purge yet
* Session store magoo
* Revert domain issue
* Add SetCookie middleware
* Temporarily remove cookie middleware and release tasks
* Re-enable SetCookieDomain
* Add some more comments, get it ready for testing
* Remove host from url options and temporarily show errors
* Allow forwarded host to be cookie
* Fix typo
* Change invalidAuthenticityToken
* Properly set app domain
* Proper Fastly cache
* Remove config.app_domain
* Remove config.app_domain
* Explicitely set remember_user_token
* More play with cookies
* Fiddle with remember_user_token
* Add remember_user_token changes
* Monkeypatch devise
* Sessions controller
* Include rememberable
* Include rememberable
* Proper cookie monkeypatch
* Proper cookie monkeypatch
* Proper cookie monkeypatch
* Remove extra cookie code
* User sign in tweak
* Close the loop
* Experiment with carrierwave public_url
* Finalize carrierwave monkeypatch
* Remove async controller specs
* Change some tests
* Update domain test
* Remove temporary production.rb change
* modify cookie logic
* Remove unneeded changes
* Remove unneeded changes
* Explicitely pass host
* Fix linting
* Fix social image test
* Add some cookie tests
* Modify article url
* Fix canonical urls
* Fix typo
* Remove sessions controller
* Remove devise monkeypatch
* Add monkeypatch
* Remove elsif
* Update spec/helpers/application_helper_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Adjust remember_cookie_sync
* Remember user token experimentation
* Fiddle with devise
* Properly configure devise
* Fix typo
* Fix formatting issue
* Add comment about middleware
* Fix typo
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Remove commented-out code
Co-authored-by: Michael Kohl <citizen428@dev.to>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-09-11 09:38:34 -04:00
Josh Puetz
7d4a7cc883
[deploy] Change lingering /internal paths to /admin ( #9673 )
...
* Change lingering `/internal` paths to `/admin`
* Fix multiline test expectation
2020-08-07 19:52:39 -04:00
Ben Halpern
3f61cce32b
[deploy] Render json+ld as proper json ( #7404 )
2020-04-21 14:16:21 -04:00
rhymes
f2b0be2043
Add Slack messengers: part 2 ( #6916 )
...
* Add Slack::Messengers::ArticlePublished
* Add Slack::Messengers::ReactionVomit
* Add Slack::Messengers::CommentUserWarned
* Add missing URL helpers
* Add Slack::Messengers::ArticleFetchedFeed
* Remove callback condition
* Build, don't create
2020-04-03 17:00:06 +02:00
Ben Halpern
e35d55c422
Add pagination to tag pages for better SEO crawling ( #6771 ) [deploy]
...
* Add pagination to tag pages for better SEO crawling
* Modify system specs
* Add some tests
* Finalize tests
* Fix things up
* Add url helpers
2020-03-27 10:34:42 -04:00
rhymes
cfb64a1c68
Add URL module and article_url, user_url helpers ( #6833 )
...
* Add AppURL with .article and .user
* Use URL.url and URL.user
* Add article_url and user_url helpers
2020-03-25 13:54:45 -04:00
