Commit graph

357 commits

Author SHA1 Message Date
Anna Buianova
7f6e0cf185 Fix ActiveRecord::RecordNotFound in Delayed::Jobs on article destroy (#1699)
* fixed `ActiveRecord::NotFound` issue for articles, on article destroy
* extracted ActiveJobs from article callbacks
* added specs for article and reaction deletions
2019-02-07 16:57:17 -05:00
Ben Halpern
152f4a52ea
Remove unnecessary queries (#1717)
* filter unnecessary queries

* Adjust article query in a couple places

* Replace tagged_with in main tag query

* Cache_tagged_with additional queries

* Modify test

* Modify cached_tagged_with to account for single tags

* Add cached_tagged_with in a few more places
2019-02-02 21:40:34 -04:00
Ben Halpern
7c7c39149c
Modify cache keys for well-trafficked views. (#1681)
* Add cache to sidebar sticky to make it stick longer

* Add last_article_at and last_comment_at

* Clean up schema.rb
2019-01-29 13:27:22 -05:00
Ben Halpern
d988bc71f9
Add reading time to articles (#1538)
* add comment template

* merge upstream

* Initial work

* make sure the template re-appears for top level comments after submission

* Small fix

* Fix git issues

* Account for missing reading times

* Add minimal score on sidebar

* Test for page to include min read

* rubocop cleanup

* Mess with test

* Add .to_i after score

* Modify search_score var
2019-01-14 15:58:33 -05:00
rhymes
6553f08d94 Rubocop cleanups (#1415)
* Update rubocop-todo.yml with new violations

* Fix Layout/EmptyLine* rules

* Fix Layout/Indentation* rules

* Fix remaining Layout/* rules

* Fix Lint/DuplicateMethods by removing unused accessor

* Fix Lint/IneffectiveAccessModifier

* Fix Lint/MissingCopEnableDirective

* Re-run rubocop auto gen config

* Fix Layout/RescueEnsureAlignment

* Fix Naming/* rules

* Fix some RSpec/* rules

* Fix typos

* Fix RSpec/LetBeforeExamples

* Series should only be an attr_writer, not an attr_accessor

* Fix RSpec/InstanceVariable

* Fix RSpec/InstanceVariable

* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample

* Fix Style/ClassAndModuleChildren

* Fix Style/ConditionalAssignment

* Fix some Style/* rules

* Trigger Travis CI build because failing tests are not failing locally

* Revert "Fix Style/ClassAndModuleChildren"

This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Jibran Kalia
f569f33e4f [WIP] Really simple calculate reading time function (#1283)
* Really simple calculate reading time function

* Move parse_it so that the number of methods in MarkdownParser is at 20

* Added test and default value for reading time
2018-12-09 13:42:32 -05:00
Ben Halpern
6b96201265
[WIP] Allow mods to remove tags and send user notification (#1252)
* Initial tag adjustments

* Finalize tag adjustments and tag adjustments controller

* Fix schema.rb

* Finalize tag removal logic

* Adjust edge cases/tests for tag adjustment moderation

* Adjust tag adjustments spec
2018-12-04 16:45:32 -05:00
Jess Lee
e36cf51a9e Refine Banish User (#1168)
* add banish user test

* refactor banish user wip

* banish user wip - bust comment cache synchronously

* add more spec scenarios

* Update Banish#strip_user_profile

* Refactor specs
2018-11-21 16:55:26 -05:00
Andy Zhao
2db2dd1e5a WIP Refactor/notifications (#1131)
* Add new columns to notifications table

* Remove stream from notifications and add new methods

* Turn off moderation comment notifications

* Add notifiable_type index to migration

* Stop creation of Stream-based notification model instances

* Add notification model create hooks

* Add badge achievement notification creation hook

* Fix some specs

* Add missing @ symbol

* Fix for tests and rename a few things

* forgot to uncomment code sigh
2018-11-19 16:09:02 -05:00
Ben Halpern
8b1755a2b3
Add organization to feed and adjust page styling (#1089)
* Add organization to feed and adjust page styling

* Add conditional indexing to article agolia

* Early return in algolia org logic

* Make org optional in algolia

* Modify org cta styling
2018-11-12 12:28:51 -05:00
Ben Halpern
1aa8e70a5b
Allow removal of collection element (#1036)
* Allow removal of collection element

* Update tests
2018-10-29 15:14:13 -04:00
Ben Halpern
359cc71b64
Add ability for users to publish series (#1034) 2018-10-29 13:04:42 -04:00
rhymes
1b60ee5009 Use timezone aware methods (#893)
* Use timezone aware datetime methods

* Use timezone aware date parse for GitHub issue tag

* Introduce a bit of chaos programming using Zonebie

Zonebie uses a random timezone to run tests, it's a really good way to see if the code is timezone dependent or not.

* Convert GitHub issue date as UTC
2018-10-18 16:26:29 -04:00
Ben Halpern
384c5ce8ae
Update internal/articles to have faster buffer controls (#839) 2018-10-05 18:22:50 -04:00
Ben Halpern
ecb9645775
Make changes to editor (#837)
* Make changes to editor

* Make minor fixes and console log removals

* Fix test in article form

* Adjust rspec test
2018-10-05 16:03:06 -04:00
Ben Halpern
7e48a23afa
Ben/add more recent posts to home feed (#775)
* Add meta to sidebar and adjust ranking algo

* Update home feed to show more recent posts from folks you follow

* Only show recent posts on home feed if user signed in
2018-09-30 14:05:59 -04:00
Mac Siri
75aac013bb Remove & replace Article::cached_find (#750)
* Fix lint

* Remove & replace Article::cached_find

with Reaction::count_for_reactable

* Update reaction.rb
2018-09-26 15:55:11 -04:00
Ben Halpern
2517bb555b
Add functionality for buffering to different accounts (#752)
* Create initial buffer updates logic

* Add UI functionality and test for sattelite tweets

* Add additional /mod functionality and re-use script partial in /internal
2018-09-26 15:51:39 -04:00
Ben Halpern
91f99036df
Update feed for slightly more customized top articles (#642)
* Update home feed logic and display

* Remove console log
2018-09-12 15:27:54 -04:00
Andy Zhao
79d8661ccc Increase #cache_tag_list limit (#436)
* Update error message for single tag length

* Increase cached_tag_list length to match tag length limit
2018-08-22 14:17:58 -04:00
Andy Zhao
4b3951cfb2 Silence cache logs and fix a small bug (#370)
* Test that async_score_calc only changes ratings if published

* Run async_score_calc only if an article is published

* Turn delaying jobs back on after tests run
2018-08-18 16:57:57 -04:00
Tsukuru Tanimichi
73d73f49c6 Remove require 'nokogiri' (#316) 2018-08-13 17:16:41 -04:00
rhymes
e588fa7ece Code cleanups (#659)
* Initial automatic cleanup with rubocop

* Fix syntax error introduced by rubocop

* Cleanup seeds file

* Cleanup lib folder

* Exclude bin folder because it contains auto generated files

* Make Rubocop a little bit more chatty

* Block length should not include comments in the count

* Cleanup config folder

* Cleanup specs

* Updated Rubocop version and generated a todo file

* Fix broken ArticlesApi spec

* Fix tests

* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Mac Siri
0f3342bcec [WIP] Implement non front-matter editor (#415)
* Create alternate editor

* Install linkstate (?)

Not sure how it disappear in the first place

* Run yarn install

* Modulize ArticleForm component

* Refactor

* Isolating css WIP

* Implement simplified frontmatter-less editor

* Modulize individual form element

* Ajust props names

* Transform json params to snakecase

* Remove codes

* Update /new, almost there for release

* Fix editor resize issues

* Change defaultvalue to value in article form tag element

* Modify html buttons in article form
2018-07-27 20:12:33 -07:00
Mac Siri
379829719f Misc DX improvement (#621)
* Add updated rack env keys

* Tone-down rack-timeout config

* Avoid cl_image_path in development

* Update README & create env var template

* Update Travis notification config

* Expand Seed file

* Manually-set Rack-timeout config vars

* Fix lint

* Fix Typo(?)

* Add ChatChannel to Seed

* Disable fbq when not in production

* Tweak after_deploy script

* Fix condition

* Change fbq clause
2018-07-25 22:08:17 -07:00
Arun Kumar
876c70d2bb Minimize creation of CacheBuster objects (#599) 2018-07-24 10:30:30 -07:00
Ben Halpern
e4bb8d7823
Modify timeout and make some queries more efficient (#593)
* Modify timeout and make some queries more efficient

* Only query podcasts if user signed in

* Remove unnecessary columns selected in boosted query etc.
2018-07-19 11:55:59 -04:00
Ben Halpern
75d3a79c12
Add search_keywords record and associated functionality (#494)
* Add search_keywords record and associated functionality

* Fix test and add badge rewarder method
2018-06-25 11:58:07 -04:00
Ben Halpern
0941b2e4fb
Add some tests around model validations (#459)
* Modify sample_application.yml and write test

* Add ahrefs verification

* Add some tests around model validations

* Indent an end

* Add a few tests

* Add tests and reserved words

* Fix live articles spec typo

* Modify ga_events_controller
2018-06-20 17:14:08 -04:00
Andy Zhao
cfd95a65af Update "Connect Twitter acct" in settings with new callback url (#439)
* Update "Connect Twitter acct" in settings with new callback url

* Remove name from comments (#437)
2018-06-15 12:52:14 -04:00
Mac Siri
dd958ba40c Move custom TagParser into lib (#399) 2018-06-08 13:44:52 -04:00
Ben Halpern
ab85216621
Update chat and modify article score calc indexing (#395) 2018-06-06 16:08:12 -04:00
Ben Halpern
fa39ef7729
Add check for published before fetching social image (#381) 2018-06-04 15:02:13 -04:00
Ben Halpern
3afb158ed2
Add additional boosted tags to articles (#371) 2018-05-31 15:28:05 -04:00
Ben Halpern
75573fd183
Fix algolia too-large-index issue (#344)
* Take darker of user colors

* Fix algolia too-large-index issue
2018-05-23 10:56:15 -04:00
Ben Halpern
c36c7d8d28
Update default social cards (#341) 2018-05-22 15:40:42 -04:00
Ben Halpern
cd4d5e9fcb
Improve and finalize video upload (#303) 2018-05-10 11:57:39 -04:00
Andy Zhao
f1cd542427 Add follow tracking for orgs with working follow (#300) 2018-05-10 09:54:46 -04:00
Ben Halpern
0b6d850ac1
Add video state column and change endpoint (#286) 2018-05-07 16:34:59 -04:00
Ben Halpern
f2101410ea
[WIP] Improve article boosting abilities and insights (#237)
* Update email subjects split test

* Create alternate editor

* Add proof of concept to emails

* Add utm for internal nav

* Add ability to boost in DEV Digest

* Adjust articles.scss

* Adjust article_form.scss

* Remove unnecessary files

* Remove files from PR

* Adjust boosted email settings

* Conditionally include organization in additional box

* Modify schema.rb
2018-05-02 12:24:54 -04:00
Ben Halpern
870325677e
Add user articles to sidebar (#253)
* Add user articles to sidebar

* Add organization save-all functionality
2018-04-27 17:44:30 -04:00
Ben Halpern
936a724ead
Update sidebar to add links and challenge (#207)
* Update sidebar to add links and challenge

* Add link on latest podcast sidebar header

* Add hover underline to sidebar widget links
2018-04-13 13:12:35 -07:00
Ben Halpern
27bc174753
Add sponsors and a couple small changes (#166) 2018-04-02 14:47:34 -04:00
Ben Halpern
74664ddf33
Fix last_comment_at logic (#99)
* Limit Google Optimize to 35% of loads

* Fix last_comment_at logic
2018-03-18 15:15:07 -04:00
Ben Halpern
6938f3b78e
Fix last_comment_at issue (#94)
* Fix last_comment_at issue

* Fix classic article test
2018-03-17 14:40:56 -04:00
Ben Halpern
c1e623ebc2
Add additional content boxes under posts (#86)
* Add additional content boxes under posts

* Fix issue with classic article for under content
2018-03-16 16:35:54 -04:00
Ben Halpern
4c22bec6a0
Adjust crosspost and date display rules (#82)
* Adjust crosspost and date display rules
2018-03-15 11:55:46 -04:00
Ben Halpern
fd138eb420
Fix published_at sorting algolia article (#81)
* Fix published_at sorting algolia article
2018-03-13 20:09:20 -04:00
Ben Halpern
9354c8fd8b
Add Eli5 tabbing logic (#77)
* Add tabs for chronological filtering

* Add Algolia filtering

* Fix infinity typo

* Fix algolia index on tabbing

* Add readable publish date across all posts

* Add eli5 logic for tabbing
2018-03-13 13:13:03 -04:00
Ben Halpern
6a16fee77a
Add Algolia filtering (#72)
* Add tabs for chronological filtering

* Add Algolia filtering
2018-03-13 12:14:27 -04:00