Commit graph

218 commits

Author SHA1 Message Date
Mac Siri
0cc9cc0250
[CI] Resolves compiled-assets caching issue (2) (#20837) 2024-04-03 17:48:51 -04:00
Mac Siri
d84b0a9f66
[CI] Resolves compiled-assets caching issue (#20836) 2024-04-03 15:01:24 -04:00
Mac Siri
e22e6284e4
[CI] Re-arrange create-cache.yml (#20829) 2024-04-02 18:26:03 -04:00
Mac Siri
23b9516d5b
Update CI's compiled-assets' cache-key (#20827) 2024-04-02 17:32:43 -04:00
Mac Siri
81aa7861b1
Resolve knapsack-cypress's issue with forks (#20824) 2024-04-01 17:12:52 -04:00
Mac Siri
b0cc94e655
[CI] Update cleanup-cache action (#20788) 2024-03-21 18:24:40 -04:00
Mac Siri
6f7c39dd40
[CI] Remove node_module cache (#20746) 2024-03-07 14:55:05 -05:00
Mac Siri
6dc49e8d0d
[CI] Simplify setup steps (#20742) 2024-03-07 12:55:30 -05:00
Mac Siri
e817378413
[CI] Add cache creator (#20740) 2024-03-06 15:04:30 -05:00
Mac Siri
0ac81957ea
Update CI.yml (#20624) 2024-02-13 17:05:50 -05:00
Mac Siri
05f75c396e
Update to codecov-action@v4 (#20606) 2024-02-08 16:37:02 -05:00
Mac Siri
afa73e06e3
Replace Webpacker with Esbuild (#20470)
* Migrate to esbuild WIP

* Add exclude

* Remove redundant file

* Move file

* Move to javascript_include_tag

* Lint fix

* WIP

* WIP

* Add watch mode to esbuild WIP

* Get jest working

* Remove babel

* Revert "Remove babel"

This reverts commit 6da35260aa19d6f97f586deb66c0ecaf48433b73.

* More WIP

* Got image to load

* WIP

* Resolve audit

* Lint fix

* WIP

* Fix jest spec

* [CI] Remove asset-restore for test build stage

* Production compliant

* Temp disable sourcemap

* Update glob

* Add esbuild helper to stimulus

* Import fragment

* Temp disable coverage to see failing tests

* Fix broken spec

* Address lint

* Set proper es6 target

* Use esbuild for everything

* wait what

* Revert "Set proper es6 target"

This reverts commit 98f5278093421baa8ffe2ca580845b01c1a1eadf.

* Revert "Use esbuild for everything"

This reverts commit 0ac46738f07ffcb6af095ccb1ffa5e439b7fefa3.

* Replace uglifier with terser

* New compiled assets version

* Remvoe honeybadger-io/webpack

* Remove cypress coverage checks for now

* Update jsconfig.json

* Update docker-compose

* Remove public/packs-test from ci cache
2024-01-25 20:29:21 +00:00
Adam Vollrath
cbd1d95848
GHA Workflows: Sanitize user input from fork workflows. (#20466)
* Improvements to Uffizzi Preview Workflows.

Signed-off-by: Adam Vollrath <adam.d.vollrath@gmail.com>

* Also unzip the rendered compose file.

Signed-off-by: Adam Vollrath <adam.d.vollrath@gmail.com>

---------

Signed-off-by: Adam Vollrath <adam.d.vollrath@gmail.com>
2023-12-21 12:56:02 +00:00
Mac Siri
d249d3989b
Consolidate dockerfile (#20460)
* Consolidate dockerfile

* Specify dockerfile target for uffizzi

* Syntax error

* Specify target in the right location
2023-12-20 14:47:03 +00:00
Mac Siri
59ee1461a4
Upgrade to Node 20 (#20424)
* Upgrade to Node 18

* Run audit fix to resolve node 16 openssl issue

* Update babel.config.js

* Replace node-version with node-version-file

* Add NODE_OPTIONS

* Specify major version only

* Try setting locally instead

* Try custom hashFunction

* Trying two things at once

* Try without legacy option

* Add back openssl-legacy-provider

* Add resolution for terser-webpack-plugin

* Use older terser-webpack-plugin

* Revert changes to CI

* Add compression-webpack-plugin to resolution

* Use new node_module cache

* Add NODE_OPTION in build_test

* Maybe remove redundant label

* Upgrade storybook

* Update bin/webpack

* Revert "Upgrade storybook"

This reverts commit fca3fb5c8718786b7db20538c5c4ae6cf44b45b8.

* Remove unnecessary change

* Update yarn.lock again

* Now try with Node 20

* Upgrade Node module cache CI

* Lint

* Update base image sha
2023-12-15 14:27:36 +00:00
Mac Siri
a0232a5f02
Extend retry time for code-coverage upload (#20373) 2023-11-21 08:52:06 -05:00
Mac Siri
4a9a08b81d
[CI] Make CLAAssistant reusable (#20359) 2023-11-15 13:38:29 -05:00
Mac Siri
5f89bc33ed
Enable merge queue (#20348) 2023-11-14 08:32:46 -05:00
Mac Siri
6d6e042465
[CI] Move CLA allowist to env var (#20340) 2023-11-10 09:00:45 -05:00
Mac Siri
f46f8ef804
Update CLA workflow (#20336) 2023-11-09 12:53:44 -05:00
Mac Siri
c479a08ad4
Migrate to contributor-assistant (#20333) 2023-11-09 07:23:45 -05:00
Mac Siri
b68a8b253c
Update CI's jest reporters (#20281) 2023-10-26 15:29:35 -04:00
PJ
67bb7a6e76
Revert "Bump sidekiq and sidekiq-unique-jobs dependencies in tandem" (#20132) 2023-09-18 13:27:08 -04:00
Mai Irie
9332ef7123
Reduce Codecov's patch target to 60% (#20095)
* Reduce Codecov's patch target to 50%

* Update codecov.yml

After internal discussion, settled on 60% as the floor for the baseline.

* Code Cov note in PR template
2023-09-15 13:31:22 -04:00
Mac Siri
40122a5c5c
[CI] Use actions/checkout@v4 (#20045) 2023-09-05 11:43:11 -04:00
Josh Klar
b58ab2fe37
ci: Fix base image builder... the right way... (#19889) 2023-08-03 13:55:29 -04:00
Josh Klar
5903372e1a
ci: Allow workflow_dispatch runs to log in to GHCR. (#19885) 2023-08-03 10:38:18 -07:00
Josh Klar
0150887926
ci: Allow workflow_dispatch runs to push to GHCR. (#19884) 2023-08-02 14:36:40 -07:00
Josh Klar
a23e1494f5
ci: Track changes to .ruby-version-next for base image builds. (#19875)
In #19871 base images changed to referencing `.ruby-version-next`
(enabling two-PR sequences for updating our Ruby version target), but
the corresponding GitHub Action was not updated, now necessitating a
manual CI run for that particular version update. This commit fixes this
oversight for future runs.
2023-08-02 11:40:35 -07:00
Peter Frank
b39b4642fe
Add "bug" label to bug issue template (#19814)
Just adding a label
2023-07-24 14:55:04 -04:00
Mac Siri
fa31b5fc60
Revert Yarn dependencies update & tighten CI settings (#19781) 2023-07-19 17:35:40 -04:00
Mac Siri
290b9bd775
[CI] Add branch specific rule for codecov upload (#19736) 2023-07-12 09:08:50 -04:00
Josh Klar
10e4fe4d6c
infra: Automatically build and push base container image when Ruby versions are updated. (#19657) 2023-07-11 12:23:49 -07:00
Helio Cola
c7bb3be603
Upgrade ruby 3.0.6 (#19651)
Co-authored-by: Josh Klar <jklar@forem.com>
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2023-07-06 16:42:20 -04:00
Mac Siri
894a318f99
Add retry to codecov upload (#19679) 2023-07-03 16:40:51 -04:00
PJ
90780fd97a
Fix comment moderation's UI bugs (#19554) 2023-06-23 09:56:24 -04:00
Mai Irie
282afaa6a2
Update PR template to include a11y checklist (#19538) 2023-05-26 12:37:48 -04:00
Mac Siri
a6a3417e5e
[CI] Move code-coverage upload into isolated process (#19532) 2023-05-26 09:09:39 -04:00
Mac Siri
a5842bd779
Revert Uffizzi refactors (#19526) 2023-05-24 10:55:27 -04:00
Mac Siri
f85db74b92
[CI] Refactor Uffizzi-build.yml (#19463)
* Simplify Uffizzi setup & use cached assets

* Remove cache assets usage

* Don't feature too many articles in seed

* Update db/seeds.rb
2023-05-16 09:41:52 -07:00
Mac Siri
e2a2d170e8
[CI] Combine Uffizzi workflows (#19429) 2023-05-05 12:59:08 -04:00
Joshua Wehner
7a9d71666f
Refactor for_display to pass article instead of params (#19376)
* Refactor for_display to pass article instead of params

* Refactor: use options in FilteredAdsQuery, deconstruct article in DisplayAd.for_display

* Typo

* Restore applicable comments
2023-04-26 16:57:10 +02:00
Peter Frank
3d53351b8f
Update issue templates and automatic comment on new issues (#19357)
* Update issue templates

Adding a new issue template as part of an effort to clean up the way we use GitHub / GitHub Discussions

* Update config.yml

* Update issue.yml
2023-04-24 13:15:40 -07:00
Mac Siri
531f15566d
Track Deploys with Honeybadger (#19338) 2023-04-17 11:14:58 -04:00
Ridhwana
0771a5cd2e
Load post_comments billboard asynchronously (#19285)
* feat: add a route to the async_info for display ads

* feat: load the billboard asyncronously

* feat: move the methods to the display_ads controller

* feat: handle params better

* feat: cache control headers

* feat: test fastly caching headers on display ads

* fix: surrogate key test

* feat: use safe navigation operator to handle cases where there is no article id

* fix: article id present then find the article

* feat: add a response test

* Fragment caching

* feat: update the article decorator

* feat: update cache keys for fragment

* feat: remove an empty line

* feat: add article id

* feat: bust cache

* feat: setup dropdown for billboard

* chore: add chunk to same line

* feat: add to safe params for caching

* Update app/controllers/display_ads_controller.rb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* feat: remove the cache deletion

* feat: update the routes to follow a new scope

* feat: update the cache params

---------

Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-04-12 18:15:15 +02:00
Mac Siri
f88a861125
Keep rubocop's usage consistent (#19293) 2023-04-06 07:53:59 -04:00
Mai Irie
3775f2b06c
PR Template cleanup (#19277)
* PR Template cleanup

Removed some sections we've been using less often to streamline the PR review process.
2023-04-05 11:58:57 -04:00
Mac Siri
e3b6e5b08d
[CI] Make CodeCov less noisy (#19286) 2023-04-03 15:56:20 -04:00
Mac Siri
f368a4ce7f
Fix broken cypress code coverage (#19282) 2023-03-30 12:36:12 -04:00
Mac Siri
64c10957e3
Update CODEOWNERS (#19276) 2023-03-29 17:20:41 -04:00